@nx/react 23.2.0-pr.36527.2252709 → 23.2.0-pr.36838.ef8e258

package/README.md

@@ -7,9 +7,9 @@
 
 <div style="text-align: center;">
 
-[![License](https://img.shields.io/npm/l/@nx/workspace.svg?style=flat-square)]()
+[![License](https://img.shields.io/npm/l/@nx/workspace.svg?style=flat-square)](<>)
 [![NPM Version](https://badge.fury.io/js/nx.svg)](https://www.npmjs.com/package/nx)
-[![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)]()
+[![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)](<>)
 [![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
 [![Join us on the Official Nx Discord Server](https://img.shields.io/discord/1143497901675401286?label=discord)](https://go.nx.dev/community)
 [![Nx Sandboxing](https://staging.nx.app/workspaces/62d013ea0852fe0a2df74438/sandbox-badge.svg)](https://nx.dev/docs/features/ci-features/sandboxing)

package/dist/src/generators/application/lib/add-e2e.js

@@ -16,7 +16,7 @@ async function addE2e(tree, options) {
             (await (0, has_rsbuild_plugin_1.hasRsbuildPlugin)(tree, options.appProjectRoot))) ||
         (options.bundler === 'vite' && (0, has_vite_plugin_1.hasVitePlugin)(tree));
     let e2eWebServerInfo = {
-        e2eWebServerAddress: `http://localhost:${options.devServerPort ?? 4200}`,
+        e2eWebServerAddress: `http://localhost:${options.port ?? 4200}`,
         e2eWebServerCommand: `${(0, devkit_1.getPackageManagerCommand)().exec} nx run ${options.projectName}:serve`,
         e2eCiWebServerCommand: `${(0, devkit_1.getPackageManagerCommand)().exec} nx run ${options.projectName}:serve-static`,
         e2eCiBaseUrl: `http://localhost:${options.port ?? 4200}`,
@@ -24,26 +24,26 @@ async function addE2e(tree, options) {
     };
     if (options.bundler === 'webpack') {
         const { getWebpackE2EWebServerInfo } = (0, devkit_1.ensurePackage)('@nx/webpack', versions_1.nxVersion);
-        e2eWebServerInfo = await getWebpackE2EWebServerInfo(tree, options.projectName, (0, devkit_1.joinPathFragments)(options.appProjectRoot, `webpack.config.${options.js ? 'js' : 'ts'}`), options.addPlugin, options.devServerPort ?? 4200);
+        e2eWebServerInfo = await getWebpackE2EWebServerInfo(tree, options.projectName, (0, devkit_1.joinPathFragments)(options.appProjectRoot, `webpack.config.${options.js ? 'js' : 'ts'}`), options.addPlugin, options.port);
     }
     else if (options.bundler === 'rspack') {
         const { getRspackE2EWebServerInfo } = (0, devkit_1.ensurePackage)('@nx/rspack', versions_1.nxVersion);
-        e2eWebServerInfo = await getRspackE2EWebServerInfo(tree, options.projectName, (0, devkit_1.joinPathFragments)(options.appProjectRoot, `rspack.config.${options.js ? 'js' : 'ts'}`), options.addPlugin, options.devServerPort ?? 4200);
+        e2eWebServerInfo = await getRspackE2EWebServerInfo(tree, options.projectName, (0, devkit_1.joinPathFragments)(options.appProjectRoot, `rspack.config.${options.js ? 'js' : 'ts'}`), options.addPlugin, options.port);
     }
     else if (options.bundler === 'vite') {
         const { getViteE2EWebServerInfo, getReactRouterE2EWebServerInfo } = (0, devkit_1.ensurePackage)('@nx/vite', versions_1.nxVersion);
         e2eWebServerInfo = options.useReactRouter
-            ? await getReactRouterE2EWebServerInfo(tree, options.projectName, (0, devkit_1.joinPathFragments)(options.appProjectRoot, `vite.config.${options.js ? 'js' : 'ts'}`), options.addPlugin, options.devServerPort ?? 4200, 
+            ? await getReactRouterE2EWebServerInfo(tree, options.projectName, (0, devkit_1.joinPathFragments)(options.appProjectRoot, `vite.config.${options.js ? 'js' : 'ts'}`), options.addPlugin, options.port ?? 4200, 
             // If the user manually sets the port, then use it for dev and preview
             options.port)
-            : await getViteE2EWebServerInfo(tree, options.projectName, (0, devkit_1.joinPathFragments)(options.appProjectRoot, `vite.config.${options.js ? 'js' : 'ts'}`), options.addPlugin, options.devServerPort ?? 4200, 
+            : await getViteE2EWebServerInfo(tree, options.projectName, (0, devkit_1.joinPathFragments)(options.appProjectRoot, `vite.config.${options.js ? 'js' : 'ts'}`), options.addPlugin, options.port ?? 4200, 
             // If the user manually sets the port, then use it for dev and preview
             options.port);
     }
     else if (options.bundler === 'rsbuild') {
         (0, devkit_1.ensurePackage)('@nx/rsbuild', versions_1.nxVersion);
         const { getRsbuildE2EWebServerInfo, } = require('@nx/rsbuild/config-utils');
-        e2eWebServerInfo = await getRsbuildE2EWebServerInfo(tree, options.projectName, (0, devkit_1.joinPathFragments)(options.appProjectRoot, `rsbuild.config.${options.js ? 'js' : 'ts'}`), options.addPlugin, options.devServerPort ?? 4200);
+        e2eWebServerInfo = await getRsbuildE2EWebServerInfo(tree, options.projectName, (0, devkit_1.joinPathFragments)(options.appProjectRoot, `rsbuild.config.${options.js ? 'js' : 'ts'}`), options.addPlugin, options.port ?? 4200);
     }
     if (!hasNxBuildPlugin) {
         await (0, web_1.webStaticServeGenerator)(tree, {

package/dist/src/generators/application/lib/add-project.js

@@ -126,6 +126,9 @@ function createRspackServeTarget(options) {
         defaultConfiguration: 'development',
         options: {
             buildTarget: `${options.projectName}:build`,
+            // @nx/rspack:dev-server defaults to 4200 at runtime, not in its schema, so
+            // omitting this is safe but the generated executor docs show no default.
+            ...(options.port != null ? { port: options.port } : {}),
             hmr: true,
         },
         configurations: {
@@ -197,6 +200,9 @@ function createServeTarget(options) {
         defaultConfiguration: 'development',
         options: {
             buildTarget: `${options.projectName}:build`,
+            // Only when asked: @nx/webpack:dev-server already defaults to 4200, so writing
+            // it unrequested would just restate the executor's own default.
+            ...(options.port != null ? { port: options.port } : {}),
             hmr: true,
         },
         configurations: {

package/dist/src/generators/application/lib/bundlers/add-rsbuild.js

@@ -27,7 +27,7 @@ async function setupRsbuildConfiguration(tree, options, tasks) {
         }, `./src/main.tsx`),
         tsConfig: './tsconfig.app.json',
         target: 'web',
-        devServerPort: options.devServerPort ?? 4200,
+        devServerPort: options.port ?? 4200,
     });
     tasks.push(rsbuildTask);
     const pathToConfigFile = (0, devkit_1.joinPathFragments)(options.appProjectRoot, 'rsbuild.config.ts');

package/dist/src/generators/application/lib/create-application-files.js

@@ -83,7 +83,10 @@ async function createApplicationFiles(host, options) {
     else if (options.bundler === 'webpack') {
         (0, devkit_1.generateFiles)(host, (0, path_1.join)(__dirname, '../files/base-webpack'), options.appProjectRoot, {
             ...templateVariables,
-            webpackPluginOptions: (0, has_webpack_plugin_1.hasWebpackPlugin)(host)
+            // Must match addProject's gate. An app that opts out gets executor targets,
+            // so it needs the executor-shaped config too — otherwise the plugin config's
+            // devServer.port and the serve target's port both describe the same server.
+            webpackPluginOptions: (0, has_webpack_plugin_1.hasWebpackPlugin)(host) && options.addPlugin
                 ? createNxWebpackPluginOptions(options, templateVariables.offsetFromRoot)
                 : null,
         });
@@ -111,7 +114,7 @@ async function createApplicationFiles(host, options) {
     else if (options.bundler === 'rspack') {
         (0, devkit_1.generateFiles)(host, (0, path_1.join)(__dirname, '../files/base-rspack'), options.appProjectRoot, {
             ...templateVariables,
-            rspackPluginOptions: (0, has_rspack_plugin_1.hasRspackPlugin)(host)
+            rspackPluginOptions: (0, has_rspack_plugin_1.hasRspackPlugin)(host) && options.addPlugin
                 ? createNxRspackPluginOptions(options, templateVariables.offsetFromRoot)
                 : null,
         });

package/dist/src/generators/application/lib/normalize-options.js

@@ -4,7 +4,6 @@ exports.normalizeOptions = normalizeOptions;
 const devkit_1 = require("@nx/devkit");
 const internal_1 = require("@nx/devkit/internal");
 const assertion_1 = require("../../../utils/assertion");
-const find_free_port_1 = require("./find-free-port");
 const internal_2 = require("@nx/js/internal");
 async function normalizeOptions(host, options) {
     await (0, internal_1.ensureRootProjectName)(options, 'application');
@@ -55,7 +54,9 @@ async function normalizeOptions(host, options) {
         unitTestRunner: options.unitTestRunner ?? 'jest',
         e2eTestRunner: options.e2eTestRunner ?? 'playwright',
         inSourceTests: options.minimal || options.inSourceTests,
-        devServerPort: options.devServerPort ?? options.port ?? (0, find_free_port_1.findFreePort)(host),
+        // This generator's CLI option has always been `--port`; `devServerPort` is
+        // programmatic-only back-compat, so there is no schema alias to lean on here.
+        port: options.port ?? options.devServerPort,
         minimal: options.minimal ?? false,
         // Programmatic callers such as the host and remote generators leave this
         // unset; the guards downstream read an unresolved `undefined` as "not eslint"

package/dist/src/generators/application/schema.d.ts

@@ -26,6 +26,7 @@ export interface Schema {
   setParserOptionsProject?: boolean;
   compiler?: 'babel' | 'swc';
   remotes?: string[];
+  /** @deprecated Use {@link Schema.port} instead. This option will be removed in Nx v25. */
   devServerPort?: number;
   skipPackageJson?: boolean;
   rootProject?: boolean;

package/dist/src/generators/application/schema.json

@@ -193,9 +193,7 @@
     },
     "port": {
       "type": "number",
-      "description": "The port to use for the development server",
-      "x-prompt": "Which port would you like to use for the dev server?",
-      "default": 4200
+      "description": "The port to use for the development server. Defaults to 4200."
     }
   },
   "required": ["directory"],

package/dist/src/generators/federate-module/schema.json

@@ -62,7 +62,7 @@
     },
     "unitTestRunner": {
       "type": "string",
-      "enum": ["jest", "none"],
+      "enum": ["jest", "vitest", "none"],
       "description": "Test runner to use for unit tests.",
       "default": "jest"
     },

package/dist/src/generators/host/files/rspack-module-federation/rspack.config.js__tmpl__

@@ -13,7 +13,7 @@ module.exports = {
     publicPath: 'auto'
   },
   devServer: {
-    port: <%= devServerPort %>,
+    port: <%= port %>,
     historyApiFallback: {
       index: '/index.html',
       disableDotRule: true,

package/dist/src/generators/host/files/rspack-module-federation/rspack.config.prod.js__tmpl__

@@ -37,7 +37,7 @@ module.exports = {
     publicPath: 'auto'
   },
   devServer: {
-    port: <%= devServerPort %>,
+    port: <%= port %>,
     historyApiFallback: {
       index: '/index.html',
       disableDotRule: true,

package/dist/src/generators/host/files/rspack-module-federation-ssr/rspack.config.js__tmpl__

@@ -15,7 +15,7 @@ const browserRspackConfig = {
     publicPath: 'auto'
   },
   devServer: {
-    port: <%= devServerPort %>,
+    port: <%= port %>,
     historyApiFallback: {
       index: '/index.html',
       disableDotRule: true,

package/dist/src/generators/host/files/rspack-module-federation-ssr-ts/rspack.config.ts__tmpl__

@@ -15,7 +15,7 @@ const browserRspackConfig = {
     publicPath: 'auto'
   },
   devServer: {
-    port: <%= devServerPort %>,
+    port: <%= port %>,
     historyApiFallback: {
       index: '/index.html',
       disableDotRule: true,

package/dist/src/generators/host/files/rspack-module-federation-ts/rspack.config.prod.ts__tmpl__

@@ -38,7 +38,7 @@ export default {
     publicPath: 'auto'
   },
   devServer: {
-    port: <%= devServerPort %>,
+    port: <%= port %>,
     historyApiFallback: {
       index: '/index.html',
       disableDotRule: true,

package/dist/src/generators/host/files/rspack-module-federation-ts/rspack.config.ts__tmpl__

@@ -13,7 +13,7 @@ export default {
     publicPath: 'auto'
   },
   devServer: {
-    port: <%= devServerPort %>,
+    port: <%= port %>,
     historyApiFallback: {
       index: '/index.html',
       disableDotRule: true,

package/dist/src/generators/host/host.js

@@ -40,6 +40,9 @@ async function hostGenerator(host, schema) {
         // TODO(colum): remove when Webpack MF works with Crystal
         addPlugin: !schema.bundler || schema.bundler === 'rspack' ? true : false,
         bundler: schema.bundler ?? 'rspack',
+        // The schema carries no default, so supply one here: remotes are numbered up
+        // from the host's port (`options.port + 1` below), which needs a concrete value.
+        port: schema.port ?? schema.devServerPort ?? 4200,
     };
     // Check to see if remotes are provided and also check if --dynamic is provided
     // if both are check that the remotes are valid names else throw an error.
@@ -73,7 +76,7 @@ async function hostGenerator(host, schema) {
     }
     const remotesWithPorts = [];
     if (schema.remotes) {
-        let remotePort = options.devServerPort + 1;
+        let remotePort = options.port + 1;
         for (const remote of schema.remotes) {
             const remoteName = await (0, normalize_remote_1.normalizeRemoteName)(host, remote, options);
             remotesWithPorts.push({ name: remoteName, port: remotePort });
@@ -84,7 +87,7 @@ async function hostGenerator(host, schema) {
                 unitTestRunner: options.unitTestRunner,
                 e2eTestRunner: options.e2eTestRunner,
                 linter: options.linter,
-                devServerPort: remotePort,
+                port: remotePort,
                 ssr: options.ssr,
                 skipFormat: true,
                 typescriptConfiguration: options.typescriptConfiguration,
@@ -110,7 +113,7 @@ async function hostGenerator(host, schema) {
         if (options.bundler !== 'rspack') {
             const setupSsrTask = await (0, setup_ssr_1.default)(host, {
                 project: options.projectName,
-                serverPort: options.devServerPort,
+                serverPort: options.port,
                 skipFormat: true,
             });
             tasks.push(setupSsrTask);

package/dist/src/generators/host/lib/setup-ssr-for-host.js

@@ -22,7 +22,7 @@ async function setupSsrForHost(tree, options, appName, defaultRemoteManifest) {
                 ...(0, create_application_files_1.createNxRspackPluginOptions)(options, (0, devkit_1.offsetFromRoot)(options.appProjectRoot), false),
                 mainServer: `./server.ts`,
             },
-            port: Number(options?.devServerPort) || 4200,
+            port: Number(options?.port) || 4200,
             appName,
             static: !options?.dynamic,
             remotes: defaultRemoteManifest.map(({ name, port }) => {
@@ -35,7 +35,7 @@ async function setupSsrForHost(tree, options, appName, defaultRemoteManifest) {
         : {
             ...options,
             static: !options?.dynamic,
-            port: Number(options?.devServerPort) || 4200,
+            port: Number(options?.port) || 4200,
             appName,
             tmpl: '',
             browserBuildOutputPath: project.targets.build?.options?.outputPath,

package/dist/src/generators/host/lib/update-module-federation-e2e-project.js

@@ -8,7 +8,7 @@ function updateModuleFederationE2eProject(host, options) {
         if (projectConfig.targets.e2e.executor !== '@nx/playwright:playwright') {
             projectConfig.targets.e2e.options = {
                 ...projectConfig.targets.e2e.options,
-                baseUrl: `http://localhost:${options.devServerPort}`,
+                baseUrl: `http://localhost:${options.port}`,
             };
             (0, devkit_1.updateProjectConfiguration)(host, options.e2eProjectName, projectConfig);
         }

package/dist/src/generators/host/schema.d.ts

@@ -4,6 +4,8 @@ import type { SupportedStyles } from '../../../typings/style';
 export interface Schema {
   classComponent?: boolean;
   compiler?: 'babel' | 'swc';
+  port?: number;
+  /** @deprecated Use {@link Schema.port} instead. This option will be removed in Nx v24. */
   devServerPort?: number;
   directory: string;
   e2eTestRunner: 'cypress' | 'playwright' | 'none';

package/dist/src/generators/host/schema.json

@@ -71,7 +71,7 @@
     },
     "unitTestRunner": {
       "type": "string",
-      "enum": ["jest", "none"],
+      "enum": ["jest", "vitest", "none"],
       "description": "Test runner to use for unit tests.",
       "default": "jest"
     },
@@ -132,10 +132,10 @@
       "x-priority": "important",
       "alias": "producers"
     },
-    "devServerPort": {
+    "port": {
       "type": "number",
-      "description": "The port for the dev server of the Producer (remote) app.",
-      "default": 4200,
+      "description": "The port at which the Consumer (host) application should be served. Defaults to 4200.",
+      "aliases": ["devServerPort"],
       "x-priority": "important"
     },
     "ssr": {

package/dist/src/generators/remote/files/rspack-module-federation/rspack.config.js__tmpl__

@@ -13,7 +13,7 @@ module.exports = {
     publicPath: 'auto'
   },
   devServer: {
-    port: <%= devServerPort %>,
+    port: <%= port %>,
     headers: {
       "Access-Control-Allow-Origin": "*"
     },

package/dist/src/generators/remote/files/rspack-module-federation-ssr/rspack.config.js__tmpl__

@@ -15,7 +15,7 @@ const browserRspackConfig = {
     publicPath: 'auto'
   },
   devServer: {
-    port: <%= devServerPort %>,
+    port: <%= port %>,
     headers: {
       "Access-Control-Allow-Origin": "*"
     },

package/dist/src/generators/remote/files/rspack-module-federation-ssr-ts/rspack.config.ts__tmpl__

@@ -15,7 +15,7 @@ const browserRspackConfig = {
     publicPath: 'auto'
   },
   devServer: {
-    port: <%= devServerPort %>,
+    port: <%= port %>,
     headers: {
       "Access-Control-Allow-Origin": "*"
     },

package/dist/src/generators/remote/files/rspack-module-federation-ts/rspack.config.ts__tmpl__

@@ -13,7 +13,7 @@ export default {
     publicPath: 'auto'
   },
   devServer: {
-    port: <%= devServerPort %>,
+    port: <%= port %>,
     headers: {
       "Access-Control-Allow-Origin": "*"
     },

package/dist/src/generators/remote/lib/setup-ssr-for-remote.js

@@ -17,12 +17,12 @@ async function setupSsrForRemote(tree, options, appName) {
                 ...(0, create_application_files_1.createNxRspackPluginOptions)(options, (0, devkit_1.offsetFromRoot)(options.appProjectRoot), false),
                 mainServer: `./server.ts`,
             },
-            port: Number(options?.devServerPort) || 4200,
+            port: Number(options?.port) || 4200,
             appName,
         }
         : {
             ...options,
-            port: Number(options?.devServerPort) || 4200,
+            port: Number(options?.port) || 4200,
             appName,
             tmpl: '',
             browserBuildOutputPath: project.targets.build?.options?.outputPath,
@@ -45,7 +45,7 @@ async function setupSsrForRemote(tree, options, appName) {
         executor: 'nx:run-commands',
         defaultConfiguration: 'development',
         options: {
-            command: `PORT=${options.devServerPort ?? 4200} node ${(0, devkit_1.joinPathFragments)(serverOutputPath, serverOutputName)}`,
+            command: `PORT=${options.port ?? 4200} node ${(0, devkit_1.joinPathFragments)(serverOutputPath, serverOutputName)}`,
         },
     };
     (0, devkit_1.updateProjectConfiguration)(tree, appName, project);

package/dist/src/generators/remote/remote.js

@@ -13,6 +13,7 @@ const internal_3 = require("@nx/js/internal");
 const update_module_federation_project_1 = require("../../rules/update-module-federation-project");
 const add_mf_env_to_inputs_1 = require("../../utils/add-mf-env-to-inputs");
 const normalize_remote_1 = require("../../utils/normalize-remote");
+const find_free_port_1 = require("../application/lib/find-free-port");
 const maybe_js_1 = require("../../utils/maybe-js");
 const module_federation_deprecation_1 = require("../../utils/module-federation-deprecation");
 const versions_1 = require("../../utils/versions");
@@ -89,6 +90,10 @@ async function remoteGenerator(host, schema) {
         // TODO(colum): remove when Webpack MF works with Crystal
         addPlugin: !schema.bundler || schema.bundler === 'rspack' ? true : false,
         bundler: schema.bundler ?? 'rspack',
+        // Unlike a plain app, a remote needs a port of its own: updateModuleFederationProject
+        // writes it to the serve target, and a dynamic remote's is also recorded in the host
+        // manifest. findFreePort reads the ports already claimed, so remotes step past each other.
+        port: schema.port ?? schema.devServerPort ?? (0, find_free_port_1.findFreePort)(host),
     };
     if (options.dynamic) {
         // Dynamic remotes generate with library { type: 'var' } by default.
@@ -139,7 +144,7 @@ async function remoteGenerator(host, schema) {
         if (options.bundler !== 'rspack') {
             const setupSsrTask = await (0, setup_ssr_1.default)(host, {
                 project: options.projectName,
-                serverPort: options.devServerPort,
+                serverPort: options.port,
                 skipFormat: true,
                 bundler: options.bundler,
             });
@@ -166,7 +171,7 @@ async function remoteGenerator(host, schema) {
     if (options.host && options.dynamic) {
         const hostConfig = (0, devkit_1.readProjectConfiguration)(host, schema.host);
         const pathToMFManifest = (0, devkit_1.joinPathFragments)((0, internal_3.getProjectSourceRoot)(hostConfig, host), 'assets/module-federation.manifest.json');
-        (0, add_remote_to_dynamic_host_1.addRemoteToDynamicHost)(host, options.projectName, options.devServerPort, pathToMFManifest);
+        (0, add_remote_to_dynamic_host_1.addRemoteToDynamicHost)(host, options.projectName, options.port, pathToMFManifest);
     }
     (0, add_mf_env_to_inputs_1.addMfEnvToTargetDefaultInputs)(host, options.bundler);
     const installTask = (0, devkit_1.addDependenciesToPackageJson)(host, {}, {

package/dist/src/generators/remote/schema.d.ts

@@ -5,6 +5,8 @@ import type { NormalizedSchema as ApplicationNormalizedSchema } from '../applica
 export interface Schema {
   classComponent?: boolean;
   compiler?: 'babel' | 'swc';
+  port?: number;
+  /** @deprecated Use {@link Schema.port} instead. This option will be removed in Nx v24. */
   devServerPort?: number;
   directory: string;
   e2eTestRunner: 'cypress' | 'playwright' | 'none';

package/dist/src/generators/remote/schema.json

@@ -77,7 +77,7 @@
     },
     "unitTestRunner": {
       "type": "string",
-      "enum": ["jest", "none"],
+      "enum": ["jest", "vitest", "none"],
       "description": "Test runner to use for unit tests.",
       "default": "jest"
     },
@@ -137,9 +137,10 @@
       "x-priority": "important",
       "alias": "consumer"
     },
-    "devServerPort": {
+    "port": {
       "type": "number",
-      "description": "The port for the dev server of the Producer (remote) app.",
+      "description": "The port on which this Producer (remote) app should be served.",
+      "aliases": ["devServerPort"],
       "x-priority": "important"
     },
     "ssr": {

package/dist/src/rules/update-module-federation-project.d.ts

@@ -3,7 +3,7 @@ export declare function updateModuleFederationProject(host: Tree, options: {
     js?: boolean;
     projectName: string;
     appProjectRoot: string;
-    devServerPort?: number;
+    port?: number;
     typescriptConfiguration?: boolean;
     dynamic?: boolean;
     bundler?: 'rspack' | 'webpack';

package/dist/src/rules/update-module-federation-project.js

@@ -32,16 +32,16 @@ function updateModuleFederationProject(host, options, isHost = false) {
                 ?.webpackConfig;
         }
     }
+    // Must precede the executor assignment below, which dereferences targets.serve:
+    // a plugin-driven workspace has no serve target in project.json to inherit.
+    projectConfig.targets.serve ??= {};
+    projectConfig.targets.serve.options ??= {};
     if (options.bundler !== 'rspack') {
         projectConfig.targets.serve.executor =
             '@nx/react:module-federation-dev-server';
     }
-    projectConfig.targets.serve ??= {};
-    projectConfig.targets.serve.options ??= {};
     projectConfig.targets.serve.options.port =
-        options.bundler === 'rspack' && options.ssr && isHost
-            ? 4000
-            : options.devServerPort;
+        options.bundler === 'rspack' && options.ssr && isHost ? 4000 : options.port;
     // `serve-static` for remotes that don't need to be in development mode
     if (options.bundler !== 'rspack') {
         const serveStaticExecutor = '@nx/react:module-federation-static-server';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/react",
-  "version": "23.2.0-pr.36527.2252709",
+  "version": "23.2.0-pr.36838.ef8e258",
   "private": false,
   "description": "The React plugin for Nx contains executors and generators for managing React applications and libraries within an Nx workspace. It provides:\n\n\n- Integration with libraries such as Jest, Vitest, Playwright, Cypress, and Storybook.\n\n- Generators for applications, libraries, components, hooks, and more.\n\n- Library build support for publishing packages to npm or other registries.\n\n- Utilities for automatic workspace refactoring.",
   "repository": {
@@ -96,7 +96,7 @@
     "react-dom": ">=18.0.0 <20.0.0",
     "express": "^4.21.2",
     "http-proxy-middleware": "^3.0.7",
-    "@nx/module-federation": "23.2.0-pr.36527.2252709"
+    "@nx/module-federation": "23.2.0-pr.36838.ef8e258"
   },
   "peerDependenciesMeta": {
     "babel-plugin-react-compiler": {
@@ -118,27 +118,27 @@
     "minimatch": "10.2.5",
     "tslib": "^2.3.0",
     "semver": "^7.6.3",
-    "@nx/devkit": "23.2.0-pr.36527.2252709",
-    "@nx/js": "23.2.0-pr.36527.2252709",
-    "@nx/eslint": "23.2.0-pr.36527.2252709",
-    "@nx/web": "23.2.0-pr.36527.2252709"
+    "@nx/devkit": "23.2.0-pr.36838.ef8e258",
+    "@nx/js": "23.2.0-pr.36838.ef8e258",
+    "@nx/eslint": "23.2.0-pr.36838.ef8e258",
+    "@nx/web": "23.2.0-pr.36838.ef8e258"
   },
   "devDependencies": {
     "express": "^4.21.2",
     "http-proxy-middleware": "^3.0.7",
-    "@nx/cypress": "23.2.0-pr.36527.2252709",
-    "@nx/module-federation": "23.2.0-pr.36527.2252709",
-    "@nx/playwright": "23.2.0-pr.36527.2252709",
-    "@nx/rollup": "23.2.0-pr.36527.2252709",
-    "@nx/rsbuild": "23.2.0-pr.36527.2252709",
-    "@nx/vite": "23.2.0-pr.36527.2252709",
-    "@nx/vitest": "23.2.0-pr.36527.2252709",
-    "@nx/webpack": "23.2.0-pr.36527.2252709",
-    "@nx/storybook": "23.2.0-pr.36527.2252709",
-    "nx": "23.2.0-pr.36527.2252709"
+    "@nx/cypress": "23.2.0-pr.36838.ef8e258",
+    "@nx/module-federation": "23.2.0-pr.36838.ef8e258",
+    "@nx/playwright": "23.2.0-pr.36838.ef8e258",
+    "@nx/rollup": "23.2.0-pr.36838.ef8e258",
+    "@nx/rsbuild": "23.2.0-pr.36838.ef8e258",
+    "@nx/vite": "23.2.0-pr.36838.ef8e258",
+    "@nx/vitest": "23.2.0-pr.36838.ef8e258",
+    "@nx/webpack": "23.2.0-pr.36838.ef8e258",
+    "@nx/storybook": "23.2.0-pr.36838.ef8e258",
+    "nx": "23.2.0-pr.36838.ef8e258"
   },
   "optionalDependencies": {
-    "@nx/vite": "23.2.0-pr.36527.2252709"
+    "@nx/vite": "23.2.0-pr.36838.ef8e258"
   },
   "publishConfig": {
     "access": "public"