@nx/react 20.5.0-canary.20250228-e8647df → 20.5.0-canary.20250304-8e6c007

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/react",
-  "version": "20.5.0-canary.20250228-e8647df",
+  "version": "20.5.0-canary.20250304-8e6c007",
   "private": false,
   "description": "The React plugin for Nx contains executors and generators for managing React applications and libraries within an Nx workspace. It provides:\n\n\n- Integration with libraries such as Jest, Vitest, Playwright, Cypress, and Storybook.\n\n- Generators for applications, libraries, components, hooks, and more.\n\n- Library build support for publishing packages to npm or other registries.\n\n- Utilities for automatic workspace refactoring.",
   "repository": {
@@ -38,11 +38,11 @@
     "minimatch": "9.0.3",
     "picocolors": "^1.1.0",
     "tslib": "^2.3.0",
-    "@nx/devkit": "20.5.0-canary.20250228-e8647df",
-    "@nx/js": "20.5.0-canary.20250228-e8647df",
-    "@nx/eslint": "20.5.0-canary.20250228-e8647df",
-    "@nx/web": "20.5.0-canary.20250228-e8647df",
-    "@nx/module-federation": "20.5.0-canary.20250228-e8647df",
+    "@nx/devkit": "20.5.0-canary.20250304-8e6c007",
+    "@nx/js": "20.5.0-canary.20250304-8e6c007",
+    "@nx/eslint": "20.5.0-canary.20250304-8e6c007",
+    "@nx/web": "20.5.0-canary.20250304-8e6c007",
+    "@nx/module-federation": "20.5.0-canary.20250304-8e6c007",
     "express": "^4.21.2",
     "http-proxy-middleware": "^3.0.3",
     "semver": "^7.6.3"

package/src/generators/library/lib/add-rollup-build-target.d.ts

@@ -1,4 +1,6 @@
 import { Tree } from 'nx/src/generators/tree';
 import { GeneratorCallback } from '@nx/devkit';
 import { NormalizedSchema } from '../schema';
-export declare function addRollupBuildTarget(host: Tree, options: NormalizedSchema): Promise<GeneratorCallback>;
+export declare function addRollupBuildTarget(host: Tree, options: NormalizedSchema & {
+    format?: Array<'esm' | 'cjs'>;
+}, external?: Set<String>): Promise<GeneratorCallback>;

package/src/generators/library/lib/add-rollup-build-target.js

@@ -4,7 +4,7 @@ exports.addRollupBuildTarget = addRollupBuildTarget;
 const devkit_1 = require("@nx/devkit");
 const maybe_js_1 = require("../../../utils/maybe-js");
 const versions_1 = require("../../../utils/versions");
-async function addRollupBuildTarget(host, options) {
+async function addRollupBuildTarget(host, options, external = new Set(['react', 'react-dom'])) {
     const tasks = [];
     const { configurationGenerator } = (0, devkit_1.ensurePackage)('@nx/rollup', versions_1.nxVersion);
     tasks.push(await configurationGenerator(host, {
@@ -19,12 +19,11 @@ async function addRollupBuildTarget(host, options) {
             '@svgr/rollup': versions_1.svgrRollupVersion,
         }));
     }
-    const external = ['react', 'react-dom'];
     if (options.style === '@emotion/styled') {
-        external.push('@emotion/react/jsx-runtime');
+        external.add('@emotion/react/jsx-runtime');
     }
     else {
-        external.push('react/jsx-runtime');
+        external.add('react/jsx-runtime');
     }
     const nxJson = (0, devkit_1.readNxJson)(host);
     const hasRollupPlugin = !!nxJson.plugins?.some((p) => typeof p === 'string'
@@ -44,8 +43,8 @@ module.exports = withNx(
             : (0, devkit_1.joinPathFragments)((0, devkit_1.offsetFromRoot)(options.projectRoot), 'dist', options.projectRoot)}',
     tsConfig: './tsconfig.lib.json',
     compiler: '${options.compiler ?? 'babel'}',
-    external: ${JSON.stringify(external)},
-    format: ['esm'],
+    external: ${JSON.stringify(Array.from(external))},
+    format: ${JSON.stringify(options.format ?? ['esm'])},
     assets:[{ input: '.', output: '.', glob: 'README.md'}],
   }, {
     // Provide additional rollup configuration here. See: https://rollupjs.org/configuration-options
@@ -74,7 +73,7 @@ module.exports = withNx(
                 tsConfig: `${options.projectRoot}/tsconfig.lib.json`,
                 project: `${options.projectRoot}/package.json`,
                 entryFile: (0, maybe_js_1.maybeJs)(options, `${options.projectRoot}/src/index.ts`),
-                external,
+                external: Array.from(external),
                 rollupConfig: `@nx/react/plugins/bundle-rollup`,
                 compiler: options.compiler ?? 'babel',
                 assets: [