@nx/react 19.6.5 → 19.6.7

package/migrations.json

@@ -229,6 +229,19 @@
           "alwaysAddToPackageJson": false
         }
       }
+    },
+    "19.7.0": {
+      "version": "19.7.0-beta.0",
+      "packages": {
+        "@module-federation/enhanced": {
+          "version": "~0.6.0",
+          "alwaysAddToPackageJson": false
+        },
+        "@module-federation/node": {
+          "version": "~2.5.0",
+          "alwaysAddToPackageJson": false
+        }
+      }
     }
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/react",
-  "version": "19.6.5",
+  "version": "19.6.7",
   "private": false,
   "description": "The React plugin for Nx contains executors and generators for managing React applications and libraries within an Nx workspace. It provides:\n\n\n- Integration with libraries such as Jest, Vitest, Playwright, Cypress, and Storybook.\n\n- Generators for applications, libraries, components, hooks, and more.\n\n- Library build support for publishing packages to npm or other registries.\n\n- Utilities for automatic workspace refactoring.",
   "repository": {
@@ -38,12 +38,12 @@
     "file-loader": "^6.2.0",
     "minimatch": "9.0.3",
     "tslib": "^2.3.0",
-    "@module-federation/enhanced": "~0.2.3",
-    "@nx/devkit": "19.6.5",
-    "@nx/js": "19.6.5",
-    "@nx/eslint": "19.6.5",
-    "@nx/web": "19.6.5",
-    "@nrwl/react": "19.6.5"
+    "@module-federation/enhanced": "~0.6.0",
+    "@nx/devkit": "19.6.7",
+    "@nx/js": "19.6.7",
+    "@nx/eslint": "19.6.7",
+    "@nx/web": "19.6.7",
+    "@nrwl/react": "19.6.7"
   },
   "publishConfig": {
     "access": "public"

package/src/executors/module-federation-ssr-dev-server/module-federation-ssr-dev-server.impl.js

@@ -28,8 +28,9 @@ function getBuildOptions(buildTarget, context) {
         ...buildOptions,
     };
 }
-function startSsrStaticRemotesFileServer(ssrStaticRemotesConfig, context, options) {
+async function* startSsrStaticRemotesFileServer(ssrStaticRemotesConfig, context, options) {
     if (ssrStaticRemotesConfig.remotes.length === 0) {
+        yield { success: true };
         return;
     }
     // The directories are usually generated with /browser and /server suffixes so we need to copy them to a common directory
@@ -55,7 +56,7 @@ function startSsrStaticRemotesFileServer(ssrStaticRemotesConfig, context, option
         sslKey: options.sslKey,
         cacheSeconds: -1,
     }, context);
-    return staticRemotesIter;
+    yield* staticRemotesIter;
 }
 async function startRemotes(remotes, context, options) {
     const remoteIters = [];
@@ -176,18 +177,30 @@ async function* moduleFederationSsrDevServer(ssrDevServerOptions, context) {
             pathToKey: options.sslKey,
         }
         : undefined);
-    return yield* (0, async_iterable_1.combineAsyncIterables)(iter, ...devRemoteIters, ...(staticRemotesIter ? [staticRemotesIter] : []), (0, async_iterable_1.createAsyncIterable)(async ({ next, done }) => {
+    const combined = (0, async_iterable_1.combineAsyncIterables)(staticRemotesIter, ...devRemoteIters);
+    let refs = 1 + (devRemoteIters?.length ?? 0);
+    for await (const result of combined) {
+        if (result.success === false)
+            throw new Error('Remotes failed to start');
+        if (result.success)
+            refs--;
+        if (refs === 0)
+            break;
+    }
+    return yield* (0, async_iterable_1.combineAsyncIterables)(iter, (0, async_iterable_1.createAsyncIterable)(async ({ next, done }) => {
+        const host = options.host ?? 'localhost';
+        const baseUrl = `http${options.ssl ? 's' : ''}://${host}:${options.port}`;
         if (!options.isInitialHost) {
+            next({ success: true, baseUrl });
             done();
             return;
         }
         if (remotes.remotePorts.length === 0) {
+            next({ success: true, baseUrl });
             done();
             return;
         }
         try {
-            const host = options.host ?? 'localhost';
-            const baseUrl = `http${options.ssl ? 's' : ''}://${host}:${options.port}`;
             const portsToWaitFor = staticRemotesIter
                 ? [options.staticRemotesPort, ...remotes.remotePorts]
                 : [...remotes.remotePorts];

package/src/module-federation/with-module-federation-ssr.js

@@ -10,13 +10,13 @@ async function withModuleFederationForSSR(options, configOverride) {
         isServer: true,
     });
     return (config) => {
-        config.target = false;
+        config.target = 'async-node';
         config.output.uniqueName = options.name;
         config.optimization = {
             ...(config.optimization ?? {}),
             runtimeChunk: false,
         };
-        config.plugins.push(new (require('@module-federation/node').UniversalFederationPlugin)({
+        config.plugins.push(new (require('@module-federation/enhanced').ModuleFederationPlugin)({
             name: options.name,
             filename: 'remoteEntry.js',
             exposes: options.exposes,
@@ -24,10 +24,6 @@ async function withModuleFederationForSSR(options, configOverride) {
             shared: {
                 ...sharedDependencies,
             },
-            library: {
-                type: 'commonjs-module',
-            },
-            isServer: true,
             /**
              * Apply user-defined config overrides
              */
@@ -38,7 +34,11 @@ async function withModuleFederationForSSR(options, configOverride) {
                     ...(configOverride?.runtimePlugins ?? []),
                     require.resolve('@nx/webpack/src/utils/module-federation/plugins/runtime-library-control.plugin.js'),
                 ]
-                : configOverride?.runtimePlugins,
+                : [
+                    ...(configOverride?.runtimePlugins ?? []),
+                    require.resolve('@module-federation/node/runtimePlugin'),
+                ],
+            virtualRuntimeEntry: true,
         }, {}), sharedLibraries.getReplacementPlugin());
         // The env var is only set from the module-federation-dev-server
         // Attach the runtime plugin

package/src/module-federation/with-module-federation.js

@@ -60,6 +60,7 @@ async function withModuleFederation(options, configOverride) {
                     require.resolve('@nx/webpack/src/utils/module-federation/plugins/runtime-library-control.plugin.js'),
                 ]
                 : configOverride?.runtimePlugins,
+            virtualRuntimeEntry: true,
         }), sharedLibraries.getReplacementPlugin());
         // The env var is only set from the module-federation-dev-server
         // Attach the runtime plugin

package/src/utils/add-mf-env-to-inputs.js

@@ -22,6 +22,7 @@ function addMfEnvToTargetDefaultInputs(tree) {
     }
     if (!mfEnvVarExists) {
         nxJson.targetDefaults[webpackExecutor].inputs.push({ env: mfEnvVar });
-        (0, devkit_1.updateNxJson)(tree, nxJson);
     }
+    nxJson.targetDefaults[webpackExecutor].cache = true;
+    (0, devkit_1.updateNxJson)(tree, nxJson);
 }

package/src/utils/versions.d.ts

@@ -37,8 +37,8 @@ export declare const typesExpressVersion = "4.17.17";
 export declare const isbotVersion = "^3.6.5";
 export declare const corsVersion = "~2.8.5";
 export declare const typesCorsVersion = "~2.8.12";
-export declare const moduleFederationNodeVersion = "~2.4.0";
-export declare const moduleFederationEnhancedVersion = "~0.2.3";
+export declare const moduleFederationNodeVersion = "~2.5.0";
+export declare const moduleFederationEnhancedVersion = "~0.6.0";
 export declare const lessVersion = "3.12.2";
 export declare const sassVersion = "^1.55.0";
 export declare const rollupPluginUrlVersion = "^8.0.2";

package/src/utils/versions.js

@@ -43,8 +43,8 @@ exports.typesExpressVersion = '4.17.17';
 exports.isbotVersion = '^3.6.5';
 exports.corsVersion = '~2.8.5';
 exports.typesCorsVersion = '~2.8.12';
-exports.moduleFederationNodeVersion = '~2.4.0';
-exports.moduleFederationEnhancedVersion = '~0.2.3';
+exports.moduleFederationNodeVersion = '~2.5.0';
+exports.moduleFederationEnhancedVersion = '~0.6.0';
 // style preprocessors
 exports.lessVersion = '3.12.2';
 exports.sassVersion = '^1.55.0';