@nx/react 18.2.0-beta.1 → 18.2.0-beta.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/react",
-  "version": "18.2.0-beta.1",
+  "version": "18.2.0-beta.3",
   "private": false,
   "description": "The React plugin for Nx contains executors and generators for managing React applications and libraries within an Nx workspace. It provides:\n\n\n- Integration with libraries such as Jest, Cypress, and Storybook.\n\n- Generators for applications, libraries, components, hooks, and more.\n\n- Library build support for publishing packages to npm or other registries.\n\n- Utilities for automatic workspace refactoring.",
   "repository": {
@@ -36,11 +36,11 @@
     "chalk": "^4.1.0",
     "minimatch": "9.0.3",
     "tslib": "^2.3.0",
-    "@nx/devkit": "18.2.0-beta.1",
-    "@nx/js": "18.2.0-beta.1",
-    "@nx/eslint": "18.2.0-beta.1",
-    "@nx/web": "18.2.0-beta.1",
-    "@nrwl/react": "18.2.0-beta.1"
+    "@nx/devkit": "18.2.0-beta.3",
+    "@nx/js": "18.2.0-beta.3",
+    "@nx/eslint": "18.2.0-beta.3",
+    "@nx/web": "18.2.0-beta.3",
+    "@nrwl/react": "18.2.0-beta.3"
   },
   "publishConfig": {
     "access": "public"

package/src/executors/module-federation-dev-server/module-federation-dev-server.impl.js

@@ -7,9 +7,10 @@ const file_server_impl_1 = require("@nx/web/src/executors/file-server/file-serve
 const module_federation_1 = require("@nx/webpack/src/utils/module-federation");
 const async_iterable_1 = require("@nx/devkit/src/utils/async-iterable");
 const wait_for_port_open_1 = require("@nx/web/src/utils/wait-for-port-open");
-const child_process_1 = require("child_process");
-const path_1 = require("path");
-const fs_1 = require("fs");
+const cache_directory_1 = require("nx/src/utils/cache-directory");
+const node_child_process_1 = require("node:child_process");
+const node_path_1 = require("node:path");
+const node_fs_1 = require("node:fs");
 function getBuildOptions(buildTarget, context) {
     const target = (0, devkit_1.parseTargetString)(buildTarget, context);
     const buildOptions = (0, devkit_1.readTargetOptions)(target, context);
@@ -31,10 +32,10 @@ function startStaticRemotesFileServer(staticRemotesConfig, context, options) {
         }
     }
     if (shouldMoveToCommonLocation) {
-        commonOutputDirectory = (0, path_1.join)(devkit_1.workspaceRoot, 'tmp/static-remotes');
+        commonOutputDirectory = (0, node_path_1.join)(devkit_1.workspaceRoot, 'tmp/static-remotes');
         for (const app of staticRemotesConfig.remotes) {
             const remoteConfig = staticRemotesConfig.config[app];
-            (0, fs_1.cpSync)(remoteConfig.outputPath, (0, path_1.join)(commonOutputDirectory, remoteConfig.urlSegment), {
+            (0, node_fs_1.cpSync)(remoteConfig.outputPath, (0, node_path_1.join)(commonOutputDirectory, remoteConfig.urlSegment), {
                 force: true,
                 recursive: true,
             });
@@ -88,7 +89,7 @@ async function buildStaticRemotes(staticRemotesConfig, nxBin, context, options)
     }
     process.env.NX_MF_DEV_SERVER_STATIC_REMOTES = JSON.stringify(mappedLocationOfRemotes);
     await new Promise((res) => {
-        const staticProcess = (0, child_process_1.fork)(nxBin, [
+        const staticProcess = (0, node_child_process_1.fork)(nxBin, [
             'run-many',
             `--target=build`,
             `--projects=${staticRemotesConfig.remotes.join(',')}`,
@@ -100,9 +101,13 @@ async function buildStaticRemotes(staticRemotesConfig, nxBin, context, options)
             cwd: context.root,
             stdio: ['ignore', 'pipe', 'pipe', 'ipc'],
         });
+        // File to debug build failures e.g. 2024-01-01T00_00_0_0Z-build.log'
+        const remoteBuildLogFile = (0, node_path_1.join)(cache_directory_1.projectGraphCacheDirectory, `${new Date().toISOString().replace(/[:\.]/g, '_')}-build.log`);
+        const stdoutStream = (0, node_fs_1.createWriteStream)(remoteBuildLogFile);
         staticProcess.stdout.on('data', (data) => {
             const ANSII_CODE_REGEX = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g;
             const stdoutString = data.toString().replace(ANSII_CODE_REGEX, '');
+            stdoutStream.write(stdoutString);
             if (stdoutString.includes('Successfully ran target build')) {
                 staticProcess.stdout.removeAllListeners('data');
                 devkit_1.logger.info(`NX Built ${staticRemotesConfig.remotes.length} static remotes`);
@@ -111,8 +116,9 @@ async function buildStaticRemotes(staticRemotesConfig, nxBin, context, options)
         });
         staticProcess.stderr.on('data', (data) => devkit_1.logger.info(data.toString()));
         staticProcess.on('exit', (code) => {
+            stdoutStream.end();
             if (code !== 0) {
-                throw new Error(`Remote failed to start. See above for errors.`);
+                throw new Error(`Remote failed to start. A complete log can be found in: ${remoteBuildLogFile}`);
             }
         });
         process.on('SIGTERM', () => staticProcess.kill('SIGTERM'));
@@ -126,8 +132,8 @@ function parseStaticRemotesConfig(staticRemotes, context) {
     const config = {};
     for (const app of staticRemotes) {
         const outputPath = context.projectGraph.nodes[app].data.targets['build'].options.outputPath;
-        const basePath = (0, path_1.dirname)(outputPath);
-        const urlSegment = (0, path_1.basename)(outputPath);
+        const basePath = (0, node_path_1.dirname)(outputPath);
+        const urlSegment = (0, node_path_1.basename)(outputPath);
         config[app] = { basePath, outputPath, urlSegment };
     }
     return { remotes: staticRemotes, config };

package/src/generators/application/lib/add-e2e.js

@@ -12,9 +12,10 @@ async function addE2e(tree, options) {
             const hasNxBuildPlugin = (options.bundler === 'webpack' && (0, has_webpack_plugin_1.hasWebpackPlugin)(tree)) ||
                 (options.bundler === 'vite' && (0, has_vite_plugin_1.hasVitePlugin)(tree));
             if (!hasNxBuildPlugin) {
-                (0, web_1.webStaticServeGenerator)(tree, {
+                await (0, web_1.webStaticServeGenerator)(tree, {
                     buildTarget: `${options.projectName}:build`,
                     targetName: 'serve-static',
+                    spa: true,
                 });
             }
             const { configurationGenerator } = (0, devkit_1.ensurePackage)('@nx/cypress', versions_1.nxVersion);