@nx/react 0.0.0-pr-29464-ce11848 → 0.0.0-pr-3-16b3273

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/react",
-  "version": "0.0.0-pr-29464-ce11848",
+  "version": "0.0.0-pr-3-16b3273",
   "private": false,
   "description": "The React plugin for Nx contains executors and generators for managing React applications and libraries within an Nx workspace. It provides:\n\n\n- Integration with libraries such as Jest, Vitest, Playwright, Cypress, and Storybook.\n\n- Generators for applications, libraries, components, hooks, and more.\n\n- Library build support for publishing packages to npm or other registries.\n\n- Utilities for automatic workspace refactoring.",
   "repository": {
@@ -38,11 +38,11 @@
     "minimatch": "9.0.3",
     "picocolors": "^1.1.0",
     "tslib": "^2.3.0",
-    "@nx/devkit": "0.0.0-pr-29464-ce11848",
-    "@nx/js": "0.0.0-pr-29464-ce11848",
-    "@nx/eslint": "0.0.0-pr-29464-ce11848",
-    "@nx/web": "0.0.0-pr-29464-ce11848",
-    "@nx/module-federation": "0.0.0-pr-29464-ce11848",
+    "@nx/devkit": "0.0.0-pr-3-16b3273",
+    "@nx/js": "0.0.0-pr-3-16b3273",
+    "@nx/eslint": "0.0.0-pr-3-16b3273",
+    "@nx/web": "0.0.0-pr-3-16b3273",
+    "@nx/module-federation": "0.0.0-pr-3-16b3273",
     "express": "^4.21.2",
     "http-proxy-middleware": "^3.0.3",
     "semver": "^7.6.3"

package/src/generators/library/lib/add-rollup-build-target.d.ts

@@ -1,6 +1,4 @@
 import { Tree } from 'nx/src/generators/tree';
 import { GeneratorCallback } from '@nx/devkit';
 import { NormalizedSchema } from '../schema';
-export declare function addRollupBuildTarget(host: Tree, options: NormalizedSchema & {
-    format?: Array<'esm' | 'cjs'>;
-}, external?: Set<String>): Promise<GeneratorCallback>;
+export declare function addRollupBuildTarget(host: Tree, options: NormalizedSchema): Promise<GeneratorCallback>;

package/src/generators/library/lib/add-rollup-build-target.js

@@ -4,7 +4,7 @@ exports.addRollupBuildTarget = addRollupBuildTarget;
 const devkit_1 = require("@nx/devkit");
 const maybe_js_1 = require("../../../utils/maybe-js");
 const versions_1 = require("../../../utils/versions");
-async function addRollupBuildTarget(host, options, external = new Set(['react', 'react-dom'])) {
+async function addRollupBuildTarget(host, options) {
     const tasks = [];
     const { configurationGenerator } = (0, devkit_1.ensurePackage)('@nx/rollup', versions_1.nxVersion);
     tasks.push(await configurationGenerator(host, {
@@ -19,11 +19,12 @@ async function addRollupBuildTarget(host, options, external = new Set(['react',
             '@svgr/rollup': versions_1.svgrRollupVersion,
         }));
     }
+    const external = ['react', 'react-dom'];
     if (options.style === '@emotion/styled') {
-        external.add('@emotion/react/jsx-runtime');
+        external.push('@emotion/react/jsx-runtime');
     }
     else {
-        external.add('react/jsx-runtime');
+        external.push('react/jsx-runtime');
     }
     const nxJson = (0, devkit_1.readNxJson)(host);
     const hasRollupPlugin = !!nxJson.plugins?.some((p) => typeof p === 'string'
@@ -43,8 +44,8 @@ module.exports = withNx(
             : (0, devkit_1.joinPathFragments)((0, devkit_1.offsetFromRoot)(options.projectRoot), 'dist', options.projectRoot)}',
     tsConfig: './tsconfig.lib.json',
     compiler: '${options.compiler ?? 'babel'}',
-    external: ${JSON.stringify(Array.from(external))},
-    format: ${JSON.stringify(options.format ?? ['esm'])},
+    external: ${JSON.stringify(external)},
+    format: ['esm'],
     assets:[{ input: '.', output: '.', glob: 'README.md'}],
   }, {
     // Provide additional rollup configuration here. See: https://rollupjs.org/configuration-options
@@ -73,7 +74,7 @@ module.exports = withNx(
                 tsConfig: `${options.projectRoot}/tsconfig.lib.json`,
                 project: `${options.projectRoot}/package.json`,
                 entryFile: (0, maybe_js_1.maybeJs)(options, `${options.projectRoot}/src/index.ts`),
-                external: Array.from(external),
+                external,
                 rollupConfig: `@nx/react/plugins/bundle-rollup`,
                 compiler: options.compiler ?? 'babel',
                 assets: [

package/src/utils/versions.d.ts

@@ -42,8 +42,8 @@ export declare const typesExpressVersion = "^4.17.21";
 export declare const isbotVersion = "^3.6.5";
 export declare const corsVersion = "~2.8.5";
 export declare const typesCorsVersion = "~2.8.12";
-export declare const moduleFederationNodeVersion = "^2.6.26";
-export declare const moduleFederationEnhancedVersion = "^0.9.0";
+export declare const moduleFederationNodeVersion = "^2.6.21";
+export declare const moduleFederationEnhancedVersion = "^0.8.8";
 export declare const lessVersion = "3.12.2";
 export declare const sassVersion = "^1.55.0";
 export declare const rollupPluginUrlVersion = "^8.0.2";

package/src/utils/versions.js

@@ -48,8 +48,8 @@ exports.typesExpressVersion = '^4.17.21';
 exports.isbotVersion = '^3.6.5';
 exports.corsVersion = '~2.8.5';
 exports.typesCorsVersion = '~2.8.12';
-exports.moduleFederationNodeVersion = '^2.6.26';
-exports.moduleFederationEnhancedVersion = '^0.9.0';
+exports.moduleFederationNodeVersion = '^2.6.21';
+exports.moduleFederationEnhancedVersion = '^0.8.8';
 // style preprocessors
 exports.lessVersion = '3.12.2';
 exports.sassVersion = '^1.55.0';