@nx/react-native 23.0.0-beta.17 → 23.0.0-beta.19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/react-native",
-  "version": "23.0.0-beta.17",
+  "version": "23.0.0-beta.19",
   "private": false,
   "description": "The Nx Plugin for React Native contains generators for managing React Native applications and libraries within an Nx workspace. It provides: \n\n-Integration with libraries such as Jest, Detox, and Storybook.\n-Scaffolding for creating buildable libraries that can be published to npm.\n-Utilities for automatic workspace refactoring.",
   "keywords": [
@@ -27,10 +27,10 @@
   "type": "commonjs",
   "types": "index.d.ts",
   "dependencies": {
-    "@nx/devkit": "23.0.0-beta.17",
-    "@nx/js": "23.0.0-beta.17",
-    "@nx/eslint": "23.0.0-beta.17",
-    "@nx/react": "23.0.0-beta.17",
+    "@nx/devkit": "23.0.0-beta.19",
+    "@nx/js": "23.0.0-beta.19",
+    "@nx/eslint": "23.0.0-beta.19",
+    "@nx/react": "23.0.0-beta.19",
     "ajv": "^8.0.0",
     "enhanced-resolve": "^5.8.3",
     "ignore": "^7.0.5",
@@ -44,11 +44,11 @@
     "metro-resolver": ">= 0.82.0"
   },
   "devDependencies": {
-    "nx": "23.0.0-beta.17"
+    "nx": "23.0.0-beta.19"
   },
   "optionalDependencies": {
-    "@nx/detox": "23.0.0-beta.17",
-    "@nx/rollup": "23.0.0-beta.17"
+    "@nx/detox": "23.0.0-beta.19",
+    "@nx/rollup": "23.0.0-beta.19"
   },
   "executors": "./executors.json",
   "ng-update": {

package/plugins/plugin.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"plugin.d.ts","sourceRoot":"","sources":["../../../../packages/react-native/plugins/plugin.ts"],"names":[],"mappings":"AAMA,OAAO,EAIL,aAAa,EAMd,MAAM,YAAY,CAAC;AAOpB,MAAM,WAAW,wBAAwB;IACvC,eAAe,CAAC,EAAE,MAAM,CAAC;IACzB,oBAAoB,CAAC,EAAE,MAAM,CAAC;IAC9B,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,oBAAoB,CAAC,EAAE,MAAM,CAAC;IAC9B,kBAAkB,CAAC,EAAE,MAAM,CAAC;IAC5B,sBAAsB,CAAC,EAAE,MAAM,CAAC;IAChC,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,kBAAkB,CAAC,EAAE,MAAM,CAAC;IAC5B,iBAAiB,CAAC,EAAE,MAAM,CAAC;CAC5B;AAOD,eAAO,MAAM,WAAW,EAAE,aAAa,CAAC,wBAAwB,CA+B/D,CAAC;AAEF,eAAO,MAAM,aAAa,yCAAc,CAAC"}
+{"version":3,"file":"plugin.d.ts","sourceRoot":"","sources":["../../../../packages/react-native/plugins/plugin.ts"],"names":[],"mappings":"AAMA,OAAO,EAML,aAAa,EAMd,MAAM,YAAY,CAAC;AAOpB,MAAM,WAAW,wBAAwB;IACvC,eAAe,CAAC,EAAE,MAAM,CAAC;IACzB,oBAAoB,CAAC,EAAE,MAAM,CAAC;IAC9B,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,oBAAoB,CAAC,EAAE,MAAM,CAAC;IAC9B,kBAAkB,CAAC,EAAE,MAAM,CAAC;IAC5B,sBAAsB,CAAC,EAAE,MAAM,CAAC;IAChC,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,kBAAkB,CAAC,EAAE,MAAM,CAAC;IAC5B,iBAAiB,CAAC,EAAE,MAAM,CAAC;CAC5B;AAOD,eAAO,MAAM,WAAW,EAAE,aAAa,CAAC,wBAAwB,CA6D/D,CAAC;AAEF,eAAO,MAAM,aAAa,yCAAc,CAAC"}

package/plugins/plugin.js

@@ -15,8 +15,29 @@ exports.createNodes = [
         const cachePath = (0, path_1.join)(cache_directory_1.workspaceDataDirectory, `react-native-${optionsHash}.hash`);
         const targetsCache = new internal_1.PluginCache(cachePath);
         const lockFileName = (0, js_1.getLockFileName)((0, devkit_1.detectPackageManager)(context.workspaceRoot));
+        const normalizedOptions = normalizeOptions(options);
         try {
-            return await (0, devkit_1.createNodesFromFiles)((configFile, options, context) => createNodesInternal(configFile, options, context, targetsCache, lockFileName), configFiles, options, context);
+            const { entries, preErrors } = await filterReactNativeConfigs(configFiles, context);
+            const projectHashes = await (0, internal_1.calculateHashesForCreateNodes)(entries.map((e) => e.projectRoot), normalizedOptions, context, entries.map(() => [lockFileName]));
+            let results = [];
+            let nodeErrors = [];
+            try {
+                results = await (0, devkit_1.createNodesFromFiles)((configFile, _, ctx, idx) => createNodesInternal(configFile, normalizedOptions, ctx, targetsCache, projectHashes[idx]), entries.map((e) => e.configFile), options, context);
+            }
+            catch (e) {
+                if (e instanceof devkit_1.AggregateCreateNodesError) {
+                    results = e.partialResults ?? [];
+                    nodeErrors = e.errors;
+                }
+                else {
+                    throw e;
+                }
+            }
+            const allErrors = [...preErrors, ...nodeErrors];
+            if (allErrors.length > 0) {
+                throw new devkit_1.AggregateCreateNodesError(allErrors, results);
+            }
+            return results;
         }
         finally {
             targetsCache.writeToDisk();
@@ -24,24 +45,8 @@ exports.createNodes = [
     },
 ];
 exports.createNodesV2 = exports.createNodes;
-async function createNodesInternal(configFile, options, context, targetsCache, lockFileName) {
-    options = normalizeOptions(options);
+async function createNodesInternal(configFile, options, context, targetsCache, hash) {
     const projectRoot = (0, path_1.dirname)(configFile);
-    // Do not create a project if package.json or project.json or metro.config.js isn't there.
-    const siblingFiles = (0, fs_1.readdirSync)((0, path_1.join)(context.workspaceRoot, projectRoot));
-    if (!siblingFiles.includes('package.json') ||
-        !siblingFiles.includes('metro.config.js')) {
-        return {};
-    }
-    // Check if it's an Expo project
-    const packageJson = (0, devkit_1.readJsonFile)((0, path_1.join)(context.workspaceRoot, projectRoot, 'package.json'));
-    const appConfig = await getAppConfig(configFile, context);
-    if (appConfig.expo ||
-        packageJson.dependencies?.['expo'] ||
-        packageJson.devDependencies?.['expo']) {
-        return {};
-    }
-    const hash = await (0, internal_1.calculateHashForCreateNodes)(projectRoot, options, context, [lockFileName]);
     if (!targetsCache.has(hash)) {
         targetsCache.set(hash, buildReactNativeTargets(projectRoot, options, context));
     }
@@ -112,6 +117,36 @@ function getAppConfig(configFilePath, context) {
     const resolvedPath = (0, path_1.join)(context.workspaceRoot, configFilePath);
     return (0, internal_1.loadConfigFile)(resolvedPath);
 }
+async function filterReactNativeConfigs(configFiles, context) {
+    const preErrors = [];
+    const candidates = await Promise.all(configFiles.map(async (configFile) => {
+        try {
+            const projectRoot = (0, path_1.dirname)(configFile);
+            const siblingFiles = (0, fs_1.readdirSync)((0, path_1.join)(context.workspaceRoot, projectRoot));
+            if (!siblingFiles.includes('package.json') ||
+                !siblingFiles.includes('metro.config.js')) {
+                return null;
+            }
+            // Skip Expo projects; the @nx/expo plugin handles them.
+            const packageJson = (0, devkit_1.readJsonFile)((0, path_1.join)(context.workspaceRoot, projectRoot, 'package.json'));
+            const appConfig = await getAppConfig(configFile, context);
+            if (appConfig.expo ||
+                packageJson.dependencies?.['expo'] ||
+                packageJson.devDependencies?.['expo']) {
+                return null;
+            }
+            return { configFile, projectRoot };
+        }
+        catch (e) {
+            preErrors.push([configFile, e]);
+            return null;
+        }
+    }));
+    return {
+        entries: candidates.filter((c) => c !== null),
+        preErrors,
+    };
+}
 function getInputs(namedInputs) {
     return [
         ...('production' in namedInputs