@nx/react-native 16.6.0-beta.3 → 16.6.0-beta.5

package/.eslintrc.json

@@ -14,6 +14,29 @@
       "rules": {
         "@nx/nx-plugin-checks": "error"
       }
+    },
+    {
+      "files": ["./package.json"],
+      "parser": "jsonc-eslint-parser",
+      "rules": {
+        "@nx/dependency-checks": [
+          "error",
+          {
+            "buildTargets": ["build-base"],
+            "ignoredDependencies": [
+              "nx",
+              "eslint",
+              "prettier",
+              "typescript",
+              "react",
+              "react-native",
+              // These are in ensurePackage
+              "@nx/rollup",
+              "@nx/storybook"
+            ]
+          }
+        ]
+      }
     }
   ]
 }

package/migrations.json

@@ -89,6 +89,18 @@
       "version": "16.1.0-beta.0",
       "description": "Upgrade @storybook/react-native to 6.5",
       "implementation": "./src/migrations/update-16-1-0/upgrade-storybook-6-5"
+    },
+    "update-16-6-0-add-dependsOn": {
+      "cli": "nx",
+      "version": "16.6.0-beta.0",
+      "description": "Add dependsOn like ensure-symlink or sync-deps to targets",
+      "implementation": "./src/migrations/update-16-6-0/add-depends-on"
+    },
+    "update-16-6-0-update-metro-config": {
+      "cli": "nx",
+      "version": "16.6.0-beta.0",
+      "description": "Update metro.config.js to use the new metro config format",
+      "implementation": "./src/migrations/update-16-6-0/update-metro-config"
     }
   },
   "packageJsonUpdates": {
@@ -1348,6 +1360,72 @@
           "alwaysAddToPackageJson": false
         }
       }
+    },
+    "16.6.0": {
+      "version": "16.6.0-beta.0",
+      "packages": {
+        "react-native": {
+          "version": "0.72.3",
+          "alwaysAddToPackageJson": false
+        },
+        "@types/react-native": {
+          "version": "0.72.2",
+          "alwaysAddToPackageJson": false
+        },
+        "metro": {
+          "version": "0.76.7",
+          "alwaysAddToPackageJson": false
+        },
+        "metro-resolver": {
+          "version": "0.76.7",
+          "alwaysAddToPackageJson": false
+        },
+        "metro-config": {
+          "version": "0.76.7",
+          "alwaysAddToPackageJson": false
+        },
+        "metro-react-native-babel-preset": {
+          "version": "0.76.7",
+          "alwaysAddToPackageJson": false
+        },
+        "metro-babel-register": {
+          "version": "0.76.7",
+          "alwaysAddToPackageJson": false
+        },
+        "metro-react-native-babel-transformer": {
+          "version": "0.76.7",
+          "alwaysAddToPackageJson": false
+        },
+        "@react-native/metro-config": {
+          "version": "^0.72.9",
+          "alwaysAddToPackageJson": false,
+          "addToPackageJson": "devDependencies"
+        },
+        "@react-native-community/cli": {
+          "version": "11.3.5",
+          "alwaysAddToPackageJson": false
+        },
+        "@react-native-community/cli-platform-android": {
+          "version": "11.3.5",
+          "alwaysAddToPackageJson": false
+        },
+        "@react-native-community/cli-platform-ios": {
+          "version": "11.3.5",
+          "alwaysAddToPackageJson": false
+        },
+        "@babel/runtime": {
+          "version": "7.22.6",
+          "alwaysAddToPackageJson": false
+        },
+        "@react-native-async-storage/async-storage": {
+          "version": "1.19.0",
+          "alwaysAddToPackageJson": false
+        },
+        "react-native-safe-area-context": {
+          "version": "4.7.1",
+          "alwaysAddToPackageJson": false
+        }
+      }
     }
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/react-native",
-  "version": "16.6.0-beta.3",
+  "version": "16.6.0-beta.5",
   "private": false,
   "description": "The Nx Plugin for React Native contains generators for managing React Native applications and libraries within an Nx workspace. It provides: \n\n-Integration with libraries such as Jest, Detox, and Storybook.\n-Scaffolding for creating buildable libraries that can be published to npm.\n-Utilities for automatic workspace refactoring.",
   "keywords": [
@@ -25,26 +25,28 @@
   "main": "./index",
   "types": "index.d.ts",
   "dependencies": {
-    "@nrwl/react-native": "16.6.0-beta.3",
-    "@nx/detox": "16.6.0-beta.3",
-    "@nx/devkit": "16.6.0-beta.3",
-    "@nx/jest": "16.6.0-beta.3",
-    "@nx/js": "16.6.0-beta.3",
-    "@nx/linter": "16.6.0-beta.3",
-    "@nx/react": "16.6.0-beta.3",
-    "@nx/workspace": "16.6.0-beta.3",
+    "@nrwl/react-native": "16.6.0-beta.5",
+    "@nx/detox": "16.6.0-beta.5",
+    "@nx/devkit": "16.6.0-beta.5",
+    "@nx/jest": "16.6.0-beta.5",
+    "@nx/js": "16.6.0-beta.5",
+    "@nx/linter": "16.6.0-beta.5",
+    "@nx/react": "16.6.0-beta.5",
+    "@nx/workspace": "16.6.0-beta.5",
     "chalk": "^4.1.0",
     "enhanced-resolve": "^5.8.3",
     "fs-extra": "^11.1.0",
     "glob": "7.1.4",
     "ignore": "^5.0.4",
-    "metro-resolver": "^0.74.1",
+    "metro-config": "0.76.7",
+    "metro-resolver": "0.76.7",
     "minimatch": "3.0.5",
     "node-fetch": "^2.6.7",
-    "tsconfig-paths": "^4.1.2"
+    "tsconfig-paths": "^4.1.2",
+    "tslib": "^2.3.0"
   },
   "peerDependencies": {
-    "react-native": ">= 0.71.0"
+    "react-native": ">= 0.72.0 < 0.73.0"
   },
   "builders": "./executors.json",
   "ng-update": {
@@ -55,5 +57,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "cd8c61d7a3b8ab9bc7bab068f5ca49bbf14abbf5"
+  "gitHead": "aab868aa0c30949832fe2c4b9cb109c204442e39"
 }

package/plugins/with-nx-metro.d.ts

@@ -1,8 +1,12 @@
+import type { MetroConfig } from 'metro-config';
 interface WithNxOptions {
     debug?: boolean;
     extensions?: string[];
+    /**
+     * @deprecated TODO(v17) in the metro.config.js, pass in to the getDefaultConfig instead: getDefaultConfig(__dirname)
+     */
     projectRoot?: string;
     watchFolders?: string[];
 }
-export declare function withNxMetro(config: any, opts?: WithNxOptions): any;
+export declare function withNxMetro(userConfig: MetroConfig, opts?: WithNxOptions): Promise<import("metro-config").ConfigT>;
 export {};

package/plugins/with-nx-metro.js

@@ -1,32 +1,37 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.withNxMetro = void 0;
+const tslib_1 = require("tslib");
 const devkit_1 = require("@nx/devkit");
+const metro_config_1 = require("metro-config");
 const path_1 = require("path");
 const fs_extra_1 = require("fs-extra");
 const metro_resolver_1 = require("./metro-resolver");
-function withNxMetro(config, opts = {}) {
+function withNxMetro(userConfig, opts = {}) {
     var _a;
-    const extensions = ['', 'ts', 'tsx', 'js', 'jsx', 'json'];
-    if (opts.debug)
-        process.env.NX_REACT_NATIVE_DEBUG = 'true';
-    if (opts.extensions)
-        extensions.push(...opts.extensions);
-    config.projectRoot = opts.projectRoot || devkit_1.workspaceRoot;
-    // Add support for paths specified by tsconfig
-    config.resolver = Object.assign(Object.assign({}, config.resolver), { resolveRequest: (0, metro_resolver_1.getResolveRequest)(extensions) });
-    let watchFolders = config.watchFolders || [];
-    watchFolders = watchFolders.concat([
-        (0, path_1.join)(devkit_1.workspaceRoot, 'node_modules'),
-        (0, path_1.join)(devkit_1.workspaceRoot, (0, devkit_1.workspaceLayout)().libsDir),
-        (0, path_1.join)(devkit_1.workspaceRoot, 'packages'),
-        (0, path_1.join)(devkit_1.workspaceRoot, '.storybook'),
-    ]);
-    if ((_a = opts.watchFolders) === null || _a === void 0 ? void 0 : _a.length) {
-        watchFolders = watchFolders.concat(opts.watchFolders);
-    }
-    watchFolders = watchFolders.filter((folder) => (0, fs_extra_1.existsSync)(folder));
-    config.watchFolders = watchFolders;
-    return config;
+    return tslib_1.__awaiter(this, void 0, void 0, function* () {
+        const extensions = ['', 'ts', 'tsx', 'js', 'jsx', 'json'];
+        if (opts.debug)
+            process.env.NX_REACT_NATIVE_DEBUG = 'true';
+        if (opts.extensions)
+            extensions.push(...opts.extensions);
+        let watchFolders = [
+            (0, path_1.join)(devkit_1.workspaceRoot, 'node_modules'),
+            (0, path_1.join)(devkit_1.workspaceRoot, (0, devkit_1.workspaceLayout)().libsDir),
+            (0, path_1.join)(devkit_1.workspaceRoot, 'packages'),
+            (0, path_1.join)(devkit_1.workspaceRoot, '.storybook'),
+        ];
+        if ((_a = opts.watchFolders) === null || _a === void 0 ? void 0 : _a.length) {
+            watchFolders = watchFolders.concat(opts.watchFolders);
+        }
+        watchFolders = watchFolders.filter((folder) => (0, fs_extra_1.existsSync)(folder));
+        const nxConfig = {
+            resolver: {
+                resolveRequest: (0, metro_resolver_1.getResolveRequest)(extensions),
+            },
+            watchFolders,
+        };
+        return (0, metro_config_1.mergeConfig)(userConfig, nxConfig);
+    });
 }
 exports.withNxMetro = withNxMetro;

package/src/executors/build-android/build-android.impl.js

@@ -2,60 +2,46 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const tslib_1 = require("tslib");
 const path_1 = require("path");
-const ensure_node_modules_symlink_1 = require("../../utils/ensure-node-modules-symlink");
 const child_process_1 = require("child_process");
 const chmod_android_gradle_files_1 = require("../../utils/chmod-android-gradle-files");
-const start_impl_1 = require("../start/start.impl");
-const sync_deps_impl_1 = require("../sync-deps/sync-deps.impl");
 const get_cli_options_1 = require("../../utils/get-cli-options");
-let childProcess;
 function buildAndroidExecutor(options, context) {
     return tslib_1.__asyncGenerator(this, arguments, function* buildAndroidExecutor_1() {
         const projectRoot = context.projectsConfigurations.projects[context.projectName].root;
-        (0, ensure_node_modules_symlink_1.ensureNodeModulesSymlink)(context.root, projectRoot);
-        if (options.sync) {
-            (0, sync_deps_impl_1.displayNewlyAddedDepsMessage)(context.projectName, yield tslib_1.__await((0, sync_deps_impl_1.syncDeps)(context.projectName, projectRoot, context.root, context.projectGraph)));
-        }
         (0, chmod_android_gradle_files_1.chmodAndroidGradlewFiles)((0, path_1.join)(projectRoot, 'android'));
-        try {
-            const tasks = [runCliBuild(context.root, projectRoot, options)];
-            if (options.packager && options.mode !== 'release') {
-                tasks.push((0, start_impl_1.runCliStart)(context.root, projectRoot, {
-                    port: options.port,
-                    resetCache: options.resetCache,
-                    interactive: options.interactive,
-                }));
-            }
-            yield tslib_1.__await(Promise.all(tasks));
-            yield yield tslib_1.__await({ success: true });
-        }
-        finally {
-            if (childProcess) {
-                childProcess.kill();
-            }
-        }
+        yield tslib_1.__await(runCliBuild(context.root, projectRoot, options));
+        yield yield tslib_1.__await({ success: true });
     });
 }
 exports.default = buildAndroidExecutor;
 function runCliBuild(workspaceRoot, projectRoot, options) {
-    return new Promise((resolve, reject) => {
+    return new Promise((res, reject) => {
         /**
          * Call the react native cli with option `--no-packager`
          * Not passing '--packager' due to cli will launch start command from the project root
          */
-        childProcess = (0, child_process_1.fork)((0, path_1.join)(workspaceRoot, './node_modules/react-native/cli.js'), ['build-android', ...createBuildAndroidOptions(options), '--no-packager'], {
-            cwd: (0, path_1.join)(workspaceRoot, projectRoot),
+        const childProcess = (0, child_process_1.fork)(require.resolve('react-native/cli.js'), ['build-android', ...createBuildAndroidOptions(options), '--no-packager'], {
+            stdio: 'inherit',
+            cwd: (0, path_1.resolve)(workspaceRoot, projectRoot),
             env: Object.assign(Object.assign({}, process.env), { RCT_METRO_PORT: options.port.toString() }),
         });
-        // Ensure the child process is killed when the parent exits
-        process.on('exit', () => childProcess.kill());
-        process.on('SIGTERM', () => childProcess.kill());
+        /**
+         * Ensure the child process is killed when the parent exits
+         */
+        const processExitListener = (signal) => () => {
+            childProcess.kill(signal);
+            process.exit();
+        };
+        process.once('exit', (signal) => childProcess.kill(signal));
+        process.once('SIGTERM', processExitListener);
+        process.once('SIGINT', processExitListener);
+        process.once('SIGQUIT', processExitListener);
         childProcess.on('error', (err) => {
             reject(err);
         });
         childProcess.on('exit', (code) => {
             if (code === 0) {
-                resolve(code);
+                res(childProcess);
             }
             else {
                 reject(code);

package/src/executors/build-android/build-android.impl.ts

@@ -1,62 +1,24 @@
-import { ExecutorContext, names } from '@nx/devkit';
-import { join } from 'path';
-import { ensureNodeModulesSymlink } from '../../utils/ensure-node-modules-symlink';
+import { ExecutorContext } from '@nx/devkit';
+import { join, resolve as pathResolve } from 'path';
 import { ChildProcess, fork } from 'child_process';
 import { ReactNativeBuildAndroidOptions } from './schema';
 import { chmodAndroidGradlewFiles } from '../../utils/chmod-android-gradle-files';
-import { runCliStart } from '../start/start.impl';
-import {
-  displayNewlyAddedDepsMessage,
-  syncDeps,
-} from '../sync-deps/sync-deps.impl';
 import { getCliOptions } from '../../utils/get-cli-options';
 
 export interface ReactNativeBuildOutput {
   success: boolean;
 }
 
-let childProcess: ChildProcess;
-
 export default async function* buildAndroidExecutor(
   options: ReactNativeBuildAndroidOptions,
   context: ExecutorContext
 ): AsyncGenerator<ReactNativeBuildOutput> {
   const projectRoot =
     context.projectsConfigurations.projects[context.projectName].root;
-  ensureNodeModulesSymlink(context.root, projectRoot);
-  if (options.sync) {
-    displayNewlyAddedDepsMessage(
-      context.projectName,
-      await syncDeps(
-        context.projectName,
-        projectRoot,
-        context.root,
-        context.projectGraph
-      )
-    );
-  }
-
   chmodAndroidGradlewFiles(join(projectRoot, 'android'));
 
-  try {
-    const tasks = [runCliBuild(context.root, projectRoot, options)];
-    if (options.packager && options.mode !== 'release') {
-      tasks.push(
-        runCliStart(context.root, projectRoot, {
-          port: options.port,
-          resetCache: options.resetCache,
-          interactive: options.interactive,
-        })
-      );
-    }
-
-    await Promise.all(tasks);
-    yield { success: true };
-  } finally {
-    if (childProcess) {
-      childProcess.kill();
-    }
-  }
+  await runCliBuild(context.root, projectRoot, options);
+  yield { success: true };
 }
 
 function runCliBuild(
@@ -64,30 +26,39 @@ function runCliBuild(
   projectRoot: string,
   options: ReactNativeBuildAndroidOptions
 ) {
-  return new Promise((resolve, reject) => {
+  return new Promise<ChildProcess>((res, reject) => {
     /**
      * Call the react native cli with option `--no-packager`
      * Not passing '--packager' due to cli will launch start command from the project root
      */
-    childProcess = fork(
-      join(workspaceRoot, './node_modules/react-native/cli.js'),
+    const childProcess = fork(
+      require.resolve('react-native/cli.js'),
       ['build-android', ...createBuildAndroidOptions(options), '--no-packager'],
       {
-        cwd: join(workspaceRoot, projectRoot),
+        stdio: 'inherit',
+        cwd: pathResolve(workspaceRoot, projectRoot),
         env: { ...process.env, RCT_METRO_PORT: options.port.toString() },
       }
     );
 
-    // Ensure the child process is killed when the parent exits
-    process.on('exit', () => childProcess.kill());
-    process.on('SIGTERM', () => childProcess.kill());
+    /**
+     * Ensure the child process is killed when the parent exits
+     */
+    const processExitListener = (signal?: number | NodeJS.Signals) => () => {
+      childProcess.kill(signal);
+      process.exit();
+    };
+    process.once('exit', (signal) => childProcess.kill(signal));
+    process.once('SIGTERM', processExitListener);
+    process.once('SIGINT', processExitListener);
+    process.once('SIGQUIT', processExitListener);
 
     childProcess.on('error', (err) => {
       reject(err);
     });
     childProcess.on('exit', (code) => {
       if (code === 0) {
-        resolve(code);
+        res(childProcess);
       } else {
         reject(code);
       }

package/src/executors/build-android/schema.d.ts

@@ -1,4 +1,5 @@
 // options taken from https://github.com/react-native-community/cli/blob/main/packages/cli-platform-android/src/commands/buildAndroid/index.ts
+// https://github.com/react-native-community/cli/blob/main/packages/cli-platform-android/README.md#build-android
 
 import { ReactNativeStartOptions } from '../start/schema';
 
@@ -20,12 +21,13 @@ export interface ReactNativeBuildAndroidOptions
   // react native options
   mode: string; // default is debug
   activeArchOnly: boolean; // default is false
-  port: number; // default is 8081
-  tasks?: Array<string>;
+  tasks?: string | Array<string>;
   extraParams?: Array<string>;
-  interactive?: boolean;
+  interactive: boolean;
 
   // nx options
+  // @deprecated, no longer used
   packager: boolean; // default is true
+  // @deprecated, add to sync-deps to dependsOn
   sync: boolean;
 }

package/src/executors/build-android/schema.json

@@ -51,7 +51,8 @@
     "packager": {
       "type": "boolean",
       "description": "Launch packager while building",
-      "default": true
+      "default": true,
+      "x-deprecated": "Run `nx run <project>:start` instead. Will be removed in Nx 17."
     },
     "port": {
       "type": "number",
@@ -59,10 +60,10 @@
       "default": 8081
     },
     "tasks": {
-      "type": "array",
-      "items": {
-        "type": "string"
-      },
+      "oneOf": [
+        { "type": "array", "items": { "type": "string" } },
+        { "type": "string" }
+      ],
       "description": "Run custom Gradle tasks. By default it's \"assembleDebug\". Will override passed mode and variant arguments.",
       "examples": [
         "assembleDebug",
@@ -79,8 +80,12 @@
       "default": false
     },
     "extraParams": {
-      "type": "string",
-      "description": "Custom params passed to gradle build command"
+      "oneOf": [
+        { "type": "array", "items": { "type": "string" } },
+        { "type": "string" }
+      ],
+      "description": "Custom params passed to gradle build command",
+      "examples": ["-x lint -x test"]
     },
     "interactive": {
       "type": "boolean",
@@ -89,7 +94,8 @@
     "sync": {
       "type": "boolean",
       "description": "Syncs npm dependencies to `package.json` (for React Native autolink).",
-      "default": true
+      "default": true,
+      "x-deprecated": "Add sync-deps to dependsOn instead"
     },
     "resetCache": {
       "type": "boolean",

package/src/executors/build-ios/build-ios.impl.d.ts

@@ -3,4 +3,4 @@ import { ReactNativeBuildIosOptions } from './schema';
 export interface ReactNativeBuildIosOutput {
     success: boolean;
 }
-export default function runIosExecutor(options: ReactNativeBuildIosOptions, context: ExecutorContext): AsyncGenerator<ReactNativeBuildIosOutput>;
+export default function buildIosExecutor(options: ReactNativeBuildIosOptions, context: ExecutorContext): AsyncGenerator<ReactNativeBuildIosOutput>;

package/src/executors/build-ios/build-ios.impl.js

@@ -4,64 +4,45 @@ const tslib_1 = require("tslib");
 const path_1 = require("path");
 const child_process_1 = require("child_process");
 const os_1 = require("os");
-const ensure_node_modules_symlink_1 = require("../../utils/ensure-node-modules-symlink");
-const sync_deps_impl_1 = require("../sync-deps/sync-deps.impl");
-const pod_install_task_1 = require("../../utils/pod-install-task");
-const start_impl_1 = require("../start/start.impl");
 const get_cli_options_1 = require("../../utils/get-cli-options");
-let childProcess;
-function runIosExecutor(options, context) {
-    return tslib_1.__asyncGenerator(this, arguments, function* runIosExecutor_1() {
+function buildIosExecutor(options, context) {
+    return tslib_1.__asyncGenerator(this, arguments, function* buildIosExecutor_1() {
         if ((0, os_1.platform)() !== 'darwin') {
             throw new Error(`The run-ios build requires Mac to run`);
         }
         const projectRoot = context.projectsConfigurations.projects[context.projectName].root;
-        (0, ensure_node_modules_symlink_1.ensureNodeModulesSymlink)(context.root, projectRoot);
-        if (options.sync) {
-            (0, sync_deps_impl_1.displayNewlyAddedDepsMessage)(context.projectName, yield tslib_1.__await((0, sync_deps_impl_1.syncDeps)(context.projectName, projectRoot, context.root, context.projectGraph)));
-        }
-        if (options.install) {
-            yield tslib_1.__await((0, pod_install_task_1.podInstall)((0, path_1.join)(context.root, projectRoot, 'ios'), options.buildFolder));
-        }
-        try {
-            const tasks = [runCliBuildIOS(context.root, projectRoot, options)];
-            if (options.packager && options.mode !== 'Release') {
-                tasks.push((0, start_impl_1.runCliStart)(context.root, projectRoot, {
-                    port: options.port,
-                    resetCache: options.resetCache,
-                    interactive: options.interactive,
-                }));
-            }
-            yield tslib_1.__await(Promise.all(tasks));
-            yield yield tslib_1.__await({ success: true });
-        }
-        finally {
-            if (childProcess) {
-                childProcess.kill();
-            }
-        }
+        yield tslib_1.__await(runCliBuildIOS(context.root, projectRoot, options));
+        return yield tslib_1.__await({ success: true });
     });
 }
-exports.default = runIosExecutor;
+exports.default = buildIosExecutor;
 function runCliBuildIOS(workspaceRoot, projectRoot, options) {
     return new Promise((resolve, reject) => {
-        /**
-         * Call the react native cli with option `--no-packager`
-         * Not passing '--packager' due to cli will launch start command from the project root
-         */
-        childProcess = (0, child_process_1.fork)((0, path_1.join)(workspaceRoot, './node_modules/react-native/cli.js'), ['build-ios', ...createBuildIOSOptions(options)], {
-            cwd: (0, path_1.join)(workspaceRoot, projectRoot),
+        const childProcess = (0, child_process_1.fork)(require.resolve('react-native/cli.js'), [
+            'build-ios',
+            ...createBuildIOSOptions(options),
+            ...(process.env.NX_VERBOSE_LOGGING === 'true' ? ['--verbose'] : []),
+        ], {
+            cwd: (0, path_1.resolve)(workspaceRoot, projectRoot),
             env: Object.assign(Object.assign({}, process.env), { RCT_METRO_PORT: options.port.toString() }),
         });
-        // Ensure the child process is killed when the parent exits
-        process.on('exit', () => childProcess.kill());
-        process.on('SIGTERM', () => childProcess.kill());
+        /**
+         * Ensure the child process is killed when the parent exits
+         */
+        const processExitListener = (signal) => () => {
+            childProcess.kill(signal);
+            process.exit();
+        };
+        process.once('exit', (signal) => childProcess.kill(signal));
+        process.once('SIGTERM', processExitListener);
+        process.once('SIGINT', processExitListener);
+        process.once('SIGQUIT', processExitListener);
         childProcess.on('error', (err) => {
             reject(err);
         });
         childProcess.on('exit', (code) => {
             if (code === 0) {
-                resolve(code);
+                resolve(childProcess);
             }
             else {
                 reject(code);