@nx/react-native 0.0.0-pr-28229-afe192c → 0.0.0-pr-28517-630ecca

package/migrations.json

@@ -1,35 +1,5 @@
 {
   "generators": {
-    "update-16-0-0-add-nx-packages": {
-      "cli": "nx",
-      "version": "16.0.0-beta.1",
-      "description": "Replace @nrwl/react-native with @nx/react-native",
-      "implementation": "./src/migrations/update-16-0-0-add-nx-packages/update-16-0-0-add-nx-packages"
-    },
-    "update-16-1-0-upgrade-storybook-6-5": {
-      "cli": "nx",
-      "version": "16.1.0-beta.0",
-      "description": "Upgrade @storybook/react-native to 6.5",
-      "implementation": "./src/migrations/update-16-1-0/upgrade-storybook-6-5"
-    },
-    "update-16-6-0-add-dependsOn": {
-      "cli": "nx",
-      "version": "16.6.0-beta.0",
-      "description": "Add dependsOn like ensure-symlink or sync-deps to targets",
-      "implementation": "./src/migrations/update-16-6-0/add-depends-on"
-    },
-    "update-16-6-0-update-metro-config": {
-      "cli": "nx",
-      "version": "16.6.0-beta.0",
-      "description": "Update metro.config.js to use the new metro config format",
-      "implementation": "./src/migrations/update-16-6-0/update-metro-config"
-    },
-    "update-16-9-0-remove-types-react-native": {
-      "cli": "nx",
-      "version": "16.9.0-beta.1",
-      "description": "Remove @types/react-native from package.json",
-      "implementation": "./src/migrations/update-16-9-0/remove-types-react-native"
-    },
     "update-18-0-0-add-web-configuration": {
       "cli": "nx",
       "version": "18.0.0-beta.0",
@@ -74,189 +44,6 @@
     }
   },
   "packageJsonUpdates": {
-    "16.0.0": {
-      "version": "16.0.0-beta.0",
-      "packages": {
-        "@react-native-community/cli": {
-          "version": "10.2.2",
-          "alwaysAddToPackageJson": false
-        },
-        "react-native": {
-          "version": "0.71.7",
-          "alwaysAddToPackageJson": false
-        },
-        "@types/react-native": {
-          "version": "0.71.6",
-          "alwaysAddToPackageJson": false
-        },
-        "@testing-library/react-native": {
-          "version": "12.0.1",
-          "alwaysAddToPackageJson": false
-        },
-        "react-native-svg": {
-          "version": "13.9.0",
-          "alwaysAddToPackageJson": false
-        }
-      }
-    },
-    "16.0.2": {
-      "version": "16.0.2-beta.0",
-      "packages": {
-        "@react-native-async-storage/async-storage": {
-          "version": "1.18.1",
-          "alwaysAddToPackageJson": false
-        },
-        "react-native-safe-area-context": {
-          "version": "4.5.1",
-          "alwaysAddToPackageJson": false
-        }
-      }
-    },
-    "16.1.5": {
-      "version": "16.1.5-beta.0",
-      "packages": {
-        "react-native": {
-          "version": "0.71.8",
-          "alwaysAddToPackageJson": false
-        },
-        "@types/react-native": {
-          "version": "0.71.7",
-          "alwaysAddToPackageJson": false
-        },
-        "@testing-library/react-native": {
-          "version": "12.1.2",
-          "alwaysAddToPackageJson": false
-        },
-        "react-native-safe-area-context": {
-          "version": "4.5.2",
-          "alwaysAddToPackageJson": false
-        }
-      }
-    },
-    "16.4.0": {
-      "version": "16.4.0-beta.5",
-      "packages": {
-        "react-native": {
-          "version": "0.71.10",
-          "alwaysAddToPackageJson": false
-        },
-        "@react-native-async-storage/async-storage": {
-          "version": "1.18.2",
-          "alwaysAddToPackageJson": false
-        },
-        "react-native-safe-area-context": {
-          "version": "4.5.3",
-          "alwaysAddToPackageJson": false
-        }
-      }
-    },
-    "16.6.0": {
-      "version": "16.6.0-beta.0",
-      "packages": {
-        "react-native": {
-          "version": "0.72.3",
-          "alwaysAddToPackageJson": false
-        },
-        "@types/react-native": {
-          "version": "0.72.2",
-          "alwaysAddToPackageJson": false
-        },
-        "metro": {
-          "version": "0.76.7",
-          "alwaysAddToPackageJson": false
-        },
-        "metro-resolver": {
-          "version": "0.76.7",
-          "alwaysAddToPackageJson": false
-        },
-        "metro-config": {
-          "version": "0.76.7",
-          "alwaysAddToPackageJson": false
-        },
-        "metro-react-native-babel-preset": {
-          "version": "0.76.7",
-          "alwaysAddToPackageJson": false
-        },
-        "metro-babel-register": {
-          "version": "0.76.7",
-          "alwaysAddToPackageJson": false
-        },
-        "metro-react-native-babel-transformer": {
-          "version": "0.76.7",
-          "alwaysAddToPackageJson": false
-        },
-        "@react-native/metro-config": {
-          "version": "^0.72.9",
-          "alwaysAddToPackageJson": false,
-          "addToPackageJson": "devDependencies"
-        },
-        "@react-native-community/cli": {
-          "version": "11.3.5",
-          "alwaysAddToPackageJson": false
-        },
-        "@react-native-community/cli-platform-android": {
-          "version": "11.3.5",
-          "alwaysAddToPackageJson": false
-        },
-        "@react-native-community/cli-platform-ios": {
-          "version": "11.3.5",
-          "alwaysAddToPackageJson": false
-        },
-        "@babel/runtime": {
-          "version": "7.22.6",
-          "alwaysAddToPackageJson": false
-        },
-        "@react-native-async-storage/async-storage": {
-          "version": "1.19.0",
-          "alwaysAddToPackageJson": false
-        },
-        "react-native-safe-area-context": {
-          "version": "4.7.1",
-          "alwaysAddToPackageJson": false
-        }
-      }
-    },
-    "16.9.0": {
-      "version": "16.9.0-beta.1",
-      "packages": {
-        "react-native": {
-          "version": "0.72.4",
-          "alwaysAddToPackageJson": false
-        },
-        "@react-native/metro-config": {
-          "version": "^0.72.11",
-          "alwaysAddToPackageJson": false
-        },
-        "@react-native-community/cli": {
-          "version": "11.3.6",
-          "alwaysAddToPackageJson": false
-        },
-        "@react-native-community/cli-platform-android": {
-          "version": "11.3.6",
-          "alwaysAddToPackageJson": false
-        },
-        "@react-native-community/cli-platform-ios": {
-          "version": "11.3.6",
-          "alwaysAddToPackageJson": false
-        },
-        "@testing-library/react-native": {
-          "version": "~12.3.0",
-          "alwaysAddToPackageJson": false
-        },
-        "@testing-library/jest-native": {
-          "version": "~5.4.3",
-          "alwaysAddToPackageJson": false
-        },
-        "@react-native-async-storage/async-storage": {
-          "version": "~1.19.3",
-          "alwaysAddToPackageJson": false
-        },
-        "react-native-safe-area-context": {
-          "version": "~4.7.2",
-          "alwaysAddToPackageJson": false
-        }
-      }
-    },
     "17.1.0": {
       "version": "17.1.0-beta.1",
       "packages": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/react-native",
-  "version": "0.0.0-pr-28229-afe192c",
+  "version": "0.0.0-pr-28517-630ecca",
   "private": false,
   "description": "The Nx Plugin for React Native contains generators for managing React Native applications and libraries within an Nx workspace. It provides: \n\n-Integration with libraries such as Jest, Detox, and Storybook.\n-Scaffolding for creating buildable libraries that can be published to npm.\n-Utilities for automatic workspace refactoring.",
   "keywords": [
@@ -36,12 +36,12 @@
     "node-fetch": "^2.6.7",
     "tsconfig-paths": "^4.1.2",
     "tslib": "^2.3.0",
-    "@nx/devkit": "0.0.0-pr-28229-afe192c",
-    "@nx/jest": "0.0.0-pr-28229-afe192c",
-    "@nx/js": "0.0.0-pr-28229-afe192c",
-    "@nx/eslint": "0.0.0-pr-28229-afe192c",
-    "@nx/react": "0.0.0-pr-28229-afe192c",
-    "@nx/workspace": "0.0.0-pr-28229-afe192c"
+    "@nx/devkit": "0.0.0-pr-28517-630ecca",
+    "@nx/jest": "0.0.0-pr-28517-630ecca",
+    "@nx/js": "0.0.0-pr-28517-630ecca",
+    "@nx/eslint": "0.0.0-pr-28517-630ecca",
+    "@nx/react": "0.0.0-pr-28517-630ecca",
+    "@nx/workspace": "0.0.0-pr-28517-630ecca"
   },
   "executors": "./executors.json",
   "ng-update": {

package/src/generators/application/application.js

@@ -5,6 +5,7 @@ exports.reactNativeApplicationGeneratorInternal = reactNativeApplicationGenerato
 const devkit_1 = require("@nx/devkit");
 const js_1 = require("@nx/js");
 const log_show_project_command_1 = require("@nx/devkit/src/utils/log-show-project-command");
+const ts_solution_setup_1 = require("@nx/js/src/utils/typescript/ts-solution-setup");
 const add_linting_1 = require("../../utils/add-linting");
 const add_jest_1 = require("../../utils/add-jest");
 const chmod_android_gradle_files_1 = require("../../utils/chmod-android-gradle-files");
@@ -24,6 +25,7 @@ async function reactNativeApplicationGenerator(host, schema) {
     });
 }
 async function reactNativeApplicationGeneratorInternal(host, schema) {
+    (0, ts_solution_setup_1.assertNotUsingTsSolutionSetup)(host, 'react-native', 'application');
     const options = await (0, normalize_options_1.normalizeOptions)(host, schema);
     const tasks = [];
     const jsInitTask = await (0, js_1.initGenerator)(host, {

package/src/generators/init/init.js

@@ -5,6 +5,7 @@ exports.reactNativeInitGeneratorInternal = reactNativeInitGeneratorInternal;
 exports.updateDependencies = updateDependencies;
 const devkit_1 = require("@nx/devkit");
 const add_plugin_1 = require("@nx/devkit/src/utils/add-plugin");
+const ts_solution_setup_1 = require("@nx/js/src/utils/typescript/ts-solution-setup");
 const plugin_1 = require("../../../plugins/plugin");
 const versions_1 = require("../../utils/versions");
 const add_git_ignore_entry_1 = require("./lib/add-git-ignore-entry");
@@ -15,6 +16,7 @@ function reactNativeInitGenerator(host, schema) {
     });
 }
 async function reactNativeInitGeneratorInternal(host, schema) {
+    (0, ts_solution_setup_1.assertNotUsingTsSolutionSetup)(host, 'react-native', 'init');
     (0, add_git_ignore_entry_1.addGitIgnoreEntry)(host);
     const nxJson = (0, devkit_1.readNxJson)(host);
     const addPluginDefault = process.env.NX_ADD_PLUGINS !== 'false' &&

package/src/generators/library/library.js

@@ -11,6 +11,7 @@ const versions_1 = require("../../utils/versions");
 const normalize_options_1 = require("./lib/normalize-options");
 const ensure_dependencies_1 = require("../../utils/ensure-dependencies");
 const log_show_project_command_1 = require("@nx/devkit/src/utils/log-show-project-command");
+const ts_solution_setup_1 = require("@nx/js/src/utils/typescript/ts-solution-setup");
 async function reactNativeLibraryGenerator(host, schema) {
     return await reactNativeLibraryGeneratorInternal(host, {
         addPlugin: false,
@@ -18,6 +19,7 @@ async function reactNativeLibraryGenerator(host, schema) {
     });
 }
 async function reactNativeLibraryGeneratorInternal(host, schema) {
+    (0, ts_solution_setup_1.assertNotUsingTsSolutionSetup)(host, 'react-native', 'library');
     const options = await (0, normalize_options_1.normalizeOptions)(host, schema);
     if (options.publishable === true && !schema.importPath) {
         throw new Error(`For publishable libs you have to provide a proper "--importPath" which needs to be a valid npm package name (e.g. my-awesome-lib or @myorg/my-lib)`);

package/src/utils/pod-install-task.js

@@ -53,7 +53,7 @@ function podInstall(iosDirectory, options = {
             (0, child_process_1.execSync)('touch .xcode.env', {
                 cwd: iosDirectory,
                 stdio: 'inherit',
-                windowsHide: true,
+                windowsHide: false,
             });
         }
         const podCommand = [
@@ -64,7 +64,7 @@ function podInstall(iosDirectory, options = {
         (0, child_process_1.execSync)(podCommand, {
             cwd: iosDirectory,
             stdio: 'inherit',
-            windowsHide: true,
+            windowsHide: false,
         });
     }
     catch (e) {

package/src/migrations/update-16-0-0-add-nx-packages/update-16-0-0-add-nx-packages.d.ts

@@ -1,2 +0,0 @@
-import { Tree } from '@nx/devkit';
-export default function replacePackage(tree: Tree): Promise<void>;

package/src/migrations/update-16-0-0-add-nx-packages/update-16-0-0-add-nx-packages.js

@@ -1,9 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.default = replacePackage;
-const devkit_1 = require("@nx/devkit");
-const replace_package_1 = require("@nx/devkit/src/utils/replace-package");
-async function replacePackage(tree) {
-    await (0, replace_package_1.replaceNrwlPackageWithNxPackage)(tree, '@nrwl/react-native', '@nx/react-native');
-    await (0, devkit_1.formatFiles)(tree);
-}

package/src/migrations/update-16-1-0/upgrade-storybook-6-5.d.ts

@@ -1,6 +0,0 @@
-import { Tree } from '@nx/devkit';
-/**
- * This migration is to upgrade storybook to 6.5.
- * - remove react-native-storybook-loader
- */
-export default function update(tree: Tree): void;

package/src/migrations/update-16-1-0/upgrade-storybook-6-5.js

@@ -1,21 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.default = update;
-const devkit_1 = require("@nx/devkit");
-/**
- * This migration is to upgrade storybook to 6.5.
- * - remove react-native-storybook-loader
- */
-function update(tree) {
-    if (tree.exists('package.json')) {
-        (0, devkit_1.updateJson)(tree, 'package.json', (packageJson) => {
-            if (packageJson.dependencies?.['react-native-storybook-loader']) {
-                delete packageJson.dependencies['react-native-storybook-loader'];
-            }
-            if (packageJson.devDependencies?.['react-native-storybook-loader']) {
-                delete packageJson.devDependencies['react-native-storybook-loader'];
-            }
-            return packageJson;
-        });
-    }
-}

package/src/migrations/update-16-6-0/add-depends-on.d.ts

@@ -1,6 +0,0 @@
-import { Tree } from '@nx/devkit';
-/**
- * This migration adds dependsOn to project.json.
- *
- */
-export default function update(tree: Tree): Promise<void>;

package/src/migrations/update-16-6-0/add-depends-on.js

@@ -1,63 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.default = update;
-const devkit_1 = require("@nx/devkit");
-/**
- * This migration adds dependsOn to project.json.
- *
- */
-async function update(tree) {
-    const projects = (0, devkit_1.getProjects)(tree);
-    for (const [name, config] of projects.entries()) {
-        if (config.targets?.['start']?.executor === '@nx/react-native:start') {
-            config.targets['start'].dependsOn = [
-                'ensure-symlink',
-                'sync-deps',
-                'pod-install',
-            ];
-            if (config.targets?.['run-ios']?.executor === '@nx/react-native:run-ios') {
-                config.targets['run-ios'].dependsOn = [
-                    'ensure-symlink',
-                    'sync-deps',
-                    'pod-install',
-                ];
-            }
-            if (config.targets?.['bundle-ios']?.executor === '@nx/react-native:bundle') {
-                config.targets['bundle-ios'].dependsOn = ['ensure-symlink'];
-            }
-            if (config.targets?.['run-android']?.executor ===
-                '@nx/react-native:run-android') {
-                config.targets['run-android'].dependsOn ??= [
-                    'ensure-symlink',
-                    'sync-deps',
-                ];
-            }
-            if (config.targets?.['build-android']?.executor ===
-                '@nx/react-native:build-android') {
-                config.targets['build-android'].dependsOn = [
-                    'ensure-symlink',
-                    'sync-deps',
-                ];
-            }
-            if (config.targets?.['build-ios']?.executor === '@nx/react-native:build-ios') {
-                config.targets['build-ios'].dependsOn ??= [
-                    'ensure-symlink',
-                    'sync-deps',
-                    'pod-install',
-                ];
-            }
-            if (config.targets?.['pod-instal']?.executor ===
-                '@nx/react-native:pod-install') {
-                config.targets['pod-install'].dependsOn ??= [
-                    'ensure-symlink',
-                    'sync-deps',
-                ];
-            }
-            if (config.targets?.['bundle-android']?.executor ===
-                '@nx/react-native:bundle') {
-                config.targets['bundle-android'].dependsOn ??= ['ensure-symlink'];
-            }
-            (0, devkit_1.updateProjectConfiguration)(tree, name, config);
-        }
-    }
-}

package/src/migrations/update-16-6-0/update-metro-config.d.ts

@@ -1,6 +0,0 @@
-import { Tree } from '@nx/devkit';
-/**
- * This migration updates metro.config.js to export config as a default.
- *
- */
-export default function update(tree: Tree): Promise<void>;

package/src/migrations/update-16-6-0/update-metro-config.js

@@ -1,63 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.default = update;
-const devkit_1 = require("@nx/devkit");
-const path_1 = require("path");
-/**
- * This migration updates metro.config.js to export config as a default.
- *
- */
-async function update(tree) {
-    const projects = (0, devkit_1.getProjects)(tree);
-    for (const [_, config] of projects.entries()) {
-        if (config.targets?.['start']?.executor === '@nx/react-native:start') {
-            if (tree.exists((0, path_1.join)(config.root, 'metro.config.js'))) {
-                const oldConfig = tree
-                    .read((0, path_1.join)(config.root, 'metro.config.js'))
-                    .toString();
-                tree.write((0, path_1.join)(config.root, 'metro-v71.config.js'), oldConfigComment + oldConfig);
-                tree.write((0, path_1.join)(config.root, 'metro.config.js'), content);
-            }
-        }
-    }
-}
-const oldConfigComment = `/**
- * Old custom configuration for React Native v0.71.
- * From @react-native/metro-config 0.72.1, it is no longer necessary to use a config function to access the complete default config.
- * Please port your custom configuration to metro.config.js.
- * Please see https://reactnative.dev/docs/metro to learn about configuration.
- */
-`;
-const content = `
-const { withNxMetro } = require('@nx/react-native');
-const { getDefaultConfig, mergeConfig } = require('@react-native/metro-config');
-
-const defaultConfig = getDefaultConfig(__dirname);
-const { assetExts, sourceExts } = defaultConfig.resolver;
-
-/**
- * Metro configuration
- * https://facebook.github.io/metro/docs/configuration
- *
- * @type {import('metro-config').MetroConfig}
- */
-const customConfig = {
-  transformer: {
-    babelTransformerPath: require.resolve('react-native-svg-transformer'),
-  },
-  resolver: {
-    assetExts: assetExts.filter((ext) => ext !== 'svg'),
-    sourceExts: [...sourceExts, 'cjs', 'mjs', 'svg'],
-  },
-};
-
-module.exports = withNxMetro(mergeConfig(defaultConfig, customConfig), {
-  // Change this to true to see debugging info.
-  // Useful if you have issues resolving modules
-  debug: false,
-  // all the file extensions used for imports other than 'ts', 'tsx', 'js', 'jsx', 'json'
-  extensions: [],
-  // Specify folders to watch, in addition to Nx defaults (workspace libraries and node_modules)
-  watchFolders: [],
-});
-`;

package/src/migrations/update-16-9-0/remove-types-react-native.d.ts

@@ -1,7 +0,0 @@
-import { Tree } from '@nx/devkit';
-/**
- * Remove @types/react-native package since it is no longer required. It would be a part of react native package.
- * @param tree
- * @returns
- */
-export default function update(tree: Tree): Promise<void>;

package/src/migrations/update-16-9-0/remove-types-react-native.js

@@ -1,13 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.default = update;
-const devkit_1 = require("@nx/devkit");
-/**
- * Remove @types/react-native package since it is no longer required. It would be a part of react native package.
- * @param tree
- * @returns
- */
-async function update(tree) {
-    (0, devkit_1.removeDependenciesFromPackageJson)(tree, [], ['@types/react-native']);
-    await (0, devkit_1.formatFiles)(tree);
-}