@nx/plugin 23.2.0-beta.1 → 23.2.0-beta.11

package/README.md

@@ -7,9 +7,9 @@
 
 <div style="text-align: center;">
 
-[![License](https://img.shields.io/npm/l/@nx/workspace.svg?style=flat-square)]()
+[![License](https://img.shields.io/npm/l/@nx/workspace.svg?style=flat-square)](<>)
 [![NPM Version](https://badge.fury.io/js/nx.svg)](https://www.npmjs.com/package/nx)
-[![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)]()
+[![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)](<>)
 [![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
 [![Join us on the Official Nx Discord Server](https://img.shields.io/discord/1143497901675401286?label=discord)](https://go.nx.dev/community)
 [![Nx Sandboxing](https://staging.nx.app/workspaces/62d013ea0852fe0a2df74438/sandbox-badge.svg)](https://nx.dev/docs/features/ci-features/sandboxing)

package/dist/src/generators/create-package/create-package.js

@@ -5,11 +5,11 @@ exports.createPackageGeneratorInternal = createPackageGeneratorInternal;
 const devkit_1 = require("@nx/devkit");
 const js_1 = require("@nx/js");
 const internal_1 = require("@nx/js/internal");
-const versions_1 = require("nx/src/utils/versions");
 const path_1 = require("path");
 const has_generator_1 = require("../../utils/has-generator");
 const generator_1 = require("../generator/generator");
 const normalize_schema_1 = require("./utils/normalize-schema");
+const internal_2 = require("@nx/devkit/internal");
 async function createPackageGenerator(host, schema) {
     return await createPackageGeneratorInternal(host, {
         useProjectJson: true,
@@ -25,7 +25,7 @@ async function createPackageGeneratorInternal(host, schema) {
         tasks.push((0, js_1.addTsLibDependencies)(host));
     }
     const installTask = (0, devkit_1.addDependenciesToPackageJson)(host, {
-        'create-nx-workspace': versions_1.nxVersion,
+        'create-nx-workspace': internal_2.nxVersion,
     }, {});
     tasks.push(installTask);
     const cliPackageTask = await createCliPackage(host, options, pluginPackageName);
@@ -52,7 +52,9 @@ async function addPresetGenerator(host, schema) {
             path: (0, path_1.join)(projectRoot, 'src/generators/preset/generator'),
             unitTestRunner: schema.unitTestRunner,
             skipFormat: true,
-            skipLintChecks: schema.linter === 'none',
+            // Lint checks are an ESLint-only feature; asking for them under any other
+            // linter makes `pluginLintCheckGenerator` log an error and do nothing.
+            skipLintChecks: schema.linter !== 'eslint',
         });
     }
     return (0, devkit_1.readJson)(host, (0, devkit_1.joinPathFragments)(projectRoot, 'package.json'))?.name;
@@ -86,7 +88,7 @@ async function createCliPackage(host, options, pluginPackageName) {
             delete packageJson.exports;
         }
         packageJson.dependencies = {
-            'create-nx-workspace': versions_1.nxVersion,
+            'create-nx-workspace': internal_2.nxVersion,
             ...(options.bundler === 'tsc' && { tslib: internal_1.tsLibVersion }),
         };
         return packageJson;

package/dist/src/generators/create-package/files/create-framework-package/bin/index.ts__tmpl__

@@ -3,7 +3,7 @@
 import { createWorkspace } from 'create-nx-workspace';
 
 async function main() {
-  const name = process.argv[2]; // TODO: use libraries like yargs or enquirer to set your workspace name
+  const name = process.argv[2]; // TODO: use libraries like yargs, <%= unitTestRunner === 'jest' ? 'enquirer' : '@clack/prompts' %>, or another prompting library to set your workspace name
   if (!name) {
     throw new Error('Please provide a name for the workspace');
   }

package/dist/src/generators/create-package/files/e2e/__cliName__.spec.ts__tmpl__

@@ -16,6 +16,8 @@ describe('<%= cliName %>', () => {
   });
 
 
+  // This test shells out synchronously, so its budget has to cover a cold
+  // package manager cache. Otherwise work that succeeded still fails on return.
   it('should be installed', () => {
     projectDirectory = createTestProject();
 
@@ -24,7 +26,7 @@ describe('<%= cliName %>', () => {
       cwd: projectDirectory,
       stdio: 'inherit',
     });
-  });
+  }, 180_000);
 });
 
 /**

package/dist/src/generators/create-package/schema.d.ts

@@ -1,4 +1,4 @@
-import type { Linter, LinterType } from '@nx/eslint';
+import type { LinterType } from '@nx/js';
 
 export interface CreatePackageSchema {
   name: string;
@@ -9,7 +9,7 @@ export interface CreatePackageSchema {
   skipFormat?: boolean;
   tags?: string;
   unitTestRunner?: 'jest' | 'vitest' | 'none';
-  linter?: Linter | LinterType;
+  linter?: LinterType;
   compiler?: 'swc' | 'tsc';
 
   // options to create e2e project, passed to e2e project generator

package/dist/src/generators/create-package/schema.json

@@ -37,9 +37,9 @@
       "description": "Test runner to use for unit tests."
     },
     "linter": {
-      "description": "The tool to use for running lint checks.",
+      "description": "The tool to use for running lint checks. Defaults to the linter the workspace already uses.",
       "type": "string",
-      "enum": ["none", "eslint"]
+      "enum": ["none", "eslint", "oxlint"]
     },
     "tags": {
       "type": "string",

package/dist/src/generators/create-package/utils/normalize-schema.d.ts

@@ -1,5 +1,5 @@
 import { Tree } from '@nx/devkit';
-import type { LinterType } from '@nx/eslint';
+import type { LinterType } from '@nx/js';
 import { CreatePackageSchema } from '../schema';
 export interface NormalizedSchema extends CreatePackageSchema {
     bundler: 'swc' | 'tsc';

package/dist/src/generators/e2e-project/e2e.d.ts

@@ -1,4 +1,4 @@
-import { type GeneratorCallback, type Tree } from '@nx/devkit';
+import { Tree, type GeneratorCallback } from '@nx/devkit';
 import type { Schema } from './schema';
 export declare function e2eProjectGenerator(host: Tree, schema: Schema): Promise<GeneratorCallback>;
 export declare function e2eProjectGeneratorInternal(host: Tree, schema: Schema): Promise<GeneratorCallback>;

package/dist/src/generators/e2e-project/e2e.js

@@ -4,11 +4,11 @@ exports.e2eProjectGenerator = e2eProjectGenerator;
 exports.e2eProjectGeneratorInternal = e2eProjectGeneratorInternal;
 const internal_1 = require("@nx/devkit/internal");
 const devkit_1 = require("@nx/devkit");
-const eslint_1 = require("@nx/eslint");
 const jest_1 = require("@nx/jest");
 const js_1 = require("@nx/js");
 const internal_2 = require("@nx/js/internal");
 const path_1 = require("path");
+const versions_1 = require("../../utils/versions");
 async function normalizeOptions(host, options) {
     const linter = await (0, internal_2.normalizeLinterOption)(host, options.linter);
     const projectName = options.rootProject ? 'e2e' : `${options.pluginName}-e2e`;
@@ -112,19 +112,122 @@ async function addJest(host, options) {
     }
     return jestTask;
 }
+async function addVitest(host, options) {
+    const projectConfiguration = {
+        name: options.projectName,
+        root: options.projectRoot,
+        projectType: 'application',
+        sourceRoot: `${options.projectRoot}/src`,
+        implicitDependencies: [options.pluginName],
+    };
+    if (options.isTsSolutionSetup) {
+        (0, devkit_1.writeJson)(host, (0, devkit_1.joinPathFragments)(options.projectRoot, 'package.json'), {
+            name: options.projectName,
+            version: '0.0.1',
+            private: true,
+        });
+        (0, devkit_1.updateProjectConfiguration)(host, options.projectName, projectConfiguration);
+    }
+    else {
+        projectConfiguration.targets = {};
+        (0, devkit_1.addProjectConfiguration)(host, options.projectName, projectConfiguration);
+    }
+    (0, devkit_1.ensurePackage)('@nx/vitest', versions_1.nxVersion);
+    // Use `require` rather than a dynamic `import()`: `ensurePackage` makes the
+    // on-demand-installed package resolvable via CJS resolution only, so a true
+    // ESM dynamic import cannot see the temp install.
+    const { configurationGenerator: vitestConfigurationGenerator, } = require('@nx/vitest/generators');
+    const vitestTask = await vitestConfigurationGenerator(host, {
+        project: options.projectName,
+        testTarget: 'e2e',
+        skipFormat: true,
+        addPlugin: options.addPlugin,
+        testEnvironment: 'node',
+        coverageProvider: 'none',
+    });
+    (0, internal_2.addLocalRegistryScripts)(host);
+    // Vitest has no `globalTeardown` option. Its `globalSetup` file must export
+    // both `setup` and `teardown`, so wire the local registry scripts through a
+    // wrapper module. Without the teardown, the verdaccio process started in
+    // setup outlives the test run.
+    const vitestGlobalSetupPath = 'tools/scripts/vitest-global-setup.ts';
+    if (!host.exists(vitestGlobalSetupPath)) {
+        host.write(vitestGlobalSetupPath, `/**
+ * This script adapts the local registry scripts to vitest's globalSetup
+ * lifecycle: vitest calls the exported setup and teardown functions around
+ * the test run.
+ */
+
+export { default as setup } from './start-local-registry';
+export { default as teardown } from './stop-local-registry';
+`);
+    }
+    // Add globalSetup to vitest config
+    // Check for both .mts and .ts extensions (mts is checked first as it's the default created by @nx/vitest)
+    const vitestConfigExtensions = ['mts', 'ts'];
+    let vitestConfigPath;
+    for (const ext of vitestConfigExtensions) {
+        const configPath = (0, devkit_1.joinPathFragments)(options.projectRoot, `vitest.config.${ext}`);
+        if (host.exists(configPath)) {
+            vitestConfigPath = configPath;
+            break;
+        }
+    }
+    if (vitestConfigPath) {
+        let vitestConfig = host.read(vitestConfigPath, 'utf-8');
+        const globalSetupPath = (0, path_1.join)((0, devkit_1.offsetFromRoot)(options.projectRoot), vitestGlobalSetupPath);
+        // Insert globalSetup in the test config
+        // Look for 'test: {' and insert our properties right after the opening brace
+        const testConfigRegex = /(test:\s*\{\s*)/;
+        const match = testConfigRegex.exec(vitestConfig);
+        if (match) {
+            // Extract the indentation from the next line to maintain consistent formatting
+            const afterMatch = vitestConfig.slice(match.index + match[0].length);
+            const nextLineMatch = afterMatch.match(/\n(\s*)/);
+            const indent = nextLineMatch ? nextLineMatch[1] : '    ';
+            vitestConfig = vitestConfig.replace(testConfigRegex, `$1\n${indent}globalSetup: '${globalSetupPath}',`);
+            host.write(vitestConfigPath, vitestConfig);
+        }
+        else {
+            // If we can't find the test config block, log a warning
+            throw new Error(`Could not find test configuration block in ${vitestConfigPath}. Please manually add the globalSetup property.`);
+        }
+    }
+    else {
+        // This should not happen as the vitest configuration generator should create the config file
+        throw new Error(`Could not find Vitest config for project ${options.projectName} at ${options.projectRoot}`);
+    }
+    const project = (0, devkit_1.readProjectConfiguration)(host, options.projectName);
+    project.targets ??= {};
+    if (project.targets.e2e) {
+        const e2eTarget = project.targets.e2e;
+        // The suites share a single tmp/test-project directory, so they have to run
+        // one at a time. Vitest 4 removed `poolOptions`, and nested options do not
+        // survive the executor's argv round-trip anyway, so use the scalar options.
+        project.targets.e2e = {
+            ...e2eTarget,
+            dependsOn: [`^build`],
+            options: {
+                ...e2eTarget.options,
+                maxWorkers: 1,
+                isolate: false,
+            },
+        };
+        (0, devkit_1.updateProjectConfiguration)(host, options.projectName, project);
+    }
+    return vitestTask;
+}
 async function addLintingToApplication(tree, options) {
-    const lintTask = await (0, eslint_1.lintProjectGenerator)(tree, {
+    return (0, internal_2.addLintingToProject)(tree, {
         linter: options.linter,
         project: options.projectName,
         tsConfigPaths: [
             (0, devkit_1.joinPathFragments)(options.projectRoot, 'tsconfig.app.json'),
         ],
-        unitTestRunner: 'jest',
-        skipFormat: true,
-        setParserOptionsProject: false,
+        unitTestRunner: options.testRunner ?? 'jest',
+        enableTypedLinting: false,
         addPlugin: options.addPlugin,
     });
-    return lintTask;
 }
 function updatePluginPackageJson(tree, options) {
     const { root } = (0, devkit_1.readProjectConfiguration)(tree, options.pluginName);
@@ -145,11 +248,19 @@ async function e2eProjectGeneratorInternal(host, schema) {
     const tasks = [];
     validatePlugin(host, schema.pluginName);
     const options = await normalizeOptions(host, schema);
+    // Default to jest if no testRunner is specified
+    options.testRunner = options.testRunner ?? 'jest';
     addFiles(host, options);
     tasks.push(await (0, js_1.setupVerdaccio)(host, {
         skipFormat: true,
     }));
-    tasks.push(await addJest(host, options));
+    // Add test runner based on the testRunner option
+    if (options.testRunner === 'vitest') {
+        tasks.push(await addVitest(host, options));
+    }
+    else {
+        tasks.push(await addJest(host, options));
+    }
     updatePluginPackageJson(host, options);
     if (options.linter !== 'none') {
         tasks.push(await addLintingToApplication(host, {

package/dist/src/generators/e2e-project/files/src/__simplePluginName__.spec.ts__tmpl__

@@ -5,17 +5,20 @@ import { mkdirSync, rmSync } from 'fs';
 describe('<%= pluginName %>', () => {
   let projectDirectory: string;
 
+  // This hook shells out synchronously twice, so its budget has to cover both
+  // installs on a cold package manager cache. Otherwise work that succeeded
+  // still fails on return.
   beforeAll(() => {
     projectDirectory = createTestProject();
 
-    // The plugin has been built and published to a local registry in the jest globalSetup
+    // The plugin has been built and published to a local registry in the globalSetup
     // Install the plugin built with the latest source code into the test repo
     execSync(`<%= packageManagerCommands.addDev %> <%= pluginPackageName %>@e2e`, {
       cwd: projectDirectory,
       stdio: 'inherit',
       env: process.env,
     });
-  });
+  }, 300_000);
 
   afterAll(() => {
     if (projectDirectory) {

package/dist/src/generators/e2e-project/schema.d.ts

@@ -1,4 +1,4 @@
-import type { Linter, LinterType } from '@nx/eslint';
+import type { LinterType } from '@nx/js';
 
 export interface Schema {
   pluginName: string;
@@ -6,7 +6,8 @@ export interface Schema {
   projectDirectory?: string;
   pluginOutputPath?: string;
   jestConfig?: string;
-  linter?: Linter | LinterType;
+  testRunner?: 'jest' | 'vitest';
+  linter?: LinterType;
   skipFormat?: boolean;
   rootProject?: boolean;
   useProjectJson?: boolean;

package/dist/src/generators/e2e-project/schema.json

@@ -30,10 +30,16 @@
       "type": "string",
       "description": "Jest config file."
     },
+    "testRunner": {
+      "type": "string",
+      "enum": ["jest", "vitest"],
+      "description": "Test runner to use for the e2e tests.",
+      "default": "jest"
+    },
     "linter": {
-      "description": "The tool to use for running lint checks.",
+      "description": "The tool to use for running lint checks. Defaults to the linter the workspace already uses.",
       "type": "string",
-      "enum": ["none", "eslint"]
+      "enum": ["none", "eslint", "oxlint"]
     },
     "minimal": {
       "type": "boolean",

package/dist/src/generators/lint-checks/generator.d.ts

@@ -1,7 +1,7 @@
 import { ProjectConfiguration, TargetConfiguration, Tree } from '@nx/devkit';
 import type { Schema as EsLintExecutorOptions } from '@nx/eslint/internal';
 import { PluginLintChecksGeneratorSchema } from './schema';
-import { PackageJson } from 'nx/src/utils/package-json';
+import { PackageJson } from '@nx/devkit/internal';
 export default function pluginLintCheckGenerator(host: Tree, options: PluginLintChecksGeneratorSchema): Promise<void>;
 export declare function addMigrationJsonChecks(host: Tree, options: PluginLintChecksGeneratorSchema, packageJson: PackageJson): void;
 export declare function getEsLintOptions(project: ProjectConfiguration): [target: string, configuration: TargetConfiguration<EsLintExecutorOptions>];

package/dist/src/generators/lint-checks/generator.js

@@ -4,9 +4,8 @@ exports.default = pluginLintCheckGenerator;
 exports.addMigrationJsonChecks = addMigrationJsonChecks;
 exports.getEsLintOptions = getEsLintOptions;
 const devkit_1 = require("@nx/devkit");
-const logger_1 = require("nx/src/utils/logger");
-const package_json_1 = require("nx/src/utils/package-json");
 const internal_1 = require("@nx/eslint/internal");
+const internal_2 = require("@nx/devkit/internal");
 async function pluginLintCheckGenerator(host, options) {
     const project = (0, devkit_1.readProjectConfiguration)(host, options.projectName);
     const packageJson = (0, devkit_1.readJson)(host, (0, devkit_1.joinPathFragments)(project.root, 'package.json'));
@@ -21,7 +20,7 @@ async function pluginLintCheckGenerator(host, options) {
         }
     }
     else {
-        devkit_1.logger.error(`${logger_1.NX_PREFIX} plugin lint checks can only be added to plugins which use eslint for linting`);
+        devkit_1.logger.error(`${internal_2.NX_PREFIX} plugin lint checks can only be added to plugins which use eslint for linting`);
     }
     if (!options.skipFormat) {
         await (0, devkit_1.formatFiles)(host);
@@ -33,7 +32,7 @@ function addMigrationJsonChecks(host, options, packageJson) {
         return;
     }
     const [eslintTarget, eslintTargetConfiguration] = getEsLintOptions(projectConfiguration) ?? [];
-    const relativeMigrationsJsonPath = (0, package_json_1.readNxMigrateConfig)(packageJson).migrations;
+    const relativeMigrationsJsonPath = (0, internal_2.readNxMigrateConfig)(packageJson).migrations;
     if (!relativeMigrationsJsonPath) {
         return;
     }
@@ -129,7 +128,7 @@ function updateProjectEslintConfig(host, options, packageJson) {
             packageJson.executors,
             packageJson.schematics,
             packageJson.builders,
-            (0, package_json_1.readNxMigrateConfig)(packageJson).migrations,
+            (0, internal_2.readNxMigrateConfig)(packageJson).migrations,
         ].filter((f) => !!f);
         const parser = (0, internal_1.useFlatConfig)(host)
             ? { languageOptions: { parser: 'jsonc-eslint-parser' } }
@@ -195,7 +194,7 @@ function setupVsCodeLintingForJsonFiles(host) {
         existing = (0, devkit_1.readJson)(host, '.vscode/settings.json');
     }
     else {
-        devkit_1.logger.info(`${logger_1.NX_PREFIX} We've updated the vscode settings for this repository to ensure that plugin lint checks show up inside your IDE. This created .vscode/settings.json. To read more about this file, check vscode's documentation. It is frequently not committed, so other developers may need to add similar settings if they'd like to see the lint checks in the IDE rather than only during linting.`);
+        devkit_1.logger.info(`${internal_2.NX_PREFIX} We've updated the vscode settings for this repository to ensure that plugin lint checks show up inside your IDE. This created .vscode/settings.json. To read more about this file, check vscode's documentation. It is frequently not committed, so other developers may need to add similar settings if they'd like to see the lint checks in the IDE rather than only during linting.`);
     }
     // setup eslint validation for json files
     const eslintValidate = existing['eslint.validate'] ?? [];

package/dist/src/generators/migration/migration.js

@@ -5,7 +5,6 @@ const internal_1 = require("@nx/devkit/internal");
 const devkit_1 = require("@nx/devkit");
 const internal_2 = require("@nx/js/internal");
 const node_path_1 = require("node:path");
-const package_json_1 = require("nx/src/utils/package-json");
 const paths_1 = require("../../utils/paths");
 const versions_1 = require("../../utils/versions");
 const generator_1 = require("../lint-checks/generator");
@@ -38,7 +37,7 @@ function addFiles(host, options) {
     });
 }
 function updateMigrationsJson(host, options) {
-    const configuredMigrationPath = (0, package_json_1.readNxMigrateConfig)((0, devkit_1.readJson)(host, (0, devkit_1.joinPathFragments)(options.projectRoot, 'package.json'))).migrations;
+    const configuredMigrationPath = (0, internal_1.readNxMigrateConfig)((0, devkit_1.readJson)(host, (0, devkit_1.joinPathFragments)(options.projectRoot, 'package.json'))).migrations;
     const migrationsPath = (0, devkit_1.joinPathFragments)(options.projectRoot, configuredMigrationPath ?? 'migrations.json');
     const migrations = host.exists(migrationsPath)
         ? (0, devkit_1.readJson)(host, migrationsPath)

package/dist/src/generators/plugin/files/plugin/src/index.ts__tmpl__

@@ -0,0 +1 @@
+export {};

package/dist/src/generators/plugin/plugin.js

@@ -83,6 +83,11 @@ async function pluginGeneratorInternal(host, schema) {
         '@nx/devkit': nxVersion,
     }, {
         [options.unitTestRunner === 'vitest' ? '@nx/vitest' : '@nx/jest']: nxVersion,
+        ...(options.e2eTestRunner === 'vitest'
+            ? { '@nx/vitest': nxVersion }
+            : options.e2eTestRunner === 'jest'
+                ? { '@nx/jest': nxVersion }
+                : {}),
         '@nx/js': nxVersion,
         '@nx/plugin': nxVersion,
     }));
@@ -103,6 +108,7 @@ async function pluginGeneratorInternal(host, schema) {
             linter: options.linter,
             useProjectJson: options.useProjectJson,
             addPlugin: options.addPlugin,
+            testRunner: options.e2eTestRunner,
         }));
     }
     if (options.linter === 'eslint' && !options.skipLintChecks) {

package/dist/src/generators/plugin/schema.d.ts

@@ -1,4 +1,4 @@
-import type { Linter, LinterType } from '@nx/eslint';
+import type { LinterType } from '@nx/js';
 
 export interface Schema {
   directory: string;
@@ -7,11 +7,15 @@ export interface Schema {
   skipTsConfig?: boolean; // default is false
   skipFormat?: boolean; // default is false
   skipLintChecks?: boolean; // default is false
-  e2eTestRunner?: 'jest' | 'none';
+  e2eTestRunner?: 'jest' | 'vitest' | 'none';
   e2eProjectDirectory?: string;
   tags?: string;
   unitTestRunner?: 'jest' | 'vitest' | 'none';
-  linter?: Linter | LinterType;
+  linter?: LinterType;
+  enableTypedLinting?: boolean;
+  /**
+   * @deprecated Use `enableTypedLinting` instead. This option will be removed in Nx v24.
+   */
   setParserOptionsProject?: boolean;
   compiler?: 'swc' | 'tsc';
   rootProject?: boolean;

package/dist/src/generators/plugin/schema.json

@@ -32,9 +32,9 @@
       "x-priority": "important"
     },
     "linter": {
-      "description": "The tool to use for running lint checks.",
+      "description": "The tool to use for running lint checks. Defaults to the linter the workspace already uses.",
       "type": "string",
-      "enum": ["none", "eslint"],
+      "enum": ["none", "eslint", "oxlint"],
       "x-priority": "important"
     },
     "unitTestRunner": {
@@ -67,7 +67,7 @@
     },
     "e2eTestRunner": {
       "type": "string",
-      "enum": ["jest", "none"],
+      "enum": ["jest", "vitest", "none"],
       "description": "Test runner to use for end to end (E2E) tests.",
       "default": "none"
     },
@@ -75,11 +75,17 @@
       "type": "string",
       "description": "A directory where the plugin E2E project is placed."
     },
-    "setParserOptionsProject": {
+    "enableTypedLinting": {
       "type": "boolean",
-      "description": "Whether or not to configure the ESLint `parserOptions.project` option. We do not do this by default for lint performance reasons.",
+      "description": "Whether to enable typed linting. For flat configs, this configures the recommended `parserOptions.projectService` and `tsconfigRootDir`. For legacy `.eslintrc` configs, this configures `parserOptions.project`. We do not enable this by default for lint performance reasons.",
       "default": false
     },
+    "setParserOptionsProject": {
+      "type": "boolean",
+      "description": "Deprecated alias for `enableTypedLinting`.",
+      "default": false,
+      "x-deprecated": "Use `enableTypedLinting` instead. This option will be removed in Nx v24."
+    },
     "compiler": {
       "type": "string",
       "enum": ["tsc", "swc"],

package/dist/src/generators/plugin/utils/normalize-schema.d.ts

@@ -1,5 +1,5 @@
 import { type Tree } from '@nx/devkit';
-import type { LinterType } from '@nx/eslint';
+import type { LinterType } from '@nx/js';
 import type { Schema } from '../schema';
 export interface NormalizedSchema extends Schema {
     projectName: string;

package/dist/src/generators/preset/generator.js

@@ -5,6 +5,7 @@ exports.presetGeneratorInternal = presetGeneratorInternal;
 const devkit_1 = require("@nx/devkit");
 const create_package_1 = require("../create-package/create-package");
 const plugin_1 = require("../plugin/plugin");
+const internal_1 = require("@nx/js/internal");
 async function presetGenerator(tree, rawOptions) {
     return await presetGeneratorInternal(tree, {
         addPlugin: false,
@@ -14,10 +15,10 @@ async function presetGenerator(tree, rawOptions) {
 }
 async function presetGeneratorInternal(tree, rawOptions) {
     const tasks = [];
-    const options = normalizeOptions(rawOptions);
+    const options = await normalizeOptions(tree, rawOptions);
     const pluginTask = await (0, plugin_1.pluginGenerator)(tree, {
         compiler: 'tsc',
-        linter: 'eslint',
+        linter: options.linter,
         skipFormat: true,
         unitTestRunner: 'jest',
         importPath: options.pluginName,
@@ -42,7 +43,7 @@ async function presetGeneratorInternal(tree, rawOptions) {
             project: options.pluginName,
             skipFormat: true,
             unitTestRunner: 'jest',
-            linter: 'eslint',
+            linter: options.linter,
             compiler: 'tsc',
             useProjectJson: options.useProjectJson,
             addPlugin: options.addPlugin,
@@ -62,7 +63,7 @@ function moveNxPluginToDevDeps(tree) {
         return json;
     });
 }
-function normalizeOptions(options) {
+async function normalizeOptions(tree, options) {
     return {
         ...options,
         pluginName: (0, devkit_1.names)(options.pluginName.includes('/')
@@ -71,6 +72,9 @@ function normalizeOptions(options) {
         createPackageName: options.createPackageName === 'false' // for command line in e2e, it is passed as a string
             ? undefined
             : options.createPackageName,
+        // Resolved once here rather than left to the two child generators, which
+        // each prompt on their own and would ask the same question twice.
+        linter: await (0, internal_1.normalizeLinterOption)(tree, options.linter),
     };
 }
 exports.default = presetGenerator;

package/dist/src/generators/preset/schema.d.ts

@@ -1,11 +1,14 @@
+import type { LinterType } from '@nx/js';
+
 export interface PresetGeneratorSchema {
   pluginName: string;
   createPackageName?: string;
   useProjectJson?: boolean;
   addPlugin?: boolean;
+  linter?: LinterType;
 }
 
-export interface NormalizedPresetGeneratorOptions
-  extends PresetGeneratorSchema {
+export interface NormalizedPresetGeneratorOptions extends PresetGeneratorSchema {
   createPackageName: string;
+  linter: LinterType;
 }

package/dist/src/generators/preset/schema.json

@@ -25,6 +25,11 @@
       "type": "string",
       "description": "Name of package which creates a workspace"
     },
+    "linter": {
+      "description": "The tool to use for running lint checks. Defaults to the linter the workspace already uses.",
+      "type": "string",
+      "enum": ["none", "eslint", "oxlint"]
+    },
     "useProjectJson": {
       "type": "boolean",
       "description": "Use a `project.json` configuration file instead of inlining the Nx configuration in the `package.json` file."

package/dist/src/utils/testing-utils/nx-project.js

@@ -6,7 +6,6 @@ exports.runPackageManagerInstall = runPackageManagerInstall;
 exports.newNxProject = newNxProject;
 exports.ensureNxProject = ensureNxProject;
 const devkit_1 = require("@nx/devkit");
-const devkit_2 = require("@nx/devkit");
 const child_process_1 = require("child_process");
 const node_fs_1 = require("node:fs");
 const path_1 = require("path");
@@ -22,9 +21,9 @@ function runNxNewCommand(args, silent) {
 }
 function patchPackageJsonForPlugin(npmPackageName, distPath) {
     const path = (0, paths_1.tmpProjPath)('package.json');
-    const json = (0, devkit_2.readJsonFile)(path);
+    const json = (0, devkit_1.readJsonFile)(path);
     json.devDependencies[npmPackageName] = `file:${devkit_1.workspaceRoot}/${distPath}`;
-    (0, devkit_2.writeJsonFile)(path, json);
+    (0, devkit_1.writeJsonFile)(path, json);
 }
 /**
  * Generate a unique name for running CLI commands
@@ -41,7 +40,7 @@ function uniq(prefix) {
  */
 function runPackageManagerInstall(silent = true) {
     const cwd = (0, paths_1.tmpProjPath)();
-    const pmc = (0, devkit_2.getPackageManagerCommand)((0, devkit_1.detectPackageManager)(cwd));
+    const pmc = (0, devkit_1.getPackageManagerCommand)((0, devkit_1.detectPackageManager)(cwd));
     const install = (0, child_process_1.execSync)(pmc.install, {
         cwd,
         ...(silent ? { stdio: ['ignore', 'ignore', 'ignore'] } : {}),

package/dist/src/utils/testing-utils/utils.d.ts

@@ -1,5 +1,5 @@
 import type { JsonParseOptions } from '@nx/devkit';
-import { directoryExists, fileExists } from 'nx/src/utils/fileutils';
+import { directoryExists, fileExists } from '@nx/devkit/internal';
 export { directoryExists, fileExists };
 /**
  * Copies module folders from the working directory to the e2e directory

package/dist/src/utils/testing-utils/utils.js

@@ -19,9 +19,9 @@ const node_fs_1 = require("node:fs");
 const path_1 = require("path");
 const paths_1 = require("./paths");
 const devkit_1 = require("@nx/devkit");
-const fileutils_1 = require("nx/src/utils/fileutils");
-Object.defineProperty(exports, "directoryExists", { enumerable: true, get: function () { return fileutils_1.directoryExists; } });
-Object.defineProperty(exports, "fileExists", { enumerable: true, get: function () { return fileutils_1.fileExists; } });
+const internal_1 = require("@nx/devkit/internal");
+Object.defineProperty(exports, "directoryExists", { enumerable: true, get: function () { return internal_1.directoryExists; } });
+Object.defineProperty(exports, "fileExists", { enumerable: true, get: function () { return internal_1.fileExists; } });
 /**
  * Copies module folders from the working directory to the e2e directory
  * @param modules a list of module names or scopes to copy
@@ -136,7 +136,7 @@ function getCwd() {
  * @param path Path to file or directory
  */
 function exists(path) {
-    return (0, fileutils_1.directoryExists)(path) || (0, fileutils_1.fileExists)(path);
+    return (0, internal_1.directoryExists)(path) || (0, internal_1.fileExists)(path);
 }
 /**
  * Get the size of a file on disk

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/plugin",
-  "version": "23.2.0-beta.1",
+  "version": "23.2.0-beta.11",
   "private": false,
   "description": "This plugin is used to create Nx plugins! It contains generators for generating common plugin features like generators, executors, migrations and more.",
   "repository": {
@@ -36,13 +36,21 @@
   },
   "dependencies": {
     "tslib": "^2.3.0",
-    "@nx/devkit": "23.2.0-beta.1",
-    "@nx/jest": "23.2.0-beta.1",
-    "@nx/js": "23.2.0-beta.1",
-    "@nx/eslint": "23.2.0-beta.1"
+    "@nx/devkit": "23.2.0-beta.11",
+    "@nx/jest": "23.2.0-beta.11",
+    "@nx/js": "23.2.0-beta.11",
+    "@nx/eslint": "23.2.0-beta.11"
   },
   "devDependencies": {
-    "nx": "23.2.0-beta.1"
+    "nx": "23.2.0-beta.11"
+  },
+  "peerDependencies": {
+    "@nx/vitest": "23.2.0-beta.11"
+  },
+  "peerDependenciesMeta": {
+    "@nx/vitest": {
+      "optional": true
+    }
   },
   "publishConfig": {
     "access": "public"