@nx/playwright 24.0.0-pr.37405.acdaf31 → 24.0.0-rc.0

package/dist/index.d.ts

@@ -1,3 +1,3 @@
-export { playwrightExecutor, PlaywrightExecutorSchema, } from './src/executors/playwright/playwright.impl';
+export type { PlaywrightExecutorSchema } from './src/executors/playwright/schema';
 export { initGenerator } from './src/generators/init/init';
 export { configurationGenerator } from './src/generators/configuration/configuration';

package/dist/index.js

@@ -1,8 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.configurationGenerator = exports.initGenerator = exports.playwrightExecutor = void 0;
-var playwright_impl_1 = require("./src/executors/playwright/playwright.impl");
-Object.defineProperty(exports, "playwrightExecutor", { enumerable: true, get: function () { return playwright_impl_1.playwrightExecutor; } });
+exports.configurationGenerator = exports.initGenerator = void 0;
 var init_1 = require("./src/generators/init/init");
 Object.defineProperty(exports, "initGenerator", { enumerable: true, get: function () { return init_1.initGenerator; } });
 var configuration_1 = require("./src/generators/configuration/configuration");

package/dist/src/executors/playwright/{playwright.impl.d.ts → schema.d.ts}

@@ -1,4 +1,3 @@
-import { ExecutorContext } from '@nx/devkit';
 export interface PlaywrightExecutorSchema {
     browser?: 'all' | 'chromium' | 'firefox' | 'webkit' | string;
     config?: string;
@@ -33,7 +32,3 @@ export interface PlaywrightExecutorSchema {
     skipInstall?: boolean;
     cacheDir?: string;
 }
-export declare function playwrightExecutor(options: PlaywrightExecutorSchema, context: ExecutorContext): Promise<{
-    success: boolean;
-}>;
-export default playwrightExecutor;

package/dist/src/executors/playwright/schema.js

@@ -0,0 +1,2 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });

package/dist/src/executors/wait-for-webserver/schema.json

@@ -4,6 +4,7 @@
   "title": "Schema for Playwright Wait For Web Server Executor",
   "description": "Waits for the E2E web server(s) to be ready.",
   "type": "object",
+  "x-deprecated": "The `@nx/playwright:wait-for-webserver` executor is deprecated and will be removed in Nx v25. The e2e targets wait for the dev server's `readyWhen` instead.",
   "properties": {
     "servers": {
       "type": "array",

package/dist/src/executors/wait-for-webserver/wait-for-webserver.impl.js

@@ -21,7 +21,7 @@ const FALLBACK_RETRY_DELAY = 1_000;
 // nothing, so it must not replace what the previous probe saw.
 const NO_OBSERVATION = 'the deadline passed before the server responded';
 async function waitForWebserverExecutor(options, context) {
-    const servers = options.servers ?? [];
+    const servers = withReadyUrl(options.servers ?? []);
     if (servers.length === 0) {
         devkit_1.logger.error('@nx/playwright:wait-for-webserver requires at least one server to wait for.');
         return { success: false };
@@ -49,6 +49,15 @@ async function waitForWebserverExecutor(options, context) {
     }
 }
 exports.default = waitForWebserverExecutor;
+// The address the server task reported when it signaled readiness. It names no
+// server, so it only moves the url of a gate waiting for exactly one.
+function withReadyUrl(servers) {
+    const readyUrl = process.env.NX_READY_URL;
+    if (!readyUrl || servers.length !== 1 || servers[0].port != null) {
+        return servers;
+    }
+    return [{ ...servers[0], url: (0, devkit_1.getReadyUrl)(servers[0].url) }];
+}
 // A malformed URL, an out-of-range port and a proxy that cannot be used are all
 // inputs that can never become valid, so they are rejected up front instead of
 // being retried until the timeout and reported as a slow server. An unusable

package/dist/src/generators/configuration/configuration.js

@@ -7,7 +7,6 @@ const internal_1 = require("@nx/devkit/internal");
 const devkit_1 = require("@nx/devkit");
 const js_1 = require("@nx/js");
 const internal_2 = require("@nx/js/internal");
-const deprecation_1 = require("../../utils/deprecation");
 const child_process_1 = require("child_process");
 const path = tslib_1.__importStar(require("path"));
 const add_linter_1 = require("../../utils/add-linter");
@@ -16,7 +15,7 @@ const versions_1 = require("../../utils/versions");
 const init_1 = require("../init/init");
 const internal_3 = require("@nx/eslint/internal");
 function configurationGenerator(tree, options) {
-    return configurationGeneratorInternal(tree, { addPlugin: false, ...options });
+    return configurationGeneratorInternal(tree, options);
 }
 async function configurationGeneratorInternal(tree, rawOptions) {
     (0, assert_supported_playwright_version_1.assertSupportedPlaywrightVersion)(tree);
@@ -25,7 +24,6 @@ async function configurationGeneratorInternal(tree, rawOptions) {
     tasks.push(await (0, init_1.initGenerator)(tree, {
         skipFormat: true,
         skipPackageJson: options.skipPackageJson,
-        addPlugin: options.addPlugin,
     }));
     const projectConfig = (0, devkit_1.readProjectConfiguration)(tree, options.project);
     const offsetFromProjectRoot = (0, devkit_1.offsetFromRoot)(projectConfig.root);
@@ -44,6 +42,8 @@ async function configurationGeneratorInternal(tree, rawOptions) {
         webServerAddress: options.webServerAddress ?? null,
         isTsSolutionSetup,
         ...options,
+        ...getCiWebServer(options),
+        toJsStringLiteral,
     });
     const playwrightConfigFile = options.js
         ? 'playwright.config.mjs'
@@ -135,23 +135,14 @@ async function configurationGeneratorInternal(tree, rawOptions) {
         }
         ignoreTestOutput(tree, options);
     }
-    const hasPlugin = (0, devkit_1.readNxJson)(tree).plugins?.some((p) => typeof p === 'string'
-        ? p === '@nx/playwright/plugin'
-        : p.plugin === '@nx/playwright/plugin');
-    if (!hasPlugin) {
-        (0, deprecation_1.warnPlaywrightExecutorGenerating)();
-        addE2eTarget(tree, options);
-        setupE2ETargetDefaults(tree);
-    }
     tasks.push(await (0, add_linter_1.addLinterToPlaywrightProject)(tree, {
         project: options.project,
         linter: options.linter,
         skipPackageJson: options.skipPackageJson,
         js: options.js,
         directory: options.directory,
-        enableTypedLinting: (0, internal_3.isTypedLintingEnabled)(options),
+        enableTypedLinting: options.enableTypedLinting,
         rootProject: options.rootProject ?? projectConfig.root === '.',
-        addPlugin: options.addPlugin,
     }));
     if (options.js) {
         const { ModuleKind } = (0, internal_2.ensureTypescript)();
@@ -179,10 +170,6 @@ async function configurationGeneratorInternal(tree, rawOptions) {
     return (0, devkit_1.runTasksInSerial)(...tasks);
 }
 async function normalizeOptions(tree, options) {
-    const nxJson = (0, devkit_1.readNxJson)(tree);
-    const addPlugin = options.addPlugin ??
-        (process.env.NX_ADD_PLUGINS !== 'false' &&
-            nxJson.useInferencePlugins !== false);
     const linter = await (0, internal_2.normalizeLinterOption)(tree, options.linter);
     if (!options.webServerCommand || !options.webServerAddress) {
         const { webServerCommand, webServerAddress } = await promptForMissingServeData(options.project);
@@ -191,11 +178,21 @@ async function normalizeOptions(tree, options) {
     }
     return {
         ...options,
-        addPlugin,
         linter,
         directory: options.directory ?? 'e2e',
     };
 }
+function getCiWebServer(options) {
+    const differs = (ciValue, value) => ciValue && ciValue !== value ? ciValue : null;
+    return {
+        ciWebServerCommand: differs(options.ciWebServerCommand, options.webServerCommand),
+        ciWebServerAddress: differs(options.ciWebServerAddress, options.webServerAddress),
+    };
+}
+// The template inserts the result with `<%-`, since `<%=` would HTML-escape it.
+function toJsStringLiteral(value) {
+    return `'${JSON.stringify(value).slice(1, -1).replace(/'/g, "\\'")}'`;
+}
 async function promptForMissingServeData(projectName) {
     if (!(0, internal_1.isInteractive)()) {
         return {
@@ -248,55 +245,6 @@ function recommendVsCodeExtensions(tree) {
         });
     }
 }
-function setupE2ETargetDefaults(tree) {
-    const nxJson = (0, devkit_1.readNxJson)(tree);
-    if (!nxJson.namedInputs) {
-        return;
-    }
-    // E2e targets depend on all their project's sources + production sources of dependencies
-    const productionFileSet = !!nxJson.namedInputs?.production;
-    // Either a `target: 'e2e'` default or a default keyed on the executor
-    // we're about to scaffold will apply to the new target — consider both
-    // before deciding to add cache/inputs. Target-keyed wins when both are
-    // present.
-    const existingForTarget = (0, internal_1.findTargetDefault)(nxJson.targetDefaults, {
-        target: 'e2e',
-    });
-    const existingForExecutor = (0, internal_1.findTargetDefault)(nxJson.targetDefaults, {
-        executor: '@nx/playwright:playwright',
-    });
-    const existingCache = existingForTarget?.cache ?? existingForExecutor?.cache;
-    const existingInputs = existingForTarget?.inputs ?? existingForExecutor?.inputs;
-    const patch = {};
-    if (existingCache === undefined) {
-        patch.cache = true;
-    }
-    if (existingInputs === undefined) {
-        patch.inputs = ['default', productionFileSet ? '^production' : '^default'];
-    }
-    if (Object.keys(patch).length > 0) {
-        (0, internal_1.upsertTargetDefault)(tree, nxJson, { target: 'e2e', ...patch });
-        (0, devkit_1.updateNxJson)(tree, nxJson);
-    }
-}
-function addE2eTarget(tree, options) {
-    const projectConfig = (0, devkit_1.readProjectConfiguration)(tree, options.project);
-    if (projectConfig?.targets?.e2e) {
-        throw new Error(`Project ${options.project} already has an e2e target.
-Rename or remove the existing e2e target.`);
-    }
-    projectConfig.targets ??= {};
-    projectConfig.targets.e2e = {
-        executor: '@nx/playwright:playwright',
-        outputs: [`{workspaceRoot}/dist/.playwright/${projectConfig.root}`],
-        options: {
-            // Generator emits `playwright.config.mts` (`.mjs` for `--js`) so the
-            // legacy executor's `--config` flag must point at the same extension.
-            config: `${projectConfig.root}/playwright.config.${options.js ? 'mjs' : 'mts'}`,
-        },
-    };
-    (0, devkit_1.updateProjectConfiguration)(tree, options.project, projectConfig);
-}
 function ignoreTestOutput(tree, options) {
     // Make sure playwright outputs are not linted.
     if (options.linter === 'eslint') {

package/dist/src/generators/configuration/files/playwright.config.mts.template

@@ -1,9 +1,15 @@
 import { defineConfig, devices } from '@playwright/test';
 import { nxE2EPreset } from '@nx/playwright/preset';
-<% if (webServerCommand && webServerAddress) { %>import { workspaceRoot } from '@nx/devkit';<% } %>
+<% if (webServerCommand && webServerAddress) { %>import { getReadyUrl, workspaceRoot } from '@nx/devkit';<% } %>
+
+<% const switchesOnCI = webServerCommand && webServerAddress && (ciWebServerCommand || ciWebServerAddress); %><% if (switchesOnCI) { %>const isCI = !!process.env['CI'];
+<% } %><% if (switchesOnCI && ciWebServerAddress) { %>// getReadyUrl moves the address to the port the server task reported.
+const webServerAddress = getReadyUrl(isCI ? <%- toJsStringLiteral(ciWebServerAddress) %> : <%- toJsStringLiteral(webServerAddress) %>);
 
 // For CI, you may want to set BASE_URL to the deployed application.
-const baseURL = process.env['BASE_URL'] || '<% if(webServerAddress) {%><%= webServerAddress %><% } else {%>http://localhost:3000<% } %>';
+const baseURL = process.env['BASE_URL'] || webServerAddress;<% } else { %>// For CI, you may want to set BASE_URL to the deployed application.
+<% if (webServerCommand && webServerAddress) { %>// getReadyUrl moves the address to the port the dev server task reported.
+const baseURL = process.env['BASE_URL'] || getReadyUrl(<%- toJsStringLiteral(webServerAddress) %>);<% } else { %>const baseURL = process.env['BASE_URL'] || <%- toJsStringLiteral(webServerAddress || 'http://localhost:3000') %>;<% } %><% } %>
 
 /**
  * Read environment variables from file.
@@ -28,14 +34,14 @@ export default defineConfig({
     baseURL,
     /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
     trace: 'on-first-retry',
-  },
-  /* Run your local dev server before starting the tests */<% if(webServerCommand && webServerAddress) {%>
+  },<% if(webServerCommand && webServerAddress) {%>
   webServer: {
-    command: '<%= webServerCommand %>',
-    url: '<%= webServerAddress %>',
+    command: <% if (ciWebServerCommand) { %>isCI ? <%- toJsStringLiteral(ciWebServerCommand) %> : <%- toJsStringLiteral(webServerCommand) %><% } else { %><%- toJsStringLiteral(webServerCommand) %><% } %>,
+    url: <% if (ciWebServerAddress) { %>webServerAddress<% } else { %>getReadyUrl(<%- toJsStringLiteral(webServerAddress) %>)<% } %>,
     reuseExistingServer: true,
     cwd: workspaceRoot
   },<% } else {%>
+  /* Run your local dev server before starting the tests */
   // webServer: {
   //   command: 'npm run start',
   //   url: 'http://127.0.0.1:3000',

package/dist/src/generators/configuration/schema.d.ts

@@ -12,10 +12,6 @@ export interface ConfigurationGeneratorSchema {
   skipInstall?: boolean;
   linter?: LinterType;
   enableTypedLinting?: boolean; // default is false
-  /**
-   * @deprecated Use `enableTypedLinting` instead. This option will be removed in Nx v24.
-   */
-  setParserOptionsProject?: boolean; // default is false
   /**
    * command to give playwright to run the web server
    * @example: "npx nx serve my-fe-app"
@@ -26,12 +22,20 @@ export interface ConfigurationGeneratorSchema {
    * @example: "http://localhost:4200"
    **/
   webServerAddress?: string;
+  /**
+   * command to run the web server when `CI` is set; defaults to `webServerCommand`
+   * @example: "npx nx serve-static my-fe-app"
+   **/
+  ciWebServerCommand?: string;
+  /**
+   * address of the web server when `CI` is set; defaults to `webServerAddress`
+   * @example: "http://localhost:4300"
+   **/
+  ciWebServerAddress?: string;
   rootProject?: boolean;
-  addPlugin?: boolean;
 }
 
 export interface NormalizedGeneratorOptions extends ConfigurationGeneratorSchema {
-  addPlugin: boolean;
   directory: string;
   linter: LinterType;
 }

package/dist/src/generators/configuration/schema.json

@@ -39,17 +39,19 @@
       "type": "string",
       "description": "The address of the web server."
     },
+    "ciWebServerCommand": {
+      "type": "string",
+      "description": "The command to start the web server when the `CI` environment variable is set. Defaults to `webServerCommand`."
+    },
+    "ciWebServerAddress": {
+      "type": "string",
+      "description": "The address of the web server when the `CI` environment variable is set. Defaults to `webServerAddress`."
+    },
     "enableTypedLinting": {
       "type": "boolean",
       "description": "Whether to enable typed linting. For flat configs, this configures the recommended `parserOptions.projectService` and `tsconfigRootDir`. For legacy `.eslintrc` configs, this configures `parserOptions.project`. We do not enable this by default for lint performance reasons.",
       "default": false
     },
-    "setParserOptionsProject": {
-      "type": "boolean",
-      "description": "Deprecated alias for `enableTypedLinting`.",
-      "default": false,
-      "x-deprecated": "Use `enableTypedLinting` instead. This option will be removed in Nx v24."
-    },
     "skipFormat": {
       "description": "Skip formatting files.",
       "type": "boolean",

package/dist/src/generators/init/init.js

@@ -8,24 +8,18 @@ const plugin_1 = require("../../plugins/plugin");
 const assert_supported_playwright_version_1 = require("../../utils/assert-supported-playwright-version");
 const versions_1 = require("../../utils/versions");
 function initGenerator(tree, options) {
-    return initGeneratorInternal(tree, { addPlugin: false, ...options });
+    return initGeneratorInternal(tree, options);
 }
 async function initGeneratorInternal(tree, options) {
     (0, assert_supported_playwright_version_1.assertSupportedPlaywrightVersion)(tree);
     const tasks = [];
-    const nxJson = (0, devkit_1.readNxJson)(tree);
-    const addPluginDefault = process.env.NX_ADD_PLUGINS !== 'false' &&
-        nxJson.useInferencePlugins !== false;
-    options.addPlugin ??= addPluginDefault;
     if (!options.skipPackageJson) {
         tasks.push((0, devkit_1.addDependenciesToPackageJson)(tree, {}, {
             '@nx/playwright': versions_1.nxVersion,
             '@playwright/test': versions_1.playwrightVersion,
         }, undefined, options.keepExistingVersions ?? true));
     }
-    if (options.addPlugin) {
-        await (0, internal_1.addPlugin)(tree, await (0, devkit_1.createProjectGraphAsync)(), '@nx/playwright/plugin', plugin_1.createNodesV2, { targetName: ['e2e', 'playwright:e2e', 'playwright-e2e'] }, options.updatePackageScripts);
-    }
+    await (0, internal_1.addPlugin)(tree, await (0, devkit_1.createProjectGraphAsync)(), '@nx/playwright/plugin', plugin_1.createNodesV2, { targetName: ['e2e', 'playwright:e2e', 'playwright-e2e'] }, options.updatePackageScripts);
     if (!options.skipFormat) {
         await (0, devkit_1.formatFiles)(tree);
     }

package/dist/src/generators/init/schema.d.ts

@@ -3,5 +3,4 @@ export interface InitGeneratorSchema {
   skipPackageJson?: boolean;
   keepExistingVersions?: boolean;
   updatePackageScripts?: boolean;
-  addPlugin?: boolean;
 }

package/dist/src/migrations/update-24-0-0/finish-inferred-conversion.md

@@ -0,0 +1,12 @@
+# Replace removed @nx/playwright executors with inferred tasks
+
+Nx 24 removed `@nx/playwright:playwright` (including old `@nrwl` aliases).
+
+Before changing anything, check for leftover work: a project target, a package.json target or a `targetDefaults` entry still uses a removed executor, or the advisory context reports a conversion error. If none applies, make no changes and stop. Treat each advisory-context item as pending work.
+
+1. Inspect all affected projects and workspace defaults. Repair config-loading errors first. Do not restore executor registrations or install older Nx packages.
+2. Preserve Playwright config, browser projects, CI sharding and webServer orchestration.
+3. Register `@nx/playwright/plugin` with options/includes that preserve custom target names and mixed inferred/explicit projects. Replace remaining removed-executor targets, including those in package.json and filtered targetDefaults. Transfer their behavior before removing obsolete defaults. Preserve configurations, dependencies, cache inputs/outputs and environment behavior. Do not silently delete unsupported options or unrelated targets. Migrate old @nrwl aliases too.
+4. Run project graph creation with the daemon and graph cache disabled (`NX_DAEMON=false NX_CACHE_PROJECT_GRAPH=false`), using the workspace package manager. Inspect resolved project targets and verify each migrated entrypoint exists and is inferred (a thin alias to an inferred target is acceptable). Resolve graph errors before completing this migration, even if task validation was skipped. Configs must load for subsequent migrations.
+5. By default run relevant real builds/tests with task cache disabled, including alternate configurations. Honor an existing preference to skip expensive task validation; otherwise offer that option when validation is slow. Skipping expensive tasks never skips conversion or the graph check. Report each skipped task as unverified. Never weaken assertions or change application behavior to make checks pass.
+6. Report converted projects, graph validation, task results and any skipped checks. Unconverted targets or a broken graph mean the migration is incomplete. Investigate task failures and distinguish missing environment prerequisites from conversion regressions; do not claim a working workspace with unresolved regressions.

package/dist/src/migrations/update-24-0-0/remove-deprecated-executors.d.ts

@@ -0,0 +1,6 @@
+import type { Tree } from '@nx/devkit';
+export default function update(tree: Tree): Promise<{
+    nextSteps?: string[];
+    agentContext?: string[];
+    skipAgentic?: boolean;
+}>;

package/dist/src/migrations/update-24-0-0/remove-deprecated-executors.js

@@ -0,0 +1,10 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = update;
+const internal_1 = require("@nx/devkit/internal");
+function update(tree) {
+    return (0, internal_1.migrateRemovedExecutors)(tree, ['@nx/playwright:playwright', '@nrwl/playwright:playwright'], async (tree, options) => {
+        const { convertToInferred } = require('../../generators/convert-to-inferred/convert-to-inferred');
+        return convertToInferred(tree, options);
+    });
+}

package/dist/src/migrations/update-24-0-0/remove-deprecated-executors.md

@@ -0,0 +1,40 @@
+#### Convert `@nx/playwright:playwright` targets to inferred tasks
+
+Nx 24 removes the `@nx/playwright:playwright` executor and its `@nrwl/playwright:playwright` alias. The migration registers `@nx/playwright/plugin` in `nx.json` and converts the targets that use those executors to inferred tasks. Options the plugin does not infer stay on the target. A target with nothing left to override is removed from project configuration. When several projects share the same remaining options, those options move to a `targetDefaults` entry scoped to the plugin. `targetDefaults` entries keyed by a removed executor are removed once no target uses that executor.
+
+The migration lists the targets the converter cannot convert safely. In agentic runs, an AI prompt finishes them and validates the project graph.
+
+#### Sample code changes
+
+##### Before
+
+```json title="myapp-e2e/project.json"
+{
+  "name": "myapp-e2e",
+  "targets": {
+    "e2e": {
+      "executor": "@nx/playwright:playwright",
+      "outputs": ["{workspaceRoot}/dist/.playwright/myapp-e2e"],
+      "options": {
+        "config": "myapp-e2e/playwright.config.ts"
+      }
+    }
+  }
+}
+```
+
+##### After
+
+```json title="nx.json"
+{
+  "plugins": [
+    {
+      "plugin": "@nx/playwright/plugin",
+      "options": {
+        "ciTargetName": "e2e-ci",
+        "targetName": "e2e"
+      }
+    }
+  ]
+}
+```

package/dist/src/plugins/plugin.d.ts

@@ -7,15 +7,31 @@ export interface PlaywrightPluginOptions {
      * for a server to be ready before failing. Overrides the `timeout` each
      * Playwright `webServer` configures. Defaults to that configured timeout,
      * or 60000 when neither is set.
+     *
+     * @deprecated Wait for the web server task's `readyWhen` instead, which
+     * `waitForServerReady` turns on. This option will be removed in Nx 25.
      */
     webServerTimeout?: number;
     /**
-     * Whether to infer a task that waits for the web server to be ready before the
-     * Playwright test tasks run. When false, no readiness task is inferred and the
-     * tests fall back to Playwright's own `reuseExistingServer` probe. Defaults to
-     * true.
+     * Whether to infer a task that probes the web server's port or url before the
+     * Playwright test tasks run. Defaults to false: the test tasks wait for the
+     * web server task's `readyWhen` instead. Turn it on for a server without a
+     * `readyWhen`, which counts as ready once it starts, so that Playwright's own
+     * probe doesn't miss and start a second server.
+     *
+     * @deprecated The test tasks wait for the web server task's `readyWhen`.
+     * This option will be removed in Nx 25.
      */
     waitForWebServer?: boolean;
+    /**
+     * Whether the inferred dependencies on the web server tasks wait for those
+     * tasks' `readyWhen` (`waitFor: 'ready'`) rather than for them to start.
+     * Defaults to true.
+     *
+     * @deprecated Leave it unset to wait for the web server task's `readyWhen`,
+     * the only behavior in Nx 25. This option will be removed in Nx 25.
+     */
+    waitForServerReady?: boolean;
 }
 export declare const createNodes: CreateNodes<PlaywrightPluginOptions>;
 export declare const createNodesV2: CreateNodes<PlaywrightPluginOptions>;

package/dist/src/plugins/plugin.js

@@ -205,7 +205,7 @@ async function buildPlaywrightTargets(configFilePath, projectRoot, options, cont
             },
         },
     };
-    applyChainDependsOn(baseTargetConfig, e2eChain, e2eReadyTargetName);
+    applyChainDependsOn(baseTargetConfig, e2eChain, e2eReadyTargetName, options.waitForServerReady);
     targets[options.targetName] = {
         ...baseTargetConfig,
         cache: true,
@@ -215,14 +215,15 @@ async function buildPlaywrightTargets(configFilePath, projectRoot, options, cont
                 : ['default', '^default']),
             ...tsconfigJsonInputs,
             { externalDependencies: ['@playwright/test'] },
+            { env: 'CI' },
         ],
         outputs: getTargetOutputs(testOutput, reporterOutputs, context.workspaceRoot, projectRoot),
     };
     if (e2eReadyTargetName) {
-        targets[e2eReadyTargetName] = buildWaitForWebserverTarget(e2eChain, options.webServerTimeout);
+        targets[e2eReadyTargetName] = buildWaitForWebserverTarget(e2eChain, options.webServerTimeout, options.waitForServerReady);
     }
     if (ciReadyTargetName && ciReadyTargetName !== e2eReadyTargetName) {
-        targets[ciReadyTargetName] = buildWaitForWebserverTarget(ciChain, options.webServerTimeout);
+        targets[ciReadyTargetName] = buildWaitForWebserverTarget(ciChain, options.webServerTimeout, options.waitForServerReady);
     }
     if (options.ciTargetName) {
         // ensure the blob reporter output is the directory containing the blob
@@ -239,13 +240,14 @@ async function buildPlaywrightTargets(configFilePath, projectRoot, options, cont
                     : ['default', '^default']),
                 ...tsconfigJsonInputs,
                 { externalDependencies: ['@playwright/test'] },
+                { env: 'CI' },
             ],
             outputs: getTargetOutputs(testOutput, ciReporterOutputs, context.workspaceRoot, projectRoot),
         };
         // Unconditionally: the chains can differ in ways the shared-gate check
         // deliberately ignores (an extra uncovered server flips parallelism), and
         // re-deriving is a no-op when they match.
-        applyChainDependsOn(ciBaseTargetConfig, ciChain, ciReadyTargetName);
+        applyChainDependsOn(ciBaseTargetConfig, ciChain, ciReadyTargetName, options.waitForServerReady);
         const groupName = 'E2E (CI)';
         metadata = { targetGroups: { [groupName]: [] } };
         const ciTargetGroup = metadata.targetGroups[groupName];
@@ -279,7 +281,7 @@ async function buildPlaywrightTargets(configFilePath, projectRoot, options, cont
             const targetName = `${options.ciTargetName}--${relativeSpecFilePath}`;
             ciTargetGroup.push(targetName);
             targets[targetName] = {
-                ...(0, internal_1.applyTestFileDirectives)(ciBaseTargetConfig, context.workspaceRoot, testFile, ['depends-on', 'ultracache']),
+                ...(0, internal_1.applyTestFileDirectives)(ciBaseTargetConfig, context.workspaceRoot, testFile, { ignoreServerInputs: true }),
                 options: {
                     ...ciBaseTargetConfig.options,
                     env: getAtomizedTaskEnvVars(reporterOutputs, outputSubfolder),
@@ -400,7 +402,8 @@ function normalizeOptions(options) {
         targetName: options?.targetName ?? 'e2e',
         ciTargetName,
         mergeReportsTargetName: `${ciTargetName}--merge-reports`,
-        waitForWebServer: options?.waitForWebServer ?? true,
+        waitForWebServer: options?.waitForWebServer ?? false,
+        waitForServerReady: options?.waitForServerReady !== false,
     };
 }
 function getTestOutput(playwrightConfig) {
@@ -546,7 +549,7 @@ function sameChain(a, b) {
     return (JSON.stringify(a.commandTasks) === JSON.stringify(b.commandTasks) &&
         JSON.stringify(a.readinessServers) === JSON.stringify(b.readinessServers));
 }
-function buildWaitForWebserverTarget(chain, webServerTimeout) {
+function buildWaitForWebserverTarget(chain, webServerTimeout, waitForServerReady) {
     return {
         executor: '@nx/playwright:wait-for-webserver',
         cache: false,
@@ -554,7 +557,7 @@ function buildWaitForWebserverTarget(chain, webServerTimeout) {
             servers: chain.readinessServers,
             ...(webServerTimeout != null ? { timeout: webServerTimeout } : {}),
         },
-        dependsOn: getDependsOn(chain.commandTasks),
+        dependsOn: getDependsOn(chain.commandTasks, waitForServerReady),
         metadata: {
             technologies: ['playwright'],
             description: 'Waits for the E2E web server(s) to be ready before the Playwright test tasks run.',
@@ -693,11 +696,12 @@ function chainRequiresSerialization(chain) {
 // was inferred). Set together with parallelism so a config that inherits one
 // state (the atomized CI base copies the e2e config) cannot end up carrying
 // both.
-function applyChainDependsOn(targetConfig, chain, readyTargetName) {
+function applyChainDependsOn(targetConfig, chain, readyTargetName, waitForServerReady) {
     if (chain.commandTasks.length) {
+        const serverDependsOn = getDependsOn(chain.commandTasks, waitForServerReady);
         targetConfig.dependsOn = readyTargetName
-            ? [...getDependsOn(chain.commandTasks), { target: readyTargetName }]
-            : getDependsOn(chain.commandTasks);
+            ? [...serverDependsOn, { target: readyTargetName }]
+            : serverDependsOn;
     }
     else {
         delete targetConfig.dependsOn;
@@ -709,7 +713,7 @@ function applyChainDependsOn(targetConfig, chain, readyTargetName) {
         delete targetConfig.parallelism;
     }
 }
-function getDependsOn(tasks) {
+function getDependsOn(tasks, waitForServerReady) {
     const projectsPerTask = new Map();
     for (const { project, target } of tasks) {
         if (!projectsPerTask.has(target)) {
@@ -720,6 +724,7 @@ function getDependsOn(tasks) {
     return Array.from(projectsPerTask.entries()).map(([target, projects]) => ({
         projects,
         target,
+        ...(waitForServerReady ? { waitFor: 'ready' } : {}),
     }));
 }
 function normalizeOutput(path, workspaceRoot, projectRoot) {

package/dist/src/utils/add-linter.d.ts

@@ -4,10 +4,6 @@ export interface PlaywrightLinterOptions {
     project: string;
     linter: LinterType;
     enableTypedLinting?: boolean;
-    /**
-     * @deprecated Use `enableTypedLinting` instead. This option will be removed in Nx v24.
-     */
-    setParserOptionsProject?: boolean;
     skipPackageJson: boolean;
     rootProject: boolean;
     js?: boolean;
@@ -15,6 +11,5 @@ export interface PlaywrightLinterOptions {
      * Directory from the project root, where the playwright files will be located.
      **/
     directory: string;
-    addPlugin?: boolean;
 }
 export declare function addLinterToPlaywrightProject(tree: Tree, options: PlaywrightLinterOptions): Promise<GeneratorCallback>;

package/dist/src/utils/add-linter.js

@@ -12,7 +12,7 @@ async function addLinterToPlaywrightProject(tree, options) {
     const tasks = [];
     const projectConfig = (0, devkit_1.readProjectConfiguration)(tree, options.project);
     const eslintFile = (0, internal_1.findEslintFile)(tree, projectConfig.root);
-    const enableTypedLinting = (0, internal_1.isTypedLintingEnabled)(options);
+    const { enableTypedLinting } = options;
     // An existing ESLint config means the project is already registered, so skip
     // straight to the Playwright-specific shaping below.
     if (options.linter !== 'eslint' || !eslintFile) {
@@ -23,7 +23,6 @@ async function addLinterToPlaywrightProject(tree, options) {
             enableTypedLinting,
             skipPackageJson: options.skipPackageJson,
             rootProject: options.rootProject,
-            addPlugin: options.addPlugin,
         }));
     }
     // Everything below configures ESLint — predefined configs, `extends`, ignore

package/executors.json

@@ -1,10 +1,5 @@
 {
   "executors": {
-    "playwright": {
-      "implementation": "./dist/src/executors/playwright/playwright.impl",
-      "schema": "./dist/src/executors/playwright/schema.json",
-      "description": "Run Playwright tests."
-    },
     "merge-reports": {
       "implementation": "./dist/src/executors/merge-reports/merge-reports.impl",
       "schema": "./dist/src/executors/merge-reports/schema.json",

package/migrations.json

@@ -5,6 +5,13 @@
       "description": "Rename imports of `createNodesV2` from `@nx/playwright/plugin` to the canonical `createNodes` export.",
       "implementation": "./dist/src/migrations/update-23-0-0/migrate-create-nodes-v2-to-create-nodes",
       "documentation": "./dist/src/migrations/update-23-0-0/migrate-create-nodes-v2-to-create-nodes.md"
+    },
+    "remove-deprecated-executors": {
+      "version": "24.0.0-beta.3",
+      "description": "Converts targets using the removed `@nx/playwright` executors to inferred tasks; an AI prompt finishes the targets the converter cannot convert safely and validates the project graph.",
+      "implementation": "./dist/src/migrations/update-24-0-0/remove-deprecated-executors",
+      "prompt": "./dist/src/migrations/update-24-0-0/finish-inferred-conversion.md",
+      "documentation": "./dist/src/migrations/update-24-0-0/remove-deprecated-executors.md"
     }
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/playwright",
-  "version": "24.0.0-pr.37405.acdaf31",
+  "version": "24.0.0-rc.0",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -75,16 +75,16 @@
     "supportsOptionalMigrations": true
   },
   "dependencies": {
-    "@nx/devkit": "24.0.0-pr.37405.acdaf31",
-    "@nx/eslint": "24.0.0-pr.37405.acdaf31",
-    "@nx/js": "24.0.0-pr.37405.acdaf31",
+    "@nx/devkit": "24.0.0-rc.0",
+    "@nx/eslint": "24.0.0-rc.0",
+    "@nx/js": "24.0.0-rc.0",
     "https-proxy-agent": "^7.0.6",
     "minimatch": "10.2.5",
     "semver": "^7.6.3",
     "tslib": "^2.3.0"
   },
   "devDependencies": {
-    "nx": "24.0.0-pr.37405.acdaf31"
+    "nx": "24.0.0-rc.0"
   },
   "peerDependencies": {
     "@playwright/test": "^1.36.0"

package/dist/src/executors/playwright/playwright.impl.js

@@ -1,83 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.playwrightExecutor = playwrightExecutor;
-const devkit_1 = require("@nx/devkit");
-const child_process_1 = require("child_process");
-const deprecation_1 = require("../../utils/deprecation");
-async function playwrightExecutor(options, context) {
-    (0, deprecation_1.warnPlaywrightExecutorDeprecation)();
-    const projectRoot = context.projectGraph?.nodes?.[context?.projectName]?.data?.root;
-    if (!projectRoot) {
-        throw new Error(`Unable to find the Project Root for ${context.projectName}. Is it set in the project.json?`);
-    }
-    if (!options.skipInstall) {
-        devkit_1.output.log({
-            title: 'Ensuring Playwright is installed.',
-            bodyLines: ['use --skipInstall to skip installation.'],
-        });
-        const pmc = (0, devkit_1.getPackageManagerCommand)();
-        (0, child_process_1.execSync)(`${pmc.exec} playwright install`, {
-            cwd: devkit_1.workspaceRoot,
-            stdio: 'inherit',
-            windowsHide: true,
-        });
-    }
-    const args = createArgs(options);
-    const env = options.cacheDir
-        ? { ...process.env, PWTEST_CACHE_DIR: options.cacheDir }
-        : undefined;
-    const p = runPlaywright(args, context.root, env);
-    p.stdout.on('data', (message) => {
-        process.stdout.write(message);
-    });
-    p.stderr.on('data', (message) => {
-        process.stderr.write(message);
-    });
-    return new Promise((resolve) => {
-        p.on('close', (code) => {
-            resolve({ success: code === 0 });
-        });
-    });
-}
-function createArgs(opts, exclude = ['skipInstall', 'cacheDir']) {
-    const args = [];
-    const { testFiles, ...rest } = opts;
-    if (testFiles) {
-        args.push(...testFiles);
-    }
-    for (const key in rest) {
-        if (exclude.includes(key))
-            continue;
-        const value = opts[key];
-        // NOTE: playwright doesn't accept pascalCase args, only kebab-case
-        const arg = (0, devkit_1.names)(key).fileName;
-        if (Array.isArray(value)) {
-            args.push(...value.map((v) => `--${arg}=${v.trim()}`));
-        }
-        else if (typeof value === 'boolean') {
-            // NOTE: playwright don't accept --arg=false, instead just don't pass the arg.
-            if (value) {
-                args.push(`--${arg}`);
-            }
-        }
-        else {
-            args.push(`--${arg}=${value}`);
-        }
-    }
-    return args;
-}
-function runPlaywright(args, cwd, env) {
-    try {
-        const cli = require.resolve('@playwright/test/cli');
-        return (0, child_process_1.fork)(cli, ['test', ...args], {
-            stdio: ['pipe', 'pipe', 'pipe', 'ipc'],
-            cwd,
-            ...(env ? { env } : {}),
-        });
-    }
-    catch (e) {
-        console.error(e);
-        throw new Error('Unable to run playwright. Is @playwright/test installed?');
-    }
-}
-exports.default = playwrightExecutor;

package/dist/src/executors/playwright/schema.json

@@ -1,166 +0,0 @@
-{
-  "$schema": "https://json-schema.org/schema",
-  "version": 2,
-  "title": "Playwright executor",
-  "description": "Run Playwright tests.",
-  "x-deprecated": "The `@nx/playwright:playwright` executor is deprecated and will be removed in Nx v24. Run `nx g @nx/playwright:convert-to-inferred` to migrate to the `@nx/playwright/plugin` inferred targets. See https://nx.dev/docs/guides/tasks--caching/convert-to-inferred for details.",
-  "type": "object",
-  "properties": {
-    "browser": {
-      "type": "string",
-      "description": "Browser to use for tests, one of 'all', 'chromium', 'firefox' or 'webkit'. If a playwright config is provided/discovered then the browserName value is expected from the configured 'projects'",
-      "x-priority": "important"
-    },
-    "config": {
-      "type": "string",
-      "description": "Configuration file, or a test directory with optional",
-      "x-completion-type": "file",
-      "x-completion-glob": "playwright?(*)@(.js|.cjs|.mjs|.ts|.cts|.mtx)",
-      "x-priority": "important"
-    },
-    "debug": {
-      "type": "boolean",
-      "description": "Run tests with Playwright Inspector. Shortcut for 'PWDEBUG=1' environment variable and '--timeout=0',--max-failures=1 --headed --workers=1' options"
-    },
-    "lastFailed": {
-      "type": "boolean",
-      "description": "Run only the tests that failed in the last run"
-    },
-    "forbidOnly": {
-      "type": "boolean",
-      "description": "Fail if test.only is called"
-    },
-    "fullyParallel": {
-      "type": "boolean",
-      "description": "Run all tests in parallel"
-    },
-    "grep": {
-      "alias": "g",
-      "type": "string",
-      "description": "Only run tests matching this regular expression"
-    },
-    "globalTimeout": {
-      "type": "number",
-      "description": "Maximum time this test suite can run in milliseconds"
-    },
-    "grepInvert": {
-      "alias": "gv",
-      "type": "string",
-      "description": "Only run tests that do not match this regular expression"
-    },
-    "testFiles": {
-      "alias": "t",
-      "type": "array",
-      "description": "Test files to run",
-      "items": {
-        "type": "string"
-      }
-    },
-    "headed": {
-      "type": "boolean",
-      "description": "Run tests in headed browsers",
-      "x-priority": "important"
-    },
-    "ignoreSnapshots": {
-      "type": "boolean",
-      "description": "Ignore screenshot and snapshot expectations"
-    },
-    "workers": {
-      "alias": "j",
-      "oneOf": [{ "type": "number" }, { "type": "string" }],
-      "description": "Number of concurrent workers or percentage of logical CPU cores, use 1 to run in a single worker"
-    },
-    "list": {
-      "type": "boolean",
-      "description": "Collect all the tests and report them, but do not run"
-    },
-    "maxFailures": {
-      "alias": "x",
-      "oneOf": [{ "type": "number" }, { "type": "boolean" }],
-      "description": "Stop after the first N failures"
-    },
-    "noDeps": {
-      "type": "boolean",
-      "description": "Do not run project dependencies"
-    },
-    "output": {
-      "type": "string",
-      "description": "Folder for output artifacts"
-    },
-    "passWithNoTests": {
-      "type": "boolean",
-      "description": "Makes test run succeed even if no tests were found",
-      "default": true
-    },
-    "project": {
-      "description": "Only run tests from the specified list of projects",
-      "type": "array",
-      "items": {
-        "type": "string"
-      }
-    },
-    "quiet": {
-      "alias": "q",
-      "type": "boolean",
-      "description": "Suppress stdio"
-    },
-    "repeatEach": {
-      "type": "number",
-      "description": "Run each test N times"
-    },
-    "reporter": {
-      "type": "string",
-      "description": "Common Reporter values to use, comma-separated, 'list', 'line', 'dot', 'json', 'junit', 'null', 'github', 'html', 'blob'. To configure reporter options, use the playwright configuration."
-    },
-    "retries": {
-      "type": "number",
-      "description": "Maximum retry count for flaky tests, zero for no retries"
-    },
-    "shard": {
-      "type": "string",
-      "description": "Shard tests and execute only the selected shard, specify in the form 'current/all', 1-based, for example '3/5'"
-    },
-    "timeout": {
-      "type": "number",
-      "description": "Specify test timeout threshold in milliseconds, zero for unlimited"
-    },
-    "trace": {
-      "type": "string",
-      "enum": [
-        "on",
-        "off",
-        "on-first-retry",
-        "on-all-retries",
-        "retain-on-failure"
-      ],
-      "description": "Force tracing mode, can be 'on', 'off', 'on-first-retry', 'on-all-retries', 'retain-on-failure'"
-    },
-    "updateSnapshots": {
-      "alias": "u",
-      "type": "boolean",
-      "description": "Update snapshots with actual results. Snapshots will be created if missing."
-    },
-    "ui": {
-      "type": "boolean",
-      "description": "Run tests in interactive UI mode"
-    },
-    "uiHost": {
-      "type": "string",
-      "description": "Host to serve UI on; specifying this option opens UI in a browser tab"
-    },
-    "uiPort": {
-      "type": "number",
-      "description": "Port to serve UI on, 0 for any free port; specifying this option opens UI in a browser tab"
-    },
-    "skipInstall": {
-      "type": "boolean",
-      "description": "Skip running playwright install before running playwright tests. This is to ensure that playwright browsers are installed before running tests.",
-      "default": false
-    },
-    "cacheDir": {
-      "type": "string",
-      "description": "Directory for Playwright internal cache (browser binaries, etc.). Sets the PWTEST_CACHE_DIR environment variable."
-    }
-  },
-  "required": []
-}

package/dist/src/utils/deprecation.d.ts

@@ -1,3 +0,0 @@
-export declare const PLAYWRIGHT_EXECUTOR_DEPRECATION_MESSAGE = "The `@nx/playwright:playwright` executor is deprecated and will be removed in Nx v24. Run `nx g @nx/playwright:convert-to-inferred` to migrate to the `@nx/playwright/plugin` inferred targets. See https://nx.dev/docs/guides/tasks--caching/convert-to-inferred for details.";
-export declare function warnPlaywrightExecutorDeprecation(): void;
-export declare function warnPlaywrightExecutorGenerating(): void;

package/dist/src/utils/deprecation.js

@@ -1,16 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.PLAYWRIGHT_EXECUTOR_DEPRECATION_MESSAGE = void 0;
-exports.warnPlaywrightExecutorDeprecation = warnPlaywrightExecutorDeprecation;
-exports.warnPlaywrightExecutorGenerating = warnPlaywrightExecutorGenerating;
-const devkit_1 = require("@nx/devkit");
-// TODO(v24): Remove the @nx/playwright:playwright executor. The inferred
-// plugin (@nx/playwright/plugin) and the convert-to-inferred generator stay
-// supported.
-exports.PLAYWRIGHT_EXECUTOR_DEPRECATION_MESSAGE = 'The `@nx/playwright:playwright` executor is deprecated and will be removed in Nx v24. Run `nx g @nx/playwright:convert-to-inferred` to migrate to the `@nx/playwright/plugin` inferred targets. See https://nx.dev/docs/guides/tasks--caching/convert-to-inferred for details.';
-function warnPlaywrightExecutorDeprecation() {
-    devkit_1.logger.warn(exports.PLAYWRIGHT_EXECUTOR_DEPRECATION_MESSAGE);
-}
-function warnPlaywrightExecutorGenerating() {
-    devkit_1.logger.warn('Generating a target that uses the deprecated `@nx/playwright:playwright` executor. The executor will be removed in Nx v24. Run `nx g @nx/playwright:convert-to-inferred` next to migrate this target to the `@nx/playwright/plugin` inferred plugin and prevent future generators from emitting executor targets. See https://nx.dev/docs/guides/tasks--caching/convert-to-inferred for details.');
-}