@nx/playwright 23.1.0-rc.3 → 23.1.1

package/dist/src/generators/configuration/configuration.js

@@ -149,7 +149,7 @@ async function configurationGeneratorInternal(tree, rawOptions) {
         skipPackageJson: options.skipPackageJson,
         js: options.js,
         directory: options.directory,
-        setParserOptionsProject: options.setParserOptionsProject,
+        enableTypedLinting: (0, internal_3.isTypedLintingEnabled)(options),
         rootProject: options.rootProject ?? projectConfig.root === '.',
         addPlugin: options.addPlugin,
     }));

package/dist/src/generators/configuration/schema.d.ts

@@ -11,6 +11,10 @@ export interface ConfigurationGeneratorSchema {
   skipPackageJson?: boolean;
   skipInstall?: boolean;
   linter?: Linter | LinterType;
+  enableTypedLinting?: boolean; // default is false
+  /**
+   * @deprecated Use `enableTypedLinting` instead. This option will be removed in Nx v24.
+   */
   setParserOptionsProject?: boolean; // default is false
   /**
    * command to give playwright to run the web server

package/dist/src/generators/configuration/schema.json

@@ -39,11 +39,17 @@
       "type": "string",
       "description": "The address of the web server."
     },
-    "setParserOptionsProject": {
+    "enableTypedLinting": {
       "type": "boolean",
-      "description": "Whether or not to configure the ESLint `parserOptions.project` option. We do not do this by default for lint performance reasons.",
+      "description": "Whether to enable typed linting. For flat configs, this configures the recommended `parserOptions.projectService` and `tsconfigRootDir`. For legacy `.eslintrc` configs, this configures `parserOptions.project`. We do not enable this by default for lint performance reasons.",
       "default": false
     },
+    "setParserOptionsProject": {
+      "type": "boolean",
+      "description": "Deprecated alias for `enableTypedLinting`.",
+      "default": false,
+      "x-deprecated": "Use `enableTypedLinting` instead. This option will be removed in Nx v24."
+    },
     "skipFormat": {
       "description": "Skip formatting files.",
       "type": "boolean",

package/dist/src/utils/add-linter.d.ts

@@ -3,7 +3,11 @@ import { Linter, LinterType } from '@nx/eslint';
 export interface PlaywrightLinterOptions {
     project: string;
     linter: Linter | LinterType;
-    setParserOptionsProject: boolean;
+    enableTypedLinting?: boolean;
+    /**
+     * @deprecated Use `enableTypedLinting` instead. This option will be removed in Nx v24.
+     */
+    setParserOptionsProject?: boolean;
     skipPackageJson: boolean;
     rootProject: boolean;
     js?: boolean;

package/dist/src/utils/add-linter.js

@@ -12,13 +12,14 @@ async function addLinterToPlaywrightProject(tree, options) {
     const tasks = [];
     const projectConfig = (0, devkit_1.readProjectConfiguration)(tree, options.project);
     const eslintFile = (0, internal_1.findEslintFile)(tree, projectConfig.root);
+    const enableTypedLinting = (0, internal_1.isTypedLintingEnabled)(options);
     if (!eslintFile) {
         tasks.push(await (0, eslint_1.lintProjectGenerator)(tree, {
             project: options.project,
             linter: options.linter,
             skipFormat: true,
             tsConfigPaths: [(0, devkit_1.joinPathFragments)(projectConfig.root, 'tsconfig.json')],
-            setParserOptionsProject: options.setParserOptionsProject,
+            enableTypedLinting,
             skipPackageJson: options.skipPackageJson,
             rootProject: options.rootProject,
             addPlugin: options.addPlugin,
@@ -43,6 +44,13 @@ async function addLinterToPlaywrightProject(tree, options) {
                 files: ['*.ts', '*.js'],
                 rules: {},
             });
+            // `lintProjectGenerator` only runs when the project has no ESLint config
+            // (it already emits the projectService block in that case). For an
+            // existing flat config it didn't run, so emit the block here when typed
+            // linting is requested.
+            if (eslintFile && enableTypedLinting) {
+                (0, internal_1.addTypedLintingToFlatConfig)(tree, projectConfig.root);
+            }
         }
         else {
             const addExtendsTask = (0, internal_1.addExtendsToLintConfig)(tree, projectConfig.root, 'plugin:playwright/recommended');
@@ -53,11 +61,12 @@ async function addLinterToPlaywrightProject(tree, options) {
             }
             (0, internal_1.addOverrideToLintConfig)(tree, projectConfig.root, {
                 files: [`${options.directory}/**/*.{ts,js,tsx,jsx}`],
-                parserOptions: !options.setParserOptionsProject
-                    ? undefined
-                    : {
-                        project: `${projectConfig.root}/tsconfig.*?.json`,
-                    },
+                // Only emit `parserOptions.project` here on the legacy `.eslintrc`
+                // stack. Flat configs use `parserOptions.projectService` emitted by
+                // `lintProjectGenerator`.
+                parserOptions: enableTypedLinting
+                    ? { project: `${projectConfig.root}/tsconfig.*?.json` }
+                    : undefined,
                 rules: {},
             });
         }

package/dist/src/utils/preset.d.ts

@@ -41,4 +41,12 @@ export interface NxPlaywrightOptions {
  * @param pathToConfig will be used to construct the output paths for reporters and test results
  * @param options optional configuration options
  */
-export declare function nxE2EPreset(pathToConfig: string, options?: NxPlaywrightOptions): import("@playwright/test").PlaywrightTestConfig<{}, {}>;
+export declare function nxE2EPreset(pathToConfig: string, options?: NxPlaywrightOptions): {
+    testDir: string;
+    outputDir: string;
+    fullyParallel: true;
+    forbidOnly: boolean;
+    retries: number;
+    workers: number;
+    reporter: any[];
+};

package/dist/src/utils/preset.js

@@ -4,7 +4,6 @@ exports.nxE2EPreset = nxE2EPreset;
 const devkit_1 = require("@nx/devkit");
 const internal_1 = require("@nx/devkit/internal");
 const internal_2 = require("@nx/js/internal");
-const test_1 = require("@playwright/test");
 const node_fs_1 = require("node:fs");
 const node_path_1 = require("node:path");
 const semver_1 = require("semver");
@@ -71,7 +70,12 @@ function nxE2EPreset(pathToConfig, options) {
             },
         ]);
     }
-    return (0, test_1.defineConfig)({
+    // Plain object on purpose: consumers spread this into their own
+    // `defineConfig(...)` call. Calling `defineConfig` here would require
+    // `@playwright/test` at runtime, which crashes when the preset package and
+    // the consuming workspace resolve different copies of it (playwright
+    // refuses to be loaded twice in one process).
+    return {
         testDir: options?.testDir ?? './src',
         outputDir: testResultOuputDir,
         /* Run tests in files in parallel */
@@ -84,5 +88,5 @@ function nxE2EPreset(pathToConfig, options) {
         workers: process.env.CI ? 1 : undefined,
         /* Reporter to use. See https://playwright.dev/docs/test-reporters */
         reporter: [...reporters],
-    });
+    };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/playwright",
-  "version": "23.1.0-rc.3",
+  "version": "23.1.1",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -78,12 +78,12 @@
     "tslib": "^2.3.0",
     "minimatch": "10.2.5",
     "semver": "^7.6.3",
-    "@nx/devkit": "23.1.0-rc.3",
-    "@nx/eslint": "23.1.0-rc.3",
-    "@nx/js": "23.1.0-rc.3"
+    "@nx/devkit": "23.1.1",
+    "@nx/eslint": "23.1.1",
+    "@nx/js": "23.1.1"
   },
   "devDependencies": {
-    "nx": "23.1.0-rc.3"
+    "nx": "23.1.1"
   },
   "peerDependencies": {
     "@playwright/test": "^1.36.0"