@nx/playwright 23.0.0-beta.15 → 23.0.0-beta.17

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/playwright",
-  "version": "23.0.0-beta.15",
+  "version": "23.0.0-beta.17",
   "type": "commonjs",
   "homepage": "https://nx.dev",
   "private": false,
@@ -34,15 +34,15 @@
     "directory": "packages/playwright"
   },
   "dependencies": {
-    "@nx/devkit": "23.0.0-beta.15",
-    "@nx/eslint": "23.0.0-beta.15",
-    "@nx/js": "23.0.0-beta.15",
+    "@nx/devkit": "23.0.0-beta.17",
+    "@nx/eslint": "23.0.0-beta.17",
+    "@nx/js": "23.0.0-beta.17",
     "tslib": "^2.3.0",
     "minimatch": "10.2.5",
     "semver": "^7.6.3"
   },
   "devDependencies": {
-    "nx": "23.0.0-beta.15"
+    "nx": "23.0.0-beta.17"
   },
   "peerDependencies": {
     "@playwright/test": "^1.36.0"

package/src/generators/configuration/configuration.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"configuration.d.ts","sourceRoot":"","sources":["../../../../../../packages/playwright/src/generators/configuration/configuration.ts"],"names":[],"mappings":"AAMA,OAAO,EAIL,iBAAiB,EAWjB,IAAI,EAML,MAAM,YAAY,CAAC;AAiBpB,OAAO,KAAK,EACV,4BAA4B,EAE7B,MAAM,UAAU,CAAC;AAGlB,wBAAgB,sBAAsB,CACpC,IAAI,EAAE,IAAI,EACV,OAAO,EAAE,4BAA4B,8BAGtC;AAED,wBAAsB,8BAA8B,CAClD,IAAI,EAAE,IAAI,EACV,UAAU,EAAE,4BAA4B,8BAkNzC;AAyKD,eAAe,sBAAsB,CAAC"}
+{"version":3,"file":"configuration.d.ts","sourceRoot":"","sources":["../../../../../../packages/playwright/src/generators/configuration/configuration.ts"],"names":[],"mappings":"AAMA,OAAO,EAIL,iBAAiB,EAWjB,IAAI,EAML,MAAM,YAAY,CAAC;AAiBpB,OAAO,KAAK,EACV,4BAA4B,EAE7B,MAAM,UAAU,CAAC;AAGlB,wBAAgB,sBAAsB,CACpC,IAAI,EAAE,IAAI,EACV,OAAO,EAAE,4BAA4B,8BAGtC;AAED,wBAAsB,8BAA8B,CAClD,IAAI,EAAE,IAAI,EACV,UAAU,EAAE,4BAA4B,8BA6NzC;AA2KD,eAAe,sBAAsB,CAAC"}

package/src/generators/configuration/configuration.js

@@ -14,7 +14,7 @@ const add_linter_1 = require("../../utils/add-linter");
 const assert_supported_playwright_version_1 = require("../../utils/assert-supported-playwright-version");
 const versions_1 = require("../../utils/versions");
 const init_1 = require("../init/init");
-const eslint_file_1 = require("@nx/eslint/src/generators/utils/eslint-file");
+const internal_3 = require("@nx/eslint/internal");
 function configurationGenerator(tree, options) {
     return configurationGeneratorInternal(tree, { addPlugin: false, ...options });
 }
@@ -29,14 +29,25 @@ async function configurationGeneratorInternal(tree, rawOptions) {
     }));
     const projectConfig = (0, devkit_1.readProjectConfiguration)(tree, options.project);
     const offsetFromProjectRoot = (0, devkit_1.offsetFromRoot)(projectConfig.root);
+    const isTsSolutionSetup = (0, internal_2.isUsingTsSolutionSetup)(tree);
+    // Always emit `playwright.config.mts`. Node forces `.mts` to ESM
+    // regardless of workspace `type`, so Playwright's runtime routes it
+    // through the ESM loader (`requireOrImport` -> dynamic `import()`),
+    // bypassing the pirates CJS-compile path that breaks ESM-shape `.ts`
+    // configs. Nx's native TS strip loads `.mts` directly via `loadTsFile`.
+    // Playwright's configLoader auto-discovers `.mts` (extension list at
+    // configLoader.js:313 is `.ts/.js/.mts/.mjs/.cts/.cjs`).
     (0, devkit_1.generateFiles)(tree, path.join(__dirname, 'files'), projectConfig.root, {
         offsetFromRoot: offsetFromProjectRoot,
         projectRoot: projectConfig.root,
         webServerCommand: options.webServerCommand ?? null,
         webServerAddress: options.webServerAddress ?? null,
+        isTsSolutionSetup,
         ...options,
     });
-    const isTsSolutionSetup = (0, internal_2.isUsingTsSolutionSetup)(tree);
+    const playwrightConfigFile = options.js
+        ? 'playwright.config.mjs'
+        : 'playwright.config.mts';
     const tsconfigPath = (0, devkit_1.joinPathFragments)(projectConfig.root, 'tsconfig.json');
     if (tree.exists(tsconfigPath)) {
         if (isTsSolutionSetup) {
@@ -50,7 +61,7 @@ async function configurationGeneratorInternal(tree, rawOptions) {
                 include: [
                     (0, devkit_1.joinPathFragments)(options.directory, '**/*.ts'),
                     (0, devkit_1.joinPathFragments)(options.directory, '**/*.js'),
-                    'playwright.config.ts',
+                    playwrightConfigFile,
                 ],
                 exclude: ['out-tsc', 'test-output'],
             };
@@ -78,7 +89,7 @@ async function configurationGeneratorInternal(tree, rawOptions) {
             include: [
                 '**/*.ts',
                 '**/*.js',
-                'playwright.config.ts',
+                playwrightConfigFile,
                 'src/**/*.spec.ts',
                 'src/**/*.spec.js',
                 'src/**/*.test.ts',
@@ -144,7 +155,7 @@ async function configurationGeneratorInternal(tree, rawOptions) {
     }));
     if (options.js) {
         const { ModuleKind } = (0, internal_2.ensureTypescript)();
-        (0, devkit_1.toJS)(tree, { extension: '.cjs', module: ModuleKind.CommonJS });
+        (0, devkit_1.toJS)(tree, { extension: '.mjs', module: ModuleKind.ESNext });
     }
     recommendVsCodeExtensions(tree);
     if (!options.skipPackageJson) {
@@ -279,7 +290,9 @@ Rename or remove the existing e2e target.`);
         executor: '@nx/playwright:playwright',
         outputs: [`{workspaceRoot}/dist/.playwright/${projectConfig.root}`],
         options: {
-            config: `${projectConfig.root}/playwright.config.${options.js ? 'cjs' : 'ts'}`,
+            // Generator emits `playwright.config.mts` (`.mjs` for `--js`) so the
+            // legacy executor's `--config` flag must point at the same extension.
+            config: `${projectConfig.root}/playwright.config.${options.js ? 'mjs' : 'mts'}`,
         },
     };
     (0, devkit_1.updateProjectConfiguration)(tree, options.project, projectConfig);
@@ -287,7 +300,7 @@ Rename or remove the existing e2e target.`);
 function ignoreTestOutput(tree, options) {
     // Make sure playwright outputs are not linted.
     if (options.linter === 'eslint') {
-        (0, eslint_file_1.addIgnoresToLintConfig)(tree, '', ['**/test-output']);
+        (0, internal_3.addIgnoresToLintConfig)(tree, '', ['**/test-output']);
     }
     // Handle gitignore
     if (!tree.exists('.gitignore')) {

package/src/generators/configuration/files/{playwright.config.ts.template → playwright.config.mts.template}

@@ -9,13 +9,20 @@ const baseURL = process.env['BASE_URL'] || '<% if(webServerAddress) {%><%= webSe
  * Read environment variables from file.
  * https://github.com/motdotla/dotenv
  */
-// require('dotenv').config();
+// import 'dotenv/config';
 
 /**
  * See https://playwright.dev/docs/test-configuration.
+ *
+ * Generated as a .mts file so Node forces ESM regardless of workspace
+ * `type`. Playwright routes `.mts` through its ESM loader (dynamic import,
+ * bypassing the pirates CJS-compile path), and Nx's native TS strip loads
+ * `.mts` directly. Playwright's configLoader auto-discovers
+ * `playwright.config.mts` via its extension list
+ * (.ts/.js/.mts/.mjs/.cts/.cjs).
  */
 export default defineConfig({
-  ...nxE2EPreset(__filename, { testDir: './<%= directory %>' }),
+  ...nxE2EPreset(import.meta.dirname, { testDir: './<%= directory %>' }),
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
   use: {
     baseURL,
@@ -50,7 +57,7 @@ export default defineConfig({
       name: "webkit",
       use: { ...devices["Desktop Safari"] },
     },
-    
+
     // Uncomment for mobile browsers support
     /* {
       name: 'Mobile Chrome',

package/src/utils/add-linter.js

@@ -3,17 +3,15 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.addLinterToPlaywrightProject = addLinterToPlaywrightProject;
 const devkit_1 = require("@nx/devkit");
 const eslint_1 = require("@nx/eslint");
-const global_eslint_config_1 = require("@nx/eslint/src/generators/init/global-eslint-config");
+const internal_1 = require("@nx/eslint/internal");
 const versions_1 = require("./versions");
-const eslint_file_1 = require("@nx/eslint/src/generators/utils/eslint-file");
-const flat_config_1 = require("@nx/eslint/src/utils/flat-config");
 async function addLinterToPlaywrightProject(tree, options) {
     if (options.linter === 'none') {
         return () => { };
     }
     const tasks = [];
     const projectConfig = (0, devkit_1.readProjectConfiguration)(tree, options.project);
-    const eslintFile = (0, eslint_file_1.findEslintFile)(tree, projectConfig.root);
+    const eslintFile = (0, internal_1.findEslintFile)(tree, projectConfig.root);
     if (!eslintFile) {
         tasks.push(await (0, eslint_1.lintProjectGenerator)(tree, {
             project: options.project,
@@ -32,28 +30,28 @@ async function addLinterToPlaywrightProject(tree, options) {
     tasks.push(!options.skipPackageJson
         ? (0, devkit_1.addDependenciesToPackageJson)(tree, {}, { 'eslint-plugin-playwright': versions_1.eslintPluginPlaywrightVersion }, undefined, true)
         : () => { });
-    if ((0, eslint_file_1.isEslintConfigSupported)(tree, projectConfig.root) ||
-        (0, eslint_file_1.isEslintConfigSupported)(tree)) {
-        if ((0, flat_config_1.useFlatConfig)(tree)) {
-            (0, eslint_file_1.addPredefinedConfigToFlatLintConfig)(tree, projectConfig.root, 'flat/recommended', {
+    if ((0, internal_1.isEslintConfigSupported)(tree, projectConfig.root) ||
+        (0, internal_1.isEslintConfigSupported)(tree)) {
+        if ((0, internal_1.useFlatConfig)(tree)) {
+            (0, internal_1.addPredefinedConfigToFlatLintConfig)(tree, projectConfig.root, 'flat/recommended', {
                 moduleName: 'playwright',
                 moduleImportPath: 'eslint-plugin-playwright',
                 spread: false,
                 insertAtTheEnd: false,
             });
-            (0, eslint_file_1.addOverrideToLintConfig)(tree, projectConfig.root, {
+            (0, internal_1.addOverrideToLintConfig)(tree, projectConfig.root, {
                 files: ['*.ts', '*.js'],
                 rules: {},
             });
         }
         else {
-            const addExtendsTask = (0, eslint_file_1.addExtendsToLintConfig)(tree, projectConfig.root, 'plugin:playwright/recommended');
+            const addExtendsTask = (0, internal_1.addExtendsToLintConfig)(tree, projectConfig.root, 'plugin:playwright/recommended');
             tasks.push(addExtendsTask);
             if (options.rootProject) {
-                (0, eslint_file_1.addPluginsToLintConfig)(tree, projectConfig.root, '@nx');
-                (0, eslint_file_1.addOverrideToLintConfig)(tree, projectConfig.root, global_eslint_config_1.javaScriptOverride);
+                (0, internal_1.addPluginsToLintConfig)(tree, projectConfig.root, '@nx');
+                (0, internal_1.addOverrideToLintConfig)(tree, projectConfig.root, internal_1.javaScriptOverride);
             }
-            (0, eslint_file_1.addOverrideToLintConfig)(tree, projectConfig.root, {
+            (0, internal_1.addOverrideToLintConfig)(tree, projectConfig.root, {
                 files: [`${options.directory}/**/*.{ts,js,tsx,jsx}`],
                 parserOptions: !options.setParserOptionsProject
                     ? undefined

package/src/utils/preset.d.ts

@@ -30,8 +30,11 @@ export interface NxPlaywrightOptions {
  *
  * you can easily extend this within your playwright config via spreading the preset
  * @example
+ * // Nx generates `playwright.config.mts` (ESM). Pass `import.meta.dirname`.
+ * // For hand-written CJS configs (`.cts` or `.ts` outside a `type: "module"`
+ * // workspace), pass `__filename` instead.
  * export default defineConfig({
- *   ...nxE2EPreset(__filename, options)
+ *   ...nxE2EPreset(import.meta.dirname, options)
  *   // add your own config here
  * })
  *

package/src/utils/preset.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"preset.d.ts","sourceRoot":"","sources":["../../../../../packages/playwright/src/utils/preset.ts"],"names":[],"mappings":"AASA,MAAM,WAAW,mBAAmB;IAClC;;;QAGI;IACJ,OAAO,CAAC,EAAE,MAAM,CAAC;IAEjB;;;OAGG;IACH,cAAc,CAAC,EAAE,QAAQ,GAAG,OAAO,GAAG,YAAY,CAAC;IACnD;;;;OAIG;IACH,mBAAmB,CAAC,EAAE,OAAO,CAAC;CAC/B;AAED;;;;;;;;;;;;;;;;;;;;;GAqBG;AACH,wBAAgB,WAAW,CACzB,YAAY,EAAE,MAAM,EACpB,OAAO,CAAC,EAAE,mBAAmB,2DA2D9B"}
+{"version":3,"file":"preset.d.ts","sourceRoot":"","sources":["../../../../../packages/playwright/src/utils/preset.ts"],"names":[],"mappings":"AASA,MAAM,WAAW,mBAAmB;IAClC;;;QAGI;IACJ,OAAO,CAAC,EAAE,MAAM,CAAC;IAEjB;;;OAGG;IACH,cAAc,CAAC,EAAE,QAAQ,GAAG,OAAO,GAAG,YAAY,CAAC;IACnD;;;;OAIG;IACH,mBAAmB,CAAC,EAAE,OAAO,CAAC;CAC/B;AAED;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AACH,wBAAgB,WAAW,CACzB,YAAY,EAAE,MAAM,EACpB,OAAO,CAAC,EAAE,mBAAmB,2DA2D9B"}

package/src/utils/preset.js

@@ -23,8 +23,11 @@ const versions_1 = require("./versions");
  *
  * you can easily extend this within your playwright config via spreading the preset
  * @example
+ * // Nx generates `playwright.config.mts` (ESM). Pass `import.meta.dirname`.
+ * // For hand-written CJS configs (`.cts` or `.ts` outside a `type: "module"`
+ * // workspace), pass `__filename` instead.
  * export default defineConfig({
- *   ...nxE2EPreset(__filename, options)
+ *   ...nxE2EPreset(import.meta.dirname, options)
  *   // add your own config here
  * })
  *