@nx/playwright 20.4.0-canary.20250117-cba25da → 20.4.0-canary.20250121-ee135b2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/playwright",
-  "version": "20.4.0-canary.20250117-cba25da",
+  "version": "20.4.0-canary.20250121-ee135b2",
   "type": "commonjs",
   "homepage": "https://nx.dev",
   "private": false,
@@ -35,11 +35,11 @@
   },
   "dependencies": {
     "@phenomnomnominal/tsquery": "~5.0.1",
-    "@nx/devkit": "20.4.0-canary.20250117-cba25da",
-    "@nx/eslint": "20.4.0-canary.20250117-cba25da",
-    "@nx/webpack": "20.4.0-canary.20250117-cba25da",
-    "@nx/vite": "20.4.0-canary.20250117-cba25da",
-    "@nx/js": "20.4.0-canary.20250117-cba25da",
+    "@nx/devkit": "20.4.0-canary.20250121-ee135b2",
+    "@nx/eslint": "20.4.0-canary.20250121-ee135b2",
+    "@nx/webpack": "20.4.0-canary.20250121-ee135b2",
+    "@nx/vite": "20.4.0-canary.20250121-ee135b2",
+    "@nx/js": "20.4.0-canary.20250121-ee135b2",
     "tslib": "^2.3.0",
     "minimatch": "9.0.3"
   },

package/src/generators/configuration/configuration.js

@@ -4,6 +4,7 @@ exports.configurationGenerator = configurationGenerator;
 exports.configurationGeneratorInternal = configurationGeneratorInternal;
 const devkit_1 = require("@nx/devkit");
 const project_name_and_root_utils_1 = require("@nx/devkit/src/generators/project-name-and-root-utils");
+const prompt_1 = require("@nx/devkit/src/generators/prompt");
 const js_1 = require("@nx/js");
 const generator_prompts_1 = require("@nx/js/src/utils/generator-prompts");
 const package_manager_workspaces_1 = require("@nx/js/src/utils/package-manager-workspaces");
@@ -170,6 +171,11 @@ async function normalizeOptions(tree, options) {
         (process.env.NX_ADD_PLUGINS !== 'false' &&
             nxJson.useInferencePlugins !== false);
     const linter = await (0, generator_prompts_1.normalizeLinterOption)(tree, options.linter);
+    if (!options.webServerCommand || !options.webServerAddress) {
+        const { webServerCommand, webServerAddress } = await promptForMissingServeData(options.project);
+        options.webServerCommand = webServerCommand;
+        options.webServerAddress = webServerAddress;
+    }
     return {
         ...options,
         addPlugin,
@@ -177,6 +183,29 @@ async function normalizeOptions(tree, options) {
         directory: options.directory ?? 'e2e',
     };
 }
+async function promptForMissingServeData(projectName) {
+    const { command, port } = await (0, prompt_1.promptWhenInteractive)([
+        {
+            type: 'input',
+            name: 'command',
+            message: 'What command should be run to serve the application locally?',
+            initial: `npx nx serve ${projectName}`,
+        },
+        {
+            type: 'numeral',
+            name: 'port',
+            message: 'What port will the application be served on?',
+            initial: 3000,
+        },
+    ], {
+        command: `npx nx serve ${projectName}`,
+        port: 3000,
+    });
+    return {
+        webServerCommand: command,
+        webServerAddress: `http://localhost:${port}`,
+    };
+}
 function getBrowsersInstallTask() {
     return () => {
         devkit_1.output.log({

package/src/plugins/plugin.js

@@ -54,7 +54,7 @@ async function createNodesInternal(configFilePath, options, context, targetsCach
         return {};
     }
     const normalizedOptions = normalizeOptions(options);
-    const hash = await (0, calculate_hash_for_create_nodes_1.calculateHashForCreateNodes)(projectRoot, options, context, [(0, js_1.getLockFileName)((0, devkit_1.detectPackageManager)(context.workspaceRoot))]);
+    const hash = await (0, calculate_hash_for_create_nodes_1.calculateHashForCreateNodes)(projectRoot, normalizedOptions, context, [(0, js_1.getLockFileName)((0, devkit_1.detectPackageManager)(context.workspaceRoot))]);
     targetsCache[hash] ??= await buildPlaywrightTargets(configFilePath, projectRoot, normalizedOptions, context);
     const { targets, metadata } = targetsCache[hash];
     return {
@@ -227,8 +227,8 @@ function createMatcher(pattern) {
 function normalizeOptions(options) {
     return {
         ...options,
-        targetName: options.targetName ?? 'e2e',
-        ciTargetName: options.ciTargetName ?? 'e2e-ci',
+        targetName: options?.targetName ?? 'e2e',
+        ciTargetName: options?.ciTargetName ?? 'e2e-ci',
     };
 }
 function getTestOutput(playwrightConfig) {