@nx/playwright 19.6.0-canary.20240813-c72ba9b → 19.6.0-rc.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/playwright",
-  "version": "19.6.0-canary.20240813-c72ba9b",
+  "version": "19.6.0-rc.0",
   "type": "commonjs",
   "homepage": "https://nx.dev",
   "private": false,
@@ -35,11 +35,11 @@
   },
   "dependencies": {
     "@phenomnomnominal/tsquery": "~5.0.1",
-    "@nx/devkit": "19.6.0-canary.20240813-c72ba9b",
-    "@nx/eslint": "19.6.0-canary.20240813-c72ba9b",
-    "@nx/webpack": "19.6.0-canary.20240813-c72ba9b",
-    "@nx/vite": "19.6.0-canary.20240813-c72ba9b",
-    "@nx/js": "19.6.0-canary.20240813-c72ba9b",
+    "@nx/devkit": "19.6.0-rc.0",
+    "@nx/eslint": "19.6.0-rc.0",
+    "@nx/webpack": "19.6.0-rc.0",
+    "@nx/vite": "19.6.0-rc.0",
+    "@nx/js": "19.6.0-rc.0",
     "tslib": "^2.3.0",
     "minimatch": "9.0.3"
   },
@@ -66,5 +66,6 @@
   },
   "nx-migrations": {
     "migrations": "./migrations.json"
-  }
+  },
+  "types": "./index.d.ts"
 }

package/src/migrations/update-19-6-0/use-serve-static-preview-for-command.js

@@ -58,17 +58,21 @@ async function default_1(tree) {
             (0, devkit_1.joinPathFragments)(graph.nodes[project].data.root, 'webpack.config.ts'),
             (0, devkit_1.joinPathFragments)(graph.nodes[project].data.root, 'webpack.config.js'),
         ].find((p) => tree.exists(p));
-        collectedProjects.push({
-            projectName: project,
-            configFile: pathToWebpackConfig ?? pathToViteConfig,
-            configFileType: pathToWebpackConfig ? 'webpack' : 'vite',
-            playwrightConfigFile: path,
-            commandValueNode,
-        });
+        const configFile = pathToWebpackConfig ?? pathToViteConfig;
+        // Only migrate projects that have a webpack or vite config file
+        if (configFile) {
+            collectedProjects.push({
+                projectName: project,
+                configFile,
+                configFileType: pathToWebpackConfig ? 'webpack' : 'vite',
+                playwrightConfigFile: path,
+                commandValueNode,
+            });
+        }
     });
     for (const projectToMigrate of collectedProjects) {
         let playwrightConfigFileContents = tree.read(projectToMigrate.playwrightConfigFile, 'utf-8');
-        const targetName = await getServeStaticTargetNameForConfigFile(tree, projectToMigrate.configFileType === 'webpack'
+        const targetName = (await getServeStaticTargetNameForConfigFile(tree, projectToMigrate.configFileType === 'webpack'
             ? '@nx/webpack/plugin'
             : '@nx/vite/plugin', projectToMigrate.configFile, projectToMigrate.configFileType === 'webpack'
             ? 'serve-static'
@@ -76,7 +80,13 @@ async function default_1(tree) {
             ? 'serveStaticTargetName'
             : 'previewTargetName', projectToMigrate.configFileType === 'webpack'
             ? plugin_1.createNodesV2
-            : plugin_2.createNodesV2);
+            : plugin_2.createNodesV2)) ??
+            getServeStaticLikeTarget(tree, graph, projectToMigrate.projectName, projectToMigrate.configFileType === 'webpack'
+                ? '@nx/web:file-server'
+                : '@nx/vite:preview-server');
+        if (!targetName) {
+            continue;
+        }
         const oldCommand = projectToMigrate.commandValueNode.getText();
         const newCommand = oldCommand.replace(/nx.*[^"']/, `nx run ${projectToMigrate.projectName}:${targetName}`);
         if (projectToMigrate.configFileType === 'webpack') {
@@ -117,9 +127,9 @@ async function getServeStaticTargetNameForConfigFile(tree, pluginName, configFil
     const nxJson = (0, devkit_1.readNxJson)(tree);
     const matchingPluginRegistrations = nxJson.plugins?.filter((p) => typeof p === 'string' ? p === pluginName : p.plugin === pluginName);
     if (!matchingPluginRegistrations) {
-        return defaultTargetName;
+        return undefined;
     }
-    let targetName = defaultTargetName;
+    let targetName = undefined;
     for (const plugin of matchingPluginRegistrations) {
         let projectConfigs;
         try {
@@ -144,3 +154,13 @@ async function getServeStaticTargetNameForConfigFile(tree, pluginName, configFil
     }
     return targetName;
 }
+function getServeStaticLikeTarget(tree, graph, projectName, executorName) {
+    if (!graph.nodes[projectName]?.data?.targets) {
+        return;
+    }
+    for (const [targetName, targetOptions] of Object.entries(graph.nodes[projectName].data.targets)) {
+        if (targetOptions.executor && targetOptions.executor === executorName) {
+            return targetName;
+        }
+    }
+}