@nx/playwright 19.4.0-beta.1 → 19.4.0-beta.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/playwright",
-  "version": "19.4.0-beta.1",
+  "version": "19.4.0-beta.2",
   "type": "commonjs",
   "homepage": "https://nx.dev",
   "private": false,
@@ -35,9 +35,9 @@
   },
   "dependencies": {
     "@phenomnomnominal/tsquery": "~5.0.1",
-    "@nx/devkit": "19.4.0-beta.1",
-    "@nx/eslint": "19.4.0-beta.1",
-    "@nx/js": "19.4.0-beta.1",
+    "@nx/devkit": "19.4.0-beta.2",
+    "@nx/eslint": "19.4.0-beta.2",
+    "@nx/js": "19.4.0-beta.2",
     "tslib": "^2.3.0",
     "minimatch": "9.0.3"
   },

package/src/executors/playwright/playwright.impl.d.ts

@@ -11,7 +11,7 @@ export interface PlaywrightExecutorSchema {
     testFiles?: string[];
     headed?: boolean;
     ignoreSnapshots?: boolean;
-    workers?: string;
+    workers?: number | string;
     list?: boolean;
     maxFailures?: number | boolean;
     noDeps?: boolean;

package/src/executors/playwright/schema.json

@@ -62,7 +62,7 @@
     },
     "workers": {
       "alias": "j",
-      "type": "string",
+      "oneOf": [{ "type": "number" }, { "type": "string" }],
       "description": "Number of concurrent workers or percentage of logical CPU cores, use 1 to run in a single worker"
     },
     "list": {

package/src/generators/convert-to-inferred/convert-to-inferred.js

@@ -6,7 +6,13 @@ const plugin_1 = require("../../plugins/plugin");
 const executor_to_plugin_migrator_1 = require("@nx/devkit/src/generators/plugin-migrations/executor-to-plugin-migrator");
 async function convertToInferred(tree, options) {
     const projectGraph = await (0, devkit_1.createProjectGraphAsync)();
-    const migratedProjects = await (0, executor_to_plugin_migrator_1.migrateExecutorToPlugin)(tree, projectGraph, '@nx/playwright:playwright', '@nx/playwright/plugin', (targetName) => ({ targetName, ciTargetName: 'e2e-ci' }), postTargetTransformer, plugin_1.createNodesV2, options.project);
+    const migratedProjects = await (0, executor_to_plugin_migrator_1.migrateProjectExecutorsToPlugin)(tree, projectGraph, '@nx/playwright/plugin', plugin_1.createNodesV2, { targetName: 'e2e', ciTargetName: 'e2e-ci' }, [
+        {
+            executors: ['@nx/playwright:playwright'],
+            postTargetTransformer,
+            targetPluginOptionMapper: (targetName) => ({ targetName }),
+        },
+    ], options.project);
     if (migratedProjects.size === 0) {
         throw new Error('Could not find any targets to migrate.');
     }
@@ -20,12 +26,21 @@ function postTargetTransformer(target) {
         if (target.options?.config) {
             delete target.options.config;
         }
-        for (const [key, value] of Object.entries(target.options)) {
-            const newKeyName = (0, devkit_1.names)(key).fileName;
-            delete target.options[key];
-            target.options[newKeyName] = value;
+        handleRenameOfProperties(target.options);
+    }
+    if (target.configurations) {
+        for (const configurationName in target.configurations) {
+            const configuration = target.configurations[configurationName];
+            handleRenameOfProperties(configuration);
         }
     }
     return target;
 }
+function handleRenameOfProperties(options) {
+    for (const [key, value] of Object.entries(options)) {
+        const newKeyName = (0, devkit_1.names)(key).fileName;
+        delete options[key];
+        options[newKeyName] = value;
+    }
+}
 exports.default = convertToInferred;

package/src/plugins/plugin.js

@@ -127,6 +127,7 @@ async function buildPlaywrightTargets(configFilePath, projectRoot, options, cont
                 metadata: {
                     technologies: ['playwright'],
                     description: `Runs Playwright Tests in ${relativeSpecFilePath} in CI`,
+                    nonAtomizedTarget: options.targetName,
                 },
             };
             dependsOn.push({
@@ -149,6 +150,7 @@ async function buildPlaywrightTargets(configFilePath, projectRoot, options, cont
             metadata: {
                 technologies: ['playwright'],
                 description: 'Runs Playwright Tests in CI',
+                nonAtomizedTarget: options.targetName,
             },
         };
         ciTargetGroup.push(options.ciTargetName);