@nx/module-federation 23.3.0-beta.7 → 23.3.0-beta.8

package/README.md

@@ -12,7 +12,7 @@
 [![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)](<>)
 [![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
 [![Join us on the Official Nx Discord Server](https://img.shields.io/discord/1143497901675401286?label=discord)](https://go.nx.dev/community)
-[![Nx Sandboxing](https://staging.nx.app/workspaces/62d013ea0852fe0a2df74438/sandbox-badge.svg)](https://nx.dev/docs/features/ci-features/sandboxing)
+[![Hours saved](https://img.shields.io/endpoint?url=https%3A%2F%2Fstaging.nx.app%2Fnx-cloud%2Fbadge%2F62d013ea0852fe0a2df74438%2Fhours-saved.json)](https://nx.dev/nx-cloud)
 
 </div>
 

package/dist/src/utils/module-federation-config.js

@@ -28,11 +28,12 @@ function buildModuleFederationConfig(mfConfig, options, frameworkConfig, project
         dependencies.npmPackages = dependencies.npmPackages.filter((pkg) => mfConfig.shared(pkg, {}) !== false);
     }
     const sharedLibraries = (0, index_1.shareWorkspaceLibraries)(dependencies.workspaceLibraries, undefined, bundler);
-    // Build npm packages list with framework-specific defaults
+    // Build npm packages list with framework-specific defaults. Undeclared defaults
+    // are dropped; a real project dependency still warns when its version is missing.
     let npmPackagesList = dependencies.npmPackages;
     if (defaultPackagesToShare.length > 0 || packagesToAvoid.length > 0) {
         npmPackagesList = Array.from(new Set([
-            ...defaultPackagesToShare,
+            ...(0, index_1.filterPackagesDeclaredInRootPackageJson)(defaultPackagesToShare),
             ...dependencies.npmPackages.filter((pkg) => !packagesToAvoid.includes(pkg)),
         ]));
     }

package/dist/src/utils/share.d.ts

@@ -17,6 +17,15 @@ export declare function shareWorkspaceLibraries(workspaceLibs: WorkspaceLibrary[
  * @param version - Version of the package to require by other apps in the Module Federation setup
  */
 export declare function getNpmPackageSharedConfig(pkgName: string, version: string): SharedLibraryConfig | undefined;
+/**
+ * Narrow a list of package names down to those with a version declared in the
+ * root package.json.
+ *
+ * Version resolution matches {@link sharePackages}, so a package kept here never
+ * trips the missing-version warning in {@link getNpmPackageSharedConfig}.
+ * @param packages - Array of package names as strings
+ */
+export declare function filterPackagesDeclaredInRootPackageJson(packages: string[]): string[];
 /**
  * Create a dictionary of packages and their Module Federation Shared Config
  * from an array of package names.

package/dist/src/utils/share.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.shareWorkspaceLibraries = shareWorkspaceLibraries;
 exports.getNpmPackageSharedConfig = getNpmPackageSharedConfig;
+exports.filterPackagesDeclaredInRootPackageJson = filterPackagesDeclaredInRootPackageJson;
 exports.sharePackages = sharePackages;
 exports.applySharedFunction = applySharedFunction;
 exports.applyAdditionalShared = applyAdditionalShared;
@@ -213,6 +214,21 @@ function getNpmPackageSharedConfig(pkgName, version) {
     }
     return { singleton: true, strictVersion: true, requiredVersion: version };
 }
+/**
+ * Narrow a list of package names down to those with a version declared in the
+ * root package.json.
+ *
+ * Version resolution matches {@link sharePackages}, so a package kept here never
+ * trips the missing-version warning in {@link getNpmPackageSharedConfig}.
+ * @param packages - Array of package names as strings
+ */
+function filterPackagesDeclaredInRootPackageJson(packages) {
+    if (packages.length === 0) {
+        return [];
+    }
+    const pkgJson = (0, package_json_1.readRootPackageJson)();
+    return packages.filter((pkg) => Boolean((0, devkit_1.getDependencyVersionFromPackageJson)(pkg, devkit_1.workspaceRoot, pkgJson)));
+}
 /**
  * Create a dictionary of packages and their Module Federation Shared Config
  * from an array of package names.

package/dist/src/with-module-federation/angular/utils.d.ts

@@ -1,6 +1,7 @@
 import { ModuleFederationConfig, SharedLibraryConfig } from '../../utils';
 /**
- * Default npm packages to always share for Angular projects.
+ * Default npm packages to share for Angular projects, each shared only when the
+ * workspace declares it in the root package.json.
  */
 export declare const DEFAULT_ANGULAR_PACKAGES_TO_SHARE: string[];
 /**

package/dist/src/with-module-federation/angular/utils.js

@@ -7,7 +7,8 @@ exports.getModuleFederationConfig = getModuleFederationConfig;
 exports.getModuleFederationConfigSync = getModuleFederationConfigSync;
 const module_federation_config_1 = require("../../utils/module-federation-config");
 /**
- * Default npm packages to always share for Angular projects.
+ * Default npm packages to share for Angular projects, each shared only when the
+ * workspace declares it in the root package.json.
  */
 exports.DEFAULT_ANGULAR_PACKAGES_TO_SHARE = [
     '@angular/core',

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nx/module-federation",
   "description": "The Nx Plugin for Module Federation contains executors and utilities that support building applications using Module Federation.",
-  "version": "23.3.0-beta.7",
+  "version": "23.3.0-beta.8",
   "type": "commonjs",
   "files": [
     "dist",
@@ -124,9 +124,9 @@
   },
   "executors": "./executors.json",
   "dependencies": {
-    "@nx/devkit": "23.3.0-beta.7",
-    "@nx/js": "23.3.0-beta.7",
-    "@nx/web": "23.3.0-beta.7",
+    "@nx/devkit": "23.3.0-beta.8",
+    "@nx/js": "23.3.0-beta.8",
+    "@nx/web": "23.3.0-beta.8",
     "@rspack/core": "^2.0.4",
     "express": "^4.21.2",
     "http-proxy-middleware": "^3.0.7",
@@ -150,7 +150,7 @@
     }
   },
   "devDependencies": {
-    "nx": "23.3.0-beta.7",
+    "nx": "23.3.0-beta.8",
     "webpack": "5.109.2"
   },
   "nx-migrations": {