@nx/module-federation 22.2.3 → 22.3.0-beta.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nx/module-federation",
   "description": "The Nx Plugin for Module Federation contains executors and utilities that support building applications using Module Federation.",
-  "version": "22.2.3",
+  "version": "22.3.0-beta.0",
   "type": "commonjs",
   "repository": {
     "type": "git",
@@ -27,9 +27,9 @@
     "@module-federation/enhanced": "^0.21.2",
     "@module-federation/node": "^2.7.21",
     "@module-federation/sdk": "^0.21.2",
-    "@nx/devkit": "22.2.3",
-    "@nx/js": "22.2.3",
-    "@nx/web": "22.2.3",
+    "@nx/devkit": "22.3.0-beta.0",
+    "@nx/js": "22.3.0-beta.0",
+    "@nx/web": "22.3.0-beta.0",
     "@rspack/core": "^1.5.2",
     "express": "^4.21.2",
     "http-proxy-middleware": "^3.0.5",
@@ -38,7 +38,7 @@
     "webpack": "^5.101.3"
   },
   "devDependencies": {
-    "nx": "22.2.3"
+    "nx": "22.3.0-beta.0"
   },
   "nx-migrations": {
     "migrations": "./migrations.json"

package/src/executors/utils/start-remote-iterators.d.ts

@@ -5,7 +5,7 @@ export declare function startRemoteIterators(options: StartRemoteIteratorsOption
         staticRemotes: string[];
         devRemotes: any[];
         dynamicRemotes: any[];
-        remotePorts: any[];
+        remotePorts: number[];
         staticRemotePort: number;
     };
     devRemoteIters: AsyncIterable<{

package/src/utils/get-remotes-for-host.d.ts

@@ -10,7 +10,7 @@ export declare function getRemotes(devRemotes: string[], skipRemotes: string[],
     staticRemotes: string[];
     devRemotes: any[];
     dynamicRemotes: any[];
-    remotePorts: any[];
+    remotePorts: number[];
     staticRemotePort: number;
 };
 export declare function getModuleFederationConfig(tsconfigPath: string | undefined, workspaceRoot: string, projectRoot: string, pluginName?: 'react' | 'angular'): any;

package/src/utils/get-remotes-for-host.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"get-remotes-for-host.d.ts","sourceRoot":"","sources":["../../../../../packages/module-federation/src/utils/get-remotes-for-host.ts"],"names":[],"mappings":"AAAA,OAAO,EAGL,KAAK,oBAAoB,EACzB,KAAK,YAAY,EAElB,MAAM,YAAY,CAAC;AAMpB,OAAO,EAAE,sBAAsB,EAAE,MAAM,UAAU,CAAC;AAElD,UAAU,+BAA+B;IACvC,WAAW,EAAE,MAAM,CAAC;IACpB,YAAY,EAAE,YAAY,CAAC;IAC3B,IAAI,EAAE,MAAM,CAAC;CACd;AAoCD,wBAAgB,iCAAiC,CAC/C,aAAa,EAAE,oBAAoB,EACnC,YAAY,EAAE,YAAY,UA0B3B;AAoCD,wBAAgB,UAAU,CACxB,UAAU,EAAE,MAAM,EAAE,EACpB,WAAW,EAAE,MAAM,EAAE,EACrB,MAAM,EAAE,sBAAsB,EAC9B,OAAO,EAAE,+BAA+B,EACxC,kBAAkB,CAAC,EAAE,MAAM;;;;;;EAkF5B;AAED,wBAAgB,yBAAyB,CACvC,YAAY,EAAE,MAAM,GAAG,SAAS,EAChC,aAAa,EAAE,MAAM,EACrB,WAAW,EAAE,MAAM,EACnB,UAAU,GAAE,OAAO,GAAG,SAAmB,OAkD1C"}
+{"version":3,"file":"get-remotes-for-host.d.ts","sourceRoot":"","sources":["../../../../../packages/module-federation/src/utils/get-remotes-for-host.ts"],"names":[],"mappings":"AAAA,OAAO,EAGL,KAAK,oBAAoB,EACzB,KAAK,YAAY,EAElB,MAAM,YAAY,CAAC;AAMpB,OAAO,EAAE,sBAAsB,EAAE,MAAM,UAAU,CAAC;AAElD,UAAU,+BAA+B;IACvC,WAAW,EAAE,MAAM,CAAC;IACpB,YAAY,EAAE,YAAY,CAAC;IAC3B,IAAI,EAAE,MAAM,CAAC;CACd;AAsCD,wBAAgB,iCAAiC,CAC/C,aAAa,EAAE,oBAAoB,EACnC,YAAY,EAAE,YAAY,UA0B3B;AAoCD,wBAAgB,UAAU,CACxB,UAAU,EAAE,MAAM,EAAE,EACpB,WAAW,EAAE,MAAM,EAAE,EACrB,MAAM,EAAE,sBAAsB,EAC9B,OAAO,EAAE,+BAA+B,EACxC,kBAAkB,CAAC,EAAE,MAAM;;;;;;EA0F5B;AAED,wBAAgB,yBAAyB,CACvC,YAAY,EAAE,MAAM,GAAG,SAAS,EAChC,aAAa,EAAE,MAAM,EACrB,WAAW,EAAE,MAAM,EACnB,UAAU,GAAE,OAAO,GAAG,SAAmB,OAkD1C"}

package/src/utils/get-remotes-for-host.js

@@ -24,8 +24,10 @@ function extractRemoteProjectsFromConfig(config, pathToManifestFile) {
              * But users might have their own, enforce only that the key is the remote name
              */
             const parsedManifest = JSON.parse(moduleFederationManifestJson);
-            if (Object.keys(parsedManifest).every((key) => typeof key === 'string')) {
-                dynamicRemotes.push(...Object.keys(parsedManifest));
+            // Get keys once instead of calling Object.keys twice
+            const manifestKeys = Object.keys(parsedManifest);
+            if (manifestKeys.every((key) => typeof key === 'string')) {
+                dynamicRemotes.push(...manifestKeys);
             }
         }
     }
@@ -77,30 +79,38 @@ function getRemotes(devRemotes, skipRemotes, config, context, pathToManifestFile
     // With dynamic remotes, the manifest file may contain the names with `_` due to MF limitations on naming
     // The project graph might contain these names with `-` rather than `_`. Check for both.
     // This can occur after migration of existing remotes past Nx 19.8
-    let normalizedDynamicRemotes = dynamicRemotes.map((r) => {
-        if (context.projectGraph.nodes[r.replace(/_/g, '-')]) {
-            return r.replace(/_/g, '-');
-        }
-        return r;
+    const normalizedDynamicRemotes = dynamicRemotes.map((r) => {
+        // Compute replacement once instead of twice
+        const normalizedName = r.replace(/_/g, '-');
+        return context.projectGraph.nodes[normalizedName] ? normalizedName : r;
     });
     const knownDynamicRemotes = normalizedDynamicRemotes.filter((r) => !remotesToSkip.has(r) && context.projectGraph.nodes[r]);
     devkit_1.logger.info(`NX Starting module federation dev-server for ${pc.bold(context.projectName)} with ${[...knownRemotes, ...knownDynamicRemotes].length} remotes`);
+    // Normalize devRemotes to array and call findMatchingProjects once
     const devServeApps = new Set(!devRemotes
         ? []
-        : Array.isArray(devRemotes)
-            ? (0, find_matching_projects_1.findMatchingProjects)(devRemotes, context.projectGraph.nodes)
-            : (0, find_matching_projects_1.findMatchingProjects)([devRemotes], context.projectGraph.nodes));
+        : (0, find_matching_projects_1.findMatchingProjects)(Array.isArray(devRemotes) ? devRemotes : [devRemotes], context.projectGraph.nodes));
     const staticRemotes = knownRemotes.filter((r) => !devServeApps.has(r));
     const devServeRemotes = [...knownRemotes, ...knownDynamicRemotes].filter((r) => devServeApps.has(r));
     const staticDynamicRemotes = knownDynamicRemotes.filter((r) => !devServeApps.has(r));
-    const remotePorts = [...devServeRemotes, ...staticDynamicRemotes].map((r) => context.projectGraph.nodes[r].data.targets['serve'].options.port);
+    // Helper to get port from remote project
+    const getRemotePort = (r) => context.projectGraph.nodes[r].data.targets['serve'].options.port;
+    // Collect ports for dev-served remotes (used in return value)
+    const remotePorts = [...devServeRemotes, ...staticDynamicRemotes].map(getRemotePort);
+    // Calculate max port in a single pass instead of creating intermediate arrays
+    let maxPort = -Infinity;
+    for (const port of remotePorts) {
+        if (port > maxPort)
+            maxPort = port;
+    }
+    for (const r of staticRemotes) {
+        const port = getRemotePort(r);
+        if (port > maxPort)
+            maxPort = port;
+    }
     const staticRemotePort = staticRemotes.length === 0 && remotePorts.length === 0
         ? undefined
-        : Math.max(...[
-            ...remotePorts,
-            ...staticRemotes.map((r) => context.projectGraph.nodes[r].data.targets['serve'].options.port),
-        ]) +
-            (remotesToSkip.size + 1);
+        : maxPort + (remotesToSkip.size + 1);
     return {
         staticRemotes,
         devRemotes: devServeRemotes,

package/src/utils/typescript.js

@@ -15,14 +15,14 @@ function readTsPathMappings(tsConfigPath = process.env.NX_TSCONFIG_PATH ?? getRo
     if (!tsConfig.has(tsConfigPath)) {
         tsConfig.set(tsConfigPath, readTsConfiguration(tsConfigPath));
     }
-    tsPathMappings.set(tsConfigPath, {});
-    Object.entries(tsConfig.get(tsConfigPath).options?.paths ?? {}).forEach(([alias, paths]) => {
-        tsPathMappings.set(tsConfigPath, {
-            ...tsPathMappings.get(tsConfigPath),
-            [alias]: paths.map((path) => path.replace(/^\.\//, '')),
-        });
-    });
-    return tsPathMappings.get(tsConfigPath);
+    // Build the processed paths object in a single pass instead of
+    // spreading on each iteration, which was O(n²) for n path aliases
+    const processedPaths = {};
+    for (const [alias, aliasPaths] of Object.entries(tsConfig.get(tsConfigPath).options?.paths ?? {})) {
+        processedPaths[alias] = aliasPaths.map((path) => path.replace(/^\.\//, ''));
+    }
+    tsPathMappings.set(tsConfigPath, processedPaths);
+    return processedPaths;
 }
 function readTsConfiguration(tsConfigPath) {
     if (!(0, fs_1.existsSync)(tsConfigPath)) {