@nx/module-federation 22.0.0-beta.8 → 22.0.0-beta.9

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nx/module-federation",
   "description": "The Nx Plugin for Module Federation contains executors and utilities that support building applications using Module Federation.",
-  "version": "22.0.0-beta.8",
+  "version": "22.0.0-beta.9",
   "type": "commonjs",
   "repository": {
     "type": "git",
@@ -27,9 +27,9 @@
     "@module-federation/enhanced": "^0.18.0",
     "@module-federation/node": "^2.7.11",
     "@module-federation/sdk": "^0.18.0",
-    "@nx/devkit": "22.0.0-beta.8",
-    "@nx/js": "22.0.0-beta.8",
-    "@nx/web": "22.0.0-beta.8",
+    "@nx/devkit": "22.0.0-beta.9",
+    "@nx/js": "22.0.0-beta.9",
+    "@nx/web": "22.0.0-beta.9",
     "@rspack/core": "^1.3.8",
     "express": "^4.21.2",
     "http-proxy-middleware": "^3.0.5",
@@ -38,7 +38,7 @@
     "webpack": "^5.101.3"
   },
   "devDependencies": {
-    "nx": "22.0.0-beta.8"
+    "nx": "22.0.0-beta.9"
   },
   "nx-migrations": {
     "migrations": "./migrations.json"

package/src/plugins/nx-module-federation-plugin/angular/nx-module-federation-plugin.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"nx-module-federation-plugin.d.ts","sourceRoot":"","sources":["../../../../../../../packages/module-federation/src/plugins/nx-module-federation-plugin/angular/nx-module-federation-plugin.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,oBAAoB,EAAE,MAAM,cAAc,CAAC;AAC9D,OAAO,EACL,sBAAsB,EACtB,gCAAgC,EACjC,MAAM,uBAAuB,CAAC;AAI/B,qBAAa,wBAAyB,YAAW,oBAAoB;IAEjE,OAAO,CAAC,QAAQ;IAIhB,OAAO,CAAC,cAAc,CAAC;gBAJf,QAAQ,EAAE;QAChB,MAAM,EAAE,sBAAsB,CAAC;QAC/B,QAAQ,CAAC,EAAE,OAAO,CAAC;KACpB,EACO,cAAc,CAAC,EAAE,gCAAgC;IAG3D,KAAK,CAAC,QAAQ,EAAE,QAAQ;CA0EzB"}
+{"version":3,"file":"nx-module-federation-plugin.d.ts","sourceRoot":"","sources":["../../../../../../../packages/module-federation/src/plugins/nx-module-federation-plugin/angular/nx-module-federation-plugin.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,oBAAoB,EAAE,MAAM,cAAc,CAAC;AAC9D,OAAO,EACL,sBAAsB,EACtB,gCAAgC,EACjC,MAAM,uBAAuB,CAAC;AAI/B,qBAAa,wBAAyB,YAAW,oBAAoB;IAEjE,OAAO,CAAC,QAAQ;IAIhB,OAAO,CAAC,cAAc,CAAC;gBAJf,QAAQ,EAAE;QAChB,MAAM,EAAE,sBAAsB,CAAC;QAC/B,QAAQ,CAAC,EAAE,OAAO,CAAC;KACpB,EACO,cAAc,CAAC,EAAE,gCAAgC;IAG3D,KAAK,CAAC,QAAQ,EAAE,QAAQ;CA4EzB"}

package/src/plugins/nx-module-federation-plugin/angular/nx-module-federation-plugin.js

@@ -14,7 +14,10 @@ class NxModuleFederationPlugin {
         }
         // This is required to ensure Module Federation will build the project correctly
         compiler.options.optimization ??= {};
-        compiler.options.optimization.runtimeChunk = false;
+        compiler.options.optimization.runtimeChunk =
+            process.env['WEBPACK_SERVE'] && !this._options.config.exposes
+                ? compiler.options.optimization?.runtimeChunk ?? undefined
+                : false;
         if (compiler.options.optimization.splitChunks) {
             compiler.options.optimization.splitChunks.cacheGroups ??= {};
             compiler.options.optimization.splitChunks.cacheGroups.default = false;
@@ -24,10 +27,6 @@ class NxModuleFederationPlugin {
             ? 'auto'
             : compiler.options.output.publicPath;
         compiler.options.output.uniqueName = this._options.config.name;
-        if (compiler.options.output.scriptType === 'module') {
-            compiler.options.output.scriptType = undefined;
-            compiler.options.output.module = undefined;
-        }
         if (this._options.isServer) {
             compiler.options.target = 'async-node';
             compiler.options.output.library ??= {
@@ -63,7 +62,7 @@ class NxModuleFederationPlugin {
                     },
                     remoteType: 'script',
                 }
-                : {}),
+                : { library: { type: 'module' } }),
             ...(this.configOverride ? this.configOverride : {}),
             runtimePlugins,
         }).apply(compiler);

package/src/utils/dependencies.js

@@ -24,12 +24,14 @@ function collectDependencies(projectGraph, name, dependencies = {
             dependencies.npmPackages.add(dependency.target.replace('npm:', ''));
         }
         else {
-            dependencies.workspaceLibraries.set(dependency.target, {
-                name: dependency.target,
-                root: projectGraph.nodes[dependency.target].data.root,
-                importKey: getLibraryImportPath(dependency.target, projectGraph),
-            });
-            collectDependencies(projectGraph, dependency.target, dependencies, seen);
+            if (projectGraph.nodes[dependency.target]) {
+                dependencies.workspaceLibraries.set(dependency.target, {
+                    name: dependency.target,
+                    root: projectGraph.nodes[dependency.target].data.root,
+                    importKey: getLibraryImportPath(dependency.target, projectGraph),
+                });
+                collectDependencies(projectGraph, dependency.target, dependencies, seen);
+            }
         }
     });
     return dependencies;

package/src/with-module-federation/angular/utils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"utils.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/with-module-federation/angular/utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAML,sBAAsB,EACtB,mBAAmB,EAGpB,MAAM,aAAa,CAAC;AASrB,wBAAgB,yBAAyB,CACvC,YAAY,EAAE,MAAM,CAAC,MAAM,EAAE,mBAAmB,CAAC,EACjD,SAAS,UAAQ,QAwBlB;AAED,eAAO,MAAM,6BAA6B,UAKzC,CAAC;AACF,eAAO,MAAM,iCAAiC,UAI7C,CAAC;AAEF,wBAAgB,+BAA+B,CAC7C,QAAQ,GAAE,OAAe,EACzB,SAAS,UAAQ,IASA,QAAQ,MAAM,YAkChC;AAED,wBAAsB,yBAAyB,CAC7C,QAAQ,EAAE,sBAAsB,EAChC,OAAO,GAAE;IACP,QAAQ,EAAE,OAAO,CAAC;IAClB,kBAAkB,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,MAAM,CAAC;CAC3B,EACvB,OAAO,GAAE,QAAQ,GAAG,SAAoB;;;;;;GA4EzC;AAED,wBAAgB,6BAA6B,CAC3C,QAAQ,EAAE,sBAAsB,EAChC,OAAO,GAAE;IACP,QAAQ,EAAE,OAAO,CAAC;IAClB,kBAAkB,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,MAAM,CAAC;CAC3B,EACvB,SAAS,UAAQ;;;;;;EAwElB"}
+{"version":3,"file":"utils.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/with-module-federation/angular/utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAML,sBAAsB,EAEtB,mBAAmB,EAGpB,MAAM,aAAa,CAAC;AASrB,wBAAgB,yBAAyB,CACvC,YAAY,EAAE,MAAM,CAAC,MAAM,EAAE,mBAAmB,CAAC,EACjD,SAAS,UAAQ,QAyBlB;AAED,eAAO,MAAM,6BAA6B,UAKzC,CAAC;AACF,eAAO,MAAM,iCAAiC,UAI7C,CAAC;AAEF,wBAAgB,+BAA+B,CAC7C,QAAQ,GAAE,OAAe,EACzB,SAAS,UAAQ,IASA,QAAQ,MAAM,YAkChC;AAED,wBAAsB,yBAAyB,CAC7C,QAAQ,EAAE,sBAAsB,EAChC,OAAO,GAAE;IACP,QAAQ,EAAE,OAAO,CAAC;IAClB,kBAAkB,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,MAAM,CAAC;CAC3B,EACvB,OAAO,GAAE,QAAQ,GAAG,SAAoB;;;;;;GA4EzC;AAED,wBAAgB,6BAA6B,CAC3C,QAAQ,EAAE,sBAAsB,EAChC,OAAO,GAAE;IACP,QAAQ,EAAE,OAAO,CAAC;IAClB,kBAAkB,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,MAAM,CAAC;CAC3B,EACvB,SAAS,UAAQ;;;;;;EA2ElB"}

package/src/with-module-federation/angular/utils.js

@@ -16,6 +16,7 @@ function applyDefaultEagerPackages(sharedConfig, useRspack = false) {
             ? [
                 '@angular/core',
                 '@angular/core/primitives/signals',
+                '@angular/core/primitives/di',
                 '@angular/core/event-dispatch',
                 '@angular/core/rxjs-interop',
                 '@angular/common',
@@ -72,7 +73,7 @@ function getFunctionDeterminateRemoteUrl(isServer = false, useRspack = false) {
         const host = serveTarget.options?.host ??
             `http${serveTarget.options.ssl ? 's' : ''}://localhost`;
         const port = serveTarget.options?.port ?? 4201;
-        return `${useRspack ? `${remote}@` : ''}${host.endsWith('/') ? host.slice(0, -1) : host}:${port}/${remoteEntry}`;
+        return `${host.endsWith('/') ? host.slice(0, -1) : host}:${port}/${remoteEntry}`;
     };
 }
 async function getModuleFederationConfig(mfConfig, options = { isServer: false }, bundler = 'rspack') {
@@ -126,8 +127,9 @@ function getModuleFederationConfigSync(mfConfig, options = { isServer: false },
         dependencies.workspaceLibraries = dependencies.workspaceLibraries.filter((lib) => mfConfig.shared(lib.importKey, {}) !== false);
         dependencies.npmPackages = dependencies.npmPackages.filter((pkg) => mfConfig.shared(pkg, {}) !== false);
     }
-    const sharedLibraries = (0, utils_1.shareWorkspaceLibraries)(dependencies.workspaceLibraries);
+    const sharedLibraries = (0, utils_1.shareWorkspaceLibraries)(dependencies.workspaceLibraries, undefined, 'rspack');
     const npmPackages = (0, utils_1.sharePackages)(Array.from(new Set([
+        ...exports.DEFAULT_ANGULAR_PACKAGES_TO_SHARE,
         ...dependencies.npmPackages.filter((pkg) => !exports.DEFAULT_NPM_PACKAGES_TO_AVOID.includes(pkg)),
     ])));
     exports.DEFAULT_NPM_PACKAGES_TO_AVOID.forEach((pkgName) => {