@nx/module-federation 21.2.1 → 21.2.3

package/migrations.json

@@ -23,21 +23,40 @@
     },
     "20.5.0": {
       "version": "20.5.0-beta.5",
-      "@module-federation/enhanced": {
-        "version": "^0.9.0",
-        "alwaysAddToPackageJson": false
-      },
-      "@module-federation/runtime": {
-        "version": "^0.9.0",
-        "alwaysAddToPackageJson": false
-      },
-      "@module-federation/sdk": {
-        "version": "^0.9.0",
-        "alwaysAddToPackageJson": false
-      },
-      "@module-federation/node": {
-        "version": "^2.6.26",
-        "alwaysAddToPackageJson": false
+      "packages": {
+        "@module-federation/enhanced": {
+          "version": "^0.9.0",
+          "alwaysAddToPackageJson": false
+        },
+        "@module-federation/runtime": {
+          "version": "^0.9.0",
+          "alwaysAddToPackageJson": false
+        },
+        "@module-federation/sdk": {
+          "version": "^0.9.0",
+          "alwaysAddToPackageJson": false
+        },
+        "@module-federation/node": {
+          "version": "^2.6.26",
+          "alwaysAddToPackageJson": false
+        }
+      }
+    },
+    "21.2.0": {
+      "version": "21.2.0-beta.6",
+      "packages": {
+        "@module-federation/enhanced": {
+          "version": "^0.15.0",
+          "alwaysAddToPackageJson": false
+        },
+        "@module-federation/runtime": {
+          "version": "^0.15.0",
+          "alwaysAddToPackageJson": false
+        },
+        "@module-federation/sdk": {
+          "version": "^0.15.0",
+          "alwaysAddToPackageJson": false
+        }
       }
     }
   }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nx/module-federation",
   "description": "The Nx Plugin for Module Federation contains executors and utilities that support building applications using Module Federation.",
-  "version": "21.2.1",
+  "version": "21.2.3",
   "type": "commonjs",
   "repository": {
     "type": "git",
@@ -25,15 +25,15 @@
   "executors": "./executors.json",
   "dependencies": {
     "tslib": "^2.3.0",
-    "@nx/devkit": "21.2.1",
-    "@nx/js": "21.2.1",
-    "@nx/web": "21.2.1",
+    "@nx/devkit": "21.2.3",
+    "@nx/js": "21.2.3",
+    "@nx/web": "21.2.3",
     "picocolors": "^1.1.0",
     "webpack": "^5.88.0",
     "@rspack/core": "^1.3.8",
-    "@module-federation/enhanced": "^0.9.0",
+    "@module-federation/enhanced": "^0.15.0",
     "@module-federation/node": "^2.6.26",
-    "@module-federation/sdk": "^0.9.0",
+    "@module-federation/sdk": "^0.15.0",
     "express": "^4.21.2",
     "http-proxy-middleware": "^3.0.3"
   },

package/src/executors/utils/build-static-remotes.js

@@ -27,6 +27,11 @@ async function buildStaticRemotes(staticRemotesConfig, nxBin, context, options,
         ], {
             cwd: context.root,
             stdio: ['ignore', 'pipe', 'pipe', 'ipc'],
+            env: {
+                ...process.env,
+                // Ensure that webpack serve env var is not passed to static remotes
+                WEBPACK_SERVE: 'false',
+            },
         });
         // File to debug build failures e.g. 2024-01-01T00_00_0_0Z-build.log'
         const remoteBuildLogFile = (0, path_1.join)(cache_directory_1.workspaceDataDirectory, `${new Date().toISOString().replace(/[:\.]/g, '_')}-build.log`);

package/src/plugins/nx-module-federation-plugin/angular/nx-module-federation-dev-server-plugin.js

@@ -48,7 +48,9 @@ class NxModuleFederationDevServerPlugin {
                 (0, utils_1.getDynamicMfManifestFile)(project, devkit_1.workspaceRoot);
         }
         else {
-            const userPathToManifestFile = (0, path_1.join)(devkit_1.workspaceRoot, this._options.devServerConfig.pathToManifestFile);
+            const userPathToManifestFile = this._options.devServerConfig.pathToManifestFile.startsWith(devkit_1.workspaceRoot)
+                ? this._options.devServerConfig.pathToManifestFile
+                : (0, path_1.join)(devkit_1.workspaceRoot, this._options.devServerConfig.pathToManifestFile);
             if (!(0, fs_1.existsSync)(userPathToManifestFile)) {
                 throw new Error(`The provided Module Federation manifest file path does not exist. Please check the file exists at "${userPathToManifestFile}".`);
             }

package/src/plugins/nx-module-federation-plugin/rspack/nx-module-federation-dev-server-plugin.js

@@ -48,7 +48,9 @@ class NxModuleFederationDevServerPlugin {
                 (0, utils_1.getDynamicMfManifestFile)(project, devkit_1.workspaceRoot);
         }
         else {
-            const userPathToManifestFile = (0, path_1.join)(devkit_1.workspaceRoot, this._options.devServerConfig.pathToManifestFile);
+            const userPathToManifestFile = this._options.devServerConfig.pathToManifestFile.startsWith(devkit_1.workspaceRoot)
+                ? this._options.devServerConfig.pathToManifestFile
+                : (0, path_1.join)(devkit_1.workspaceRoot, this._options.devServerConfig.pathToManifestFile);
             if (!(0, fs_1.existsSync)(userPathToManifestFile)) {
                 throw new Error(`The provided Module Federation manifest file path does not exist. Please check the file exists at "${userPathToManifestFile}".`);
             }

package/src/plugins/utils/build-static-remotes.js

@@ -25,6 +25,10 @@ async function buildStaticRemotes(staticRemotesConfig, options, nxBin) {
         ], {
             cwd: devkit_1.workspaceRoot,
             stdio: ['ignore', 'pipe', 'pipe', 'ipc'],
+            env: {
+                ...process.env,
+                WEBPACK_SERVE: 'false',
+            },
         });
         // File to debug build failures e.g. 2024-01-01T00_00_0_0Z-build.log'
         const remoteBuildLogFile = (0, path_1.join)(cache_directory_1.workspaceDataDirectory, 

package/src/plugins/utils/get-dynamic-manifest-file.js

@@ -1,8 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getDynamicMfManifestFile = getDynamicMfManifestFile;
-const path_1 = require("path");
+const ts_solution_setup_1 = require("@nx/js/src/utils/typescript/ts-solution-setup");
 const fs_1 = require("fs");
+const path_1 = require("path");
 function getDynamicMfManifestFile(project, workspaceRoot) {
     // {sourceRoot}/assets/module-federation.manifest.json was the generated
     // path for the manifest file in the past. We now generate the manifest
@@ -12,6 +13,6 @@ function getDynamicMfManifestFile(project, workspaceRoot) {
     // at the old path.
     return [
         (0, path_1.join)(workspaceRoot, project.root, 'public/module-federation.manifest.json'),
-        (0, path_1.join)(workspaceRoot, project.sourceRoot, 'assets/module-federation.manifest.json'),
+        (0, path_1.join)(workspaceRoot, (0, ts_solution_setup_1.getProjectSourceRoot)(project), 'assets/module-federation.manifest.json'),
     ].find((path) => (0, fs_1.existsSync)(path));
 }

package/src/utils/dependencies.js

@@ -1,8 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getDependentPackagesForProject = getDependentPackagesForProject;
-const typescript_1 = require("./typescript");
 const devkit_1 = require("@nx/devkit");
+const ts_solution_setup_1 = require("@nx/js/src/utils/typescript/ts-solution-setup");
+const typescript_1 = require("./typescript");
 function getDependentPackagesForProject(projectGraph, name) {
     const { npmPackages, workspaceLibraries } = collectDependencies(projectGraph, name);
     return {
@@ -39,7 +40,7 @@ function getLibraryImportPath(library, projectGraph) {
         buildLibsFromSource = process.env.NX_BUILD_LIBS_FROM_SOURCE === 'true';
     }
     const libraryNode = projectGraph.nodes[library];
-    let sourceRoots = [libraryNode.data.sourceRoot];
+    let sourceRoots = [(0, ts_solution_setup_1.getProjectSourceRoot)(libraryNode.data)];
     if (!buildLibsFromSource && process.env.NX_BUILD_TARGET) {
         const buildTarget = (0, devkit_1.parseTargetString)(process.env.NX_BUILD_TARGET, projectGraph);
         sourceRoots = (0, devkit_1.getOutputsForTargetAndConfiguration)(buildTarget, {}, libraryNode);

package/src/utils/remotes.js

@@ -2,7 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.mapRemotes = mapRemotes;
 exports.mapRemotesForSSR = mapRemotesForSSR;
-const path_1 = require("path");
+const url_helpers_1 = require("./url-helpers");
 /**
  * Map remote names to a format that can be understood and used by Module
  * Federation.
@@ -29,19 +29,11 @@ function mapRemotes(remotes, remoteEntryExt, determineRemoteUrl, isRemoteGlobal
 function handleArrayRemote(remote, remoteEntryExt, isRemoteGlobal) {
     const [nxRemoteProjectName, remoteLocation] = remote;
     const mfRemoteName = normalizeRemoteName(nxRemoteProjectName);
-    // Remote string starts like "promise new Promise(...)" – return as-is
+    const finalRemoteUrl = (0, url_helpers_1.processRemoteLocation)(remoteLocation, remoteEntryExt);
+    // Promise-based remotes should not use the global prefix format
     if (remoteLocation.startsWith('promise new Promise')) {
-        return remoteLocation;
+        return finalRemoteUrl;
     }
-    const resolvedUrl = new URL(remoteLocation);
-    const ext = (0, path_1.extname)(resolvedUrl.pathname);
-    const needsRemoteEntry = !['.js', '.mjs', '.json'].includes(ext);
-    if (needsRemoteEntry) {
-        resolvedUrl.pathname = resolvedUrl.pathname.endsWith('/')
-            ? `${resolvedUrl.pathname}remoteEntry.${remoteEntryExt}`
-            : `${resolvedUrl.pathname}/remoteEntry.${remoteEntryExt}`;
-    }
-    const finalRemoteUrl = resolvedUrl.href;
     return isRemoteGlobal ? `${mfRemoteName}@${finalRemoteUrl}` : finalRemoteUrl;
 }
 // Helper function to deal with remotes that are strings
@@ -65,16 +57,14 @@ function mapRemotesForSSR(remotes, remoteEntryExt, determineRemoteUrl) {
         if (Array.isArray(remote)) {
             let [nxRemoteProjectName, remoteLocation] = remote;
             const mfRemoteName = normalizeRemoteName(nxRemoteProjectName);
-            const resolvedUrl = new URL(remoteLocation);
-            const remoteLocationExt = (0, path_1.extname)(resolvedUrl.pathname);
-            const needsRemoteEntry = !['.js', '.mjs', '.json'].includes(remoteLocationExt);
-            if (needsRemoteEntry) {
-                resolvedUrl.pathname = resolvedUrl.pathname.endsWith('/')
-                    ? `${resolvedUrl.pathname}remoteEntry.${remoteEntryExt}`
-                    : `${resolvedUrl.pathname}/remoteEntry.${remoteEntryExt}`;
+            const finalRemoteUrl = (0, url_helpers_1.processRemoteLocation)(remoteLocation, remoteEntryExt);
+            // Promise-based remotes should not use the global prefix format
+            if (remoteLocation.startsWith('promise new Promise')) {
+                mappedRemotes[mfRemoteName] = finalRemoteUrl;
+            }
+            else {
+                mappedRemotes[mfRemoteName] = `${mfRemoteName}@${finalRemoteUrl}`;
             }
-            const finalRemoteUrl = resolvedUrl.href;
-            mappedRemotes[mfRemoteName] = `${mfRemoteName}@${finalRemoteUrl}`;
         }
         else if (typeof remote === 'string') {
             const mfRemoteName = normalizeRemoteName(remote);

package/src/utils/url-helpers.d.ts

@@ -0,0 +1,13 @@
+/**
+ * Checks if a URL string is absolute (has protocol)
+ */
+export declare function isAbsoluteUrl(url: string): boolean;
+/**
+ * Safely processes remote locations, handling both relative and absolute URLs
+ * while preserving query parameters and hash fragments for absolute URLs
+ */
+export declare function processRemoteLocation(remoteLocation: string, remoteEntryExt: 'js' | 'mjs'): string;
+/**
+ * Processes remote URLs for runtime environments, resolving relative URLs against window.location.origin
+ */
+export declare function processRuntimeRemoteUrl(remoteUrl: string, remoteEntryExt: 'js' | 'mjs'): string;

package/src/utils/url-helpers.js

@@ -0,0 +1,70 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.isAbsoluteUrl = isAbsoluteUrl;
+exports.processRemoteLocation = processRemoteLocation;
+exports.processRuntimeRemoteUrl = processRuntimeRemoteUrl;
+const path_1 = require("path");
+/**
+ * Checks if a URL string is absolute (has protocol)
+ */
+function isAbsoluteUrl(url) {
+    try {
+        new URL(url);
+        return true;
+    }
+    catch {
+        return false;
+    }
+}
+/**
+ * Safely processes remote locations, handling both relative and absolute URLs
+ * while preserving query parameters and hash fragments for absolute URLs
+ */
+function processRemoteLocation(remoteLocation, remoteEntryExt) {
+    // Handle promise-based remotes as-is
+    if (remoteLocation.startsWith('promise new Promise')) {
+        return remoteLocation;
+    }
+    if (isAbsoluteUrl(remoteLocation)) {
+        // Use new URL parsing for absolute URLs (supports query params/hash)
+        const url = new URL(remoteLocation);
+        const ext = (0, path_1.extname)(url.pathname);
+        const needsRemoteEntry = !['.js', '.mjs', '.json'].includes(ext);
+        if (needsRemoteEntry) {
+            url.pathname = url.pathname.endsWith('/')
+                ? `${url.pathname}remoteEntry.${remoteEntryExt}`
+                : `${url.pathname}/remoteEntry.${remoteEntryExt}`;
+        }
+        return url.href;
+    }
+    else {
+        // Use string manipulation for relative URLs (backward compatibility)
+        const ext = (0, path_1.extname)(remoteLocation);
+        const needsRemoteEntry = !['.js', '.mjs', '.json'].includes(ext);
+        if (needsRemoteEntry) {
+            const baseRemote = remoteLocation.endsWith('/')
+                ? remoteLocation.slice(0, -1)
+                : remoteLocation;
+            return `${baseRemote}/remoteEntry.${remoteEntryExt}`;
+        }
+        return remoteLocation;
+    }
+}
+/**
+ * Processes remote URLs for runtime environments, resolving relative URLs against window.location.origin
+ */
+function processRuntimeRemoteUrl(remoteUrl, remoteEntryExt) {
+    if (isAbsoluteUrl(remoteUrl)) {
+        return processRemoteLocation(remoteUrl, remoteEntryExt);
+    }
+    else {
+        // For runtime relative URLs, resolve against current origin
+        const baseUrl = typeof globalThis !== 'undefined' &&
+            typeof globalThis.window !== 'undefined' &&
+            globalThis.window.location
+            ? globalThis.window.location.origin
+            : 'http://localhost';
+        const absoluteUrl = new URL(remoteUrl, baseUrl).href;
+        return processRemoteLocation(absoluteUrl, remoteEntryExt);
+    }
+}

package/src/with-module-federation/angular/with-module-federation.js

@@ -19,7 +19,7 @@ async function withModuleFederation(options, configOverride) {
             },
             optimization: {
                 ...(config.optimization ?? {}),
-                runtimeChunk: isDevServer
+                runtimeChunk: isDevServer && !options.exposes
                     ? config.optimization?.runtimeChunk ?? undefined
                     : false,
             },

package/src/with-module-federation/rspack/with-module-federation.js

@@ -26,7 +26,7 @@ async function withModuleFederation(options, configOverride) {
         }
         config.optimization = {
             ...(config.optimization ?? {}),
-            runtimeChunk: isDevServer
+            runtimeChunk: isDevServer && !options.exposes
                 ? config.optimization?.runtimeChunk ?? undefined
                 : false,
         };

package/src/with-module-federation/webpack/with-module-federation.js

@@ -18,7 +18,7 @@ async function withModuleFederation(options, configOverride) {
         config.output.scriptType = 'text/javascript';
         config.optimization = {
             ...(config.optimization ?? {}),
-            runtimeChunk: isDevServer
+            runtimeChunk: isDevServer && !options.exposes
                 ? config.optimization?.runtimeChunk ?? undefined
                 : false,
         };

package/url-helpers.d.ts

@@ -0,0 +1,13 @@
+/**
+ * Checks if a URL string is absolute (has protocol)
+ */
+export declare function isAbsoluteUrl(url: string): boolean;
+/**
+ * Safely processes remote locations, handling both relative and absolute URLs
+ * while preserving query parameters and hash fragments for absolute URLs
+ */
+export declare function processRemoteLocation(remoteLocation: string, remoteEntryExt: 'js' | 'mjs'): string;
+/**
+ * Processes remote URLs for runtime environments, resolving relative URLs against window.location.origin
+ */
+export declare function processRuntimeRemoteUrl(remoteUrl: string, remoteEntryExt: 'js' | 'mjs'): string;

package/url-helpers.js

@@ -0,0 +1,78 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.isAbsoluteUrl = isAbsoluteUrl;
+exports.processRemoteLocation = processRemoteLocation;
+exports.processRuntimeRemoteUrl = processRuntimeRemoteUrl;
+// Browser-safe helper function to extract file extension from a path
+function extname(path) {
+    const lastDot = path.lastIndexOf('.');
+    const lastSlash = Math.max(path.lastIndexOf('/'), path.lastIndexOf('\\'));
+    if (lastDot === -1 || lastDot < lastSlash) {
+        return '';
+    }
+    return path.slice(lastDot);
+}
+/**
+ * Checks if a URL string is absolute (has protocol)
+ */
+function isAbsoluteUrl(url) {
+    try {
+        new URL(url);
+        return true;
+    }
+    catch {
+        return false;
+    }
+}
+/**
+ * Safely processes remote locations, handling both relative and absolute URLs
+ * while preserving query parameters and hash fragments for absolute URLs
+ */
+function processRemoteLocation(remoteLocation, remoteEntryExt) {
+    // Handle promise-based remotes as-is
+    if (remoteLocation.startsWith('promise new Promise')) {
+        return remoteLocation;
+    }
+    if (isAbsoluteUrl(remoteLocation)) {
+        // Use new URL parsing for absolute URLs (supports query params/hash)
+        const url = new URL(remoteLocation);
+        const ext = extname(url.pathname);
+        const needsRemoteEntry = !['.js', '.mjs', '.json'].includes(ext);
+        if (needsRemoteEntry) {
+            url.pathname = url.pathname.endsWith('/')
+                ? `${url.pathname}remoteEntry.${remoteEntryExt}`
+                : `${url.pathname}/remoteEntry.${remoteEntryExt}`;
+        }
+        return url.href;
+    }
+    else {
+        // Use string manipulation for relative URLs (backward compatibility)
+        const ext = extname(remoteLocation);
+        const needsRemoteEntry = !['.js', '.mjs', '.json'].includes(ext);
+        if (needsRemoteEntry) {
+            const baseRemote = remoteLocation.endsWith('/')
+                ? remoteLocation.slice(0, -1)
+                : remoteLocation;
+            return `${baseRemote}/remoteEntry.${remoteEntryExt}`;
+        }
+        return remoteLocation;
+    }
+}
+/**
+ * Processes remote URLs for runtime environments, resolving relative URLs against window.location.origin
+ */
+function processRuntimeRemoteUrl(remoteUrl, remoteEntryExt) {
+    if (isAbsoluteUrl(remoteUrl)) {
+        return processRemoteLocation(remoteUrl, remoteEntryExt);
+    }
+    else {
+        // For runtime relative URLs, resolve against current origin
+        const baseUrl = typeof globalThis !== 'undefined' &&
+            typeof globalThis.window !== 'undefined' &&
+            globalThis.window.location
+            ? globalThis.window.location.origin
+            : 'http://localhost';
+        const absoluteUrl = new URL(remoteUrl, baseUrl).href;
+        return processRemoteLocation(absoluteUrl, remoteEntryExt);
+    }
+}