@nx/module-federation 21.1.2 → 21.1.3

package/README.md

@@ -1,7 +1,7 @@
 <p style="text-align: center;">
   <picture>
     <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-dark.svg">
-    <img alt="Nx - Smart Monorepos · Fast CI" src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-light.svg" width="100%">
+    <img alt="Nx - Smart Repos · Fast Builds" src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-light.svg" width="100%">
   </picture>
 </p>
 
@@ -20,9 +20,9 @@
 
 <hr>
 
-# Nx: Smart Monorepos · Fast CI
+# Nx: Smart Repos · Fast Builds
 
-Nx is a build system, optimized for monorepos, with plugins for popular frameworks and tools and advanced CI capabilities including caching and distribution.
+An AI-first build platform that connects everything from your editor to CI. Helping you deliver fast, without breaking things.
 
 This package is a [Module Federation plugin for Nx](https://nx.dev/nx-api/module-federation).
 Module Federation allows developers to share code between deployed applications easier and makes team collaboration more efficient.  
@@ -66,5 +66,5 @@ npx nx@latest init
 - [Blog Posts About Nx](https://nx.dev/blog)
 
 <p style="text-align: center;"><a href="https://nx.dev/#learning-materials" target="_blank" rel="noreferrer"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-courses-and-videos.svg" 
-width="100%" alt="Nx - Smart Monorepos · Fast CI"></a></p>
+width="100%" alt="Nx - Smart Repos · Fast Builds"></a></p>
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nx/module-federation",
   "description": "The Nx Plugin for Module Federation contains executors and utilities that support building applications using Module Federation.",
-  "version": "21.1.2",
+  "version": "21.1.3",
   "type": "commonjs",
   "repository": {
     "type": "git",
@@ -25,9 +25,9 @@
   "executors": "./executors.json",
   "dependencies": {
     "tslib": "^2.3.0",
-    "@nx/devkit": "21.1.2",
-    "@nx/js": "21.1.2",
-    "@nx/web": "21.1.2",
+    "@nx/devkit": "21.1.3",
+    "@nx/js": "21.1.3",
+    "@nx/web": "21.1.3",
     "picocolors": "^1.1.0",
     "webpack": "^5.88.0",
     "@rspack/core": "^1.3.8",

package/src/utils/remotes.js

@@ -27,30 +27,22 @@ function mapRemotes(remotes, remoteEntryExt, determineRemoteUrl, isRemoteGlobal
 }
 // Helper function to deal with remotes that are arrays
 function handleArrayRemote(remote, remoteEntryExt, isRemoteGlobal) {
-    let [nxRemoteProjectName, remoteLocation] = remote;
+    const [nxRemoteProjectName, remoteLocation] = remote;
     const mfRemoteName = normalizeRemoteName(nxRemoteProjectName);
-    const remoteLocationExt = (0, path_1.extname)(remoteLocation);
-    // If remote location already has .js or .mjs extension
-    if (['.js', '.mjs', '.json'].includes(remoteLocationExt)) {
-        if (isRemoteGlobal && !remoteLocation.startsWith(`${mfRemoteName}@`)) {
-            return `${mfRemoteName}@${remoteLocation}`;
-        }
+    // Remote string starts like "promise new Promise(...)" – return as-is
+    if (remoteLocation.startsWith('promise new Promise')) {
         return remoteLocation;
     }
-    const baseRemote = remoteLocation.endsWith('/')
-        ? remoteLocation.slice(0, -1)
-        : remoteLocation;
-    const globalPrefix = isRemoteGlobal
-        ? `${normalizeRemoteName(nxRemoteProjectName)}@`
-        : '';
-    // if the remote is defined with anything other than http then we assume it's a promise based remote
-    // In that case we should use what the user provides as the remote location
-    if (!remoteLocation.startsWith('promise new Promise')) {
-        return `${globalPrefix}${baseRemote}/remoteEntry.${remoteEntryExt}`;
-    }
-    else {
-        return remoteLocation;
+    const resolvedUrl = new URL(remoteLocation);
+    const ext = (0, path_1.extname)(resolvedUrl.pathname);
+    const needsRemoteEntry = !['.js', '.mjs', '.json'].includes(ext);
+    if (needsRemoteEntry) {
+        resolvedUrl.pathname = resolvedUrl.pathname.endsWith('/')
+            ? `${resolvedUrl.pathname}remoteEntry.${remoteEntryExt}`
+            : `${resolvedUrl.pathname}/remoteEntry.${remoteEntryExt}`;
     }
+    const finalRemoteUrl = resolvedUrl.href;
+    return isRemoteGlobal ? `${mfRemoteName}@${finalRemoteUrl}` : finalRemoteUrl;
 }
 // Helper function to deal with remotes that are strings
 function handleStringRemote(nxRemoteProjectName, determineRemoteUrl, isRemoteGlobal) {
@@ -73,12 +65,16 @@ function mapRemotesForSSR(remotes, remoteEntryExt, determineRemoteUrl) {
         if (Array.isArray(remote)) {
             let [nxRemoteProjectName, remoteLocation] = remote;
             const mfRemoteName = normalizeRemoteName(nxRemoteProjectName);
-            const remoteLocationExt = (0, path_1.extname)(remoteLocation);
-            mappedRemotes[mfRemoteName] = `${mfRemoteName}@${['.js', '.mjs', '.json'].includes(remoteLocationExt)
-                ? remoteLocation
-                : `${remoteLocation.endsWith('/')
-                    ? remoteLocation.slice(0, -1)
-                    : remoteLocation}/remoteEntry.${remoteEntryExt}`}`;
+            const resolvedUrl = new URL(remoteLocation);
+            const remoteLocationExt = (0, path_1.extname)(resolvedUrl.pathname);
+            const needsRemoteEntry = !['.js', '.mjs', '.json'].includes(remoteLocationExt);
+            if (needsRemoteEntry) {
+                resolvedUrl.pathname = resolvedUrl.pathname.endsWith('/')
+                    ? `${resolvedUrl.pathname}remoteEntry.${remoteEntryExt}`
+                    : `${resolvedUrl.pathname}/remoteEntry.${remoteEntryExt}`;
+            }
+            const finalRemoteUrl = resolvedUrl.href;
+            mappedRemotes[mfRemoteName] = `${mfRemoteName}@${finalRemoteUrl}`;
         }
         else if (typeof remote === 'string') {
             const mfRemoteName = normalizeRemoteName(remote);