@nx/module-federation 0.0.0-pr-32490-e4fdfa9 → 0.0.0-pr-32868-a65a4a2

package/README.md

@@ -22,7 +22,7 @@
 
 # Nx: Smart Repos · Fast Builds
 
-An AI-first build platform that connects everything from your editor to CI. Helping you deliver fast, without breaking things.
+Get to green PRs in half the time. Nx optimizes your builds, scales your CI, and fixes failed PRs. Built for developers and AI agents.
 
 This package is a [Module Federation plugin for Nx](https://nx.dev/nx-api/module-federation).
 Module Federation allows developers to share code between deployed applications easier and makes team collaboration more efficient.  

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nx/module-federation",
   "description": "The Nx Plugin for Module Federation contains executors and utilities that support building applications using Module Federation.",
-  "version": "0.0.0-pr-32490-e4fdfa9",
+  "version": "0.0.0-pr-32868-a65a4a2",
   "type": "commonjs",
   "repository": {
     "type": "git",
@@ -24,21 +24,21 @@
   "main": "index.js",
   "executors": "./executors.json",
   "dependencies": {
-    "tslib": "^2.3.0",
-    "@nx/devkit": "0.0.0-pr-32490-e4fdfa9",
-    "@nx/js": "0.0.0-pr-32490-e4fdfa9",
-    "@nx/web": "0.0.0-pr-32490-e4fdfa9",
-    "picocolors": "^1.1.0",
-    "webpack": "^5.101.3",
-    "@rspack/core": "^1.3.8",
     "@module-federation/enhanced": "^0.18.0",
     "@module-federation/node": "^2.7.11",
     "@module-federation/sdk": "^0.18.0",
+    "@nx/devkit": "0.0.0-pr-32868-a65a4a2",
+    "@nx/js": "0.0.0-pr-32868-a65a4a2",
+    "@nx/web": "0.0.0-pr-32868-a65a4a2",
+    "@rspack/core": "^1.3.8",
     "express": "^4.21.2",
-    "http-proxy-middleware": "^3.0.5"
+    "http-proxy-middleware": "^3.0.5",
+    "picocolors": "^1.1.0",
+    "tslib": "^2.3.0",
+    "webpack": "^5.101.3"
   },
   "devDependencies": {
-    "nx": "0.0.0-pr-32490-e4fdfa9"
+    "nx": "0.0.0-pr-32868-a65a4a2"
   },
   "nx-migrations": {
     "migrations": "./migrations.json"

package/src/plugins/utils/get-remotes.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"get-remotes.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/plugins/utils/get-remotes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAU,YAAY,EAAiB,MAAM,YAAY,CAAC;AACjE,OAAO,EAA6B,sBAAsB,EAAE,MAAM,aAAa,CAAC;AAIhF,wBAAgB,UAAU,CACxB,MAAM,EAAE,sBAAsB,EAC9B,YAAY,EAAE,YAAY,EAC1B,kBAAkB,CAAC,EAAE,MAAM;;;;EAkC5B"}
+{"version":3,"file":"get-remotes.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/plugins/utils/get-remotes.ts"],"names":[],"mappings":"AAAA,OAAO,EAAU,YAAY,EAAiB,MAAM,YAAY,CAAC;AACjE,OAAO,EAA6B,sBAAsB,EAAE,MAAM,aAAa,CAAC;AAIhF,wBAAgB,UAAU,CACxB,MAAM,EAAE,sBAAsB,EAC9B,YAAY,EAAE,YAAY,EAC1B,kBAAkB,CAAC,EAAE,MAAM;;;;EAoC5B"}

package/src/plugins/utils/get-remotes.js

@@ -19,6 +19,7 @@ function getRemotes(config, projectGraph, pathToManifestFile) {
         return r;
     });
     const knownDynamicRemotes = normalizedDynamicRemotes.filter((r) => projectGraph.nodes[r]);
+    knownDynamicRemotes.forEach((r) => collectRemoteProjects(r, collectedRemotes, projectGraph));
     const remotePorts = [...collectedRemotes, ...knownDynamicRemotes].map((r) => projectGraph.nodes[r].data.targets['serve'].options.port);
     const staticRemotePort = Math.max(...[...remotePorts]) + 1;
     return {
@@ -33,12 +34,16 @@ function extractRemoteProjectsFromConfig(config, pathToManifestFile) {
     if (pathToManifestFile && (0, fs_1.existsSync)(pathToManifestFile)) {
         const moduleFederationManifestJson = (0, fs_1.readFileSync)(pathToManifestFile, 'utf-8');
         if (moduleFederationManifestJson) {
-            // This should have shape of
-            // {
-            //   "remoteName": "remoteLocation",
-            // }
+            /**
+             *
+             * This should have shape of
+             * {
+             *   "remoteName": "remoteLocation",
+             * }
+             * But users might have their own, enforce only that the key is the remote name
+             */
             const parsedManifest = JSON.parse(moduleFederationManifestJson);
-            if (Object.keys(parsedManifest).every((key) => typeof key === 'string' && typeof parsedManifest[key] === 'string')) {
+            if (Object.keys(parsedManifest).every((key) => typeof key === 'string')) {
                 dynamicRemotes.push(...Object.keys(parsedManifest));
             }
         }

package/src/utils/get-remotes-for-host.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"get-remotes-for-host.d.ts","sourceRoot":"","sources":["../../../../../packages/module-federation/src/utils/get-remotes-for-host.ts"],"names":[],"mappings":"AAAA,OAAO,EAGL,KAAK,oBAAoB,EACzB,KAAK,YAAY,EAElB,MAAM,YAAY,CAAC;AAMpB,OAAO,EAAE,sBAAsB,EAAE,MAAM,UAAU,CAAC;AAElD,UAAU,+BAA+B;IACvC,WAAW,EAAE,MAAM,CAAC;IACpB,YAAY,EAAE,YAAY,CAAC;IAC3B,IAAI,EAAE,MAAM,CAAC;CACd;AAqCD,wBAAgB,iCAAiC,CAC/C,aAAa,EAAE,oBAAoB,EACnC,YAAY,EAAE,YAAY,UA0B3B;AAoCD,wBAAgB,UAAU,CACxB,UAAU,EAAE,MAAM,EAAE,EACpB,WAAW,EAAE,MAAM,EAAE,EACrB,MAAM,EAAE,sBAAsB,EAC9B,OAAO,EAAE,+BAA+B,EACxC,kBAAkB,CAAC,EAAE,MAAM;;;;;;EAkF5B;AAED,wBAAgB,yBAAyB,CACvC,YAAY,EAAE,MAAM,GAAG,SAAS,EAChC,aAAa,EAAE,MAAM,EACrB,WAAW,EAAE,MAAM,EACnB,UAAU,GAAE,OAAO,GAAG,SAAmB,OAkD1C"}
+{"version":3,"file":"get-remotes-for-host.d.ts","sourceRoot":"","sources":["../../../../../packages/module-federation/src/utils/get-remotes-for-host.ts"],"names":[],"mappings":"AAAA,OAAO,EAGL,KAAK,oBAAoB,EACzB,KAAK,YAAY,EAElB,MAAM,YAAY,CAAC;AAMpB,OAAO,EAAE,sBAAsB,EAAE,MAAM,UAAU,CAAC;AAElD,UAAU,+BAA+B;IACvC,WAAW,EAAE,MAAM,CAAC;IACpB,YAAY,EAAE,YAAY,CAAC;IAC3B,IAAI,EAAE,MAAM,CAAC;CACd;AAoCD,wBAAgB,iCAAiC,CAC/C,aAAa,EAAE,oBAAoB,EACnC,YAAY,EAAE,YAAY,UA0B3B;AAoCD,wBAAgB,UAAU,CACxB,UAAU,EAAE,MAAM,EAAE,EACpB,WAAW,EAAE,MAAM,EAAE,EACrB,MAAM,EAAE,sBAAsB,EAC9B,OAAO,EAAE,+BAA+B,EACxC,kBAAkB,CAAC,EAAE,MAAM;;;;;;EAkF5B;AAED,wBAAgB,yBAAyB,CACvC,YAAY,EAAE,MAAM,GAAG,SAAS,EAChC,aAAa,EAAE,MAAM,EACrB,WAAW,EAAE,MAAM,EACnB,UAAU,GAAE,OAAO,GAAG,SAAmB,OAkD1C"}

package/src/utils/get-remotes-for-host.js

@@ -15,12 +15,16 @@ function extractRemoteProjectsFromConfig(config, pathToManifestFile) {
     if (pathToManifestFile && (0, fs_1.existsSync)(pathToManifestFile)) {
         const moduleFederationManifestJson = (0, fs_1.readFileSync)(pathToManifestFile, 'utf-8');
         if (moduleFederationManifestJson) {
-            // This should have shape of
-            // {
-            //   "remoteName": "remoteLocation",
-            // }
+            /**
+             *
+             * This should have shape of
+             * {
+             *   "remoteName": "remoteLocation",
+             * }
+             * But users might have their own, enforce only that the key is the remote name
+             */
             const parsedManifest = JSON.parse(moduleFederationManifestJson);
-            if (Object.keys(parsedManifest).every((key) => typeof key === 'string' && typeof parsedManifest[key] === 'string')) {
+            if (Object.keys(parsedManifest).every((key) => typeof key === 'string')) {
                 dynamicRemotes.push(...Object.keys(parsedManifest));
             }
         }

package/src/with-module-federation/angular/utils.d.ts

@@ -6,7 +6,7 @@ export declare function getFunctionDeterminateRemoteUrl(isServer?: boolean, useR
 export declare function getModuleFederationConfig(mfConfig: ModuleFederationConfig, options?: {
     isServer: boolean;
     determineRemoteUrl?: (remote: string) => string;
-}): Promise<{
+}, bundler?: 'rspack' | 'webpack'): Promise<{
     sharedLibraries: import("../../utils").SharedWorkspaceLibraryConfig;
     sharedDependencies: {
         [x: string]: SharedLibraryConfig;

package/src/with-module-federation/angular/utils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"utils.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/with-module-federation/angular/utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAML,sBAAsB,EACtB,mBAAmB,EAGpB,MAAM,aAAa,CAAC;AASrB,wBAAgB,yBAAyB,CACvC,YAAY,EAAE,MAAM,CAAC,MAAM,EAAE,mBAAmB,CAAC,EACjD,SAAS,UAAQ,QAwBlB;AAED,eAAO,MAAM,6BAA6B,UAKzC,CAAC;AACF,eAAO,MAAM,iCAAiC,UAI7C,CAAC;AAEF,wBAAgB,+BAA+B,CAC7C,QAAQ,GAAE,OAAe,EACzB,SAAS,UAAQ,IASA,QAAQ,MAAM,YAkChC;AAED,wBAAsB,yBAAyB,CAC7C,QAAQ,EAAE,sBAAsB,EAChC,OAAO,GAAE;IACP,QAAQ,EAAE,OAAO,CAAC;IAClB,kBAAkB,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,MAAM,CAAC;CAC3B;;;;;;GA0ExB;AAED,wBAAgB,6BAA6B,CAC3C,QAAQ,EAAE,sBAAsB,EAChC,OAAO,GAAE;IACP,QAAQ,EAAE,OAAO,CAAC;IAClB,kBAAkB,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,MAAM,CAAC;CAC3B,EACvB,SAAS,UAAQ;;;;;;EAwElB"}
+{"version":3,"file":"utils.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/with-module-federation/angular/utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAML,sBAAsB,EACtB,mBAAmB,EAGpB,MAAM,aAAa,CAAC;AASrB,wBAAgB,yBAAyB,CACvC,YAAY,EAAE,MAAM,CAAC,MAAM,EAAE,mBAAmB,CAAC,EACjD,SAAS,UAAQ,QAwBlB;AAED,eAAO,MAAM,6BAA6B,UAKzC,CAAC;AACF,eAAO,MAAM,iCAAiC,UAI7C,CAAC;AAEF,wBAAgB,+BAA+B,CAC7C,QAAQ,GAAE,OAAe,EACzB,SAAS,UAAQ,IASA,QAAQ,MAAM,YAkChC;AAED,wBAAsB,yBAAyB,CAC7C,QAAQ,EAAE,sBAAsB,EAChC,OAAO,GAAE;IACP,QAAQ,EAAE,OAAO,CAAC;IAClB,kBAAkB,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,MAAM,CAAC;CAC3B,EACvB,OAAO,GAAE,QAAQ,GAAG,SAAoB;;;;;;GA4EzC;AAED,wBAAgB,6BAA6B,CAC3C,QAAQ,EAAE,sBAAsB,EAChC,OAAO,GAAE;IACP,QAAQ,EAAE,OAAO,CAAC;IAClB,kBAAkB,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,MAAM,CAAC;CAC3B,EACvB,SAAS,UAAQ;;;;;;EAwElB"}

package/src/with-module-federation/angular/utils.js

@@ -75,7 +75,7 @@ function getFunctionDeterminateRemoteUrl(isServer = false, useRspack = false) {
         return `${useRspack ? `${remote}@` : ''}${host.endsWith('/') ? host.slice(0, -1) : host}:${port}/${remoteEntry}`;
     };
 }
-async function getModuleFederationConfig(mfConfig, options = { isServer: false }) {
+async function getModuleFederationConfig(mfConfig, options = { isServer: false }, bundler = 'rspack') {
     let projectGraph;
     try {
         projectGraph = (0, devkit_1.readCachedProjectGraph)();
@@ -91,7 +91,7 @@ async function getModuleFederationConfig(mfConfig, options = { isServer: false }
         dependencies.workspaceLibraries = dependencies.workspaceLibraries.filter((lib) => mfConfig.shared(lib.importKey, {}) !== false);
         dependencies.npmPackages = dependencies.npmPackages.filter((pkg) => mfConfig.shared(pkg, {}) !== false);
     }
-    const sharedLibraries = (0, utils_1.shareWorkspaceLibraries)(dependencies.workspaceLibraries);
+    const sharedLibraries = (0, utils_1.shareWorkspaceLibraries)(dependencies.workspaceLibraries, undefined, bundler);
     const npmPackages = (0, utils_1.sharePackages)(Array.from(new Set([
         ...exports.DEFAULT_ANGULAR_PACKAGES_TO_SHARE,
         ...dependencies.npmPackages.filter((pkg) => !exports.DEFAULT_NPM_PACKAGES_TO_AVOID.includes(pkg)),

package/src/with-module-federation/angular/with-module-federation-ssr.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"with-module-federation-ssr.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/with-module-federation/angular/with-module-federation-ssr.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,KAAK,sBAAsB,EAC3B,KAAK,gCAAgC,EACtC,MAAM,aAAa,CAAC;AAGrB,wBAAsB,0BAA0B,CAC9C,OAAO,EAAE,sBAAsB,EAC/B,cAAc,CAAC,EAAE,gCAAgC,iCAwFlD"}
+{"version":3,"file":"with-module-federation-ssr.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/with-module-federation/angular/with-module-federation-ssr.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,KAAK,sBAAsB,EAC3B,KAAK,gCAAgC,EACtC,MAAM,aAAa,CAAC;AAGrB,wBAAsB,0BAA0B,CAC9C,OAAO,EAAE,sBAAsB,EAC/B,cAAc,CAAC,EAAE,gCAAgC,iCA4FlD"}

package/src/with-module-federation/angular/with-module-federation-ssr.js

@@ -10,7 +10,7 @@ async function withModuleFederationForSSR(options, configOverride) {
     const isDevServer = process.env['WEBPACK_SERVE'];
     const { sharedLibraries, sharedDependencies, mappedRemotes } = await (0, utils_2.getModuleFederationConfig)(options, {
         isServer: true,
-    });
+    }, 'webpack');
     return (config) => {
         const updatedConfig = {
             ...(config ?? {}),

package/src/with-module-federation/angular/with-module-federation.js

@@ -13,7 +13,7 @@ async function withModuleFederation(options, configOverride) {
         paths: [require.resolve('@angular-devkit/build-angular')],
     });
     const isDevServer = process.env['WEBPACK_SERVE'];
-    const { sharedLibraries, sharedDependencies, mappedRemotes } = await (0, utils_2.getModuleFederationConfig)(options);
+    const { sharedLibraries, sharedDependencies, mappedRemotes } = await (0, utils_2.getModuleFederationConfig)(options, undefined, 'webpack');
     return (config) => {
         const updatedConfig = {
             ...(config ?? {}),

package/src/with-module-federation/webpack/utils.d.ts

@@ -3,7 +3,7 @@ export declare function getFunctionDeterminateRemoteUrl(isServer?: boolean): (re
 export declare function getModuleFederationConfig(mfConfig: ModuleFederationConfig, options?: {
     isServer: boolean;
     determineRemoteUrl?: (remote: string) => string;
-}): Promise<{
+}, bundler?: 'rspack' | 'webpack'): Promise<{
     sharedLibraries: import("../../utils").SharedWorkspaceLibraryConfig;
     sharedDependencies: {
         [x: string]: import("../../utils").SharedLibraryConfig;

package/src/with-module-federation/webpack/utils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"utils.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/with-module-federation/webpack/utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAML,sBAAsB,EAGvB,MAAM,aAAa,CAAC;AAWrB,wBAAgB,+BAA+B,CAAC,QAAQ,GAAE,OAAe,IAItD,QAAQ,MAAM,YAkChC;AAED,wBAAsB,yBAAyB,CAC7C,QAAQ,EAAE,sBAAsB,EAChC,OAAO,GAAE;IACP,QAAQ,EAAE,OAAO,CAAC;IAClB,kBAAkB,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,MAAM,CAAC;CAC3B;;;;;;GA4ExB"}
+{"version":3,"file":"utils.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/with-module-federation/webpack/utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAML,sBAAsB,EAGvB,MAAM,aAAa,CAAC;AAWrB,wBAAgB,+BAA+B,CAAC,QAAQ,GAAE,OAAe,IAItD,QAAQ,MAAM,YAkChC;AAED,wBAAsB,yBAAyB,CAC7C,QAAQ,EAAE,sBAAsB,EAChC,OAAO,GAAE;IACP,QAAQ,EAAE,OAAO,CAAC;IAClB,kBAAkB,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,MAAM,CAAC;CAC3B,EACvB,OAAO,GAAE,QAAQ,GAAG,SAAoB;;;;;;GA8EzC"}

package/src/with-module-federation/webpack/utils.js

@@ -36,7 +36,7 @@ function getFunctionDeterminateRemoteUrl(isServer = false) {
         return `${host.endsWith('/') ? host.slice(0, -1) : host}:${port}/${remoteEntry}`;
     };
 }
-async function getModuleFederationConfig(mfConfig, options = { isServer: false }) {
+async function getModuleFederationConfig(mfConfig, options = { isServer: false }, bundler = 'rspack') {
     let projectGraph;
     try {
         projectGraph = (0, devkit_1.readCachedProjectGraph)();
@@ -53,7 +53,7 @@ async function getModuleFederationConfig(mfConfig, options = { isServer: false }
         dependencies.workspaceLibraries = dependencies.workspaceLibraries.filter((lib) => mfConfig.shared(lib.importKey, {}) !== false);
         dependencies.npmPackages = dependencies.npmPackages.filter((pkg) => mfConfig.shared(pkg, {}) !== false);
     }
-    const sharedLibraries = (0, utils_1.shareWorkspaceLibraries)(dependencies.workspaceLibraries);
+    const sharedLibraries = (0, utils_1.shareWorkspaceLibraries)(dependencies.workspaceLibraries, undefined, bundler);
     const npmPackages = (0, utils_1.sharePackages)(dependencies.npmPackages);
     const sharedDependencies = {
         ...sharedLibraries.getLibraries(project.root),

package/src/with-module-federation/webpack/with-module-federation-ssr.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"with-module-federation-ssr.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/with-module-federation/webpack/with-module-federation-ssr.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,sBAAsB,EAEtB,gCAAgC,EACjC,MAAM,aAAa,CAAC;AAIrB,wBAAsB,0BAA0B,CAC9C,OAAO,EAAE,sBAAsB,EAC/B,cAAc,CAAC,EAAE,gCAAgC,iCA0ElD"}
+{"version":3,"file":"with-module-federation-ssr.d.ts","sourceRoot":"","sources":["../../../../../../packages/module-federation/src/with-module-federation/webpack/with-module-federation-ssr.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,sBAAsB,EAEtB,gCAAgC,EACjC,MAAM,aAAa,CAAC;AAIrB,wBAAsB,0BAA0B,CAC9C,OAAO,EAAE,sBAAsB,EAC/B,cAAc,CAAC,EAAE,gCAAgC,iCA8ElD"}

package/src/with-module-federation/webpack/with-module-federation-ssr.js

@@ -10,7 +10,7 @@ async function withModuleFederationForSSR(options, configOverride) {
     const isDevServer = process.env['WEBPACK_SERVE'];
     const { sharedLibraries, sharedDependencies, mappedRemotes } = await (0, utils_2.getModuleFederationConfig)(options, {
         isServer: true,
-    });
+    }, 'webpack');
     return (config) => {
         config.target = 'async-node';
         config.output.uniqueName = options.name;

package/src/with-module-federation/webpack/with-module-federation.js

@@ -12,7 +12,7 @@ async function withModuleFederation(options, configOverride) {
         return (config) => config;
     }
     const isDevServer = process.env['WEBPACK_SERVE'];
-    const { sharedDependencies, sharedLibraries, mappedRemotes } = await (0, utils_2.getModuleFederationConfig)(options);
+    const { sharedDependencies, sharedLibraries, mappedRemotes } = await (0, utils_2.getModuleFederationConfig)(options, undefined, 'webpack');
     return (config, ctx) => {
         config.output.uniqueName = options.name;
         config.output.publicPath = 'auto';