@nx/js 23.3.0-pr.37036.f6e3fb2 → 23.3.0-pr.37224.268062c

package/README.md

@@ -12,7 +12,7 @@
 [![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)](<>)
 [![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
 [![Join us on the Official Nx Discord Server](https://img.shields.io/discord/1143497901675401286?label=discord)](https://go.nx.dev/community)
-[![Nx Sandboxing](https://staging.nx.app/workspaces/62d013ea0852fe0a2df74438/sandbox-badge.svg)](https://nx.dev/docs/features/ci-features/sandboxing)
+[![Hours saved](https://img.shields.io/endpoint?url=https%3A%2F%2Fstaging.nx.app%2Fnx-cloud%2Fbadge%2F62d013ea0852fe0a2df74438%2Fhours-saved.json)](https://nx.dev/nx-cloud)
 
 </div>
 

package/dist/src/executors/tsc/lib/batch/build-task-info-per-tsconfig-map.js

@@ -28,7 +28,7 @@ function processTasksAndPopulateTsConfigTaskInfoMap(tsConfigTaskInfoMap, tasksOp
             tsConfigTaskInfoMap[tsConfigPath] = taskInfo;
             taskTsConfigCache.add(taskName);
         }
-        processTasksAndPopulateTsConfigTaskInfoMap(tsConfigTaskInfoMap, tasksOptions, context, context.taskGraph.dependencies[taskName], taskInMemoryTsConfigMap);
+        processTasksAndPopulateTsConfigTaskInfoMap(tsConfigTaskInfoMap, tasksOptions, context, context.taskGraph.dependencies[taskName].map((edge) => edge.id), taskInMemoryTsConfigMap);
     }
 }
 function createTaskInfo(taskName, taskOptions, context, tsConfig) {

package/dist/src/executors/tsc/lib/get-tsconfig.js

@@ -48,7 +48,9 @@ function generateTaskProjectTsConfig(task, tasksOptions, context, taskInMemoryTs
 }
 function getDependencyTasksInOtherProjects(task, project, context) {
     const implicitDependencies = new Set(context.projectGraph.nodes[project].data.implicitDependencies ?? []);
-    return context.taskGraph.dependencies[task].filter((t) => {
+    return context.taskGraph.dependencies[task]
+        .map((edge) => edge.id)
+        .filter((t) => {
         const { project: dependencyProject } = (0, devkit_1.parseTargetString)(t, context);
         // Tasks for implicit dependencies are skipped since incremental builds only apply to explicit dependencies
         return (t !== task &&

package/dist/src/release/version-actions.d.ts

@@ -21,6 +21,7 @@ export default class JsVersionActions extends VersionActions {
     updateProjectVersion(tree: Tree, newVersion: string): Promise<string[]>;
     updateProjectDependencies(tree: Tree, projectGraph: ProjectGraph, dependenciesToUpdate: Record<string, string>, resolveVersionForDependency?: ResolveVersionForDependency): Promise<string[]>;
     private getLocalDependencyProjectLookup;
+    private shouldPreserveUnconfiguredPrivateDevDependency;
     private resolveLocalDependencySpecifier;
     private applyVersionPrefix;
     private updateManifestValues;

package/dist/src/release/version-actions.js

@@ -223,6 +223,9 @@ class JsVersionActions extends release_1.VersionActions {
                                 version = await this.resolveLocalDependencySpecifier(dependencyName, currentVersion, targetProject, resolveVersion);
                             }
                             catch (error) {
+                                if (this.shouldPreserveUnconfiguredPrivateDevDependency(tree, json, depType, dependencyName, targetProject, error)) {
+                                    continue;
+                                }
                                 const message = error instanceof Error ? error.message : String(error);
                                 throw new Error(`Unable to replace local dependency protocol "${currentVersion}" for "${dependencyName}" in manifest "${manifestToUpdate.manifestPath}". ${message}`);
                             }
@@ -277,11 +280,36 @@ class JsVersionActions extends release_1.VersionActions {
             if (!packageName) {
                 continue;
             }
-            lookup.set(packageName, { projectName });
+            lookup.set(packageName, {
+                projectName,
+                projectRoot: node.data.root,
+            });
         }
         localDependencyProjectsByGraph.set(projectGraph, lookup);
         return lookup;
     }
+    shouldPreserveUnconfiguredPrivateDevDependency(tree, manifest, dependencyType, dependencyName, targetProject, error) {
+        if (dependencyType !== 'devDependencies' ||
+            error?.code !==
+                'NX_RELEASE_PROJECT_NOT_CONFIGURED' ||
+            [
+                manifest.dependencies,
+                manifest.peerDependencies,
+                manifest.optionalDependencies,
+            ].some((dependencies) => dependencies?.[dependencyName] !== undefined)) {
+            return false;
+        }
+        const targetManifestPath = (0, node_path_1.join)(targetProject.projectRoot, 'package.json');
+        if (!tree.exists(targetManifestPath)) {
+            return false;
+        }
+        try {
+            return (0, devkit_1.readJson)(tree, targetManifestPath).private === true;
+        }
+        catch {
+            return false;
+        }
+    }
     async resolveLocalDependencySpecifier(dependencyName, versionSpecifier, targetProject, resolveVersion) {
         if (versionSpecifier.startsWith('file:')) {
             const resolvedVersion = await resolveVersion(targetProject.projectName);

package/dist/src/utils/buildable-libs-utils.js

@@ -206,7 +206,7 @@ function collectNpmDependencies(projectName, projectGraph, dependentTasks, colle
     return dependencies;
 }
 function collectDependentTasks(project, task, taskGraph, projectGraph, shallow, areTopLevelDeps = true, dependentTasks = new Map()) {
-    for (const depTask of taskGraph.dependencies[task] ?? []) {
+    for (const { id: depTask } of taskGraph.dependencies[task] ?? []) {
         if (dependentTasks.has(depTask)) {
             if (!dependentTasks.get(depTask).isTopLevel && areTopLevelDeps) {
                 dependentTasks.get(depTask).isTopLevel = true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "23.3.0-pr.37036.f6e3fb2",
+  "version": "23.3.0-pr.37224.268062c",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -138,8 +138,8 @@
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-typescript": "^7.22.5",
     "@babel/runtime": "^7.22.6",
-    "@nx/devkit": "23.3.0-pr.37036.f6e3fb2",
-    "@nx/workspace": "23.3.0-pr.37036.f6e3fb2",
+    "@nx/devkit": "23.3.0-pr.37224.268062c",
+    "@nx/workspace": "23.3.0-pr.37224.268062c",
     "@zkochan/js-yaml": "0.0.7",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^3.1.0",
@@ -159,14 +159,14 @@
     "tslib": "^2.3.0"
   },
   "devDependencies": {
-    "@nx/esbuild": "23.3.0-pr.37036.f6e3fb2",
-    "@nx/eslint": "23.3.0-pr.37036.f6e3fb2",
-    "@nx/jest": "23.3.0-pr.37036.f6e3fb2",
-    "@nx/oxlint": "23.3.0-pr.37036.f6e3fb2",
-    "@nx/rollup": "23.3.0-pr.37036.f6e3fb2",
-    "@nx/vite": "23.3.0-pr.37036.f6e3fb2",
-    "@nx/vitest": "23.3.0-pr.37036.f6e3fb2",
-    "nx": "23.3.0-pr.37036.f6e3fb2"
+    "@nx/esbuild": "23.3.0-pr.37224.268062c",
+    "@nx/eslint": "23.3.0-pr.37224.268062c",
+    "@nx/jest": "23.3.0-pr.37224.268062c",
+    "@nx/oxlint": "23.3.0-pr.37224.268062c",
+    "@nx/rollup": "23.3.0-pr.37224.268062c",
+    "@nx/vite": "23.3.0-pr.37224.268062c",
+    "@nx/vitest": "23.3.0-pr.37224.268062c",
+    "nx": "23.3.0-pr.37224.268062c"
   },
   "peerDependencies": {
     "@swc/cli": ">=0.6.0 <0.9.0",