@nx/js 23.3.0-beta.1 → 23.3.0-beta.2

package/dist/src/executors/release-publish/release-publish.impl.js

@@ -39,6 +39,19 @@ function isAlreadyPublishedPublishError(stdoutData, stderr = '', stdout = '') {
         (error?.code === 'E409' &&
             errorMessage.includes('this package is already present')));
 }
+function isNpmViewNotFoundError(err) {
+    if (err.code === 'ENOBUFS' || err.signal) {
+        return false;
+    }
+    try {
+        const errorCode = JSON.parse(err.stdout?.toString() || '{}').error?.code;
+        if (errorCode) {
+            return errorCode === 'E404';
+        }
+    }
+    catch { }
+    return /(?:^|\n)npm (?:ERR!|error) code E404(?:\n|$)/i.test(err.stderr?.toString() || '');
+}
 async function runExecutor(options, context) {
     const pm = (0, devkit_1.detectPackageManager)();
     // Check if npm is installed (needed for dist-tag management and as fallback for view command)
@@ -146,10 +159,11 @@ Please update the local dependency on "${depName}" to be a valid semantic versio
     }, warnFn);
     // Use bun info when bun is the package manager, otherwise use npm view
     // (npm view works across npm/pnpm/yarn environments and is the established default)
+    const npmViewDistTagField = `dist-tags[${tag}]`;
     const npmViewCommandSegments = pm === 'bun'
         ? ['bun info', packageName, `--json --"${registryConfigKey}=${registry}"`]
         : [
-            `npm view ${packageName} versions dist-tags --json --"${registryConfigKey}=${registry}"`,
+            `npm view ${packageName}@${packageJson.version} name version "${npmViewDistTagField}" --json --"${registryConfigKey}=${registry}"`,
         ];
     const npmDistTagAddCommandSegments = [
         `npm dist-tag add ${packageName}@${packageJson.version} ${tag} --"${registryConfigKey}=${registry}"`,
@@ -172,22 +186,46 @@ Please update the local dependency on "${depName}" to be a valid semantic versio
                 windowsHide: true,
             });
             // `npm view`/`bun info` can exit 0 with empty stdout when the package exists in the registry but has
-            // no published versions or dist-tags yet (e.g. GitHub packages). Treat empty output the samme as
+            // no published versions or dist-tags yet (e.g. GitHub packages). Treat empty output the same as
             // package not existing yet and continue to the publish step.
-            const resultJson = JSON.parse(result.toString().trim() || '{}');
-            const distTags = resultJson['dist-tags'] || {};
-            if (distTags[tag] === currentVersion) {
+            const output = result.toString().trim();
+            let distTagVersion;
+            let versionExists;
+            if (!output) {
+                versionExists = false;
+            }
+            else {
+                const resultJson = JSON.parse(output);
+                if (pm === 'bun') {
+                    distTagVersion = resultJson['dist-tags']?.[tag];
+                    versionExists = (Array.isArray(resultJson.versions)
+                        ? resultJson.versions
+                        : [resultJson.versions]).includes(currentVersion);
+                }
+                else {
+                    const metadataEntries = Array.isArray(resultJson)
+                        ? resultJson
+                        : [resultJson];
+                    const currentVersionMetadata = metadataEntries.find((metadata) => metadata?.name === packageName &&
+                        metadata?.version === currentVersion);
+                    if (!currentVersionMetadata) {
+                        console.error(`Something unexpected went wrong when checking for existing dist-tags. The registry returned metadata that did not match ${packageName}@${currentVersion}.`);
+                        return {
+                            success: false,
+                        };
+                    }
+                    distTagVersion = currentVersionMetadata[npmViewDistTagField];
+                    versionExists = true;
+                }
+            }
+            if (distTagVersion === currentVersion) {
                 console.warn(`Skipped ${packageTxt} because v${currentVersion} already exists in ${registry} with tag "${tag}"`);
                 return {
                     success: true,
                 };
             }
             if (isNpmInstalled) {
-                // If only one version of a package exists in the registry, versions will be a string instead of an array.
-                const versions = Array.isArray(resultJson.versions)
-                    ? resultJson.versions
-                    : [resultJson.versions];
-                if (versions.includes(currentVersion)) {
+                if (versionExists) {
                     try {
                         if (!isDryRun) {
                             (0, child_process_1.execSync)(npmDistTagAddCommandSegments.join(' '), {
@@ -248,35 +286,15 @@ Please update the local dependency on "${depName}" to be a valid semantic versio
             }
         }
         catch (err) {
-            try {
-                const stdoutData = JSON.parse(err.stdout?.toString() || '{}');
-                // If the error is that the package doesn't exist, then we can ignore it because we will be publishing it for the first time in the next step
-                if (!(stdoutData.error?.code?.includes('E404') &&
-                    stdoutData.error?.summary?.toLowerCase().includes('not found')) &&
-                    !(err.stderr?.toString().includes('E404') &&
-                        err.stderr?.toString().toLowerCase().includes('not found')) &&
-                    // bun uses plain '404' instead of 'E404'
-                    !(err.stderr?.toString().includes('404') &&
-                        err.stderr?.toString().toLowerCase().includes('not found'))) {
-                    console.error(`Something unexpected went wrong when checking for existing dist-tags.\n`, err);
-                    return {
-                        success: false,
-                    };
-                }
-            }
-            catch {
-                // JSON parse failed entirely — check stderr/stdout for plain 404
-                const stderrStr = err.stderr?.toString() || '';
-                const stdoutStr = err.stdout?.toString() || '';
-                if (!((stderrStr.includes('404') &&
-                    stderrStr.toLowerCase().includes('not found')) ||
-                    (stdoutStr.includes('404') &&
-                        stdoutStr.toLowerCase().includes('not found')))) {
-                    console.error(`Something unexpected went wrong when checking for existing dist-tags.\n`, err);
-                    return {
-                        success: false,
-                    };
-                }
+            const isNotFound = pm === 'bun'
+                ? [err.stderr?.toString(), err.stdout?.toString()].some((output) => output?.includes('404') &&
+                    output.toLowerCase().includes('not found'))
+                : isNpmViewNotFoundError(err);
+            if (!isNotFound) {
+                console.error(`Something unexpected went wrong when checking for existing dist-tags.\n`, err);
+                return {
+                    success: false,
+                };
             }
         }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "23.3.0-beta.1",
+  "version": "23.3.0-beta.2",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -147,18 +147,18 @@
     "source-map-support": "0.5.19",
     "tinyglobby": "^0.2.12",
     "tslib": "^2.3.0",
-    "@nx/devkit": "23.3.0-beta.1",
-    "@nx/workspace": "23.3.0-beta.1"
+    "@nx/workspace": "23.3.0-beta.2",
+    "@nx/devkit": "23.3.0-beta.2"
   },
   "devDependencies": {
-    "@nx/jest": "23.3.0-beta.1",
-    "@nx/esbuild": "23.3.0-beta.1",
-    "@nx/eslint": "23.3.0-beta.1",
-    "@nx/oxlint": "23.3.0-beta.1",
-    "@nx/rollup": "23.3.0-beta.1",
-    "@nx/vite": "23.3.0-beta.1",
-    "@nx/vitest": "23.3.0-beta.1",
-    "nx": "23.3.0-beta.1"
+    "@nx/jest": "23.3.0-beta.2",
+    "@nx/esbuild": "23.3.0-beta.2",
+    "@nx/eslint": "23.3.0-beta.2",
+    "@nx/oxlint": "23.3.0-beta.2",
+    "@nx/vitest": "23.3.0-beta.2",
+    "@nx/rollup": "23.3.0-beta.2",
+    "nx": "23.3.0-beta.2",
+    "@nx/vite": "23.3.0-beta.2"
   },
   "peerDependencies": {
     "@swc/cli": ">=0.6.0 <0.9.0",