@nx/js 23.1.0 → 23.2.0-beta.1

package/dist/babel.js

@@ -41,6 +41,17 @@ module.exports = function (api, options = {}) {
             options.decorators ?? { legacy: true },
         ],
         [require.resolve('@babel/plugin-transform-class-properties'), { loose }],
+        // class-properties runs babel's shared class-features plugin, which hard-errors
+        // on private methods and static blocks unless their transforms are loaded too.
+        // This bites when an ESM-only dep using that syntax is transformed (un-ignored
+        // via transformIgnorePatterns). private-property-in-object completes babel's
+        // loose-consistency trio so `loose` stays uniform across the class-features transforms.
+        [require.resolve('@babel/plugin-transform-private-methods'), { loose }],
+        [
+            require.resolve('@babel/plugin-transform-private-property-in-object'),
+            { loose },
+        ],
+        require.resolve('@babel/plugin-transform-class-static-block'),
     ].filter(Boolean);
     return {
         presets: [

package/dist/src/executors/release-publish/extract-npm-publish-json-data.js

@@ -8,67 +8,107 @@ const expectedNpmPublishJsonKeys = [
     'size',
     'filename',
 ];
-// Regular expression to match JSON-like objects, including up to two levels of
-// nested objects.
-// /{(?:[^{}]|{(?:[^{}]|{[^{}]*})*})*}/g
-// Two levels of nesting are required to support both shapes of npm/pnpm publish
-// output:
-//   - Older npm (<= 11.13) prints the publish summary as a flat object whose only
-//     nesting is its own "files" array (one level deep).
-//   - Newer npm (>= 11.16, bundled with Node 26) nests that same summary under the
-//     package name, e.g. { "@scope/pkg": { ...id/name/files... } }, adding a
-//     second level. pnpm publish nests the same way when run from the workspace
-//     root. Matching two levels lets us capture the wrapper object in the nested
-//     case so its braces are not left behind in beforeJsonData/afterJsonData.
-const jsonRegex = /{(?:[^{}]|{(?:[^{}]|{[^{}]*})*})*}/g;
+// Pair each '{' with its matching '}' in the publish output. The output is npm's
+// pretty-printed JSON summary interleaved with arbitrary lifecycle-script text,
+// so we recognize only genuine JSON structure and treat everything else as
+// opaque, without interpreting it as JSON (unlike a JSONC parser):
+//   - Braces and quotes inside a JSON string value are ignored, so a files[].path
+//     like "templates/{{name}}/file.txt" doesn't throw off the pairing (#36236).
+//   - '//' and '/*' are not comments; lifecycle output legitimately prints globs
+//     and paths such as dist/*.js, and npm/pnpm emit plain JSON.
+//   - A raw newline ends a string. A valid JSON string never contains one (it is
+//     escaped as \n), so this can't truncate a real value, but it stops a stray
+//     unpaired '"' in log text from swallowing the summary on a later line.
+//   - A quote only opens a string inside an object, so a lone '"' in the preamble
+//     or between objects stays inert.
+// Stray unmatched braces are left unpaired.
+function matchBracePositions(str) {
+    const matches = new Map();
+    const openBraceStack = [];
+    let inString = false;
+    for (let i = 0; i < str.length; i++) {
+        const char = str[i];
+        if (inString) {
+            if (char === '\\') {
+                i++; // skip the escaped character
+            }
+            else if (char === '"' || char === '\n' || char === '\r') {
+                inString = false;
+            }
+            continue;
+        }
+        if (char === '"') {
+            if (openBraceStack.length > 0) {
+                inString = true;
+            }
+        }
+        else if (char === '{') {
+            openBraceStack.push(i);
+        }
+        else if (char === '}') {
+            const openIndex = openBraceStack.pop();
+            if (openIndex !== undefined) {
+                matches.set(openIndex, i);
+            }
+        }
+    }
+    return matches;
+}
+// Yield every balanced {...} object in the output, left to right by start
+// position, so an outer wrapper is seen before the objects nested inside it.
+function* iterateBalancedJsonObjects(str) {
+    const closeByOpen = matchBracePositions(str);
+    for (let i = 0; i < str.length; i++) {
+        const closeIndex = closeByOpen.get(i);
+        if (closeIndex !== undefined) {
+            yield { text: str.slice(i, closeIndex + 1), index: i };
+        }
+    }
+}
 function isNpmPublishSummary(value) {
     return (typeof value === 'object' &&
         value !== null &&
         expectedNpmPublishJsonKeys.every((key) => value[key] !== undefined));
 }
 function extractNpmPublishJsonData(str) {
-    const jsonMatches = str.match(jsonRegex);
-    if (jsonMatches) {
-        for (const match of jsonMatches) {
-            // Cheap upfront check to see if the stringified JSON data has the expected keys as substrings
-            if (!expectedNpmPublishJsonKeys.every((key) => str.includes(key))) {
-                continue;
-            }
-            // Full JSON parsing to identify the JSON object
-            let parsedJson;
-            try {
-                parsedJson = JSON.parse(match);
-            }
-            catch {
-                // Ignore parsing errors for unrelated JSON blocks
-                continue;
-            }
-            // npm <= 11.13 emits the summary as a flat object, while npm >= 11.16 (and
-            // pnpm publish run from the workspace root) nest it one level deep under the
-            // package name. Support both by unwrapping a single level when the matched
-            // object isn't itself the summary.
-            let publishData = null;
-            if (isNpmPublishSummary(parsedJson)) {
-                publishData = parsedJson;
-            }
-            else if (typeof parsedJson === 'object' && parsedJson !== null) {
-                for (const value of Object.values(parsedJson)) {
-                    if (isNpmPublishSummary(value)) {
-                        publishData = value;
-                        break;
-                    }
+    for (const { text: match, index } of iterateBalancedJsonObjects(str)) {
+        // Cheap check to skip candidates that can't be the summary before parsing
+        if (!expectedNpmPublishJsonKeys.every((key) => match.includes(key))) {
+            continue;
+        }
+        // Full JSON parsing to identify the JSON object
+        let parsedJson;
+        try {
+            parsedJson = JSON.parse(match);
+        }
+        catch {
+            // Ignore parsing errors for unrelated JSON blocks
+            continue;
+        }
+        // npm <= 11.13 emits the summary as a flat object, while npm >= 11.16 (and
+        // pnpm publish run from the workspace root) nest it one level deep under the
+        // package name. Support both by unwrapping a single level when the matched
+        // object isn't itself the summary.
+        let publishData = null;
+        if (isNpmPublishSummary(parsedJson)) {
+            publishData = parsedJson;
+        }
+        else if (typeof parsedJson === 'object' && parsedJson !== null) {
+            for (const value of Object.values(parsedJson)) {
+                if (isNpmPublishSummary(value)) {
+                    publishData = value;
+                    break;
                 }
             }
-            if (!publishData) {
-                continue;
-            }
-            const jsonStartIndex = str.indexOf(match);
-            return {
-                beforeJsonData: str.slice(0, jsonStartIndex),
-                jsonData: publishData,
-                afterJsonData: str.slice(jsonStartIndex + match.length),
-            };
         }
+        if (!publishData) {
+            continue;
+        }
+        return {
+            beforeJsonData: str.slice(0, index),
+            jsonData: publishData,
+            afterJsonData: str.slice(index + match.length),
+        };
     }
     // No applicable jsonData detected, the whole contents is the beforeJsonData
     return {

package/dist/src/executors/release-publish/log-tar.js

@@ -14,9 +14,13 @@ const logTar = (tarball, opts = {}) => {
     console.log(chalk_1.default.magenta('=== Tarball Contents ==='));
     if (tarball.files.length) {
         console.log('');
-        const columnData = (0, columnify_1.default)(tarball.files
+        const columnData = (0, columnify_1.default)(
+        // Sort for a stable listing: pnpm 11 orders files differently than
+        // npm and pnpm 10.
+        [...tarball.files]
+            .sort((a, b) => (a.path < b.path ? -1 : a.path > b.path ? 1 : 0))
             .map((f) => {
-            const bytes = (0, format_bytes_1.formatBytes)(f.size, false);
+            const bytes = typeof f.size === 'number' ? (0, format_bytes_1.formatBytes)(f.size, false) : '';
             return /^node_modules\//.test(f.path)
                 ? null
                 : { path: f.path, size: `${bytes}` };

package/dist/src/executors/release-publish/release-publish.impl.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = runExecutor;
 const devkit_1 = require("@nx/devkit");
 const child_process_1 = require("child_process");
+const fs_1 = require("fs");
 const npm_run_path_1 = require("npm-run-path");
 const path_1 = require("path");
 const is_locally_linked_package_version_1 = require("../../utils/is-locally-linked-package-version");
@@ -349,6 +350,20 @@ function runPublish(ctx) {
                 success: false,
             };
         }
+        // pnpm 11 dropped the per-file size field from its publish --json output,
+        // so recover the sizes from disk for the tarball contents log.
+        if (Array.isArray(jsonData.files)) {
+            for (const file of jsonData.files) {
+                if (typeof file.size !== 'number' && typeof file.path === 'string') {
+                    try {
+                        file.size = (0, fs_1.statSync)((0, path_1.join)(packageRoot, file.path)).size;
+                    }
+                    catch {
+                        // leave the size unknown, logTar omits it
+                    }
+                }
+            }
+        }
         if (isDryRun) {
             for (const [key, val] of Object.entries(jsonData)) {
                 if (typeof val !== 'string') {

package/dist/src/plugins/jest/start-local-registry.js

@@ -36,6 +36,11 @@ function startLocalRegistry({ localRegistryTarget, storage, verbose, clearStorag
                 (0, child_process_1.execSync)(`npm config set //${listenAddress}:${port}/:_authToken "${authToken}" --ws=false`, {
                     windowsHide: true,
                 });
+                // pnpm 11 reads pnpm_config_* env vars instead of npm_config_*, and
+                // they take precedence over any registry configured in ~/.npmrc
+                process.env.pnpm_config_registry = registry;
+                process.env[`pnpm_config_//${listenAddress}:${port}/:_authToken`] =
+                    authToken;
                 // bun
                 process.env.BUN_CONFIG_REGISTRY = registry;
                 process.env.BUN_CONFIG_TOKEN = authToken;
@@ -44,7 +49,7 @@ function startLocalRegistry({ localRegistryTarget, storage, verbose, clearStorag
                 // yarnv2
                 process.env.YARN_NPM_REGISTRY_SERVER = registry;
                 process.env.YARN_UNSAFE_HTTP_WHITELIST = listenAddress;
-                console.log('Set npm, bun, and yarn config registry to ' + registry);
+                console.log('Set npm, pnpm, bun, and yarn config registry to ' + registry);
                 resolve(() => {
                     childProcess.kill();
                     (0, child_process_1.execSync)(`npm config delete //${listenAddress}:${port}/:_authToken --ws=false`, {

package/dist/src/utils/swc/add-swc-dependencies.js

@@ -4,7 +4,11 @@ exports.getSwcDependencies = getSwcDependencies;
 exports.addSwcDependencies = addSwcDependencies;
 exports.addSwcRegisterDependencies = addSwcRegisterDependencies;
 const devkit_1 = require("@nx/devkit");
+const internal_1 = require("@nx/devkit/internal");
 const versions_1 = require("../versions");
+// @swc/core's postinstall only installs a wasm fallback for platforms not
+// covered by its prebuilt optional dependencies, so skip it.
+const swcAllowBuilds = { '@swc/core': false };
 function getSwcDependencies() {
     const dependencies = {
         '@swc/helpers': versions_1.swcHelpersVersion,
@@ -17,8 +21,10 @@ function getSwcDependencies() {
 }
 function addSwcDependencies(tree) {
     const { dependencies, devDependencies } = getSwcDependencies();
+    (0, internal_1.acknowledgeBuildScripts)(tree, (0, devkit_1.detectPackageManager)(tree.root), swcAllowBuilds);
     return (0, devkit_1.addDependenciesToPackageJson)(tree, dependencies, devDependencies, undefined, true);
 }
 function addSwcRegisterDependencies(tree) {
+    (0, internal_1.acknowledgeBuildScripts)(tree, (0, devkit_1.detectPackageManager)(tree.root), swcAllowBuilds);
     return (0, devkit_1.addDependenciesToPackageJson)(tree, {}, { '@swc-node/register': versions_1.swcNodeVersion, '@swc/core': versions_1.swcCoreVersion }, undefined, true);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "23.1.0",
+  "version": "23.2.0-beta.1",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -123,6 +123,9 @@
     "@babel/core": "^7.23.2",
     "@babel/plugin-proposal-decorators": "^7.22.7",
     "@babel/plugin-transform-class-properties": "^7.22.5",
+    "@babel/plugin-transform-class-static-block": "^7.22.5",
+    "@babel/plugin-transform-private-methods": "^7.22.5",
+    "@babel/plugin-transform-private-property-in-object": "^7.22.5",
     "@babel/plugin-transform-runtime": "^7.23.2",
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-typescript": "^7.22.5",
@@ -144,11 +147,11 @@
     "source-map-support": "0.5.19",
     "tinyglobby": "^0.2.12",
     "tslib": "^2.3.0",
-    "@nx/devkit": "23.1.0",
-    "@nx/workspace": "23.1.0"
+    "@nx/devkit": "23.2.0-beta.1",
+    "@nx/workspace": "23.2.0-beta.1"
   },
   "devDependencies": {
-    "nx": "23.1.0"
+    "nx": "23.2.0-beta.1"
   },
   "peerDependencies": {
     "@swc/cli": ">=0.6.0 <0.9.0",