@nx/js 22.4.0-beta.0 → 22.4.0-beta.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "22.4.0-beta.0",
+  "version": "22.4.0-beta.1",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -39,8 +39,8 @@
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-typescript": "^7.22.5",
     "@babel/runtime": "^7.22.6",
-    "@nx/devkit": "22.4.0-beta.0",
-    "@nx/workspace": "22.4.0-beta.0",
+    "@nx/devkit": "22.4.0-beta.1",
+    "@nx/workspace": "22.4.0-beta.1",
     "@zkochan/js-yaml": "0.0.7",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^3.1.0",
@@ -60,7 +60,7 @@
     "tslib": "^2.3.0"
   },
   "devDependencies": {
-    "nx": "22.4.0-beta.0"
+    "nx": "22.4.0-beta.1"
   },
   "peerDependencies": {
     "verdaccio": "^6.0.5"

package/src/utils/typescript/plugin.d.ts

@@ -1,4 +1,3 @@
 import type { NxJsonConfiguration } from '@nx/devkit';
 export declare function ensureProjectIsIncludedInPluginRegistrations(nxJson: NxJsonConfiguration, projectRoot: string, buildTargetName: string | null): void;
-export declare function ensureProjectIsExcludedFromPluginRegistrations(nxJson: NxJsonConfiguration, projectRoot: string): void;
 //# sourceMappingURL=plugin.d.ts.map

package/src/utils/typescript/plugin.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"plugin.d.ts","sourceRoot":"","sources":["../../../../../../packages/js/src/utils/typescript/plugin.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAEV,mBAAmB,EACpB,MAAM,YAAY,CAAC;AAIpB,wBAAgB,4CAA4C,CAC1D,MAAM,EAAE,mBAAmB,EAC3B,WAAW,EAAE,MAAM,EACnB,eAAe,EAAE,MAAM,GAAG,IAAI,GAC7B,IAAI,CAmGN;AAED,wBAAgB,8CAA8C,CAC5D,MAAM,EAAE,mBAAmB,EAC3B,WAAW,EAAE,MAAM,GAClB,IAAI,CAyCN"}
+{"version":3,"file":"plugin.d.ts","sourceRoot":"","sources":["../../../../../../packages/js/src/utils/typescript/plugin.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAEV,mBAAmB,EACpB,MAAM,YAAY,CAAC;AAIpB,wBAAgB,4CAA4C,CAC1D,MAAM,EAAE,mBAAmB,EAC3B,WAAW,EAAE,MAAM,EACnB,eAAe,EAAE,MAAM,GAAG,IAAI,GAC7B,IAAI,CAmGN"}

package/src/utils/typescript/plugin.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ensureProjectIsIncludedInPluginRegistrations = ensureProjectIsIncludedInPluginRegistrations;
-exports.ensureProjectIsExcludedFromPluginRegistrations = ensureProjectIsExcludedFromPluginRegistrations;
 const devkit_internals_1 = require("nx/src/devkit-internals");
 function ensureProjectIsIncludedInPluginRegistrations(nxJson, projectRoot, buildTargetName) {
     nxJson.plugins ??= [];
@@ -14,7 +13,7 @@ function ensureProjectIsIncludedInPluginRegistrations(nxJson, projectRoot, build
         }
         if (typeof registration === 'string') {
             if (buildTargetName) {
-                // if it's a string all projects are included but the are no user-specified options
+                // if it's a string all projects are included but there are no user-specified options
                 // and the build task is not inferred by default, so we need to exclude it
                 nxJson.plugins[index] = {
                     plugin: '@nx/js/typescript',
@@ -87,38 +86,6 @@ function ensureProjectIsIncludedInPluginRegistrations(nxJson, projectRoot, build
         nxJson.plugins.push(registration);
     }
 }
-function ensureProjectIsExcludedFromPluginRegistrations(nxJson, projectRoot) {
-    if (!nxJson.plugins?.length ||
-        !nxJson.plugins.some(isTypeScriptPluginRegistration)) {
-        return;
-    }
-    let index = 0;
-    for (const registration of nxJson.plugins) {
-        if (!isTypeScriptPluginRegistration(registration)) {
-            index++;
-            continue;
-        }
-        if (typeof registration === 'string') {
-            // if it's a string, it includes all projects, so we need to exclude it
-            nxJson.plugins[index] = {
-                plugin: '@nx/js/typescript',
-                exclude: [`${projectRoot}/*`],
-            };
-        }
-        else {
-            // check if the project would be included by the plugin registration
-            const matchingConfigFiles = (0, devkit_internals_1.findMatchingConfigFiles)([`${projectRoot}/tsconfig.json`], '**/tsconfig.json', registration.include, registration.exclude);
-            if (matchingConfigFiles.length &&
-                (registration.options?.typecheck !== false ||
-                    registration.options?.build)) {
-                // the project is included by a plugin registration that infers any of the targets, so we need to exclude it
-                registration.exclude ??= [];
-                registration.exclude.push(`${projectRoot}/*`);
-            }
-        }
-        index++;
-    }
-}
 function isTypeScriptPluginRegistration(plugin) {
     return ((typeof plugin === 'string' && plugin === '@nx/js/typescript') ||
         (typeof plugin !== 'string' && plugin.plugin === '@nx/js/typescript'));
@@ -128,7 +95,13 @@ function matchesBuildTargetDefinition(buildOptions, buildTargetName) {
         return !buildTargetName;
     }
     if (!buildTargetName) {
-        return false;
+        // we don't want a build target to be inferred, in which case we'll generate
+        // the package.json with the entry points pointing to source, so, as long as
+        // we don't skip the build check, this registration is valid even if it has
+        // build options defined
+        return typeof buildOptions === 'object'
+            ? !buildOptions.skipBuildCheck
+            : true;
     }
     if (buildOptions === true && buildTargetName === 'build') {
         return true;