@nx/js 20.3.0 → 20.3.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "20.3.0",
+  "version": "20.3.1",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -39,8 +39,8 @@
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-typescript": "^7.22.5",
     "@babel/runtime": "^7.22.6",
-    "@nx/devkit": "20.3.0",
-    "@nx/workspace": "20.3.0",
+    "@nx/devkit": "20.3.1",
+    "@nx/workspace": "20.3.1",
     "@zkochan/js-yaml": "0.0.7",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^2.8.0",

package/src/generators/release-version/utils/update-lock-file.js

@@ -99,7 +99,7 @@ function execLockFileUpdate(command, cwd, env = {}) {
                 `Verify that '${command}' succeeds when run from the workspace root.`,
                 `To configure a string of arguments to be passed to this command, set the 'release.version.generatorOptions.installArgs' property in nx.json.`,
                 `To ignore install lifecycle scripts, set 'release.version.generatorOptions.installIgnoreScripts' to true in nx.json.`,
-                `To disable this step entirely, set 'release.version.skipLockFileUpdate' to true in nx.json.`,
+                `To disable this step entirely, set 'release.version.generatorOptions.skipLockFileUpdate' to true in nx.json.`,
             ],
         });
         throw e;

package/src/generators/typescript-sync/typescript-sync.js

@@ -260,8 +260,8 @@ function collectProjectDependencies(tree, projectName, projectGraph, collectedDe
     collectedDependencies.set(projectName, []);
     for (const dep of projectGraph.dependencies[projectName]) {
         const targetProjectNode = projectGraph.nodes[dep.target];
-        if (!targetProjectNode) {
-            // It's an npm dependency
+        if (!targetProjectNode || dep.type === 'implicit') {
+            // It's an npm or an implicit dependency
             continue;
         }
         // Add the target project node to the list of dependencies for the current project

package/src/plugins/typescript/plugin.js

@@ -274,10 +274,16 @@ function getOutputs(configFilePath, tsConfig, internalProjectReferences, workspa
         }
         else if (config.options.outDir) {
             outputs.add(pathToInputOrOutput(config.options.outDir, workspaceRoot, projectRoot));
-            if (config.options.tsBuildInfoFile &&
-                !(0, node_path_1.normalize)(config.options.tsBuildInfoFile).startsWith(`${(0, node_path_1.normalize)(config.options.outDir)}${node_path_1.sep}`)) {
-                // https://www.typescriptlang.org/tsconfig#tsBuildInfoFile
-                outputs.add(pathToInputOrOutput(config.options.tsBuildInfoFile, workspaceRoot, projectRoot));
+            if (config.options.tsBuildInfoFile) {
+                if (!(0, node_path_1.normalize)(config.options.tsBuildInfoFile).startsWith(`${(0, node_path_1.normalize)(config.options.outDir)}${node_path_1.sep}`)) {
+                    // https://www.typescriptlang.org/tsconfig#tsBuildInfoFile
+                    outputs.add(pathToInputOrOutput(config.options.tsBuildInfoFile, workspaceRoot, projectRoot));
+                }
+            }
+            else if (config.options.rootDir && config.options.rootDir !== '.') {
+                // If rootDir is set, then the tsbuildinfo file will be outside the outDir so we need to add it.
+                const relativeRootDir = (0, node_path_1.relative)(config.options.rootDir, (0, node_path_1.join)(workspaceRoot, projectRoot));
+                outputs.add(pathToInputOrOutput((0, devkit_1.joinPathFragments)(config.options.outDir, relativeRootDir, `*.tsbuildinfo`), workspaceRoot, projectRoot));
             }
         }
         else if (config.fileNames.length) {

package/src/utils/buildable-libs-utils.js

@@ -230,6 +230,9 @@ function computeCompilerOptionsPaths(tsConfig, dependencies) {
 }
 function createTmpTsConfig(tsconfigPath, workspaceRoot, projectRoot, dependencies, useWorkspaceAsBaseUrl = false) {
     const tmpTsConfigPath = (0, path_1.join)(workspaceRoot, 'tmp', projectRoot, process.env.NX_TASK_TARGET_TARGET ?? 'build', 'tsconfig.generated.json');
+    if (tsconfigPath === tmpTsConfigPath) {
+        return tsconfigPath;
+    }
     const parsedTSConfig = readTsConfigWithRemappedPaths(tsconfigPath, tmpTsConfigPath, dependencies, workspaceRoot);
     process.on('exit', () => cleanupTmpTsConfigFile(tmpTsConfigPath));
     if (useWorkspaceAsBaseUrl) {

package/src/utils/typescript/ts-solution-setup.js

@@ -128,16 +128,6 @@ function updateTsconfigFiles(tree, projectRoot, runtimeTsconfigFileName, compile
             return json;
         });
     }
-    if (tree.exists(tsconfigE2E)) {
-        // tsconfig.json for e2e projects need to have references array
-        (0, devkit_1.updateJson)(tree, tsconfigE2E, (json) => {
-            json.references ??= [];
-            const projectPath = (0, posix_1.relative)(e2eRoot, projectRoot);
-            if (!json.references.some((x) => x.path === projectPath))
-                json.references.push({ path: projectPath });
-            return json;
-        });
-    }
     if (tree.exists('tsconfig.json')) {
         (0, devkit_1.updateJson)(tree, 'tsconfig.json', (json) => {
             const projectPath = './' + projectRoot;