@nx/js 20.0.1 → 20.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "20.0.1",
+  "version": "20.0.2",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -39,8 +39,8 @@
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-typescript": "^7.22.5",
     "@babel/runtime": "^7.22.6",
-    "@nx/devkit": "20.0.1",
-    "@nx/workspace": "20.0.1",
+    "@nx/devkit": "20.0.2",
+    "@nx/workspace": "20.0.2",
     "@zkochan/js-yaml": "0.0.7",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^2.8.0",

package/src/executors/node/lib/kill-tree.js

@@ -20,7 +20,7 @@ async function killTree(pid, signal) {
         switch (process.platform) {
             case 'win32':
                 (0, child_process_1.exec)('taskkill /pid ' + pid + ' /T /F', {
-                    windowsHide: true,
+                    windowsHide: false,
                 }, (error) => {
                     // Ignore Fatal errors (128) because it might be due to the process already being killed.
                     // On Linux/Mac we can check ESRCH (no such process), but on Windows we can't.
@@ -30,7 +30,7 @@ async function killTree(pid, signal) {
             case 'darwin':
                 buildProcessTree(pid, tree, pidsToProcess, function (parentPid) {
                     return (0, child_process_1.spawn)('pgrep', ['-P', parentPid], {
-                        windowsHide: true,
+                        windowsHide: false,
                     });
                 }, function () {
                     killAll(tree, signal, callback);
@@ -39,7 +39,7 @@ async function killTree(pid, signal) {
             default: // Linux
                 buildProcessTree(pid, tree, pidsToProcess, function (parentPid) {
                     return (0, child_process_1.spawn)('ps', ['-o', 'pid', '--no-headers', '--ppid', parentPid], {
-                        windowsHide: true,
+                        windowsHide: false,
                     });
                 }, function () {
                     killAll(tree, signal, callback);

package/src/executors/release-publish/release-publish.impl.js

@@ -96,7 +96,7 @@ Please update the local dependency on "${depName}" to be a valid semantic versio
                 env: processEnv(true),
                 cwd: context.root,
                 stdio: ['ignore', 'pipe', 'pipe'],
-                windowsHide: true,
+                windowsHide: false,
             });
             const resultJson = JSON.parse(result.toString());
             const distTags = resultJson['dist-tags'] || {};
@@ -117,7 +117,7 @@ Please update the local dependency on "${depName}" to be a valid semantic versio
                             env: processEnv(true),
                             cwd: context.root,
                             stdio: 'ignore',
-                            windowsHide: true,
+                            windowsHide: false,
                         });
                         console.log(`Added the dist-tag ${tag} to v${currentVersion} for registry ${registry}.\n`);
                     }
@@ -204,7 +204,7 @@ Please update the local dependency on "${depName}" to be a valid semantic versio
             env: processEnv(true),
             cwd: context.root,
             stdio: ['ignore', 'pipe', 'pipe'],
-            windowsHide: true,
+            windowsHide: false,
         });
         /**
          * We cannot JSON.parse the output directly because if the user is using lifecycle scripts, npm/pnpm will mix its publish output with the JSON output all on stdout.

package/src/executors/verdaccio/verdaccio.impl.js

@@ -38,12 +38,12 @@ async function verdaccioExecutor(options, context) {
     }
     const cleanupFunctions = options.location === 'none' ? [] : [setupNpm(options), setupYarn(options)];
     const processExitListener = (signal) => {
-        if (childProcess) {
-            childProcess.kill(signal);
-        }
         for (const fn of cleanupFunctions) {
             fn();
         }
+        if (childProcess) {
+            childProcess.kill(signal);
+        }
     };
     process.on('exit', processExitListener);
     process.on('SIGTERM', processExitListener);
@@ -113,7 +113,7 @@ function createVerdaccioOptions(options, workspaceRoot) {
 }
 function setupNpm(options) {
     try {
-        (0, child_process_1.execSync)('npm --version', { env, windowsHide: true });
+        (0, child_process_1.execSync)('npm --version', { env, windowsHide: false });
     }
     catch (e) {
         return () => { };
@@ -124,13 +124,13 @@ function setupNpm(options) {
         scopes.forEach((scope) => {
             const registryName = scope ? `${scope}:registry` : 'registry';
             try {
-                npmRegistryPaths.push((0, child_process_1.execSync)(`npm config get ${registryName} --location ${options.location}`, { env, windowsHide: true })
+                npmRegistryPaths.push((0, child_process_1.execSync)(`npm config get ${registryName} --location ${options.location}`, { env, windowsHide: false })
                     ?.toString()
                     ?.trim()
                     ?.replace('\u001b[2K\u001b[1G', '') // strip out ansi codes
                 );
-                (0, child_process_1.execSync)(`npm config set ${registryName} http://localhost:${options.port}/ --location ${options.location}`, { env, windowsHide: true });
-                (0, child_process_1.execSync)(`npm config set //localhost:${options.port}/:_authToken="secretVerdaccioToken" --location ${options.location}`, { env, windowsHide: true });
+                (0, child_process_1.execSync)(`npm config set ${registryName} http://localhost:${options.port}/ --location ${options.location}`, { env, windowsHide: false });
+                (0, child_process_1.execSync)(`npm config set //localhost:${options.port}/:_authToken="secretVerdaccioToken" --location ${options.location}`, { env, windowsHide: false });
                 devkit_1.logger.info(`Set npm ${registryName} to http://localhost:${options.port}/`);
             }
             catch (e) {
@@ -139,7 +139,7 @@ function setupNpm(options) {
         });
         return () => {
             try {
-                const currentNpmRegistryPath = (0, child_process_1.execSync)(`npm config get registry --location ${options.location}`, { env, windowsHide: true })
+                const currentNpmRegistryPath = (0, child_process_1.execSync)(`npm config get registry --location ${options.location}`, { env, windowsHide: false })
                     ?.toString()
                     ?.trim()
                     ?.replace('\u001b[2K\u001b[1G', ''); // strip out ansi codes
@@ -147,18 +147,18 @@ function setupNpm(options) {
                     const registryName = scope ? `${scope}:registry` : 'registry';
                     if (npmRegistryPaths[index] &&
                         currentNpmRegistryPath.includes('localhost')) {
-                        (0, child_process_1.execSync)(`npm config set ${registryName} ${npmRegistryPaths[index]} --location ${options.location}`, { env, windowsHide: true });
+                        (0, child_process_1.execSync)(`npm config set ${registryName} ${npmRegistryPaths[index]} --location ${options.location}`, { env, windowsHide: false });
                         devkit_1.logger.info(`Reset npm ${registryName} to ${npmRegistryPaths[index]}`);
                     }
                     else {
                         (0, child_process_1.execSync)(`npm config delete ${registryName} --location ${options.location}`, {
                             env,
-                            windowsHide: true,
+                            windowsHide: false,
                         });
                         devkit_1.logger.info('Cleared custom npm registry');
                     }
                 });
-                (0, child_process_1.execSync)(`npm config delete //localhost:${options.port}/:_authToken  --location ${options.location}`, { env, windowsHide: true });
+                (0, child_process_1.execSync)(`npm config delete //localhost:${options.port}/:_authToken  --location ${options.location}`, { env, windowsHide: false });
             }
             catch (e) {
                 throw new Error(`Failed to reset npm registry: ${e.message}`);
@@ -173,17 +173,17 @@ function getYarnUnsafeHttpWhitelist(isYarnV1) {
     return !isYarnV1
         ? new Set(JSON.parse((0, child_process_1.execSync)(`yarn config get unsafeHttpWhitelist --json`, {
             env,
-            windowsHide: true,
+            windowsHide: false,
         }).toString()))
         : null;
 }
 function setYarnUnsafeHttpWhitelist(currentWhitelist, options) {
     if (currentWhitelist.size > 0) {
-        (0, child_process_1.execSync)(`yarn config set unsafeHttpWhitelist --json '${JSON.stringify(Array.from(currentWhitelist))}'` + (options.location === 'user' ? ' --home' : ''), { env, windowsHide: true });
+        (0, child_process_1.execSync)(`yarn config set unsafeHttpWhitelist --json '${JSON.stringify(Array.from(currentWhitelist))}'` + (options.location === 'user' ? ' --home' : ''), { env, windowsHide: false });
     }
     else {
         (0, child_process_1.execSync)(`yarn config unset unsafeHttpWhitelist` +
-            (options.location === 'user' ? ' --home' : ''), { env, windowsHide: true });
+            (options.location === 'user' ? ' --home' : ''), { env, windowsHide: false });
     }
 }
 function setupYarn(options) {
@@ -192,7 +192,9 @@ function setupYarn(options) {
     const scopes = ['', ...(options.scopes || [])];
     try {
         isYarnV1 =
-            (0, semver_1.major)((0, child_process_1.execSync)('yarn --version', { env, windowsHide: true }).toString().trim()) === 1;
+            (0, semver_1.major)((0, child_process_1.execSync)('yarn --version', { env, windowsHide: false })
+                .toString()
+                .trim()) === 1;
     }
     catch {
         // This would fail if yarn is not installed which is okay
@@ -204,14 +206,14 @@ function setupYarn(options) {
             const scopeName = scope ? `${scope}:` : '';
             yarnRegistryPaths.push((0, child_process_1.execSync)(`yarn config get ${scopeName}${registryConfigName}`, {
                 env,
-                windowsHide: true,
+                windowsHide: false,
             })
                 ?.toString()
                 ?.trim()
                 ?.replace('\u001b[2K\u001b[1G', '') // strip out ansi codes
             );
             (0, child_process_1.execSync)(`yarn config set ${scopeName}${registryConfigName} http://localhost:${options.port}/` +
-                (options.location === 'user' ? ' --home' : ''), { env, windowsHide: true });
+                (options.location === 'user' ? ' --home' : ''), { env, windowsHide: false });
             devkit_1.logger.info(`Set yarn ${scopeName}registry to http://localhost:${options.port}/`);
         });
         const currentWhitelist = getYarnUnsafeHttpWhitelist(isYarnV1);
@@ -224,7 +226,7 @@ function setupYarn(options) {
         }
         return () => {
             try {
-                const currentYarnRegistryPath = (0, child_process_1.execSync)(`yarn config get ${registryConfigName}`, { env, windowsHide: true })
+                const currentYarnRegistryPath = (0, child_process_1.execSync)(`yarn config get ${registryConfigName}`, { env, windowsHide: false })
                     ?.toString()
                     ?.trim()
                     ?.replace('\u001b[2K\u001b[1G', ''); // strip out ansi codes
@@ -237,13 +239,13 @@ function setupYarn(options) {
                         (0, child_process_1.execSync)(`yarn config set ${registryName} ${yarnRegistryPaths[index]}` +
                             (options.location === 'user' ? ' --home' : ''), {
                             env,
-                            windowsHide: true,
+                            windowsHide: false,
                         });
                         devkit_1.logger.info(`Reset yarn ${registryName} to ${yarnRegistryPaths[index]}`);
                     }
                     else {
                         (0, child_process_1.execSync)(`yarn config ${isYarnV1 ? 'delete' : 'unset'} ${registryName}` +
-                            (options.location === 'user' ? ' --home' : ''), { env, windowsHide: true });
+                            (options.location === 'user' ? ' --home' : ''), { env, windowsHide: false });
                         devkit_1.logger.info(`Cleared custom yarn ${registryConfigName}`);
                     }
                 });

package/src/generators/release-version/release-version.js

@@ -121,7 +121,7 @@ To fix this you will either need to add a package.json file at that location, or
                             // Must be non-blocking async to allow spinner to render
                             currentVersion = await new Promise((resolve, reject) => {
                                 (0, node_child_process_1.exec)(`npm view ${packageName} version --"${registryConfigKey}=${registry}" --tag=${tag}`, {
-                                    windowsHide: true,
+                                    windowsHide: false,
                                 }, (error, stdout, stderr) => {
                                     if (error) {
                                         return reject(error);

package/src/generators/release-version/utils/update-lock-file.js

@@ -89,7 +89,7 @@ function execLockFileUpdate(command, cwd, env = {}) {
                 ...process.env,
                 ...env,
             },
-            windowsHide: true,
+            windowsHide: false,
         });
     }
     catch (e) {

package/src/generators/setup-verdaccio/generator.js

@@ -10,7 +10,7 @@ async function setupVerdaccio(tree, options) {
     if (!tree.exists('.verdaccio/config.yml')) {
         (0, devkit_1.generateFiles)(tree, path.join(__dirname, 'files'), '.verdaccio', {
             npmUplinkRegistry: (0, child_process_1.execSync)('npm config get registry', {
-                windowsHide: true,
+                windowsHide: false,
             })
                 ?.toString()
                 ?.trim() ?? 'https://registry.npmjs.org',

package/src/plugins/jest/start-local-registry.js

@@ -28,7 +28,7 @@ function startLocalRegistry({ localRegistryTarget, storage, verbose, clearStorag
                 const registry = `http://localhost:${port}`;
                 process.env.npm_config_registry = registry;
                 (0, child_process_1.execSync)(`npm config set //localhost:${port}/:_authToken "secretVerdaccioToken"`, {
-                    windowsHide: true,
+                    windowsHide: false,
                 });
                 // yarnv1
                 process.env.YARN_REGISTRY = registry;
@@ -39,7 +39,7 @@ function startLocalRegistry({ localRegistryTarget, storage, verbose, clearStorag
                 resolve(() => {
                     childProcess.kill();
                     (0, child_process_1.execSync)(`npm config delete //localhost:${port}/:_authToken`, {
-                        windowsHide: true,
+                        windowsHide: false,
                     });
                 });
                 childProcess?.stdout?.off('data', listener);

package/src/utils/npm-config.js

@@ -76,7 +76,7 @@ async function getNpmConfigValue(key, cwd) {
 async function execAsync(command, cwd) {
     // Must be non-blocking async to allow spinner to render
     return new Promise((resolve, reject) => {
-        (0, child_process_1.exec)(command, { cwd, windowsHide: true }, (error, stdout, stderr) => {
+        (0, child_process_1.exec)(command, { cwd, windowsHide: false }, (error, stdout, stderr) => {
             if (error) {
                 return reject(error);
             }

package/src/utils/swc/compile-swc.js

@@ -62,7 +62,7 @@ async function compileSwc(context, normalizedOptions, postCompilationCallback) {
     const swcCmdLog = (0, node_child_process_1.execSync)(getSwcCmd(normalizedOptions), {
         encoding: 'utf8',
         cwd: normalizedOptions.swcCliOptions.swcCwd,
-        windowsHide: true,
+        windowsHide: false,
     });
     devkit_1.logger.log(swcCmdLog.replace(/\n/, ''));
     const isCompileSuccess = swcCmdLog.includes('Successfully compiled');
@@ -99,7 +99,7 @@ async function* compileSwcWatch(context, normalizedOptions, postCompilationCallb
         let watcherOnExit;
         const swcWatcher = (0, node_child_process_1.exec)(getSwcCmd(normalizedOptions, true), {
             cwd: normalizedOptions.swcCliOptions.swcCwd,
-            windowsHide: true,
+            windowsHide: false,
         });
         processOnExit = () => {
             swcWatcher.kill();