@nx/js 19.8.1 → 19.8.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "19.8.1",
+  "version": "19.8.3",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -39,8 +39,8 @@
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-typescript": "^7.22.5",
     "@babel/runtime": "^7.22.6",
-    "@nx/devkit": "19.8.1",
-    "@nx/workspace": "19.8.1",
+    "@nx/devkit": "19.8.3",
+    "@nx/workspace": "19.8.3",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^2.8.0",
     "babel-plugin-transform-typescript-metadata": "^0.3.1",
@@ -61,7 +61,7 @@
     "ts-node": "10.9.1",
     "tsconfig-paths": "^4.1.2",
     "tslib": "^2.3.0",
-    "@nrwl/js": "19.8.1"
+    "@nrwl/js": "19.8.3"
   },
   "peerDependencies": {
     "verdaccio": "^5.0.4"

package/src/generators/init/init.js

@@ -109,6 +109,15 @@ async function initGeneratorInternal(tree, schema) {
             return json;
         });
     }
+    const rootTsConfigFileName = (0, ts_config_1.getRootTsConfigFileName)(tree);
+    // If the root tsconfig file uses `importHelpers` then we must install tslib
+    // in order to run tsc for build and typecheck.
+    if (rootTsConfigFileName) {
+        const rootTsConfig = (0, devkit_1.readJson)(tree, rootTsConfigFileName);
+        if (rootTsConfig.compilerOptions?.importHelpers) {
+            devDependencies['tslib'] = versions_1.tsLibVersion;
+        }
+    }
     const installTask = !schema.skipPackageJson
         ? (0, devkit_1.addDependenciesToPackageJson)(tree, {}, devDependencies, undefined, schema.keepExistingVersions)
         : () => { };

package/src/generators/library/library.js

@@ -105,9 +105,6 @@ async function libraryGeneratorInternal(tree, schema) {
             (0, devkit_1.joinPathFragments)(options.projectRoot, './src', 'index.' + (options.js ? 'js' : 'ts')),
         ]);
     }
-    if (options.bundler !== 'none') {
-        addBundlerDependencies(tree, options);
-    }
     if (!options.skipFormat) {
         await (0, devkit_1.formatFiles)(tree);
     }
@@ -269,23 +266,6 @@ async function addLint(tree, options) {
     }
     return task;
 }
-function addBundlerDependencies(tree, options) {
-    (0, devkit_1.updateJson)(tree, `${options.projectRoot}/package.json`, (json) => {
-        if (options.bundler === 'tsc') {
-            json.dependencies = {
-                ...json.dependencies,
-                tslib: versions_1.tsLibVersion,
-            };
-        }
-        else if (options.bundler === 'swc') {
-            json.dependencies = {
-                ...json.dependencies,
-                '@swc/helpers': versions_1.swcHelpersVersion,
-            };
-        }
-        return json;
-    });
-}
 function updateTsConfig(tree, options) {
     (0, devkit_1.updateJson)(tree, (0, path_1.join)(options.projectRoot, 'tsconfig.json'), (json) => {
         if (options.strict) {

package/src/generators/typescript-sync/typescript-sync.d.ts

@@ -1,4 +1,4 @@
 import { type Tree } from '@nx/devkit';
-import type { SyncGeneratorResult } from 'nx/src/utils/sync-generators';
+import { type SyncGeneratorResult } from 'nx/src/utils/sync-generators';
 export declare function syncGenerator(tree: Tree): Promise<SyncGeneratorResult>;
 export default syncGenerator;

package/src/generators/typescript-sync/typescript-sync.js

@@ -5,6 +5,7 @@ const devkit_1 = require("@nx/devkit");
 const ignore_1 = require("ignore");
 const jsonc_parser_1 = require("jsonc-parser");
 const posix_1 = require("node:path/posix");
+const sync_generators_1 = require("nx/src/utils/sync-generators");
 const ts = require("typescript");
 const plugin_1 = require("../../plugins/typescript/plugin");
 const COMMON_RUNTIME_TS_CONFIG_FILE_NAMES = [
@@ -25,12 +26,16 @@ async function syncGenerator(tree) {
         return p.plugin === plugin_1.PLUGIN_NAME;
     });
     if (!tscPluginConfig) {
-        throw new Error(`The ${plugin_1.PLUGIN_NAME} plugin must be added to the "plugins" array in nx.json before syncing tsconfigs`);
+        throw new sync_generators_1.SyncError(`The "${plugin_1.PLUGIN_NAME}" plugin is not registered`, [
+            `The "${plugin_1.PLUGIN_NAME}" plugin must be added to the "plugins" array in "nx.json" in order to sync the project graph information to the TypeScript configuration files.`,
+        ]);
     }
     // Root tsconfig containing project references for the whole workspace
     const rootTsconfigPath = 'tsconfig.json';
     if (!tree.exists(rootTsconfigPath)) {
-        throw new Error(`A "tsconfig.json" file must exist in the workspace root in order to use this sync generator.`);
+        throw new sync_generators_1.SyncError('Missing root "tsconfig.json"', [
+            `A "tsconfig.json" file must exist in the workspace root in order to sync the project graph information to the TypeScript configuration files.`,
+        ]);
     }
     const rawTsconfigContentsCache = new Map();
     const stringifiedRootJsonContents = readRawTsconfigContents(tree, rawTsconfigContentsCache, rootTsconfigPath);
@@ -128,7 +133,7 @@ async function syncGenerator(tree) {
     if (hasChanges) {
         await (0, devkit_1.formatFiles)(tree);
         return {
-            outOfSyncMessage: 'Based on the workspace project graph, some TypeScript configuration files are missing project references to the projects they depend on.',
+            outOfSyncMessage: 'Based on the workspace project graph, some TypeScript configuration files are missing project references to the projects they depend on or contain outdated project references.',
         };
     }
 }