@nx/js 19.7.0-beta.3 → 19.7.0-beta.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "19.7.0-beta.3",
+  "version": "19.7.0-beta.5",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -39,8 +39,8 @@
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-typescript": "^7.22.5",
     "@babel/runtime": "^7.22.6",
-    "@nx/devkit": "19.7.0-beta.3",
-    "@nx/workspace": "19.7.0-beta.3",
+    "@nx/devkit": "19.7.0-beta.5",
+    "@nx/workspace": "19.7.0-beta.5",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^2.8.0",
     "babel-plugin-transform-typescript-metadata": "^0.3.1",
@@ -61,7 +61,7 @@
     "ts-node": "10.9.1",
     "tsconfig-paths": "^4.1.2",
     "tslib": "^2.3.0",
-    "@nrwl/js": "19.7.0-beta.3"
+    "@nrwl/js": "19.7.0-beta.5"
   },
   "peerDependencies": {
     "verdaccio": "^5.0.4"

package/src/executors/node/node-with-require-overrides.d.ts

@@ -1,4 +1,7 @@
+declare const Module: any;
 declare const url: any;
-declare const patchSigint: any;
-declare const patchRequire: any;
+declare const originalLoader: any;
 declare const dynamicImport: Function;
+declare const mappings: any;
+declare const keys: string[];
+declare const fileToRun: any;

package/src/executors/node/node-with-require-overrides.js

@@ -1,7 +1,21 @@
+const Module = require('module');
 const url = require('node:url');
-const { patchSigint } = require('./patch-sigint');
-const { patchRequire } = require('./patch-require');
-patchSigint();
-patchRequire();
+const originalLoader = Module._load;
 const dynamicImport = new Function('specifier', 'return import(specifier)');
-dynamicImport(url.pathToFileURL(process.env.NX_FILE_TO_RUN));
+const mappings = JSON.parse(process.env.NX_MAPPINGS);
+const keys = Object.keys(mappings);
+const fileToRun = url.pathToFileURL(process.env.NX_FILE_TO_RUN);
+Module._load = function (request, parent) {
+    if (!parent)
+        return originalLoader.apply(this, arguments);
+    const match = keys.find((k) => request === k);
+    if (match) {
+        const newArguments = [...arguments];
+        newArguments[0] = mappings[match];
+        return originalLoader.apply(this, newArguments);
+    }
+    else {
+        return originalLoader.apply(this, arguments);
+    }
+};
+dynamicImport(fileToRun);

package/src/executors/node/node.impl.js

@@ -111,14 +111,11 @@ async function* nodeExecutor(options, context) {
                         task.childProcess.stderr.on('data', handleStdErr);
                         task.childProcess.once('exit', (code) => {
                             task.childProcess.off('data', handleStdErr);
-                            if (options.watch &&
-                                !task.killed &&
-                                // SIGINT should exist the process rather than watch for changes.
-                                code !== 130) {
+                            if (options.watch && !task.killed) {
                                 devkit_1.logger.info(`NX Process exited with code ${code}, waiting for changes to restart...`);
                             }
-                            if (!options.watch || code === 130) {
-                                if (code !== 0 && code !== 130) {
+                            if (!options.watch) {
+                                if (code !== 0) {
                                     error(new Error(`Process exited with code ${code}`));
                                 }
                                 else {
@@ -204,8 +201,10 @@ async function* nodeExecutor(options, context) {
                         devkit_1.logger.error(`Watch error: ${err?.message ?? 'Unknown'}`);
                     }
                     else {
-                        devkit_1.logger.info(`NX File change detected. Restarting...`);
-                        await runBuild();
+                        if (options.watch) {
+                            devkit_1.logger.info(`NX File change detected. Restarting...`);
+                            await runBuild();
+                        }
                     }
                 });
             }

package/src/executors/release-publish/release-publish.impl.js

@@ -163,6 +163,9 @@ async function runExecutor(options, context) {
     if (options.otp) {
         npmPublishCommandSegments.push(`--otp=${options.otp}`);
     }
+    if (options.access) {
+        npmPublishCommandSegments.push(`--access=${options.access}`);
+    }
     if (isDryRun) {
         npmPublishCommandSegments.push(`--dry-run`);
     }

package/src/executors/release-publish/schema.d.ts

@@ -4,5 +4,6 @@ export interface PublishExecutorSchema {
   tag?: string;
   otp?: number;
   dryRun?: boolean;
+  access?: 'public' | 'restricted';
   firstRelease?: boolean;
 }

package/src/executors/release-publish/schema.json

@@ -17,6 +17,11 @@
       "type": "string",
       "description": "The distribution tag to apply to the published package."
     },
+    "access": {
+      "type": "string",
+      "enum": ["public", "restricted"],
+      "description": "Overrides the access level of the published package. Unscoped packages cannot be set to restricted. See the npm publish documentation for more information."
+    },
     "dryRun": {
       "type": "boolean",
       "description": "Whether to run the command without actually publishing the package to the registry."

package/src/generators/release-version/release-version.js

@@ -468,6 +468,21 @@ To fix this you will either need to add a package.json file at that location, or
                     // Auto (i.e.infer existing) by default
                     let versionPrefix = options.versionPrefix ?? 'auto';
                     const currentDependencyVersion = json[dependentProject.dependencyCollection][dependencyPackageName];
+                    // Depending on the package manager, locally linked packages could reference packages with `"private": true` and no version field at all
+                    const currentPackageVersion = json.version ?? null;
+                    if (!currentPackageVersion &&
+                        isLocallyLinkedPackageVersion(currentDependencyVersion)) {
+                        if (forceVersionBump) {
+                            // Look up any dependent projects from the transitiveLocalPackageDependents list
+                            const transitiveDependentProjects = transitiveLocalPackageDependents.filter((localPackageDependency) => localPackageDependency.target === dependentProject.source);
+                            versionData[dependentProject.source] = {
+                                currentVersion: currentPackageVersion,
+                                newVersion: currentDependencyVersion,
+                                dependentProjects: transitiveDependentProjects,
+                            };
+                        }
+                        return json;
+                    }
                     // For auto, we infer the prefix based on the current version of the dependent
                     if (versionPrefix === 'auto') {
                         versionPrefix = ''; // we don't want to end up printing auto
@@ -487,7 +502,6 @@ To fix this you will either need to add a package.json file at that location, or
                         newDepVersion;
                     // Bump the dependent's version if applicable and record it in the version data
                     if (forceVersionBump) {
-                        const currentPackageVersion = json.version;
                         const newPackageVersion = (0, version_1.deriveNewSemverVersion)(currentPackageVersion, forceVersionBump, options.preid);
                         json.version = newPackageVersion;
                         // Look up any dependent projects from the transitiveLocalPackageDependents list
@@ -655,3 +669,33 @@ class ProjectLogger {
         });
     }
 }
+let pm;
+let pmVersion;
+const localPackageProtocols = [
+    'file:', // all package managers
+    'workspace:', // not npm
+    'portal:', // modern yarn only
+];
+function isLocallyLinkedPackageVersion(version) {
+    // Not using a supported local protocol
+    if (!localPackageProtocols.some((protocol) => version.startsWith(protocol))) {
+        return false;
+    }
+    // Supported by all package managers
+    if (version.startsWith('file:')) {
+        return true;
+    }
+    // Determine specific package manager in use
+    if (!pm) {
+        pm = (0, devkit_1.detectPackageManager)();
+        pmVersion = (0, devkit_1.getPackageManagerVersion)(pm);
+    }
+    if (pm === 'npm' && version.startsWith('workspace:')) {
+        throw new Error(`The "workspace:" protocol is not yet supported by npm (https://github.com/npm/rfcs/issues/765). Please ensure you have a valid setup according to your package manager before attempting to release packages.`);
+    }
+    if (version.startsWith('portal:') &&
+        (pm !== 'yarn' || (0, semver_2.lt)(pmVersion, '2.0.0'))) {
+        throw new Error(`The "portal:" protocol is only supported by yarn@2.0.0 and above. Please ensure you have a valid setup according to your package manager before attempting to release packages.`);
+    }
+    return true;
+}

package/src/executors/node/patch-require.d.ts

@@ -1,5 +0,0 @@
-/**
- * Overrides require calls to map buildable workspace libs to their output location.
- * This is useful for running programs compiled via TSC/SWC that aren't bundled.
- */
-export declare function patchRequire(): void;

package/src/executors/node/patch-require.js

@@ -1,26 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.patchRequire = patchRequire;
-const Module = require('node:module');
-const originalLoader = Module._load;
-/**
- * Overrides require calls to map buildable workspace libs to their output location.
- * This is useful for running programs compiled via TSC/SWC that aren't bundled.
- */
-function patchRequire() {
-    const mappings = JSON.parse(process.env.NX_MAPPINGS);
-    const keys = Object.keys(mappings);
-    Module._load = function (request, parent) {
-        if (!parent)
-            return originalLoader.apply(this, arguments);
-        const match = keys.find((k) => request === k);
-        if (match) {
-            const newArguments = [...arguments];
-            newArguments[0] = mappings[match];
-            return originalLoader.apply(this, newArguments);
-        }
-        else {
-            return originalLoader.apply(this, arguments);
-        }
-    };
-}

package/src/executors/node/patch-sigint.d.ts

@@ -1,5 +0,0 @@
-/**
- * Patches the current process so that Ctrl+C is properly handled.
- * Without this patch, SIGINT or Ctrl+C does not wait for graceful shutdown and exits immediately.
- */
-export declare function patchSigint(): void;

package/src/executors/node/patch-sigint.js

@@ -1,24 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.patchSigint = patchSigint;
-const readline = require('node:readline');
-/**
- * Patches the current process so that Ctrl+C is properly handled.
- * Without this patch, SIGINT or Ctrl+C does not wait for graceful shutdown and exits immediately.
- */
-function patchSigint() {
-    readline.emitKeypressEvents(process.stdin);
-    if (process.stdin.isTTY)
-        process.stdin.setRawMode(true);
-    process.stdin.on('keypress', async (chunk, key) => {
-        if (key && key.ctrl && key.name === 'c') {
-            process.stdin.setRawMode(false); // To ensure nx terminal is not stuck in raw mode
-            const listeners = process.listeners('SIGINT');
-            for (const listener of listeners) {
-                await listener('SIGINT');
-            }
-            process.exit(130);
-        }
-    });
-    console.log('To exit the process, press Ctrl+C');
-}