@nx/js 19.6.4 → 19.6.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "19.6.4",
+  "version": "19.6.5",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -39,8 +39,8 @@
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-typescript": "^7.22.5",
     "@babel/runtime": "^7.22.6",
-    "@nx/devkit": "19.6.4",
-    "@nx/workspace": "19.6.4",
+    "@nx/devkit": "19.6.5",
+    "@nx/workspace": "19.6.5",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^2.8.0",
     "babel-plugin-transform-typescript-metadata": "^0.3.1",
@@ -61,7 +61,7 @@
     "ts-node": "10.9.1",
     "tsconfig-paths": "^4.1.2",
     "tslib": "^2.3.0",
-    "@nrwl/js": "19.6.4"
+    "@nrwl/js": "19.6.5"
   },
   "peerDependencies": {
     "verdaccio": "^5.0.4"

package/src/generators/release-version/release-version.js

@@ -468,6 +468,21 @@ To fix this you will either need to add a package.json file at that location, or
                     // Auto (i.e.infer existing) by default
                     let versionPrefix = options.versionPrefix ?? 'auto';
                     const currentDependencyVersion = json[dependentProject.dependencyCollection][dependencyPackageName];
+                    // Depending on the package manager, locally linked packages could reference packages with `"private": true` and no version field at all
+                    const currentPackageVersion = json.version ?? null;
+                    if (!currentPackageVersion &&
+                        isLocallyLinkedPackageVersion(currentDependencyVersion)) {
+                        if (forceVersionBump) {
+                            // Look up any dependent projects from the transitiveLocalPackageDependents list
+                            const transitiveDependentProjects = transitiveLocalPackageDependents.filter((localPackageDependency) => localPackageDependency.target === dependentProject.source);
+                            versionData[dependentProject.source] = {
+                                currentVersion: currentPackageVersion,
+                                newVersion: currentDependencyVersion,
+                                dependentProjects: transitiveDependentProjects,
+                            };
+                        }
+                        return json;
+                    }
                     // For auto, we infer the prefix based on the current version of the dependent
                     if (versionPrefix === 'auto') {
                         versionPrefix = ''; // we don't want to end up printing auto
@@ -487,7 +502,6 @@ To fix this you will either need to add a package.json file at that location, or
                         newDepVersion;
                     // Bump the dependent's version if applicable and record it in the version data
                     if (forceVersionBump) {
-                        const currentPackageVersion = json.version;
                         const newPackageVersion = (0, version_1.deriveNewSemverVersion)(currentPackageVersion, forceVersionBump, options.preid);
                         json.version = newPackageVersion;
                         // Look up any dependent projects from the transitiveLocalPackageDependents list
@@ -655,3 +669,33 @@ class ProjectLogger {
         });
     }
 }
+let pm;
+let pmVersion;
+const localPackageProtocols = [
+    'file:', // all package managers
+    'workspace:', // not npm
+    'portal:', // modern yarn only
+];
+function isLocallyLinkedPackageVersion(version) {
+    // Not using a supported local protocol
+    if (!localPackageProtocols.some((protocol) => version.startsWith(protocol))) {
+        return false;
+    }
+    // Supported by all package managers
+    if (version.startsWith('file:')) {
+        return true;
+    }
+    // Determine specific package manager in use
+    if (!pm) {
+        pm = (0, devkit_1.detectPackageManager)();
+        pmVersion = (0, devkit_1.getPackageManagerVersion)(pm);
+    }
+    if (pm === 'npm' && version.startsWith('workspace:')) {
+        throw new Error(`The "workspace:" protocol is not yet supported by npm (https://github.com/npm/rfcs/issues/765). Please ensure you have a valid setup according to your package manager before attempting to release packages.`);
+    }
+    if (version.startsWith('portal:') &&
+        (pm !== 'yarn' || (0, semver_2.lt)(pmVersion, '2.0.0'))) {
+        throw new Error(`The "portal:" protocol is only supported by yarn@2.0.0 and above. Please ensure you have a valid setup according to your package manager before attempting to release packages.`);
+    }
+    return true;
+}