@nx/js 19.3.0-beta.0 → 19.3.0-beta.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "19.3.0-beta.0",
+  "version": "19.3.0-beta.1",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -58,9 +58,9 @@
     "semver": "^7.5.3",
     "source-map-support": "0.5.19",
     "tslib": "^2.3.0",
-    "@nx/devkit": "19.3.0-beta.0",
-    "@nx/workspace": "19.3.0-beta.0",
-    "@nrwl/js": "19.3.0-beta.0"
+    "@nx/devkit": "19.3.0-beta.1",
+    "@nx/workspace": "19.3.0-beta.1",
+    "@nrwl/js": "19.3.0-beta.1"
   },
   "peerDependencies": {
     "verdaccio": "^5.0.4"

package/src/executors/release-publish/release-publish.impl.js

@@ -80,7 +80,11 @@ async function runExecutor(options, context) {
                     success: true,
                 };
             }
-            if (resultJson.versions.includes(currentVersion)) {
+            // If only one version of a package exists in the registry, versions will be a string instead of an array.
+            const versions = Array.isArray(resultJson.versions)
+                ? resultJson.versions
+                : [resultJson.versions];
+            if (versions.includes(currentVersion)) {
                 try {
                     if (!isDryRun) {
                         (0, child_process_1.execSync)(npmDistTagAddCommandSegments.join(' '), {

package/src/executors/verdaccio/schema.d.ts

@@ -1,7 +1,7 @@
 export interface VerdaccioExecutorSchema {
   location: 'global' | 'user' | 'project' | 'none';
   storage?: string;
-  port: number;
+  port?: number;
   config?: string;
   clear?: boolean;
 }

package/src/executors/verdaccio/schema.json

@@ -18,8 +18,7 @@
     },
     "port": {
       "type": "number",
-      "description": "Port of local registry that Verdaccio should listen to",
-      "default": 4873
+      "description": "Port of local registry that Verdaccio should listen to"
     },
     "config": {
       "type": "string",

package/src/executors/verdaccio/verdaccio.impl.js

@@ -98,12 +98,15 @@ function startVerdaccio(options, workspaceRoot) {
 }
 function createVerdaccioOptions(options, workspaceRoot) {
     const verdaccioArgs = [];
-    if (options.port) {
-        verdaccioArgs.push('--listen', options.port.toString());
-    }
     if (options.config) {
         verdaccioArgs.push('--config', (0, path_1.join)(workspaceRoot, options.config));
     }
+    else {
+        options.port ??= 4873; // set default port if config is not provided
+    }
+    if (options.port) {
+        verdaccioArgs.push('--listen', options.port.toString());
+    }
     return verdaccioArgs;
 }
 function setupNpm(options) {

package/src/generators/release-version/release-version.js

@@ -255,7 +255,12 @@ To fix this you will either need to add a package.json file at that location, or
                             log(`📄 Resolved the specifier as "${specifier}" since the current version is a prerelease.`);
                         }
                         else {
-                            log(`📄 Resolved the specifier as "${specifier}" using git history and the conventional commits standard.`);
+                            let extraText = '';
+                            if (options.preid && !specifier.startsWith('pre')) {
+                                specifier = `pre${specifier}`;
+                                extraText = `, combined with your given preid "${options.preid}"`;
+                            }
+                            log(`📄 Resolved the specifier as "${specifier}" using git history and the conventional commits standard${extraText}.`);
                         }
                         break;
                     }

package/src/generators/release-version/utils/sort-projects-topologically.js

@@ -24,7 +24,9 @@ function sortProjectsTopologically(projectGraph, projectNodes) {
         const node = processQueue.shift();
         sortedProjects.push(node);
         // Process each project that depends on the current node
-        filteredDependencies.forEach((dep) => {
+        filteredDependencies
+            .filter((dep) => dep.target === node.name)
+            .forEach((dep) => {
             const dependentNode = projectGraph.nodes[dep.source];
             const count = edges.get(dependentNode) - 1;
             edges.set(dependentNode, count);

package/src/utils/typescript/create-ts-config.js

@@ -30,6 +30,10 @@ function extractTsConfigBase(host) {
             delete tsconfig.compilerOptions[compilerOption];
         }
     }
+    // If we don't set baseDir then builds will fail when more than one projects exist.
+    if (typeof baseCompilerOptions.baseUrl === 'undefined') {
+        baseCompilerOptions.baseUrl = '.';
+    }
     (0, json_1.writeJson)(host, 'tsconfig.base.json', {
         compileOnSave: false,
         compilerOptions: baseCompilerOptions,