@nx/js 18.3.0-beta.0 → 18.3.0-beta.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "18.3.0-beta.0",
+  "version": "18.3.0-beta.1",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -57,9 +57,9 @@
     "semver": "^7.5.3",
     "source-map-support": "0.5.19",
     "tslib": "^2.3.0",
-    "@nx/devkit": "18.3.0-beta.0",
-    "@nx/workspace": "18.3.0-beta.0",
-    "@nrwl/js": "18.3.0-beta.0"
+    "@nx/devkit": "18.3.0-beta.1",
+    "@nx/workspace": "18.3.0-beta.1",
+    "@nrwl/js": "18.3.0-beta.1"
   },
   "peerDependencies": {
     "verdaccio": "^5.0.4"

package/src/executors/node/node.impl.js

@@ -13,6 +13,7 @@ const buildable_libs_utils_1 = require("../../utils/buildable-libs-utils");
 const kill_tree_1 = require("./lib/kill-tree");
 const fileutils_1 = require("nx/src/utils/fileutils");
 const get_main_file_dir_1 = require("../../utils/get-main-file-dir");
+const utils_1 = require("nx/src/tasks-runner/utils");
 function debounce(fn, wait) {
     let timeoutId;
     return () => {
@@ -36,6 +37,7 @@ async function* nodeExecutor(options, context) {
     const buildOptions = {
         ...(0, devkit_1.readTargetOptions)(buildTarget, context),
         ...options.buildTargetOptions,
+        target: buildTarget.target,
     };
     if (options.waitUntilTargets && options.waitUntilTargets.length > 0) {
         const results = await runWaitUntilTargets(options, context);
@@ -112,8 +114,14 @@ async function* nodeExecutor(options, context) {
                             if (options.watch && !task.killed) {
                                 devkit_1.logger.info(`NX Process exited with code ${code}, waiting for changes to restart...`);
                             }
-                            if (!options.watch)
-                                done();
+                            if (!options.watch) {
+                                if (code !== 0) {
+                                    error(new Error(`Process exited with code ${code}`));
+                                }
+                                else {
+                                    done();
+                                }
+                            }
                             resolve();
                         });
                         next({ success: true, options: buildOptions });
@@ -257,6 +265,18 @@ function getFileToRun(context, project, buildOptions, buildTargetExecutor) {
     // If using run-commands or another custom executor, then user should set
     // outputFileName, but we can try the default value that we use.
     if (!buildOptions?.outputPath && !buildOptions?.outputFileName) {
+        // If we are using crystal for infering the target, we can use the output path from the target.
+        // Since the output path has a token for the project name, we need to interpolate it.
+        // {workspaceRoot}/dist/{projectRoot} -> dist/my-app
+        const outputPath = project.data.targets[buildOptions.target]?.outputs?.[0];
+        if (outputPath) {
+            const outputFilePath = (0, utils_1.interpolate)(outputPath, {
+                projectName: project.name,
+                projectRoot: project.data.root,
+                workspaceRoot: '',
+            });
+            return path.join(outputFilePath, 'main.js');
+        }
         const fallbackFile = path.join('dist', project.data.root, 'main.js');
         devkit_1.logger.warn(`Build option ${chalk.bold('outputFileName')} not set for ${chalk.bold(project.name)}. Using fallback value of ${chalk.bold(fallbackFile)}.`);
         return (0, path_1.join)(context.root, fallbackFile);