@nx/js 18.2.0-beta.0 → 18.2.0-beta.2

package/LICENSE

@@ -1,6 +1,6 @@
 (The MIT License)
 
-Copyright (c) 2017-2023 Narwhal Technologies Inc.
+Copyright (c) 2017-2024 Narwhal Technologies Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

package/babel.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const path_1 = require("path");
+const semver_1 = require("semver");
 const devkit_1 = require("@nx/devkit");
 module.exports = function (api, options = {}) {
     api.assertVersion(7);
@@ -27,22 +28,7 @@ module.exports = function (api, options = {}) {
                 // such as import syntax.
                 isTest || process.env.NODE_ENV === 'test' || process.env.JEST_WORKER_ID
                     ? { targets: { node: 'current' }, loose: true }
-                    : {
-                        // Allow importing core-js in entrypoint and use browserslist to select polyfills.
-                        useBuiltIns: options.useBuiltIns ?? 'entry',
-                        corejs: options.useBuiltIns !== false
-                            ? // Setting the minor version as well for better optimization (See: https://github.com/zloirock/core-js#babelpreset-env)
-                                '3.36'
-                            : null,
-                        // Do not transform modules to CJS
-                        modules: false,
-                        targets: isModern ? { esmodules: 'intersect' } : undefined,
-                        bugfixes: true,
-                        // Exclude transforms that make all code slower
-                        exclude: ['transform-typeof-symbol'],
-                        // This must match the setting for `@babel/plugin-proposal-class-properties`
-                        loose,
-                    },
+                    : createBabelPresetEnvOptions(options.useBuiltIns, isModern, loose),
             ],
             [
                 require.resolve('@babel/preset-typescript'),
@@ -92,3 +78,34 @@ module.exports = function (api, options = {}) {
         ],
     };
 };
+function createBabelPresetEnvOptions(useBuiltIns, isModern, loose) {
+    const presetOptions = {
+        // Do not transform modules to CJS
+        modules: false,
+        targets: isModern ? { esmodules: 'intersect' } : undefined,
+        bugfixes: true,
+        // Exclude transforms that make all code slower
+        exclude: ['transform-typeof-symbol'],
+        // This must match the setting for `@babel/plugin-proposal-class-properties`
+        loose,
+    };
+    // If core-js is installed then set corresponding options, otherwise don't use core-js.
+    // Previously, core-js was required for all projects, but it is not longer required when using only stable JS features that does not need to be transpiled.
+    const coreJsVersion = findCoreJsVersion();
+    if (coreJsVersion) {
+        presetOptions.useBuiltIns = useBuiltIns ?? 'entry';
+        presetOptions.corejs = useBuiltIns !== false ? coreJsVersion : null;
+    }
+    return presetOptions;
+}
+function findCoreJsVersion() {
+    try {
+        // nx-ignore-next-line
+        const v = require('core-js/package.json').version;
+        const { major, minor } = (0, semver_1.parse)(v);
+        return `${major}.${minor}`;
+    }
+    catch (e) {
+        return null;
+    }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "18.2.0-beta.0",
+  "version": "18.2.0-beta.2",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -57,9 +57,9 @@
     "semver": "^7.5.3",
     "source-map-support": "0.5.19",
     "tslib": "^2.3.0",
-    "@nx/devkit": "18.2.0-beta.0",
-    "@nx/workspace": "18.2.0-beta.0",
-    "@nrwl/js": "18.2.0-beta.0"
+    "@nx/devkit": "18.2.0-beta.2",
+    "@nx/workspace": "18.2.0-beta.2",
+    "@nrwl/js": "18.2.0-beta.2"
   },
   "peerDependencies": {
     "verdaccio": "^5.0.4"

package/src/utils/find-npm-dependencies.js

@@ -121,8 +121,9 @@ function collectHelperDependencies(workspaceRoot, sourceProject, projectGraph, b
         return;
     if (target.executor === '@nx/js:tsc' && target.options?.tsConfig) {
         const tsConfig = (0, ts_config_1.readTsConfig)((0, path_1.join)(workspaceRoot, target.options.tsConfig));
-        if (tsConfig?.options['importHelpers']) {
-            npmDeps['tslib'] = projectGraph.externalNodes['npm:tslib']?.data.version;
+        if (tsConfig?.options['importHelpers'] &&
+            projectGraph.externalNodes['npm:tslib']?.type === 'npm') {
+            npmDeps['tslib'] = projectGraph.externalNodes['npm:tslib'].data.version;
         }
     }
     if (target.executor === '@nx/js:swc') {
@@ -132,9 +133,10 @@ function collectHelperDependencies(workspaceRoot, sourceProject, projectGraph, b
         const swcConfig = (0, fileutils_1.fileExists)(swcConfigPath)
             ? (0, devkit_1.readJsonFile)(swcConfigPath)
             : {};
-        if (swcConfig?.jsc?.externalHelpers) {
+        if (swcConfig?.jsc?.externalHelpers &&
+            projectGraph.externalNodes['npm:@swc/helpers']?.type === 'npm') {
             npmDeps['@swc/helpers'] =
-                projectGraph.externalNodes['npm:@swc/helpers']?.data.version;
+                projectGraph.externalNodes['npm:@swc/helpers'].data.version;
         }
     }
 }