@nx/js 17.2.6 → 17.2.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "17.2.6",
+  "version": "17.2.8",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -57,9 +57,9 @@
     "semver": "7.5.3",
     "source-map-support": "0.5.19",
     "tslib": "^2.3.0",
-    "@nx/devkit": "17.2.6",
-    "@nx/workspace": "17.2.6",
-    "@nrwl/js": "17.2.6"
+    "@nx/devkit": "17.2.8",
+    "@nx/workspace": "17.2.8",
+    "@nrwl/js": "17.2.8"
   },
   "peerDependencies": {
     "verdaccio": "^5.0.4"

package/src/executors/release-publish/release-publish.impl.js

@@ -17,6 +17,11 @@ function processEnv(color) {
     return env;
 }
 async function runExecutor(options, context) {
+    /**
+     * We need to check both the env var and the option because the executor may have been triggered
+     * indirectly via dependsOn, in which case the env var will be set, but the option will not.
+     */
+    const isDryRun = process.env.NX_DRY_RUN === 'true' || options.dryRun || false;
     const projectConfig = context.projectsConfigurations.projects[context.projectName];
     const packageRoot = (0, devkit_1.joinPathFragments)(context.root, options.packageRoot ?? projectConfig.root);
     const packageJsonPath = (0, devkit_1.joinPathFragments)(packageRoot, 'package.json');
@@ -46,7 +51,7 @@ async function runExecutor(options, context) {
     if (options.otp) {
         npmPublishCommandSegments.push(`--otp=${options.otp}`);
     }
-    if (options.dryRun) {
+    if (isDryRun) {
         npmPublishCommandSegments.push(`--dry-run`);
     }
     // Resolve values using the `npm config` command so that things like environment variables and `publishConfig`s are accounted for
@@ -60,7 +65,7 @@ async function runExecutor(options, context) {
      * Therefore, so as to not produce misleading output in dry around dist-tags being altered, we do not
      * perform the npm view step, and just show npm publish's dry-run output.
      */
-    if (!options.dryRun) {
+    if (!isDryRun) {
         const currentVersion = projectPackageJson.version;
         try {
             const result = (0, child_process_1.execSync)(npmViewCommandSegments.join(' '), {
@@ -78,7 +83,7 @@ async function runExecutor(options, context) {
             }
             if (resultJson.versions.includes(currentVersion)) {
                 try {
-                    if (!options.dryRun) {
+                    if (!isDryRun) {
                         (0, child_process_1.execSync)(`npm dist-tag add ${packageName}@${currentVersion} ${tag} --registry=${registry}`, {
                             env: processEnv(true),
                             cwd: packageRoot,
@@ -96,20 +101,26 @@ async function runExecutor(options, context) {
                 catch (err) {
                     try {
                         const stdoutData = JSON.parse(err.stdout?.toString() || '{}');
-                        console.error('npm dist-tag add error:');
-                        if (stdoutData.error.summary) {
-                            console.error(stdoutData.error.summary);
-                        }
-                        if (stdoutData.error.detail) {
-                            console.error(stdoutData.error.detail);
-                        }
-                        if (context.isVerbose) {
-                            console.error('npm dist-tag add stdout:');
-                            console.error(JSON.stringify(stdoutData, null, 2));
+                        // If the error is that the package doesn't exist, then we can ignore it because we will be publishing it for the first time in the next step
+                        if (!(stdoutData.error?.code?.includes('E404') &&
+                            stdoutData.error?.summary?.includes('no such package available')) &&
+                            !(err.stderr?.toString().includes('E404') &&
+                                err.stderr?.toString().includes('no such package available'))) {
+                            console.error('npm dist-tag add error:');
+                            if (stdoutData.error.summary) {
+                                console.error(stdoutData.error.summary);
+                            }
+                            if (stdoutData.error.detail) {
+                                console.error(stdoutData.error.detail);
+                            }
+                            if (context.isVerbose) {
+                                console.error('npm dist-tag add stdout:');
+                                console.error(JSON.stringify(stdoutData, null, 2));
+                            }
+                            return {
+                                success: false,
+                            };
                         }
-                        return {
-                            success: false,
-                        };
                     }
                     catch (err) {
                         console.error('Something unexpected went wrong when processing the npm dist-tag add output\n', err);
@@ -145,7 +156,7 @@ async function runExecutor(options, context) {
         // If npm workspaces are in use, the publish output will nest the data under the package name, so we normalize it first
         const normalizedStdoutData = stdoutData[packageName] ?? stdoutData;
         (0, log_tar_1.logTar)(normalizedStdoutData);
-        if (options.dryRun) {
+        if (isDryRun) {
             console.log(`Would publish to ${registry} with tag "${tag}", but ${chalk.keyword('orange')('[dry-run]')} was set`);
         }
         else {