@nx/js 17.2.4 → 17.2.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "17.2.4",
+  "version": "17.2.6",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -57,9 +57,9 @@
     "semver": "7.5.3",
     "source-map-support": "0.5.19",
     "tslib": "^2.3.0",
-    "@nx/devkit": "17.2.4",
-    "@nx/workspace": "17.2.4",
-    "@nrwl/js": "17.2.4"
+    "@nx/devkit": "17.2.6",
+    "@nx/workspace": "17.2.6",
+    "@nrwl/js": "17.2.6"
   },
   "peerDependencies": {
     "verdaccio": "^5.0.4"

package/src/executors/release-publish/release-publish.impl.js

@@ -124,7 +124,9 @@ async function runExecutor(options, context) {
             const stdoutData = JSON.parse(err.stdout?.toString() || '{}');
             // If the error is that the package doesn't exist, then we can ignore it because we will be publishing it for the first time in the next step
             if (!(stdoutData.error?.code?.includes('E404') &&
-                stdoutData.error?.summary?.includes('no such package available'))) {
+                stdoutData.error?.summary?.includes('no such package available')) &&
+                !(err.stderr?.toString().includes('E404') &&
+                    err.stderr?.toString().includes('no such package available'))) {
                 console.error(`Something unexpected went wrong when checking for existing dist-tags.\n`, err);
                 return {
                     success: false,

package/src/generators/library/files/lib/README.md

@@ -14,6 +14,6 @@ Run `<%= cliCommand %> build <%= name %>` to build the library.
 
 ## Running unit tests
 
-Run `<%= cliCommand %> test <%= name %>` to execute the unit tests via [Jest](https://jestjs.io).
+Run `<%= cliCommand %> test <%= name %>` to execute the unit tests via <% if(unitTestRunner === 'jest') { %>[Jest](https://jestjs.io)<% } else { %>[Vitest](https://vitest.dev/)<% } %>.
 
 <% } %>

package/src/generators/library/files/lib/tsconfig.lib.json__tmpl__

@@ -6,5 +6,9 @@
     "types": ["node"]
   },
   "include": ["src/**/*.ts"<% if (js) { %>, "src/**/*.js"<% } %>],
-  "exclude": ["jest.config.ts", "src/**/*.spec.ts", "src/**/*.test.ts"<% if (js) { %>, "src/**/*.spec.js", "src/**/*.test.js"<% } %>]
+  "exclude": [
+    <% if (hasUnitTestRunner && unitTestRunner === 'jest') { %>"jest.config.ts", 
+    <% } else if (hasUnitTestRunner) { %>"vite.config.ts", 
+    <% } %>"src/**/*.spec.ts", "src/**/*.test.ts"<% if (js) { %>, "src/**/*.spec.js", "src/**/*.test.js"<% } %>
+  ]
 }

package/src/generators/release-version/release-version.js

@@ -18,8 +18,12 @@ async function releaseVersionGenerator(tree, options) {
     try {
         const versionData = {};
         // If the user provided a specifier, validate that it is valid semver or a relative semver keyword
-        if (options.specifier && !(0, semver_1.isValidSemverSpecifier)(options.specifier)) {
-            throw new Error(`The given version specifier "${options.specifier}" is not valid. You provide an exact version or a valid semver keyword such as "major", "minor", "patch", etc.`);
+        if (options.specifier) {
+            if (!(0, semver_1.isValidSemverSpecifier)(options.specifier)) {
+                throw new Error(`The given version specifier "${options.specifier}" is not valid. You provide an exact version or a valid semver keyword such as "major", "minor", "patch", etc.`);
+            }
+            // The node semver library classes a leading `v` as valid, but we want to ensure it is not present in the final version
+            options.specifier = options.specifier.replace(/^v/, '');
         }
         const projects = options.projects;
         const createResolvePackageRoot = (customPackageRoot) => (projectNode) => {