@nx/js 16.5.1 → 16.6.0-beta.1

package/migrations.json

@@ -41,6 +41,12 @@
       "version": "16.0.0-beta.1",
       "description": "Replace @nrwl/js with @nx/js",
       "implementation": "./src/migrations/update-16-0-0-add-nx-packages/update-16-0-0-add-nx-packages"
+    },
+    "explicitly-set-projects-to-update-buildable-deps": {
+      "cli": "nx",
+      "version": "16.6.0-beta.0",
+      "description": "Explicitly set 'updateBuildableProjectDepsInPackageJson' to 'true' in targets that rely on that value as the default.",
+      "factory": "./src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps"
     }
   },
   "packageJsonUpdates": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "16.5.1",
+  "version": "16.6.0-beta.1",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -39,9 +39,9 @@
     "@babel/preset-env": "^7.15.0",
     "@babel/preset-typescript": "^7.15.0",
     "@babel/runtime": "^7.14.8",
-    "@nrwl/js": "16.5.1",
-    "@nx/devkit": "16.5.1",
-    "@nx/workspace": "16.5.1",
+    "@nrwl/js": "16.6.0-beta.1",
+    "@nx/devkit": "16.6.0-beta.1",
+    "@nx/workspace": "16.6.0-beta.1",
     "@phenomnomnominal/tsquery": "~5.0.1",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^2.8.0",
@@ -69,5 +69,5 @@
     "access": "public"
   },
   "types": "./src/index.d.ts",
-  "gitHead": "7b7f1e7f72a34cb31cff43ea0ebb80d0eab1ac79"
+  "gitHead": "cf9f5cbe6a7ce3b916ec6505dc8488f669cbc52b"
 }

package/src/executors/swc/schema.json

@@ -69,13 +69,15 @@
     "updateBuildableProjectDepsInPackageJson": {
       "type": "boolean",
       "description": "Whether to update the buildable project dependencies in the build output package.json.",
-      "default": true
+      "default": false,
+      "x-deprecated": "Configure the project to use the '@nx/dependency-checks' ESLint rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks). It will be removed in v17."
     },
     "buildableProjectDepsInPackageJsonType": {
       "type": "string",
       "description": "When `updateBuildableProjectDepsInPackageJson` is `true`, this adds dependencies to either `peerDependencies` or `dependencies`.",
       "enum": ["dependencies", "peerDependencies"],
-      "default": "peerDependencies"
+      "default": "peerDependencies",
+      "x-deprecated": "Configure the project to use the '@nx/dependency-checks' ESLint rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks). It will be removed in v17."
     },
     "external": {
       "description": "A list projects to be treated as external. This feature is experimental",

package/src/executors/tsc/schema.json

@@ -57,13 +57,15 @@
     "updateBuildableProjectDepsInPackageJson": {
       "type": "boolean",
       "description": "Whether to update the buildable project dependencies in the build output package.json.",
-      "default": true
+      "default": false,
+      "x-deprecated": "Configure the project to use the '@nx/dependency-checks' ESLint rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks). It will be removed in v17."
     },
     "buildableProjectDepsInPackageJsonType": {
       "type": "string",
       "description": "When `updateBuildableProjectDepsInPackageJson` is `true`, this adds dependencies to either `peerDependencies` or `dependencies`.",
       "enum": ["dependencies", "peerDependencies"],
-      "default": "peerDependencies"
+      "default": "peerDependencies",
+      "x-deprecated": "Configure the project to use the '@nx/dependency-checks' ESLint rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks). It will be removed in v17."
     },
     "external": {
       "description": "A list projects to be treated as external. This feature is experimental",

package/src/generators/library/library.js

@@ -238,8 +238,8 @@ function createFiles(tree, options, filesDir) {
 }
 function addJest(tree, options) {
     return tslib_1.__awaiter(this, void 0, void 0, function* () {
-        const { jestProjectGenerator } = (0, devkit_1.ensurePackage)('@nx/jest', versions_1.nxVersion);
-        return yield jestProjectGenerator(tree, Object.assign(Object.assign({}, options), { project: options.name, setupFile: 'none', supportTsx: false, skipSerializers: true, testEnvironment: options.testEnvironment, skipFormat: true, compiler: options.bundler === 'swc' || options.bundler === 'tsc'
+        const { configurationGenerator } = (0, devkit_1.ensurePackage)('@nx/jest', versions_1.nxVersion);
+        return yield configurationGenerator(tree, Object.assign(Object.assign({}, options), { project: options.name, setupFile: 'none', supportTsx: false, skipSerializers: true, testEnvironment: options.testEnvironment, skipFormat: true, compiler: options.bundler === 'swc' || options.bundler === 'tsc'
                 ? options.bundler
                 : options.bundler === 'rollup'
                     ? 'swc'

package/src/generators/setup-build/generator.js

@@ -70,8 +70,8 @@ function setupBuildGenerator(tree, options) {
                 break;
             }
             case 'esbuild': {
-                const { esbuildProjectGenerator } = (0, devkit_1.ensurePackage)('@nx/esbuild', versions_1.nxVersion);
-                const task = yield esbuildProjectGenerator(tree, {
+                const { configurationGenerator } = (0, devkit_1.ensurePackage)('@nx/esbuild', versions_1.nxVersion);
+                const task = yield configurationGenerator(tree, {
                     main: mainFile,
                     buildTarget: options.buildTarget,
                     project: options.project,
@@ -81,8 +81,8 @@ function setupBuildGenerator(tree, options) {
                 break;
             }
             case 'rollup': {
-                const { rollupProjectGenerator } = (0, devkit_1.ensurePackage)('@nx/rollup', versions_1.nxVersion);
-                const task = yield rollupProjectGenerator(tree, {
+                const { configurationGenerator } = (0, devkit_1.ensurePackage)('@nx/rollup', versions_1.nxVersion);
+                const task = yield configurationGenerator(tree, {
                     buildTarget: options.buildTarget,
                     main: mainFile,
                     project: options.project,

package/src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps.d.ts

@@ -0,0 +1,2 @@
+import { Tree } from '@nx/devkit';
+export default function (tree: Tree): Promise<void>;

package/src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps.js

@@ -0,0 +1,39 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const tslib_1 = require("tslib");
+const devkit_1 = require("@nx/devkit");
+const executors = new Set([
+    '@nx/js:swc',
+    '@nrwl/js:swc',
+    '@nx/js:tsc',
+    '@nrwl/js:tsc',
+]);
+function default_1(tree) {
+    var _a;
+    var _b;
+    return tslib_1.__awaiter(this, void 0, void 0, function* () {
+        // use project graph to get the expanded target configurations
+        const projectGraph = yield (0, devkit_1.createProjectGraphAsync)();
+        for (const [projectName, { data: projectData }] of Object.entries(projectGraph.nodes)) {
+            if (projectData.projectType !== 'library') {
+                continue;
+            }
+            for (const [targetName, target] of Object.entries(projectData.targets || {})) {
+                if (!executors.has(target.executor)) {
+                    continue;
+                }
+                if (!target.options ||
+                    target.options.updateBuildableProjectDepsInPackageJson === undefined) {
+                    // read the project configuration to write the explicit project configuration
+                    // and avoid writing the expanded target configuration
+                    const project = (0, devkit_1.readProjectConfiguration)(tree, projectName);
+                    (_a = (_b = project.targets[targetName]).options) !== null && _a !== void 0 ? _a : (_b.options = {});
+                    project.targets[targetName].options.updateBuildableProjectDepsInPackageJson = true;
+                    (0, devkit_1.updateProjectConfiguration)(tree, projectName, project);
+                }
+            }
+        }
+        yield (0, devkit_1.formatFiles)(tree);
+    });
+}
+exports.default = default_1;

package/src/utils/schema.d.ts

@@ -42,7 +42,17 @@ export interface ExecutorOptions {
   watch: boolean;
   clean?: boolean;
   transformers: TransformerEntry[];
+  /**
+   * @deprecated Configure the project to use the `@nx/dependency-checks` ESLint
+   * rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks).
+   * It will be removed in v17.
+   */
   updateBuildableProjectDepsInPackageJson?: boolean;
+  /**
+   * @deprecated Configure the project to use the `@nx/dependency-checks` ESLint
+   * rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks).
+   * It will be removed in v17.
+   */
   buildableProjectDepsInPackageJsonType?: 'dependencies' | 'peerDependencies';
   external?: 'all' | 'none' | string[];
   externalBuildTargets?: string[];