@nx/js 0.0.0-pr-3-c6ccd0d → 0.0.0-pr-30250-73071c2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "0.0.0-pr-3-c6ccd0d",
+  "version": "0.0.0-pr-30250-73071c2",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -39,8 +39,8 @@
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-typescript": "^7.22.5",
     "@babel/runtime": "^7.22.6",
-    "@nx/devkit": "0.0.0-pr-3-c6ccd0d",
-    "@nx/workspace": "0.0.0-pr-3-c6ccd0d",
+    "@nx/devkit": "0.0.0-pr-30250-73071c2",
+    "@nx/workspace": "0.0.0-pr-30250-73071c2",
     "@zkochan/js-yaml": "0.0.7",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^3.1.0",
@@ -52,10 +52,11 @@
     "ignore": "^5.0.4",
     "js-tokens": "^4.0.0",
     "jsonc-parser": "3.2.0",
-    "minimatch": "9.0.3",
     "npm-package-arg": "11.0.1",
     "npm-run-path": "^4.0.1",
     "ora": "5.3.0",
+    "picocolors": "^1.1.0",
+    "picomatch": "4.0.2",
     "semver": "^7.5.3",
     "source-map-support": "0.5.19",
     "tinyglobby": "^0.2.10",

package/src/executors/node/node.impl.js

@@ -298,7 +298,7 @@ function getFileToRun(context, project, buildOptions, buildTargetExecutor) {
             const outputFilePath = (0, utils_1.interpolate)(outputPath, {
                 projectName: project.name,
                 projectRoot: project.data.root,
-                workspaceRoot: '',
+                workspaceRoot: context.root,
             });
             return path.join(outputFilePath, 'main.js');
         }

package/src/generators/library/library.js

@@ -161,7 +161,7 @@ async function libraryGeneratorInternal(tree, schema) {
 async function configureProject(tree, options) {
     if (options.hasPlugin) {
         const nxJson = (0, devkit_1.readNxJson)(tree);
-        (0, plugin_1.ensureProjectIsIncludedInPluginRegistrations)(nxJson, options.projectRoot);
+        (0, plugin_1.ensureProjectIsIncludedInPluginRegistrations)(nxJson, options.projectRoot, options.bundler === 'none' ? null : 'build');
         (0, devkit_1.updateNxJson)(tree, nxJson);
     }
     const projectConfiguration = {
@@ -719,9 +719,7 @@ function createProjectTsConfigs(tree, options) {
             .map(([k, v]) => `${JSON.stringify(k)}: ${JSON.stringify(v)}`)
             .join(',\n    '),
         tmpl: '',
-        outDir: options.bundler === 'tsc'
-            ? 'dist'
-            : `out-tsc/${options.projectRoot.split('/').pop()}`,
+        outDir: 'dist',
         emitDeclarationOnly: options.bundler === 'tsc' ? false : true,
     });
     // tsconfig.json
@@ -734,6 +732,12 @@ function createProjectTsConfigs(tree, options) {
                 json.references.push({
                     path: './tsconfig.lib.json',
                 });
+                // If using `tsc` to build, then we do not want a typecheck target that duplicates the work, since both run `tsc`.
+                // This applies to `@nx/js/typescript` plugin only.
+                if (options.bundler === 'tsc') {
+                    json['nx'] ??= {};
+                    json['nx'].addTypecheckTarget = false;
+                }
                 return json;
             });
         }
@@ -745,6 +749,12 @@ function createProjectTsConfigs(tree, options) {
                 include: [],
                 references: [{ path: './tsconfig.lib.json' }],
             };
+            // If using `tsc` to build, then we do not want a typecheck target that duplicates the work, since both run `tsc`.
+            // This applies to `@nx/js/typescript` plugin only.
+            if (options.bundler === 'tsc') {
+                tsconfig['nx'] ??= {};
+                tsconfig['nx'].addTypecheckTarget = false;
+            }
             (0, devkit_1.writeJson)(tree, (0, devkit_1.joinPathFragments)(options.projectRoot, 'tsconfig.json'), tsconfig);
             // update root project tsconfig.json references with the new lib tsconfig
             (0, devkit_1.updateJson)(tree, 'tsconfig.json', (json) => {

package/src/plugins/typescript/plugin.js

@@ -3,7 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.createNodes = exports.createNodesV2 = exports.PLUGIN_NAME = exports.createDependencies = void 0;
 const devkit_1 = require("@nx/devkit");
 const get_named_inputs_1 = require("@nx/devkit/src/utils/get-named-inputs");
-const minimatch_1 = require("minimatch");
+const picomatch = require("picomatch");
 const node_fs_1 = require("node:fs");
 const node_path_1 = require("node:path");
 const posix = require("node:path/posix");
@@ -178,7 +178,9 @@ function buildTscTargets(configFilePath, projectRoot, options, context) {
     const tsConfig = retrieveTsConfigFromCache(configFilePath, context.workspaceRoot);
     let internalProjectReferences;
     // Typecheck target
-    if ((0, node_path_1.basename)(configFilePath) === 'tsconfig.json' && options.typecheck) {
+    if ((0, node_path_1.basename)(configFilePath) === 'tsconfig.json' &&
+        options.typecheck &&
+        tsConfig.raw?.['nx']?.addTypecheckTarget !== false) {
         internalProjectReferences = resolveInternalProjectReferences(tsConfig, context.workspaceRoot, projectRoot);
         const externalProjectReferences = resolveShallowExternalProjectReferences(tsConfig, context.workspaceRoot, projectRoot);
         const targetName = options.typecheck.targetName;
@@ -276,8 +278,8 @@ function getInputs(namedInputs, configFilePath, tsConfig, internalProjectReferen
             });
             const normalize = (p) => (p.startsWith('./') ? p.slice(2) : p);
             config.raw.exclude.forEach((excludePath) => {
-                if (!otherFilesInclude.some((includePath) => (0, minimatch_1.minimatch)(normalize(includePath), normalize(excludePath)) ||
-                    (0, minimatch_1.minimatch)(normalize(excludePath), normalize(includePath)))) {
+                if (!otherFilesInclude.some((includePath) => picomatch(normalize(excludePath))(normalize(includePath)) ||
+                    picomatch(normalize(includePath))(normalize(excludePath)))) {
                     excludePaths.add(excludePath);
                 }
             });
@@ -554,7 +556,7 @@ function hasExternalProjectReferences(tsConfigPath, tsConfig, workspaceRoot, pro
     return false;
 }
 function isExternalProjectReference(refTsConfigPath, workspaceRoot, projectRoot) {
-    const relativePath = posix.relative(workspaceRoot, refTsConfigPath);
+    const relativePath = posixRelative(workspaceRoot, refTsConfigPath);
     if (cache.isExternalProjectReference[relativePath] !== undefined) {
         return cache.isExternalProjectReference[relativePath];
     }
@@ -584,7 +586,7 @@ function getTsConfigDirName(tsConfigPath) {
         : (0, node_path_1.normalize)(tsConfigPath);
 }
 function retrieveTsConfigFromCache(tsConfigPath, workspaceRoot) {
-    const relativePath = posix.relative(workspaceRoot, tsConfigPath);
+    const relativePath = posixRelative(workspaceRoot, tsConfigPath);
     // we don't need to check the hash if it's in the cache, because we've already
     // checked it when we initially populated the cache
     return tsConfigCache[relativePath]
@@ -600,7 +602,7 @@ function initializeTsConfigCache(configFilePaths, workspaceRoot) {
     }
 }
 function readTsConfigAndCache(tsConfigPath, workspaceRoot) {
-    const relativePath = posix.relative(workspaceRoot, tsConfigPath);
+    const relativePath = posixRelative(workspaceRoot, tsConfigPath);
     const hash = getFileHash(tsConfigPath, workspaceRoot);
     let extendedFilesHash;
     if (tsConfigCache[relativePath] &&
@@ -716,7 +718,7 @@ function resolveExtendedTsConfigPath(tsConfigPath, directory) {
     }
 }
 function getFileHash(filePath, workspaceRoot) {
-    const relativePath = posix.relative(workspaceRoot, filePath);
+    const relativePath = posixRelative(workspaceRoot, filePath);
     if (!cache.fileHashes[relativePath]) {
         const content = readFile(filePath, workspaceRoot);
         cache.fileHashes[relativePath] = (0, file_hasher_1.hashArray)([content]);
@@ -724,7 +726,7 @@ function getFileHash(filePath, workspaceRoot) {
     return cache.fileHashes[relativePath];
 }
 function readFile(filePath, workspaceRoot) {
-    const relativePath = posix.relative(workspaceRoot, filePath);
+    const relativePath = posixRelative(workspaceRoot, filePath);
     if (!cache.rawFiles[relativePath]) {
         const content = (0, node_fs_1.readFileSync)(filePath, 'utf8');
         cache.rawFiles[relativePath] = content;
@@ -737,6 +739,9 @@ function toAbsolutePaths(cache, workspaceRoot) {
         updatedCache[key] = {
             data: {
                 options: { noEmit: data.options.noEmit },
+                raw: {
+                    nx: { addTypecheckTarget: data.raw?.['nx']?.addTypecheckTarget },
+                },
                 extendedConfigFile: data.extendedConfigFile,
             },
             extendedFilesHash,
@@ -769,29 +774,38 @@ function toRelativePaths(cache, workspaceRoot) {
         updatedCache[key] = {
             data: {
                 options: { noEmit: data.options.noEmit },
+                raw: {
+                    nx: { addTypecheckTarget: data.raw?.['nx']?.addTypecheckTarget },
+                },
                 extendedConfigFile: data.extendedConfigFile,
             },
             extendedFilesHash,
             hash,
         };
         if (data.options.rootDir) {
-            updatedCache[key].data.options.rootDir = posix.relative(workspaceRoot, data.options.rootDir);
+            updatedCache[key].data.options.rootDir = posixRelative(workspaceRoot, data.options.rootDir);
         }
         if (data.options.outDir) {
-            updatedCache[key].data.options.outDir = posix.relative(workspaceRoot, data.options.outDir);
+            updatedCache[key].data.options.outDir = posixRelative(workspaceRoot, data.options.outDir);
         }
         if (data.options.outFile) {
-            updatedCache[key].data.options.outFile = posix.relative(workspaceRoot, data.options.outFile);
+            updatedCache[key].data.options.outFile = posixRelative(workspaceRoot, data.options.outFile);
         }
         if (data.options.tsBuildInfoFile) {
-            updatedCache[key].data.options.tsBuildInfoFile = posix.relative(workspaceRoot, data.options.tsBuildInfoFile);
+            updatedCache[key].data.options.tsBuildInfoFile = posixRelative(workspaceRoot, data.options.tsBuildInfoFile);
         }
         if (data.extendedConfigFile?.filePath) {
-            updatedCache[key].data.extendedConfigFile.filePath = posix.relative(workspaceRoot, data.extendedConfigFile.filePath);
+            updatedCache[key].data.extendedConfigFile.filePath = posixRelative(workspaceRoot, data.extendedConfigFile.filePath);
         }
         if (data.projectReferences) {
-            updatedCache[key].data.projectReferences = data.projectReferences.map((ref) => ({ ...ref, path: posix.relative(workspaceRoot, ref.path) }));
+            updatedCache[key].data.projectReferences = data.projectReferences.map((ref) => ({
+                ...ref,
+                path: posixRelative(workspaceRoot, ref.path),
+            }));
         }
     }
     return updatedCache;
 }
+function posixRelative(workspaceRoot, path) {
+    return posix.normalize((0, node_path_1.relative)(workspaceRoot, path));
+}

package/src/plugins/typescript/util.js

@@ -27,7 +27,6 @@ function addBuildAndWatchDepsTargets(workspaceRoot, projectRoot, targets, option
             dependsOn: ['^build'],
         };
         targets[options.watchDepsTargetName ?? 'watch-deps'] = {
-            continuous: true,
             dependsOn: [buildDepsTargetName],
             command: `${pmc.exec} nx watch --projects ${projectName} --includeDependentProjects -- ${pmc.exec} nx ${buildDepsTargetName} ${projectName}`,
         };

package/src/utils/assets/copy-assets-handler.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.CopyAssetsHandler = exports.defaultFileEventHandler = void 0;
-const minimatch_1 = require("minimatch");
+const picomatch = require("picomatch");
 const node_fs_1 = require("node:fs");
 const pathPosix = require("node:path/posix");
 const path = require("node:path");
@@ -9,6 +9,7 @@ const ignore_1 = require("ignore");
 const tinyglobby_1 = require("tinyglobby");
 const devkit_1 = require("@nx/devkit");
 const client_1 = require("nx/src/daemon/client/client");
+const picocolors_1 = require("picocolors");
 const defaultFileEventHandler = (events) => {
     const dirs = new Set(events.map((event) => path.dirname(event.dest)));
     dirs.forEach((d) => (0, node_fs_1.mkdirSync)(d, { recursive: true }));
@@ -24,6 +25,9 @@ const defaultFileEventHandler = (events) => {
         else {
             devkit_1.logger.error(`Unknown file event: ${event.type}`);
         }
+        const eventDir = path.dirname(event.src);
+        const relativeDest = path.relative(eventDir, event.dest);
+        devkit_1.logger.log(`\n${(0, picocolors_1.dim)(relativeDest)}`);
     });
 };
 exports.defaultFileEventHandler = defaultFileEventHandler;
@@ -115,10 +119,12 @@ class CopyAssetsHandler {
     async processWatchEvents(events) {
         const fileEvents = [];
         for (const event of events) {
-            const pathFromRoot = path.relative(this.rootDir, event.path);
+            const pathFromRoot = event.path.startsWith(this.rootDir)
+                ? path.relative(this.rootDir, event.path)
+                : event.path;
             for (const ag of this.assetGlobs) {
-                if ((0, minimatch_1.minimatch)(pathFromRoot, ag.pattern) &&
-                    !ag.ignore?.some((ig) => (0, minimatch_1.minimatch)(pathFromRoot, ig)) &&
+                if (picomatch(ag.pattern)(pathFromRoot) &&
+                    !ag.ignore?.some((ig) => picomatch(ig)(pathFromRoot)) &&
                     !this.ignore.ignores(pathFromRoot)) {
                     const relPath = path.relative(ag.input, pathFromRoot);
                     const destPath = relPath.startsWith('..') ? pathFromRoot : relPath;
@@ -137,7 +143,7 @@ class CopyAssetsHandler {
     }
     filesToEvent(files, assetGlob) {
         return files.reduce((acc, src) => {
-            if (!assetGlob.ignore?.some((ig) => (0, minimatch_1.minimatch)(src, ig)) &&
+            if (!assetGlob.ignore?.some((ig) => picomatch(ig)(src)) &&
                 !this.ignore.ignores(src)) {
                 const relPath = path.relative(assetGlob.input, src);
                 const dest = relPath.startsWith('..') ? src : relPath;

package/src/utils/buildable-libs-utils.js

@@ -16,6 +16,7 @@ const fileutils_1 = require("nx/src/utils/fileutils");
 const output_1 = require("nx/src/utils/output");
 const path_1 = require("path");
 const ts_config_1 = require("./typescript/ts-config");
+const crypto_1 = require("crypto");
 function isBuildable(target, node) {
     return (node.data.targets &&
         node.data.targets[target] &&
@@ -229,7 +230,7 @@ function computeCompilerOptionsPaths(tsConfig, dependencies) {
     return paths;
 }
 function createTmpTsConfig(tsconfigPath, workspaceRoot, projectRoot, dependencies, useWorkspaceAsBaseUrl = false) {
-    const tmpTsConfigPath = (0, path_1.join)(workspaceRoot, 'tmp', projectRoot, process.env.NX_TASK_TARGET_TARGET ?? 'build', 'tsconfig.generated.json');
+    const tmpTsConfigPath = (0, path_1.join)(workspaceRoot, 'tmp', projectRoot, process.env.NX_TASK_TARGET_TARGET ?? 'build', `tsconfig.generated.${(0, crypto_1.randomUUID)()}.json`);
     if (tsconfigPath === tmpTsConfigPath) {
         return tsconfigPath;
     }

package/src/utils/package-manager-workspaces.js

@@ -5,7 +5,7 @@ exports.isUsingPackageManagerWorkspaces = isUsingPackageManagerWorkspaces;
 exports.isWorkspacesEnabled = isWorkspacesEnabled;
 exports.getProjectPackageManagerWorkspaceStateWarningTask = getProjectPackageManagerWorkspaceStateWarningTask;
 const devkit_1 = require("@nx/devkit");
-const minimatch_1 = require("minimatch");
+const picomatch = require("picomatch");
 const posix_1 = require("node:path/posix");
 const package_json_1 = require("nx/src/plugins/package-json");
 const semver_1 = require("semver");
@@ -13,17 +13,18 @@ function getProjectPackageManagerWorkspaceState(tree, projectRoot) {
     if (!isUsingPackageManagerWorkspaces(tree)) {
         return 'no-workspaces';
     }
-    const patterns = (0, package_json_1.getGlobPatternsFromPackageManagerWorkspaces)(tree.root, (path) => (0, devkit_1.readJson)(tree, path, { expectComments: true }));
-    const isIncluded = patterns.some((p) => (0, minimatch_1.minimatch)((0, posix_1.join)(projectRoot, 'package.json'), p));
+    const patterns = (0, package_json_1.getGlobPatternsFromPackageManagerWorkspaces)(tree.root, (path) => (0, devkit_1.readJson)(tree, path, { expectComments: true }), (path) => {
+        const content = tree.read(path, 'utf-8');
+        const { load } = require('@zkochan/js-yaml');
+        return load(content, { filename: path });
+    }, (path) => tree.exists(path));
+    const isIncluded = patterns.some((p) => picomatch(p)((0, posix_1.join)(projectRoot, 'package.json')));
     return isIncluded ? 'included' : 'excluded';
 }
 function isUsingPackageManagerWorkspaces(tree) {
     return isWorkspacesEnabled(tree);
 }
-function isWorkspacesEnabled(tree
-// packageManager: PackageManager = detectPackageManager(),
-// root: string = workspaceRoot
-) {
+function isWorkspacesEnabled(tree) {
     const packageManager = (0, devkit_1.detectPackageManager)(tree.root);
     if (packageManager === 'pnpm') {
         return tree.exists('pnpm-workspace.yaml');

package/src/utils/typescript/plugin.d.ts

@@ -1,3 +1,3 @@
 import type { NxJsonConfiguration } from '@nx/devkit';
-export declare function ensureProjectIsIncludedInPluginRegistrations(nxJson: NxJsonConfiguration, projectRoot: string, buildTargetName?: string): void;
+export declare function ensureProjectIsIncludedInPluginRegistrations(nxJson: NxJsonConfiguration, projectRoot: string, buildTargetName: string | null): void;
 export declare function ensureProjectIsExcludedFromPluginRegistrations(nxJson: NxJsonConfiguration, projectRoot: string): void;

package/src/utils/typescript/plugin.js

@@ -3,7 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.ensureProjectIsIncludedInPluginRegistrations = ensureProjectIsIncludedInPluginRegistrations;
 exports.ensureProjectIsExcludedFromPluginRegistrations = ensureProjectIsExcludedFromPluginRegistrations;
 const devkit_internals_1 = require("nx/src/devkit-internals");
-function ensureProjectIsIncludedInPluginRegistrations(nxJson, projectRoot, buildTargetName = 'build') {
+function ensureProjectIsIncludedInPluginRegistrations(nxJson, projectRoot, buildTargetName) {
     nxJson.plugins ??= [];
     let isIncluded = false;
     let index = 0;
@@ -13,12 +13,17 @@ function ensureProjectIsIncludedInPluginRegistrations(nxJson, projectRoot, build
             continue;
         }
         if (typeof registration === 'string') {
-            // if it's a string all projects are included but the are no user-specified options
-            // and the build task is not inferred by default, so we need to exclude it
-            nxJson.plugins[index] = {
-                plugin: '@nx/js/typescript',
-                exclude: [`${projectRoot}/*`],
-            };
+            if (buildTargetName) {
+                // if it's a string all projects are included but the are no user-specified options
+                // and the build task is not inferred by default, so we need to exclude it
+                nxJson.plugins[index] = {
+                    plugin: '@nx/js/typescript',
+                    exclude: [`${projectRoot}/*`],
+                };
+            }
+            else {
+                isIncluded = true;
+            }
         }
         else {
             // check if the project would be included by the plugin registration
@@ -27,7 +32,7 @@ function ensureProjectIsIncludedInPluginRegistrations(nxJson, projectRoot, build
                 // it's included by the plugin registration, check if the user-specified options would result
                 // in the appropriate build task being inferred, if not, we need to exclude it
                 if (registration.options?.typecheck !== false &&
-                    matchesBuildTarget(registration.options?.build, buildTargetName)) {
+                    matchesBuildTargetDefinition(registration.options?.build, buildTargetName)) {
                     // it has the desired options, do nothing, but continue processing
                     // other registrations to exclude as needed
                     isIncluded = true;
@@ -40,7 +45,7 @@ function ensureProjectIsIncludedInPluginRegistrations(nxJson, projectRoot, build
             }
             else if (!isIncluded &&
                 registration.options?.typecheck !== false &&
-                matchesBuildTarget(registration.options?.build, buildTargetName)) {
+                matchesBuildTargetDefinition(registration.options?.build, buildTargetName)) {
                 if (!registration.exclude?.length) {
                     // negative pattern are not supported by the `exclude` option so we
                     // can't update it to not exclude the project, so we only update the
@@ -66,17 +71,20 @@ function ensureProjectIsIncludedInPluginRegistrations(nxJson, projectRoot, build
     if (!isIncluded) {
         // the project is not included by any plugin registration with an inferred build task
         // with the given name, so we create a new plugin registration for it
-        nxJson.plugins.push({
+        const registration = {
             plugin: '@nx/js/typescript',
             include: [`${projectRoot}/*`],
             options: {
                 typecheck: { targetName: 'typecheck' },
-                build: {
-                    targetName: buildTargetName,
-                    configName: 'tsconfig.lib.json',
-                },
             },
-        });
+        };
+        if (buildTargetName) {
+            registration.options.build = {
+                targetName: buildTargetName,
+                configName: 'tsconfig.lib.json',
+            };
+        }
+        nxJson.plugins.push(registration);
     }
 }
 function ensureProjectIsExcludedFromPluginRegistrations(nxJson, projectRoot) {
@@ -115,8 +123,11 @@ function isTypeScriptPluginRegistration(plugin) {
     return ((typeof plugin === 'string' && plugin === '@nx/js/typescript') ||
         (typeof plugin !== 'string' && plugin.plugin === '@nx/js/typescript'));
 }
-function matchesBuildTarget(buildOptions, buildTargetName) {
+function matchesBuildTargetDefinition(buildOptions, buildTargetName) {
     if (buildOptions === undefined || buildOptions === false) {
+        return !buildTargetName;
+    }
+    if (!buildTargetName) {
         return false;
     }
     if (buildOptions === true && buildTargetName === 'build') {

package/src/utils/typescript/ts-solution-setup.js

@@ -90,9 +90,7 @@ function updateTsconfigFiles(tree, projectRoot, runtimeTsconfigFileName, compile
             json.extends = (0, devkit_1.joinPathFragments)(offset, 'tsconfig.base.json');
             json.compilerOptions = {
                 ...json.compilerOptions,
-                // Make sure d.ts files from typecheck does not conflict with bundlers.
-                // Other tooling like jest write to "out-tsc/jest" to we just default to "out-tsc/<project-name>".
-                outDir: (0, devkit_1.joinPathFragments)('out-tsc', projectRoot.split('/').at(-1)),
+                outDir: 'dist',
                 rootDir,
                 ...compilerOptions,
             };
@@ -146,6 +144,10 @@ function updateTsconfigFiles(tree, projectRoot, runtimeTsconfigFileName, compile
     }
 }
 function addProjectToTsSolutionWorkspace(tree, projectDir) {
+    const state = (0, package_manager_workspaces_1.getProjectPackageManagerWorkspaceState)(tree, projectDir);
+    if (state === 'included') {
+        return;
+    }
     // If dir is "libs/foo" then use "libs/*" so we don't need so many entries in the workspace file.
     // If dir is nested like "libs/shared/foo" then we add "libs/shared/*".
     // If the dir is just "foo" then we have to add it as is.