@nx/js 0.0.0-pr-28808-eac89e6 → 0.0.0-pr-29122-4727ac1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/js",
-  "version": "0.0.0-pr-28808-eac89e6",
+  "version": "0.0.0-pr-29122-4727ac1",
   "private": false,
   "description": "The JS plugin for Nx contains executors and generators that provide the best experience for developing JavaScript and TypeScript projects. ",
   "repository": {
@@ -39,8 +39,8 @@
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-typescript": "^7.22.5",
     "@babel/runtime": "^7.22.6",
-    "@nx/devkit": "0.0.0-pr-28808-eac89e6",
-    "@nx/workspace": "0.0.0-pr-28808-eac89e6",
+    "@nx/devkit": "0.0.0-pr-29122-4727ac1",
+    "@nx/workspace": "0.0.0-pr-29122-4727ac1",
     "@zkochan/js-yaml": "0.0.7",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^2.8.0",

package/src/generators/library/library.js

@@ -135,6 +135,10 @@ async function libraryGeneratorInternal(tree, schema) {
             logNxReleaseDocsInfo();
         });
     }
+    // Always run install to link packages.
+    if (options.isUsingTsSolutionConfig) {
+        tasks.push(() => (0, devkit_1.installPackagesTask)(tree));
+    }
     tasks.push(() => {
         (0, log_show_project_command_1.logShowProjectCommand)(options.name);
     });
@@ -816,6 +820,17 @@ function determineEntryFields(options) {
                 // Safest option is to not set a type field.
                 // Allow the user to decide which module format their library is using
                 type: undefined,
+                // For non-buildable libraries, point to source so we can still use them in apps via bundlers like Vite.
+                main: options.isUsingTsSolutionConfig
+                    ? options.js
+                        ? './src/index.js'
+                        : './src/index.ts'
+                    : undefined,
+                types: options.isUsingTsSolutionConfig
+                    ? options.js
+                        ? './src/index.js'
+                        : './src/index.ts'
+                    : undefined,
             };
         }
     }

package/src/generators/library/schema.d.ts

@@ -1,7 +1,4 @@
-import type {
-  ProjectNameAndRootFormat,
-  ProjectNameAndRootOptions,
-} from '@nx/devkit/src/generators/project-name-and-root-utils';
+import type { ProjectNameAndRootOptions } from '@nx/devkit/src/generators/project-name-and-root-utils';
 // nx-ignore-next-line
 const { Linter, LinterType } = require('@nx/eslint'); // use require to import to avoid circular dependency
 import type { ProjectPackageManagerWorkspaceState } from '../../utils/package-manager-workspaces';
@@ -12,7 +9,6 @@ export type Bundler = 'swc' | 'tsc' | 'rollup' | 'vite' | 'esbuild' | 'none';
 export interface LibraryGeneratorSchema {
   directory: string;
   name?: string;
-  projectNameAndRootFormat?: ProjectNameAndRootFormat;
   skipFormat?: boolean;
   tags?: string;
   skipTsConfig?: boolean;