@nx/jest 24.0.1 → 24.0.2

package/dist/src/plugins/plugin.js

@@ -5,6 +5,8 @@ const tslib_1 = require("tslib");
 const internal_1 = require("@nx/devkit/internal");
 const devkit_1 = require("@nx/devkit");
 const minimatch_1 = require("minimatch");
+const picomatch = require("picomatch");
+const node_child_process_1 = require("node:child_process");
 const node_fs_1 = require("node:fs");
 const node_path_1 = require("node:path");
 const posix = tslib_1.__importStar(require("node:path/posix"));
@@ -206,7 +208,6 @@ async function buildJestTargets(rawConfig, needsDtsInputs, configFilePath, proje
                     [groupName]: targetGroup,
                 },
             };
-            const specIgnoreRegexes = rawConfig.testPathIgnorePatterns?.map((p) => new RegExp(replaceRootDirInPath(projectRoot, p)));
             for (const testPath of specs) {
                 const relativePath = (0, devkit_1.normalizePath)((0, node_path_1.relative)((0, node_path_1.join)(context.workspaceRoot, projectRoot), testPath));
                 if (relativePath.includes('../')) {
@@ -219,9 +220,6 @@ async function buildJestTargets(rawConfig, needsDtsInputs, configFilePath, proje
                             testMatch,
                         }, null, 2)}`);
                 }
-                if (specIgnoreRegexes?.some((regex) => regex.test(relativePath))) {
-                    continue;
-                }
                 const targetName = `${options.ciTargetName}--${relativePath}`;
                 dependsOn.push({
                     target: targetName,
@@ -606,21 +604,152 @@ function requireJestUtil(packageName, projectRoot, workspaceRoot) {
         paths: [(0, node_path_1.dirname)(resolvedJestCorePaths[jestPath])],
     }));
 }
+// Defaults copied from https://github.com/jestjs/jest/blob/d1a2ed7/packages/jest-config/src/Defaults.ts
+const DEFAULT_TEST_MATCH = [
+    '**/__tests__/**/*.?([mc])[jt]s?(x)',
+    '**/?(*.)+(spec|test).?([mc])[jt]s?(x)',
+];
+const DEFAULT_MODULE_FILE_EXTENSIONS = [
+    'js',
+    'mjs',
+    'cjs',
+    'jsx',
+    'ts',
+    'mts',
+    'cts',
+    'tsx',
+    'json',
+    'node',
+];
+// Mirrors how Jest selects test files: jest-haste-map's file list, then
+// SearchSource's checks, all on the absolute path
 async function getTestPaths(projectRoot, rawConfig, rootDir, context, presetCache) {
-    const testMatch = await getJestOption(rawConfig, rootDir, 'testMatch', presetCache);
-    let paths = await (0, internal_1.globWithWorkspaceContext)(context.workspaceRoot, (testMatch || [
-        // Default copied from https://github.com/jestjs/jest/blob/d1a2ed7/packages/jest-config/src/Defaults.ts#L84
-        '**/__tests__/**/*.?([mc])[jt]s?(x)',
-        '**/?(*.)+(spec|test).?([mc])[jt]s?(x)',
-    ]).map((pattern) => posix.join(projectRoot, pattern)), []);
-    const testRegex = await getJestOption(rawConfig, rootDir, 'testRegex', presetCache);
-    if (testRegex) {
-        const testRegexes = Array.isArray(rawConfig.testRegex)
-            ? rawConfig.testRegex.map((r) => new RegExp(r))
-            : [new RegExp(rawConfig.testRegex)];
-        paths = paths.filter((path) => testRegexes.some((r) => r.test(path)));
-    }
-    return { specs: paths, testMatch };
+    // Jest resolves rootDir's symlinks. Resolve the workspace root with it so
+    // file paths still compare; a default rootDir needs neither
+    let workspaceRoot = context.workspaceRoot;
+    if (rawConfig.rootDir) {
+        rootDir = tryRealpath(rootDir);
+        workspaceRoot = tryRealpath(workspaceRoot);
+    }
+    const preset = await loadPresetConfig(rawConfig, rootDir, presetCache);
+    // jest-config lets a key the config sets override the preset, even when empty
+    const getOption = (name, defaultValue) => (Object.hasOwn(rawConfig, name) ? rawConfig : preset)?.[name] ??
+        defaultValue;
+    const toArray = (value) => Array.isArray(value) ? value : [value];
+    const posixRootDir = (0, devkit_1.normalizePath)(rootDir);
+    const toRegExp = (patterns) => patterns.length > 0
+        ? new RegExp(patterns
+            .map((pattern) => pattern.replaceAll('<rootDir>', posixRootDir))
+            .join('|'))
+        : undefined;
+    // jest-config reads a falsy testRegex as none
+    const testRegex = toArray(getOption('testRegex', []) || []);
+    // jest-config drops the default testMatch when testRegex is set
+    const testMatch = toArray(getOption('testMatch', testRegex.length > 0 ? [] : DEFAULT_TEST_MATCH));
+    const roots = getOption('roots', ['<rootDir>']).map((root) => `${(0, devkit_1.normalizePath)((0, node_path_1.resolve)(rootDir, replaceRootDirInPath(rootDir, root)))}/`);
+    const extensions = new Set([
+        'snap',
+        ...getOption('moduleFileExtensions', DEFAULT_MODULE_FILE_EXTENSIONS),
+    ]);
+    // jest-config swaps its default haste, which sets forceNodeFilesystemAPI,
+    // for any haste the config or preset sets, even an empty one
+    const hasteConfig = [rawConfig, preset].find((config) => config && Object.hasOwn(config, 'haste'));
+    const useNativeFind = !!hasteConfig &&
+        !hasteConfig.haste?.forceNodeFilesystemAPI &&
+        (await hasNativeFindSupport());
+    // jest-haste-map's native find crawler matches extensions as
+    // case-insensitive suffixes, its Node API crawler as the last extension
+    const suffixes = [...extensions].map((ext) => `.${ext}`.toLowerCase());
+    const hasExtension = useNativeFind
+        ? (path) => {
+            const lowerCasePath = path.toLowerCase();
+            return suffixes.some((suffix) => lowerCasePath.endsWith(suffix));
+        }
+        : (path) => extensions.has((0, node_path_1.extname)(path).slice(1));
+    // jest-config concatenates preset and config modulePathIgnorePatterns
+    const modulePathIgnorePattern = toRegExp((preset?.modulePathIgnorePatterns ?? []).concat(rawConfig.modulePathIgnorePatterns ?? []));
+    const testPathIgnorePattern = toRegExp(getOption('testPathIgnorePatterns', ['/node_modules/']));
+    const testRegexes = testRegex.map((regex) => new RegExp(regex));
+    // Globbing from the project root already applies `**/` globs, so only other
+    // globs need a match check
+    const testMatchers = testMatch.every((pattern) => pattern.startsWith('**/'))
+        ? []
+        : testMatch.map((pattern) => {
+            // Built like jest-util's: minimatch would read `(a|b)` groups literally
+            const isMatch = picomatch(replacePathSepForGlob(replaceRootDirInPath(escapeGlobCharacters(rootDir), pattern)), { dot: true }, true);
+            return {
+                isMatch,
+                negated: isMatch.state.negated || !!isMatch.state.negatedExtglob,
+            };
+        });
+    // Unless every testMatch glob is negated, a file must match a non-negated one
+    const includePatterns = testMatch.filter((_, i) => !testMatchers[i]?.negated);
+    const candidates = await (0, internal_1.globWithWorkspaceContext)(context.workspaceRoot, includePatterns.length > 0
+        ? includePatterns.map((pattern) => {
+            const path = replaceRootDirInPath(rootDir, pattern);
+            return (0, node_path_1.isAbsolute)(path)
+                ? (0, devkit_1.normalizePath)((0, node_path_1.relative)(workspaceRoot, path))
+                : posix.join(projectRoot, pattern);
+        })
+        : [posix.join(projectRoot, '**/*')], []);
+    const workspacePath = (0, devkit_1.normalizePath)((0, node_path_1.join)(workspaceRoot, '/'));
+    const specs = candidates.filter((file) => {
+        const path = workspacePath + file;
+        return (hasExtension(path) &&
+            !modulePathIgnorePattern?.test(path) &&
+            roots.some((root) => path.includes(root)) &&
+            (testMatchers.length === 0 || matchesGlobs(testMatchers, path)) &&
+            !testPathIgnorePattern?.test(path) &&
+            (testRegexes.length === 0 || testRegexes.some((r) => r.test(path))));
+    });
+    return { specs, testMatch };
+}
+function matchesGlobs(matchers, path) {
+    let kept;
+    for (const { isMatch, negated } of matchers) {
+        const matched = isMatch(path);
+        if (!matched && negated) {
+            kept = false;
+        }
+        else if (matched && !negated) {
+            kept = true;
+        }
+    }
+    return matchers.every(({ negated }) => negated)
+        ? kept !== false
+        : kept === true;
+}
+// Ports of the jest-config and jest-util helpers Jest uses to put rootDir into
+// testMatch globs
+function escapeGlobCharacters(path) {
+    return path.replaceAll(/([!()*?[\\\]{}])/g, '\\$1');
+}
+function replacePathSepForGlob(path) {
+    return path.replaceAll(/\\(?![$()+.?^{}])/g, '/');
+}
+function tryRealpath(path) {
+    try {
+        return node_fs_1.realpathSync.native(path);
+    }
+    catch {
+        return path;
+    }
+}
+let nativeFindSupport;
+// Port of jest-haste-map's check for a find that supports -iname, cached
+// because the find on PATH doesn't change during a process lifetime
+function hasNativeFindSupport() {
+    nativeFindSupport ??= new Promise((done) => {
+        try {
+            const child = (0, node_child_process_1.spawn)('find', ['.', '-type', 'f', '(', '-iname', '*.ts', '-o', '-iname', '*.js', ')'], { cwd: __dirname, stdio: 'ignore', windowsHide: true });
+            child.on('error', () => done(false));
+            child.on('exit', (code) => done(code === 0));
+        }
+        catch {
+            done(false);
+        }
+    });
+    return nativeFindSupport;
 }
 /**
  * Collects workspace-relative paths to files whose CONTENT the plugin reads
@@ -939,11 +1068,3 @@ function getTsJestMajorVersion() {
     }
     return cachedTsJestMajorVersion;
 }
-async function getJestOption(rawConfig, rootDir, optionName, presetCache) {
-    if (rawConfig[optionName])
-        return rawConfig[optionName];
-    const preset = await loadPresetConfig(rawConfig, rootDir, presetCache);
-    if (preset?.[optionName])
-        return preset[optionName];
-    return undefined;
-}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/jest",
-  "version": "24.0.1",
+  "version": "24.0.2",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -103,21 +103,22 @@
     }
   },
   "dependencies": {
-    "@nx/devkit": "24.0.1",
-    "@nx/js": "24.0.1",
+    "@nx/devkit": "24.0.2",
+    "@nx/js": "24.0.2",
     "@phenomnomnominal/tsquery": "~6.2.0",
     "identity-obj-proxy": "3.0.0",
     "jest-config": "^30.0.2",
     "jest-resolve": "^30.0.2",
     "jsonc-parser": "^3.2.0",
     "minimatch": "10.2.5",
+    "picomatch": "4.0.4",
     "resolve.exports": "2.0.3",
     "semver": "^7.6.3",
     "tslib": "^2.3.0",
     "yargs-parser": "21.1.1"
   },
   "devDependencies": {
-    "nx": "24.0.1"
+    "nx": "24.0.2"
   },
   "publishConfig": {
     "access": "public"