@nx/jest 23.3.0-pr.37068.f95e11e → 23.3.0-rc.0

package/README.md

@@ -12,7 +12,7 @@
 [![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)](<>)
 [![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
 [![Join us on the Official Nx Discord Server](https://img.shields.io/discord/1143497901675401286?label=discord)](https://go.nx.dev/community)
-[![Nx Sandboxing](https://staging.nx.app/workspaces/62d013ea0852fe0a2df74438/sandbox-badge.svg)](https://nx.dev/docs/features/ci-features/sandboxing)
+[![Hours saved](https://img.shields.io/endpoint?url=https%3A%2F%2Fstaging.nx.app%2Fnx-cloud%2Fbadge%2F62d013ea0852fe0a2df74438%2Fhours-saved.json)](https://nx.dev/nx-cloud)
 
 </div>
 

package/dist/src/generators/init/init.js

@@ -70,10 +70,11 @@ function createJestDefaultPatch(existing, productionFileSet, presetExt) {
 }
 function updateDependencies(tree, options) {
     const { jestVersion, nxVersion } = (0, versions_1.versions)(tree);
-    // jest 30 pulls in unrs-resolver; its postinstall only fetches a fallback
-    // binding for platforms not covered by its prebuilt optional dependencies,
-    // so skip it.
+    // jest-resolve depends on unrs-resolver, and from jest 30.5.0 it pins a
+    // jest-haste-map that depends on @parcel/watcher. Neither build is needed:
+    // the binding has a fallback and the watcher ships prebuilt.
     (0, internal_1.acknowledgeBuildScripts)(tree, (0, devkit_1.detectPackageManager)(tree.root), {
+        '@parcel/watcher': false,
         'unrs-resolver': false,
     });
     return (0, devkit_1.addDependenciesToPackageJson)(tree, {}, {

package/dist/src/plugins/plugin.js

@@ -1,11 +1,13 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.createNodesV2 = exports.createNodes = void 0;
+const tslib_1 = require("tslib");
 const internal_1 = require("@nx/devkit/internal");
 const devkit_1 = require("@nx/devkit");
 const minimatch_1 = require("minimatch");
 const node_fs_1 = require("node:fs");
 const node_path_1 = require("node:path");
+const posix = tslib_1.__importStar(require("node:path/posix"));
 const js_1 = require("@nx/js");
 const internal_2 = require("@nx/js/internal");
 const versions_1 = require("../utils/versions");
@@ -171,14 +173,19 @@ async function buildJestTargets(rawConfig, needsDtsInputs, configFilePath, proje
     const rootDir = rawConfig.rootDir
         ? (0, node_path_1.resolve)((0, node_path_1.dirname)(absConfigFilePath), rawConfig.rootDir)
         : (0, node_path_1.resolve)(context.workspaceRoot, projectRoot);
-    const cache = (target.cache = true);
+    let cache = (target.cache = true);
     const inputs = (target.inputs = await getInputs(namedInputs, rawConfig, rootDir, projectRoot, context.workspaceRoot, presetCache, needsDtsInputs, useJestResolver));
     let metadata;
     const groupName = options?.ciGroupName ?? (0, internal_1.deriveGroupNameFromTarget)(options?.ciTargetName);
     if (disableJestRuntime) {
-        const outputs = (target.outputs = getOutputs(projectRoot, rawConfig.coverageDirectory
-            ? (0, node_path_1.join)(context.workspaceRoot, projectRoot, rawConfig.coverageDirectory)
-            : undefined, undefined, context));
+        const { outputs, cacheable } = getOutputs(projectRoot, 
+        // Mirrors jest-config `normalize`: resolve against rootDir after the
+        // `<rootDir>` token, leaving an absolute path untouched.
+        rawConfig.coverageDirectory
+            ? (0, node_path_1.resolve)(rootDir, replaceRootDirInPath(rootDir, rawConfig.coverageDirectory))
+            : undefined, undefined, context);
+        target.outputs = outputs;
+        cache = target.cache = cacheable;
         if (options?.ciTargetName) {
             const { specs, testMatch } = await getTestPaths(projectRoot, rawConfig, rootDir, context, presetCache);
             const targetGroup = [];
@@ -237,7 +244,7 @@ async function buildJestTargets(rawConfig, needsDtsInputs, configFilePath, proje
             if (targetGroup.length > 0) {
                 targets[options.ciTargetName] = {
                     executor: 'nx:noop',
-                    cache: true,
+                    cache,
                     inputs,
                     outputs,
                     dependsOn,
@@ -266,13 +273,17 @@ async function buildJestTargets(rawConfig, needsDtsInputs, configFilePath, proje
             config = await readConfig({
                 _: [],
                 $0: undefined,
-            }, rawConfig, undefined, (0, node_path_1.dirname)(absConfigFilePath));
+            }, 
+            // Jest resolves a relative rootDir only when it reads the file itself.
+            rawConfig.rootDir ? { ...rawConfig, rootDir } : rawConfig, undefined, (0, node_path_1.dirname)(absConfigFilePath));
         }
         catch (e) {
             console.error(e);
             throw e;
         }
-        const outputs = (target.outputs = getOutputs(projectRoot, config.globalConfig?.coverageDirectory, config.globalConfig?.outputFile, context));
+        const { outputs, cacheable } = getOutputs(projectRoot, config.globalConfig?.coverageDirectory, config.globalConfig?.outputFile, context);
+        target.outputs = outputs;
+        cache = target.cache = cacheable;
         if (options?.ciTargetName) {
             // nx-ignore-next-line
             const { default: Runtime } = requireJestUtil('jest-runtime', projectRoot, context.workspaceRoot);
@@ -342,7 +353,7 @@ async function buildJestTargets(rawConfig, needsDtsInputs, configFilePath, proje
                 }
                 targets[options.ciTargetName] = {
                     executor: 'nx:noop',
-                    cache: true,
+                    cache,
                     inputs,
                     outputs,
                     dependsOn,
@@ -534,19 +545,22 @@ function getOutputs(projectRoot, coverageDirectory, outputFile, context) {
     function getOutput(path) {
         const relativePath = (0, node_path_1.relative)((0, node_path_1.join)(context.workspaceRoot, projectRoot), path);
         if (relativePath.startsWith('..')) {
-            return (0, node_path_1.join)('{workspaceRoot}', (0, node_path_1.join)(projectRoot, relativePath));
+            return (0, devkit_1.joinPathFragments)('{workspaceRoot}', projectRoot, relativePath);
         }
         else {
-            return (0, node_path_1.join)('{projectRoot}', relativePath);
+            return (0, devkit_1.joinPathFragments)('{projectRoot}', relativePath);
         }
     }
-    const outputs = [];
-    for (const outputOption of [coverageDirectory, outputFile]) {
-        if (outputOption) {
-            outputs.push(getOutput(outputOption));
-        }
-    }
-    return outputs;
+    const outputPaths = [coverageDirectory, outputFile].filter((path) => !!path);
+    // Outputs outside the workspace cannot be cached: keep the target runnable
+    // but uncached.
+    const cacheable = outputPaths.every((path) => !isPathOutside((0, node_path_1.relative)(context.workspaceRoot, path)));
+    return { outputs: cacheable ? outputPaths.map(getOutput) : [], cacheable };
+}
+function isPathOutside(relativePath) {
+    return (relativePath === '..' ||
+        relativePath.startsWith(`..${node_path_1.sep}`) ||
+        (0, node_path_1.isAbsolute)(relativePath));
 }
 function normalizeOptions(options) {
     options ??= {};
@@ -587,7 +601,7 @@ async function getTestPaths(projectRoot, rawConfig, rootDir, context, presetCach
         // Default copied from https://github.com/jestjs/jest/blob/d1a2ed7/packages/jest-config/src/Defaults.ts#L84
         '**/__tests__/**/*.?([mc])[jt]s?(x)',
         '**/?(*.)+(spec|test).?([mc])[jt]s?(x)',
-    ]).map((pattern) => (0, node_path_1.join)(projectRoot, pattern)), []);
+    ]).map((pattern) => posix.join(projectRoot, pattern)), []);
     const testRegex = await getJestOption(rawConfig, rootDir, 'testRegex', presetCache);
     if (testRegex) {
         const testRegexes = Array.isArray(rawConfig.testRegex)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/jest",
-  "version": "23.3.0-pr.37068.f95e11e",
+  "version": "23.3.0-rc.0",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -105,6 +105,8 @@
   "dependencies": {
     "@jest/reporters": "^30.0.2",
     "@jest/test-result": "^30.0.2",
+    "@nx/devkit": "23.3.0-rc.0",
+    "@nx/js": "23.3.0-rc.0",
     "@phenomnomnominal/tsquery": "~6.2.0",
     "identity-obj-proxy": "3.0.0",
     "jest-config": "^30.0.2",
@@ -116,12 +118,10 @@
     "resolve.exports": "2.0.3",
     "semver": "^7.6.3",
     "tslib": "^2.3.0",
-    "yargs-parser": "21.1.1",
-    "@nx/devkit": "23.3.0-pr.37068.f95e11e",
-    "@nx/js": "23.3.0-pr.37068.f95e11e"
+    "yargs-parser": "21.1.1"
   },
   "devDependencies": {
-    "nx": "23.3.0-pr.37068.f95e11e"
+    "nx": "23.3.0-rc.0"
   },
   "publishConfig": {
     "access": "public"

package/readme-template.md

@@ -0,0 +1,18 @@
+<p style="text-align: center;">
+  <picture>
+    <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-dark.svg">
+    <img alt="Nx - Smart Monorepos · Fast Builds" src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-light.svg" width="100%">
+  </picture>
+</p>
+
+{{links}}
+
+<hr>
+
+# Nx: Smart Monorepos · Fast Builds
+
+Get to green PRs in half the time. Nx optimizes your builds, scales your CI, and fixes failed PRs. Built for developers and AI agents.
+
+This package is a [Jest plugin for Nx](https://nx.dev/jest/overview).
+
+{{content}}