@nx/jest 23.3.0-beta.2 → 23.3.0-beta.4

package/dist/src/generators/init/init.js

@@ -70,10 +70,11 @@ function createJestDefaultPatch(existing, productionFileSet, presetExt) {
 }
 function updateDependencies(tree, options) {
     const { jestVersion, nxVersion } = (0, versions_1.versions)(tree);
-    // jest 30 pulls in unrs-resolver; its postinstall only fetches a fallback
-    // binding for platforms not covered by its prebuilt optional dependencies,
-    // so skip it.
+    // jest-resolve depends on unrs-resolver, and from jest 30.5.0 it pins a
+    // jest-haste-map that depends on @parcel/watcher. Neither build is needed:
+    // the binding has a fallback and the watcher ships prebuilt.
     (0, internal_1.acknowledgeBuildScripts)(tree, (0, devkit_1.detectPackageManager)(tree.root), {
+        '@parcel/watcher': false,
         'unrs-resolver': false,
     });
     return (0, devkit_1.addDependenciesToPackageJson)(tree, {}, {

package/dist/src/plugins/plugin.js

@@ -171,14 +171,19 @@ async function buildJestTargets(rawConfig, needsDtsInputs, configFilePath, proje
     const rootDir = rawConfig.rootDir
         ? (0, node_path_1.resolve)((0, node_path_1.dirname)(absConfigFilePath), rawConfig.rootDir)
         : (0, node_path_1.resolve)(context.workspaceRoot, projectRoot);
-    const cache = (target.cache = true);
+    let cache = (target.cache = true);
     const inputs = (target.inputs = await getInputs(namedInputs, rawConfig, rootDir, projectRoot, context.workspaceRoot, presetCache, needsDtsInputs, useJestResolver));
     let metadata;
     const groupName = options?.ciGroupName ?? (0, internal_1.deriveGroupNameFromTarget)(options?.ciTargetName);
     if (disableJestRuntime) {
-        const outputs = (target.outputs = getOutputs(projectRoot, rawConfig.coverageDirectory
-            ? (0, node_path_1.join)(context.workspaceRoot, projectRoot, rawConfig.coverageDirectory)
-            : undefined, undefined, context));
+        const { outputs, cacheable } = getOutputs(projectRoot, 
+        // Mirrors jest-config `normalize`: resolve against rootDir after the
+        // `<rootDir>` token, leaving an absolute path untouched.
+        rawConfig.coverageDirectory
+            ? (0, node_path_1.resolve)(rootDir, replaceRootDirInPath(rootDir, rawConfig.coverageDirectory))
+            : undefined, undefined, context);
+        target.outputs = outputs;
+        cache = target.cache = cacheable;
         if (options?.ciTargetName) {
             const { specs, testMatch } = await getTestPaths(projectRoot, rawConfig, rootDir, context, presetCache);
             const targetGroup = [];
@@ -237,7 +242,7 @@ async function buildJestTargets(rawConfig, needsDtsInputs, configFilePath, proje
             if (targetGroup.length > 0) {
                 targets[options.ciTargetName] = {
                     executor: 'nx:noop',
-                    cache: true,
+                    cache,
                     inputs,
                     outputs,
                     dependsOn,
@@ -266,13 +271,17 @@ async function buildJestTargets(rawConfig, needsDtsInputs, configFilePath, proje
             config = await readConfig({
                 _: [],
                 $0: undefined,
-            }, rawConfig, undefined, (0, node_path_1.dirname)(absConfigFilePath));
+            }, 
+            // Jest resolves a relative rootDir only when it reads the file itself.
+            rawConfig.rootDir ? { ...rawConfig, rootDir } : rawConfig, undefined, (0, node_path_1.dirname)(absConfigFilePath));
         }
         catch (e) {
             console.error(e);
             throw e;
         }
-        const outputs = (target.outputs = getOutputs(projectRoot, config.globalConfig?.coverageDirectory, config.globalConfig?.outputFile, context));
+        const { outputs, cacheable } = getOutputs(projectRoot, config.globalConfig?.coverageDirectory, config.globalConfig?.outputFile, context);
+        target.outputs = outputs;
+        cache = target.cache = cacheable;
         if (options?.ciTargetName) {
             // nx-ignore-next-line
             const { default: Runtime } = requireJestUtil('jest-runtime', projectRoot, context.workspaceRoot);
@@ -342,7 +351,7 @@ async function buildJestTargets(rawConfig, needsDtsInputs, configFilePath, proje
                 }
                 targets[options.ciTargetName] = {
                     executor: 'nx:noop',
-                    cache: true,
+                    cache,
                     inputs,
                     outputs,
                     dependsOn,
@@ -534,19 +543,22 @@ function getOutputs(projectRoot, coverageDirectory, outputFile, context) {
     function getOutput(path) {
         const relativePath = (0, node_path_1.relative)((0, node_path_1.join)(context.workspaceRoot, projectRoot), path);
         if (relativePath.startsWith('..')) {
-            return (0, node_path_1.join)('{workspaceRoot}', (0, node_path_1.join)(projectRoot, relativePath));
+            return (0, devkit_1.joinPathFragments)('{workspaceRoot}', projectRoot, relativePath);
         }
         else {
-            return (0, node_path_1.join)('{projectRoot}', relativePath);
+            return (0, devkit_1.joinPathFragments)('{projectRoot}', relativePath);
         }
     }
-    const outputs = [];
-    for (const outputOption of [coverageDirectory, outputFile]) {
-        if (outputOption) {
-            outputs.push(getOutput(outputOption));
-        }
-    }
-    return outputs;
+    const outputPaths = [coverageDirectory, outputFile].filter((path) => !!path);
+    // Outputs outside the workspace cannot be cached: keep the target runnable
+    // but uncached.
+    const cacheable = outputPaths.every((path) => !isPathOutside((0, node_path_1.relative)(context.workspaceRoot, path)));
+    return { outputs: cacheable ? outputPaths.map(getOutput) : [], cacheable };
+}
+function isPathOutside(relativePath) {
+    return (relativePath === '..' ||
+        relativePath.startsWith(`..${node_path_1.sep}`) ||
+        (0, node_path_1.isAbsolute)(relativePath));
 }
 function normalizeOptions(options) {
     options ??= {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/jest",
-  "version": "23.3.0-beta.2",
+  "version": "23.3.0-beta.4",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -117,11 +117,11 @@
     "semver": "^7.6.3",
     "tslib": "^2.3.0",
     "yargs-parser": "21.1.1",
-    "@nx/devkit": "23.3.0-beta.2",
-    "@nx/js": "23.3.0-beta.2"
+    "@nx/devkit": "23.3.0-beta.4",
+    "@nx/js": "23.3.0-beta.4"
   },
   "devDependencies": {
-    "nx": "23.3.0-beta.2"
+    "nx": "23.3.0-beta.4"
   },
   "publishConfig": {
     "access": "public"