@nx/jest 23.1.0-beta.3 → 23.1.0-beta.4

package/dist/src/migrations/update-23-1-0/set-ts-jest-isolated-modules.md

@@ -39,3 +39,13 @@ TypeScript 6 and above resolves `exports` under `bundler` with `commonjs`, so th
   }
 }
 ```
+
+#### Verifying the workspace
+
+After the migration runs, verify the workspace still typechecks and fix anything `isolatedModules` surfaced:
+
+```bash
+nx run-many -t typecheck
+```
+
+`isolatedModules` can fail typecheck (TS1205 - re-exporting a type needs `export type`; TS2748 - const enum access) or break a project's tests at runtime even when typecheck passes. The cause is a package that re-exports a value through both `module.exports` and an ESM `export` (for example napi bindings exposing a `const enum`); per-file transpilation cannot preserve it, and consumers of that const enum break too. To fix a broken project, remove `isolatedModules` from its `tsconfig.spec.json`; if that brings back the `TS2307: Cannot find module` error this migration was added to prevent, that project needs `isolatedModules`, so fix the source instead.

package/dist/src/migrations/update-23-1-0/verify-typecheck.md

@@ -0,0 +1,14 @@
+# Verify typecheck after the Nx 23.1 migration
+
+This migration enables `isolatedModules` on ts-jest spec configs. Run
+`nx run-many -t typecheck` and fix any project it broke.
+
+`isolatedModules` can fail typecheck (TS1205 - a re-exported type needs `export type`;
+TS2748 - const enum access) or break a project's tests at runtime. To fix a broken
+project, remove `isolatedModules` from its `tsconfig.spec.json` and re-run. If a
+`TS2307: Cannot find module` error then appears for a workspace library, that project
+needs `isolatedModules` - keep it and fix the source instead (avoid mixing
+`module.exports` with an ESM `export`, and avoid cross-file `const enum`).
+
+Re-run until the projects this migration touched typecheck. See the migration
+documentation for details.

package/migrations.json

@@ -79,12 +79,13 @@
       "documentation": "./dist/src/migrations/update-23-0-0/migrate-create-nodes-v2-to-create-nodes.md"
     },
     "set-ts-jest-isolated-modules": {
-      "version": "23.1.0-beta.3",
+      "version": "23.1.0-beta.4",
       "requires": {
         "ts-jest": ">=29.2.0"
       },
-      "description": "Set `isolatedModules: true` in `tsconfig.spec.json` for ts-jest projects on TypeScript < 6. ts-jest 29.2+ forces `moduleResolution: node10` on the CommonJS path, which ignores package `exports` maps and breaks (TS2307) resolution of exports-only workspace libraries; transpiling per file avoids the type-resolution failure.",
+      "description": "Set `isolatedModules: true` in `tsconfig.spec.json` for ts-jest projects on TypeScript < 6 (ts-jest 29.2+ forces `moduleResolution: node10` on the CommonJS path, which ignores package `exports` maps and breaks resolution of exports-only workspace libraries), then verify the workspace still typechecks and remedy any failures the change surfaced.",
       "implementation": "./dist/src/migrations/update-23-1-0/set-ts-jest-isolated-modules",
+      "prompt": "./dist/src/migrations/update-23-1-0/verify-typecheck.md",
       "documentation": "./dist/src/migrations/update-23-1-0/set-ts-jest-isolated-modules.md"
     }
   },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/jest",
-  "version": "23.1.0-beta.3",
+  "version": "23.1.0-beta.4",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -117,11 +117,11 @@
     "semver": "^7.6.3",
     "tslib": "^2.3.0",
     "yargs-parser": "21.1.1",
-    "@nx/devkit": "23.1.0-beta.3",
-    "@nx/js": "23.1.0-beta.3"
+    "@nx/devkit": "23.1.0-beta.4",
+    "@nx/js": "23.1.0-beta.4"
   },
   "devDependencies": {
-    "nx": "23.1.0-beta.3"
+    "nx": "23.1.0-beta.4"
   },
   "publishConfig": {
     "access": "public"