@nx/jest 23.1.0-beta.2 → 23.1.0-beta.4

package/dist/src/generators/configuration/files/common/tsconfig.spec.json__tmpl__

@@ -3,7 +3,8 @@
   "compilerOptions": {
     "outDir": "<%= outDir %>",<% if (module) { %>
     "module": "<%= module %>",<% } if (module === 'commonjs') { %>
-    "moduleResolution": "<%= moduleResolution %>",<% } if (supportTsx) { %>
+    "moduleResolution": "<%= moduleResolution %>",<% } if (isolatedModules) { %>
+    "isolatedModules": true,<% } if (supportTsx) { %>
     "jsx": "react-jsx",<% } %>"types": ["jest", "node"]
   },<% if(setupFile !== 'none') { %>
   "files": ["src/test-setup.ts"],<% } %>

package/dist/src/generators/configuration/lib/create-files.js

@@ -46,6 +46,16 @@ function createFiles(tree, options, presetExt) {
     const coverageDirectory = options.isTsSolutionSetup
         ? `test-output/jest/coverage`
         : `${rootOffset}coverage/${projectRoot}`;
+    const usesTsJestModuleSettings = !options.isTsSolutionSetup || transformer === 'ts-jest';
+    const moduleResolution = usesTsJestModuleSettings
+        ? (0, internal_1.getTsConfigModuleResolution)(tree)
+        : undefined;
+    // ts-jest forces `moduleResolution: node10` on the CommonJS path for
+    // TypeScript < 6, and node10 ignores package `exports`. Transpiling per file
+    // keeps exports-only workspace libraries resolvable. See NXC-4591.
+    const isolatedModules = options.isTsSolutionSetup &&
+        transformer === 'ts-jest' &&
+        moduleResolution === 'node10';
     (0, devkit_1.generateFiles)(tree, (0, path_1.join)(__dirname, commonFilesFolder), projectConfig.root, {
         tmpl: '',
         ...options,
@@ -64,12 +74,9 @@ function createFiles(tree, options, presetExt) {
         outDir: options.isTsSolutionSetup
             ? `./out-tsc/jest`
             : `${rootOffset}dist/out-tsc`,
-        module: !options.isTsSolutionSetup || transformer === 'ts-jest'
-            ? 'commonjs'
-            : undefined,
-        moduleResolution: !options.isTsSolutionSetup || transformer === 'ts-jest'
-            ? (0, internal_1.getTsConfigModuleResolution)(tree)
-            : undefined,
+        module: usesTsJestModuleSettings ? 'commonjs' : undefined,
+        moduleResolution,
+        isolatedModules,
     });
     if (options.setupFile !== 'angular') {
         (0, devkit_1.generateFiles)(tree, (0, path_1.join)(__dirname, options.isTsSolutionSetup

package/dist/src/migrations/update-23-1-0/set-ts-jest-isolated-modules.d.ts

@@ -0,0 +1,8 @@
+import { type Tree } from '@nx/devkit';
+/**
+ * NXC-4591: ts-jest 29.2+ uses `moduleResolution: node10` on the CommonJS path
+ * for TypeScript < 6, which ignores package `exports` and breaks exports-only
+ * workspace libs (TS2307). `isolatedModules: true` makes ts-jest transpile per
+ * file, skipping that resolution. TS >= 6 is unaffected.
+ */
+export default function (tree: Tree): Promise<void>;

package/dist/src/migrations/update-23-1-0/set-ts-jest-isolated-modules.js

@@ -0,0 +1,86 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = default_1;
+const devkit_1 = require("@nx/devkit");
+const internal_1 = require("@nx/js/internal");
+const jsonc_parser_1 = require("jsonc-parser");
+const config_file_1 = require("../../utils/config/config-file");
+const FORMATTING_OPTIONS = {
+    formattingOptions: { keepLines: true, insertSpaces: true, tabSize: 2 },
+};
+// A jest config mentioning any of these uses swc/babel/angular (or is the root
+// aggregator), not ts-jest, so skip it.
+const NON_TS_JEST_MARKERS = [
+    '@swc/jest',
+    'babel-jest',
+    'jest-preset-angular',
+    'getJestProjectsAsync',
+];
+/**
+ * NXC-4591: ts-jest 29.2+ uses `moduleResolution: node10` on the CommonJS path
+ * for TypeScript < 6, which ignores package `exports` and breaks exports-only
+ * workspace libs (TS2307). `isolatedModules: true` makes ts-jest transpile per
+ * file, skipping that resolution. TS >= 6 is unaffected.
+ */
+async function default_1(tree) {
+    // TS >= 6 resolves `exports` under bundler + commonjs; not affected.
+    if ((0, internal_1.isTypescriptVersionAtLeast)(tree, '6.0.0')) {
+        return;
+    }
+    // Path-based workspaces resolve via tsconfig `paths`, not `exports`; skip them.
+    if (!(0, internal_1.isUsingTsSolutionSetup)(tree)) {
+        return;
+    }
+    // Fresh ts-solution workspaces already enable this in the base config.
+    if (rootEnablesIsolatedModules(tree)) {
+        return;
+    }
+    let count = 0;
+    for (const [, project] of (0, devkit_1.getProjects)(tree)) {
+        const specPath = getTsJestSpecTsconfig(tree, project.root);
+        if (specPath && setIsolatedModules(tree, specPath)) {
+            count++;
+        }
+    }
+    if (count > 0) {
+        devkit_1.logger.info(`NXC-4591: set "isolatedModules": true in ${count} tsconfig.spec.json file(s) so ts-jest resolves exports-only workspace libraries on TypeScript < 6.`);
+    }
+    await (0, devkit_1.formatFiles)(tree);
+}
+function rootEnablesIsolatedModules(tree) {
+    return (readCompilerOption(tree, 'tsconfig.base.json', 'isolatedModules') === true);
+}
+// The project's tsconfig.spec.json if it runs ts-jest, else null.
+function getTsJestSpecTsconfig(tree, root) {
+    const jestConfig = (0, config_file_1.findJestConfig)(tree, root);
+    if (!jestConfig) {
+        return null;
+    }
+    const source = tree.read(jestConfig, 'utf-8') ?? '';
+    if (NON_TS_JEST_MARKERS.some((marker) => source.includes(marker))) {
+        return null;
+    }
+    const specPath = (0, devkit_1.joinPathFragments)(root, 'tsconfig.spec.json');
+    return tree.exists(specPath) ? specPath : null;
+}
+function setIsolatedModules(tree, tsconfigPath) {
+    if (readCompilerOption(tree, tsconfigPath, 'isolatedModules') === true) {
+        return false;
+    }
+    const contents = tree.read(tsconfigPath, 'utf-8');
+    if (!contents) {
+        return false;
+    }
+    const edits = (0, jsonc_parser_1.modify)(contents, ['compilerOptions', 'isolatedModules'], true, FORMATTING_OPTIONS);
+    tree.write(tsconfigPath, (0, jsonc_parser_1.applyEdits)(contents, edits));
+    return true;
+}
+function readCompilerOption(tree, tsconfigPath, option) {
+    const contents = tree.read(tsconfigPath, 'utf-8');
+    if (!contents) {
+        return undefined;
+    }
+    const root = (0, jsonc_parser_1.parseTree)(contents);
+    const node = root && (0, jsonc_parser_1.findNodeAtLocation)(root, ['compilerOptions', option]);
+    return node ? (0, jsonc_parser_1.getNodeValue)(node) : undefined;
+}

package/dist/src/migrations/update-23-1-0/set-ts-jest-isolated-modules.md

@@ -0,0 +1,51 @@
+#### Set isolatedModules for ts-jest below TypeScript 6
+
+The jest 30 path of `@nx/jest` bumps ts-jest to 29.4.x.
+On the CommonJS jest path, ts-jest 29.2+ uses `moduleResolution: node10` when `bundler` is invalid alongside the forced `module: commonjs`, which is the case below TypeScript 6.
+`node10` does not read package `exports` maps, so a workspace library that exposes types only through `exports` fails to resolve during the ts-jest type check:
+
+```text
+error TS2307: Cannot find module '@my-org/some-lib' or its corresponding type declarations.
+```
+
+The migration sets `isolatedModules: true` in each affected `tsconfig.spec.json`, so ts-jest transpiles each file independently and skips the cross-file type resolution that was failing.
+This matches the `isolatedModules: true` that fresh ts-solution workspaces already set in `tsconfig.base.json`.
+Type checking stays on each project's dedicated typecheck target.
+
+The migration runs only below TypeScript 6, in ts-solution workspaces that do not already enable `isolatedModules`.
+TypeScript 6 and above resolves `exports` under `bundler` with `commonjs`, so those workspaces are left unchanged.
+
+#### Sample code changes
+
+##### Before
+
+```json title="tsconfig.spec.json"
+{
+  "extends": "../../tsconfig.base.json",
+  "compilerOptions": {
+    "types": ["jest", "node"]
+  }
+}
+```
+
+##### After
+
+```json title="tsconfig.spec.json" {4}
+{
+  "extends": "../../tsconfig.base.json",
+  "compilerOptions": {
+    "isolatedModules": true,
+    "types": ["jest", "node"]
+  }
+}
+```
+
+#### Verifying the workspace
+
+After the migration runs, verify the workspace still typechecks and fix anything `isolatedModules` surfaced:
+
+```bash
+nx run-many -t typecheck
+```
+
+`isolatedModules` can fail typecheck (TS1205 - re-exporting a type needs `export type`; TS2748 - const enum access) or break a project's tests at runtime even when typecheck passes. The cause is a package that re-exports a value through both `module.exports` and an ESM `export` (for example napi bindings exposing a `const enum`); per-file transpilation cannot preserve it, and consumers of that const enum break too. To fix a broken project, remove `isolatedModules` from its `tsconfig.spec.json`; if that brings back the `TS2307: Cannot find module` error this migration was added to prevent, that project needs `isolatedModules`, so fix the source instead.

package/dist/src/migrations/update-23-1-0/verify-typecheck.md

@@ -0,0 +1,14 @@
+# Verify typecheck after the Nx 23.1 migration
+
+This migration enables `isolatedModules` on ts-jest spec configs. Run
+`nx run-many -t typecheck` and fix any project it broke.
+
+`isolatedModules` can fail typecheck (TS1205 - a re-exported type needs `export type`;
+TS2748 - const enum access) or break a project's tests at runtime. To fix a broken
+project, remove `isolatedModules` from its `tsconfig.spec.json` and re-run. If a
+`TS2307: Cannot find module` error then appears for a workspace library, that project
+needs `isolatedModules` - keep it and fix the source instead (avoid mixing
+`module.exports` with an ESM `export`, and avoid cross-file `const enum`).
+
+Re-run until the projects this migration touched typecheck. See the migration
+documentation for details.

package/migrations.json

@@ -77,6 +77,16 @@
       "description": "Rename imports of `createNodesV2` from `@nx/jest/plugin` to the canonical `createNodes` export.",
       "implementation": "./dist/src/migrations/update-23-0-0/migrate-create-nodes-v2-to-create-nodes",
       "documentation": "./dist/src/migrations/update-23-0-0/migrate-create-nodes-v2-to-create-nodes.md"
+    },
+    "set-ts-jest-isolated-modules": {
+      "version": "23.1.0-beta.4",
+      "requires": {
+        "ts-jest": ">=29.2.0"
+      },
+      "description": "Set `isolatedModules: true` in `tsconfig.spec.json` for ts-jest projects on TypeScript < 6 (ts-jest 29.2+ forces `moduleResolution: node10` on the CommonJS path, which ignores package `exports` maps and breaks resolution of exports-only workspace libraries), then verify the workspace still typechecks and remedy any failures the change surfaced.",
+      "implementation": "./dist/src/migrations/update-23-1-0/set-ts-jest-isolated-modules",
+      "prompt": "./dist/src/migrations/update-23-1-0/verify-typecheck.md",
+      "documentation": "./dist/src/migrations/update-23-1-0/set-ts-jest-isolated-modules.md"
     }
   },
   "packageJsonUpdates": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/jest",
-  "version": "23.1.0-beta.2",
+  "version": "23.1.0-beta.4",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -110,17 +110,18 @@
     "jest-config": "^30.0.2",
     "jest-resolve": "^30.0.2",
     "jest-util": "^30.0.2",
+    "jsonc-parser": "^3.2.0",
     "minimatch": "10.2.5",
     "picocolors": "^1.1.0",
     "resolve.exports": "2.0.3",
     "semver": "^7.6.3",
     "tslib": "^2.3.0",
     "yargs-parser": "21.1.1",
-    "@nx/devkit": "23.1.0-beta.2",
-    "@nx/js": "23.1.0-beta.2"
+    "@nx/devkit": "23.1.0-beta.4",
+    "@nx/js": "23.1.0-beta.4"
   },
   "devDependencies": {
-    "nx": "23.1.0-beta.2"
+    "nx": "23.1.0-beta.4"
   },
   "publishConfig": {
     "access": "public"