@nx/gradle 23.1.1 → 23.1.2

package/dist/src/executors/gradle/gradle-batch.impl.d.ts

@@ -1,7 +1,6 @@
 import { ExecutorContext, ProjectGraphProjectNode, TaskGraph } from '@nx/devkit';
-import { RunCommandsOptions } from 'nx/src/executors/run-commands/run-commands.impl';
-import { TaskResult } from 'nx/src/config/misc-interfaces';
 import { GradleExecutorSchema } from './schema';
+import { RunCommandsOptions, TaskResult } from '@nx/devkit/internal';
 export declare const batchRunnerPath: string;
 export default function gradleBatch(taskGraph: TaskGraph, inputs: Record<string, GradleExecutorSchema>, overrides: RunCommandsOptions, context: ExecutorContext): AsyncGenerator<{
     task: string;

package/dist/src/executors/gradle/gradle.impl.js

@@ -1,11 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = gradleExecutor;
-const tslib_1 = require("tslib");
 const devkit_1 = require("@nx/devkit");
 const exec_gradle_1 = require("../../utils/exec-gradle");
 const node_path_1 = require("node:path");
-const run_commands_impl_1 = tslib_1.__importDefault(require("nx/src/executors/run-commands/run-commands.impl"));
+const internal_1 = require("@nx/devkit/internal");
 const get_exclude_task_1 = require("./get-exclude-task");
 async function gradleExecutor(options, context) {
     let projectRoot = context.projectGraph.nodes[context.projectName]?.data?.root ?? context.root;
@@ -56,7 +55,7 @@ async function gradleExecutor(options, context) {
         });
     }
     try {
-        const { success } = await (0, run_commands_impl_1.default)({
+        const { success } = await (0, internal_1.runCommandsExecutor)({
             command: `${gradlewPath} ${options.taskName}`,
             cwd: (0, node_path_1.dirname)(gradlewPath),
             args: args,

package/dist/src/generators/ci-workflow/generator.js

@@ -3,8 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.ciWorkflowGenerator = ciWorkflowGenerator;
 const devkit_1 = require("@nx/devkit");
 const path_1 = require("path");
-const nx_cloud_utils_1 = require("nx/src/utils/nx-cloud-utils");
-const default_base_1 = require("nx/src/utils/default-base");
+const internal_1 = require("@nx/devkit/internal");
 function getCiCommands(ci) {
     switch (ci) {
         case 'circleci': {
@@ -54,13 +53,13 @@ function getTemplateData(tree, options) {
     const { name: workflowName, fileName: workflowFileName } = (0, devkit_1.names)(options.name);
     let nxCloudHost = 'nx.app';
     try {
-        const nxCloudUrl = (0, nx_cloud_utils_1.getNxCloudUrl)((0, devkit_1.readNxJson)(tree));
+        const nxCloudUrl = (0, internal_1.getNxCloudUrl)((0, devkit_1.readNxJson)(tree));
         nxCloudHost = new URL(nxCloudUrl).host;
     }
     catch { }
-    const mainBranch = (0, default_base_1.deduceDefaultBase)();
+    const mainBranch = (0, internal_1.deduceDefaultBase)();
     const commands = options.commands ?? getCiCommands(options.ci);
-    const connectedToCloud = (0, nx_cloud_utils_1.isNxCloudUsed)((0, devkit_1.readNxJson)(tree));
+    const connectedToCloud = (0, internal_1.isNxCloudUsed)((0, devkit_1.readNxJson)(tree));
     return {
         workflowName,
         workflowFileName,

package/dist/src/generators/init/gradle-project-graph-plugin-utils.js

@@ -205,14 +205,15 @@ async function addNxProjectGraphPluginToBuildGradle(gradleFilePath, buildGradleC
     if (!hasPluginViaAlias) {
         const applyPluginPattern = versionCatalogPluginAccessor
             ? new RegExp(`\\s*plugin\\(${versionCatalogPluginAccessor.replace(/\./g, '\\.')}\\)`)
-            : new RegExp(`\\s*plugin\\(["']${versions_1.gradleProjectGraphPluginName}["']\\)`);
+            : // Both DSL forms, so a re-run doesn't append a duplicate apply.
+                new RegExp(`\\s*plugin\\s*[:(]\\s*["']${versions_1.gradleProjectGraphPluginName.replace(/\./g, '\\.')}["']`);
         if (buildGradleContent.includes('allprojects {')) {
             if (!applyPluginPattern.test(buildGradleContent)) {
                 const applyPlugin = versionCatalogPluginAccessor
                     ? `plugin(${versionCatalogPluginAccessor})`
                     : isKotlinDsl
                         ? `plugin("${versions_1.gradleProjectGraphPluginName}")`
-                        : `plugin "${versions_1.gradleProjectGraphPluginName}"`;
+                        : `plugin: "${versions_1.gradleProjectGraphPluginName}"`;
                 buildGradleContent = buildGradleContent.replace(/allprojects\s*\{/, `allprojects {\n    apply ${applyPlugin}`);
             }
         }

package/dist/src/plugin/dependencies.js

@@ -5,10 +5,10 @@ const devkit_1 = require("@nx/devkit");
 const node_path_1 = require("node:path");
 const get_project_graph_from_gradle_plugin_1 = require("./utils/get-project-graph-from-gradle-plugin");
 const split_config_files_1 = require("../utils/split-config-files");
-const workspace_context_1 = require("nx/src/utils/workspace-context");
 const node_fs_1 = require("node:fs");
+const internal_1 = require("@nx/devkit/internal");
 const createDependencies = async (options, context) => {
-    const files = await (0, workspace_context_1.globWithWorkspaceContext)(devkit_1.workspaceRoot, Array.from(split_config_files_1.GRADLEW_FILES));
+    const files = await (0, internal_1.globWithWorkspaceContext)(devkit_1.workspaceRoot, Array.from(split_config_files_1.GRADLEW_FILES));
     const { gradlewFiles } = (0, split_config_files_1.splitConfigFiles)(files);
     await (0, get_project_graph_from_gradle_plugin_1.populateProjectGraph)(context.workspaceRoot, gradlewFiles.map((file) => (0, node_path_1.join)(devkit_1.workspaceRoot, file)), options);
     const { dependencies: dependenciesFromReport } = (0, get_project_graph_from_gradle_plugin_1.getCurrentProjectGraphReport)();

package/dist/src/plugin/nodes.js

@@ -4,9 +4,6 @@ exports.makeCreateNodesForGradleConfigFile = exports.createNodesV2 = exports.cre
 const internal_1 = require("@nx/devkit/internal");
 const devkit_1 = require("@nx/devkit");
 const node_path_1 = require("node:path");
-const cache_directory_1 = require("nx/src/utils/cache-directory");
-const plugin_cache_utils_1 = require("nx/src/utils/plugin-cache-utils");
-const file_hasher_1 = require("nx/src/hasher/file-hasher");
 const split_config_files_1 = require("../utils/split-config-files");
 const get_project_graph_from_gradle_plugin_1 = require("./utils/get-project-graph-from-gradle-plugin");
 const gradle_plugin_options_1 = require("./utils/gradle-plugin-options");
@@ -71,9 +68,9 @@ exports.createNodes = [
     split_config_files_1.gradleConfigAndTestGlob,
     async (files, options, context) => {
         const { buildFiles: buildFilesFromSplitConfigFiles, gradlewFiles } = (0, split_config_files_1.splitConfigFiles)(files);
-        const optionsHash = (0, file_hasher_1.hashObject)(options);
-        const cachePath = (0, node_path_1.join)(cache_directory_1.workspaceDataDirectory, `gradle-${optionsHash}.hash`);
-        const pluginCache = new plugin_cache_utils_1.PluginCache(cachePath);
+        const optionsHash = (0, internal_1.hashObject)(options);
+        const cachePath = (0, node_path_1.join)(internal_1.workspaceDataDirectory, `gradle-${optionsHash}.hash`);
+        const pluginCache = new internal_1.PluginCache(cachePath);
         await (0, get_project_graph_from_gradle_plugin_1.populateProjectGraph)(context.workspaceRoot, gradlewFiles.map((f) => (0, node_path_1.join)(context.workspaceRoot, f)), options);
         const report = (0, get_project_graph_from_gradle_plugin_1.getCurrentProjectGraphReport)();
         const { nodes, externalNodes = {}, buildFiles = [] } = report;

package/dist/src/plugin/utils/get-project-graph-from-gradle-plugin.js

@@ -8,13 +8,11 @@ exports.processNxProjectGraph = processNxProjectGraph;
 const node_fs_1 = require("node:fs");
 const node_path_1 = require("node:path");
 const devkit_1 = require("@nx/devkit");
-const workspace_context_1 = require("nx/src/utils/workspace-context");
 const split_config_files_1 = require("../../utils/split-config-files");
 const versions_1 = require("../../utils/versions");
-const cache_directory_1 = require("nx/src/utils/cache-directory");
 const get_project_graph_lines_1 = require("./get-project-graph-lines");
 const gradle_plugin_options_1 = require("./gradle-plugin-options");
-const devkit_internals_1 = require("nx/src/devkit-internals");
+const internal_1 = require("@nx/devkit/internal");
 function readProjectGraphReportCache(cachePath, hash) {
     const projectGraphReportCache = (0, node_fs_1.existsSync)(cachePath)
         ? (0, devkit_1.readJsonFile)(cachePath)
@@ -43,7 +41,7 @@ function writeProjectGraphReportToCache(cachePath, results, hash) {
     }
 }
 let projectGraphReportCache;
-let projectGraphReportCachePath = (0, node_path_1.join)(cache_directory_1.workspaceDataDirectory, 'gradle-nodes.hash');
+let projectGraphReportCachePath = (0, node_path_1.join)(internal_1.workspaceDataDirectory, 'gradle-nodes.hash');
 function getCurrentProjectGraphReport() {
     if (!projectGraphReportCache) {
         throw new devkit_1.AggregateCreateNodesError([
@@ -72,8 +70,8 @@ function getCurrentBuildFiles() {
 async function populateProjectGraph(workspaceRoot, gradlewFiles, options) {
     const normalizedOptions = (0, gradle_plugin_options_1.normalizeOptions)(options);
     const gradleConfigHash = (0, devkit_1.hashArray)([
-        await (0, workspace_context_1.hashWithWorkspaceContext)(workspaceRoot, [split_config_files_1.gradleConfigAndTestGlob]),
-        (0, devkit_internals_1.hashObject)(normalizedOptions),
+        await (0, internal_1.hashWithWorkspaceContext)(workspaceRoot, [split_config_files_1.gradleConfigAndTestGlob]),
+        (0, internal_1.hashObject)(normalizedOptions),
         process.env.CI,
     ]);
     const cached = readProjectGraphReportCache(projectGraphReportCachePath, gradleConfigHash);

package/dist/src/plugin/utils/get-project-graph-lines.js

@@ -4,9 +4,9 @@ exports.cancelPendingProjectGraphRequest = cancelPendingProjectGraphRequest;
 exports.getGraphTimeoutMs = getGraphTimeoutMs;
 exports.getNxProjectGraphLines = getNxProjectGraphLines;
 const devkit_1 = require("@nx/devkit");
-const devkit_internals_1 = require("nx/src/devkit-internals");
 const exec_gradle_1 = require("../../utils/exec-gradle");
-const DEFAULT_GRAPH_TIMEOUT_SECONDS = (0, devkit_internals_1.isCI)() ? 600 : 120;
+const internal_1 = require("@nx/devkit/internal");
+const DEFAULT_GRAPH_TIMEOUT_SECONDS = (0, internal_1.isCI)() ? 600 : 120;
 let currentAbortController;
 /**
  * Cancel any in-flight Gradle project graph process.

package/dist/src/plugin-v1/nodes.d.ts

@@ -1,5 +1,5 @@
+import { PluginCache } from '@nx/devkit/internal';
 import { CreateNodes, CreateNodesContext, ProjectConfiguration } from '@nx/devkit';
-import { PluginCache } from 'nx/src/utils/plugin-cache-utils';
 import { GradleReport } from './utils/get-gradle-report';
 export interface GradlePluginOptions {
     includeSubprojectsTasks?: boolean;

package/dist/src/plugin-v1/nodes.js

@@ -4,11 +4,7 @@ exports.createNodes = exports.makeCreateNodesForGradleConfigFile = exports.creat
 const internal_1 = require("@nx/devkit/internal");
 const devkit_1 = require("@nx/devkit");
 const node_path_1 = require("node:path");
-const cache_directory_1 = require("nx/src/utils/cache-directory");
-const plugin_cache_utils_1 = require("nx/src/utils/plugin-cache-utils");
-const devkit_internals_1 = require("nx/src/devkit-internals");
 const get_gradle_report_1 = require("./utils/get-gradle-report");
-const file_hasher_1 = require("nx/src/hasher/file-hasher");
 const split_config_files_1 = require("../utils/split-config-files");
 const exec_gradle_1 = require("../utils/exec-gradle");
 const cacheableTaskType = new Set(['Build', 'Verification']);
@@ -33,9 +29,9 @@ exports.createNodesV2 = [
     split_config_files_1.gradleConfigAndTestGlob,
     async (files, options, context) => {
         const { buildFiles, projectRoots, gradlewFiles, testFiles } = (0, split_config_files_1.splitConfigFiles)(files);
-        const optionsHash = (0, file_hasher_1.hashObject)(options);
-        const cachePath = (0, node_path_1.join)(cache_directory_1.workspaceDataDirectory, `gradle-${optionsHash}.hash`);
-        const pluginCache = new plugin_cache_utils_1.PluginCache(cachePath);
+        const optionsHash = (0, internal_1.hashObject)(options);
+        const cachePath = (0, node_path_1.join)(internal_1.workspaceDataDirectory, `gradle-${optionsHash}.hash`);
+        const pluginCache = new internal_1.PluginCache(cachePath);
         await (0, get_gradle_report_1.populateGradleReport)(context.workspaceRoot, gradlewFiles.map((f) => (0, node_path_1.join)(context.workspaceRoot, f)));
         const gradleReport = (0, get_gradle_report_1.getCurrentGradleReport)();
         const gradleProjectRootToTestFilesMap = getGradleProjectRootToTestFilesMap(testFiles, projectRoots);
@@ -257,7 +253,7 @@ function getGradleProjectRootToTestFilesMap(testFiles, projectRoots) {
     const roots = new Map(projectRoots.map((root) => [root, root]));
     const testFilesToGradleProjectMap = {};
     testFiles.forEach((testFile) => {
-        const projectRoot = (0, devkit_internals_1.findProjectForPath)(testFile, roots);
+        const projectRoot = (0, internal_1.findProjectForPath)(testFile, roots);
         if (projectRoot) {
             if (!testFilesToGradleProjectMap[projectRoot]) {
                 testFilesToGradleProjectMap[projectRoot] = [];

package/dist/src/plugin-v1/utils/get-gradle-report.js

@@ -8,12 +8,11 @@ exports.processGradleDependencies = processGradleDependencies;
 const node_fs_1 = require("node:fs");
 const node_path_1 = require("node:path");
 const devkit_1 = require("@nx/devkit");
-const workspace_context_1 = require("nx/src/utils/workspace-context");
 const path_1 = require("path");
 const split_config_files_1 = require("../../utils/split-config-files");
 const get_project_report_lines_1 = require("./get-project-report-lines");
-const cache_directory_1 = require("nx/src/utils/cache-directory");
 const exec_gradle_1 = require("../../utils/exec-gradle");
+const internal_1 = require("@nx/devkit/internal");
 function readGradleReportCache(cachePath, hash) {
     const gradleReportJson = (0, node_fs_1.existsSync)(cachePath)
         ? (0, devkit_1.readJsonFile)(cachePath)
@@ -65,7 +64,7 @@ function writeGradleReportToCache(cachePath, results, hash) {
     }
 }
 let gradleReportCache;
-let gradleReportCachePath = (0, node_path_1.join)(cache_directory_1.workspaceDataDirectory, 'gradle-report-v1.hash');
+let gradleReportCachePath = (0, node_path_1.join)(internal_1.workspaceDataDirectory, 'gradle-report-v1.hash');
 function getCurrentGradleReport() {
     if (!gradleReportCache) {
         throw new devkit_1.AggregateCreateNodesError([
@@ -88,7 +87,7 @@ function getCurrentGradleReport() {
  * @returns Promise<void>
  */
 async function populateGradleReport(workspaceRoot, gradlewFiles) {
-    const gradleConfigHash = await (0, workspace_context_1.hashWithWorkspaceContext)(workspaceRoot, [
+    const gradleConfigHash = await (0, internal_1.hashWithWorkspaceContext)(workspaceRoot, [
         split_config_files_1.gradleConfigAndTestGlob,
     ]);
     const cached = readGradleReportCache(gradleReportCachePath, gradleConfigHash);

package/dist/src/utils/exec-gradle.d.ts

@@ -1,5 +1,5 @@
 import { NxJsonConfiguration } from '@nx/devkit';
-import { ExecFileOptions } from 'node:child_process';
+import { SpawnOptions } from 'node:child_process';
 export declare const fileSeparator: string;
 export declare const newLineSeparator: string;
 /**
@@ -14,7 +14,7 @@ export declare function getGradleExecFile(): string;
  * @param execOptions exec options
  * @returns promise with the stdout buffer
  */
-export declare function execGradleAsync(gradleBinaryPath: string, args: ReadonlyArray<string>, execOptions?: ExecFileOptions): Promise<Buffer>;
+export declare function execGradleAsync(gradleBinaryPath: string, args: ReadonlyArray<string>, execOptions?: Omit<SpawnOptions, 'shell'>): Promise<Buffer>;
 export declare function getCustomGradleExecutableDirectoryFromPlugin(nxJson: NxJsonConfiguration): string | undefined;
 /**
  * This function recursively finds the nearest gradlew file in the workspace

package/dist/src/utils/exec-gradle.js

@@ -7,14 +7,10 @@ exports.getCustomGradleExecutableDirectoryFromPlugin = getCustomGradleExecutable
 exports.findGradlewFile = findGradlewFile;
 exports.findGradlewUsingFilePathTraversal = findGradlewUsingFilePathTraversal;
 exports.findGradlewUsingCustomExecutableDirectory = findGradlewUsingCustomExecutableDirectory;
-const tslib_1 = require("tslib");
 const devkit_1 = require("@nx/devkit");
-const node_child_process_1 = require("node:child_process");
 const node_fs_1 = require("node:fs");
 const node_path_1 = require("node:path");
-const run_commands_impl_1 = require("nx/src/executors/run-commands/run-commands.impl");
-const exit_codes_1 = require("nx/src/utils/exit-codes");
-const tree_kill_1 = tslib_1.__importDefault(require("tree-kill"));
+const internal_1 = require("@nx/devkit/internal");
 exports.fileSeparator = process.platform.startsWith('win')
     ? 'file:///'
     : 'file://';
@@ -36,37 +32,43 @@ function getGradleExecFile() {
  * @returns promise with the stdout buffer
  */
 function execGradleAsync(gradleBinaryPath, args, execOptions = {}) {
-    // Extract signal so we can handle cancellation with tree-kill
+    // Extract signal so we can handle cancellation with a process-tree kill
     // instead of Node's default which only kills the immediate child.
     const { signal, ...restOptions } = execOptions;
     return new Promise((res, rej) => {
-        const cp = (0, node_child_process_1.execFile)(gradleBinaryPath, args, {
+        // Without the filter, empty args reach gradle as literal empty arguments.
+        const cp = (0, internal_1.safeSpawn)(gradleBinaryPath, args.filter(Boolean), {
             cwd: (0, node_path_1.dirname)(gradleBinaryPath),
-            shell: true,
-            windowsHide: true,
             env: process.env,
-            maxBuffer: run_commands_impl_1.LARGE_BUFFER,
             ...restOptions,
-        }, undefined);
-        // Use tree-kill on abort to kill the entire process tree
-        // (cmd.exe → gradlew.bat → java.exe), not just the shell.
+        });
+        let stdout = Buffer.from('');
+        // On abort, kill the entire process tree (gradlew spawns java) and settle
+        // immediately — a wedged JVM that outlives the kill signal would otherwise
+        // keep this promise pending and the abort error would never surface.
         const onAbort = () => {
             if (cp.pid) {
-                (0, tree_kill_1.default)(cp.pid);
+                (0, internal_1.killProcessTreeGraceful)(cp.pid).catch(() => { });
             }
+            rej(stdout);
         };
         signal?.addEventListener('abort', onAbort, { once: true });
-        let stdout = Buffer.from('');
         cp.stdout?.on('data', (data) => {
             stdout += data;
         });
         cp.stderr?.on('data', (data) => {
             stdout += data;
         });
+        // Without a shell the child is gradlew itself, so spawn can fail outright —
+        // Node then emits `error` and never `exit`.
+        cp.on('error', (err) => {
+            signal?.removeEventListener('abort', onAbort);
+            rej(err);
+        });
         cp.on('exit', (code, s) => {
             signal?.removeEventListener('abort', onAbort);
             if (code === null)
-                code = (0, exit_codes_1.signalToCode)(s);
+                code = (0, internal_1.signalToCode)(s);
             if (code === 0) {
                 res(stdout);
             }

package/dist/src/utils/split-config-files.js

@@ -2,8 +2,8 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.gradleConfigAndTestGlob = exports.gradleConfigGlob = exports.GRADLE_TEST_FILES = exports.GRADLE_VERSION_CATALOG_GLOB = exports.GRADLEW_FILES = exports.GRADLE_BUILD_FILES = void 0;
 exports.splitConfigFiles = splitConfigFiles;
-const globs_1 = require("nx/src/utils/globs");
 const node_path_1 = require("node:path");
+const internal_1 = require("@nx/devkit/internal");
 exports.GRADLE_BUILD_FILES = new Set(['build.gradle', 'build.gradle.kts']);
 exports.GRADLEW_FILES = new Set(['gradlew', 'gradlew.bat']);
 exports.GRADLE_VERSION_CATALOG_GLOB = '**/gradle/*.versions.toml';
@@ -15,7 +15,7 @@ exports.GRADLE_TEST_FILES = [
     '**/src/test/groovy/**/*Test.groovy',
     '**/src/test/groovy/**/*Tests.groovy',
 ];
-exports.gradleConfigGlob = (0, globs_1.combineGlobPatterns)(...Array.from(exports.GRADLE_BUILD_FILES).map((file) => `**/${file}`));
+exports.gradleConfigGlob = (0, internal_1.combineGlobPatterns)(...Array.from(exports.GRADLE_BUILD_FILES).map((file) => `**/${file}`));
 // Files that influence Gradle's configuration phase and therefore the project
 // graph report: any *.gradle(.kts) script (build, settings, script plugins),
 // gradle.properties, the wrapper pin, and buildSrc build logic.
@@ -28,7 +28,7 @@ const GRADLE_CONFIG_FILE_PATTERNS = [
     'buildSrc/**/*.java',
     'buildSrc/**/*.groovy',
 ];
-exports.gradleConfigAndTestGlob = (0, globs_1.combineGlobPatterns)(...GRADLE_CONFIG_FILE_PATTERNS, ...GRADLE_CONFIG_FILE_PATTERNS.map((pattern) => `**/${pattern}`), ...Array.from(exports.GRADLEW_FILES), ...Array.from(exports.GRADLEW_FILES).map((file) => `**/${file}`), ...exports.GRADLE_TEST_FILES, exports.GRADLE_VERSION_CATALOG_GLOB);
+exports.gradleConfigAndTestGlob = (0, internal_1.combineGlobPatterns)(...GRADLE_CONFIG_FILE_PATTERNS, ...GRADLE_CONFIG_FILE_PATTERNS.map((pattern) => `**/${pattern}`), ...Array.from(exports.GRADLEW_FILES), ...Array.from(exports.GRADLEW_FILES).map((file) => `**/${file}`), ...exports.GRADLE_TEST_FILES, exports.GRADLE_VERSION_CATALOG_GLOB);
 /**
  * This function split config files into build files, settings files, test files and project roots
  * @param files list of files to split

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/gradle",
-  "version": "23.1.1",
+  "version": "23.1.2",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -76,12 +76,11 @@
   },
   "dependencies": {
     "toml-eslint-parser": "^0.10.0",
-    "tree-kill": "^1.2.2",
     "tslib": "^2.3.0",
-    "@nx/devkit": "23.1.1"
+    "@nx/devkit": "23.1.2"
   },
   "devDependencies": {
-    "nx": "23.1.1"
+    "nx": "23.1.2"
   },
   "publishConfig": {
     "access": "public"