@nx/expo 19.2.0-rc.0 → 19.2.0-rc.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/expo",
-  "version": "19.2.0-rc.0",
+  "version": "19.2.0-rc.1",
   "private": false,
   "description": "The Expo Plugin for Nx contains executors and generators for managing and developing an expo application within your workspace. For example, you can directly build for different target platforms as well as generate projects and publish your code.",
   "keywords": [
@@ -28,7 +28,7 @@
   "main": "./index",
   "types": "index.d.ts",
   "dependencies": {
-    "@nx/devkit": "19.2.0-rc.0",
+    "@nx/devkit": "19.2.0-rc.1",
     "chalk": "^4.1.0",
     "enhanced-resolve": "^5.8.3",
     "fs-extra": "^11.1.0",
@@ -37,13 +37,13 @@
     "node-fetch": "^2.6.7",
     "tslib": "^2.3.0",
     "tsconfig-paths": "^4.1.2",
-    "@nx/jest": "19.2.0-rc.0",
-    "@nx/js": "19.2.0-rc.0",
-    "@nx/eslint": "19.2.0-rc.0",
-    "@nx/react": "19.2.0-rc.0",
-    "@nx/web": "19.2.0-rc.0",
-    "@nx/webpack": "19.2.0-rc.0",
-    "@nrwl/expo": "19.2.0-rc.0"
+    "@nx/jest": "19.2.0-rc.1",
+    "@nx/js": "19.2.0-rc.1",
+    "@nx/eslint": "19.2.0-rc.1",
+    "@nx/react": "19.2.0-rc.1",
+    "@nx/web": "19.2.0-rc.1",
+    "@nx/webpack": "19.2.0-rc.1",
+    "@nrwl/expo": "19.2.0-rc.1"
   },
   "executors": "./executors.json",
   "ng-update": {

package/src/executors/sync-deps/schema.d.ts

@@ -2,4 +2,5 @@ export interface ExpoSyncDepsOptions {
   include: string[] | string; // default is an empty array []
   exclude: string[] | string; // default is an empty array []
   all: boolean; // default is false
+  excludeImplicit: boolean; // default is false
 }

package/src/executors/sync-deps/schema.json

@@ -28,6 +28,11 @@
       "type": "boolean",
       "description": "Copy all dependencies and devDependencies from the workspace root package.json.",
       "default": false
+    },
+    "excludeImplicit": {
+      "type": "boolean",
+      "description": "This will ignore npm packages from projects listed in implicitDependencies (e.g. backend API projects)",
+      "default": false
     }
   }
 }

package/src/executors/sync-deps/sync-deps.impl.d.ts

@@ -5,5 +5,5 @@ export interface ReactNativeSyncDepsOutput {
     success: boolean;
 }
 export default function syncDepsExecutor(options: ExpoSyncDepsOptions, context: ExecutorContext): AsyncGenerator<ReactNativeSyncDepsOutput>;
-export declare function syncDeps(projectName: string, projectPackageJson: PackageJson, projectPackageJsonPath: string, workspacePackageJson: PackageJson, projectGraph?: ProjectGraph, include?: string[], exclude?: string[], all?: boolean): Promise<string[]>;
+export declare function syncDeps(projectName: string, projectPackageJson: PackageJson, projectPackageJsonPath: string, workspacePackageJson: PackageJson, projectGraph?: ProjectGraph, include?: string[], exclude?: string[], all?: boolean, excludeImplicit?: boolean): Promise<string[]>;
 export declare function displayNewlyAddedDepsMessage(projectName: string, deps: string[]): void;

package/src/executors/sync-deps/sync-deps.impl.js

@@ -15,14 +15,14 @@ async function* syncDepsExecutor(options, context) {
         ? options.include.split(',')
         : options.include, typeof options.exclude === 'string'
         ? options.exclude.split(',')
-        : options.exclude, options.all));
+        : options.exclude, options.all, options.excludeImplicit));
     yield { success: true };
 }
 exports.default = syncDepsExecutor;
-async function syncDeps(projectName, projectPackageJson, projectPackageJsonPath, workspacePackageJson, projectGraph = (0, devkit_1.readCachedProjectGraph)(), include = [], exclude = [], all = false) {
+async function syncDeps(projectName, projectPackageJson, projectPackageJsonPath, workspacePackageJson, projectGraph = (0, devkit_1.readCachedProjectGraph)(), include = [], exclude = [], all = false, excludeImplicit = false) {
     let npmDeps = all
         ? Object.keys(workspacePackageJson.dependencies || {})
-        : (0, find_all_npm_dependencies_1.findAllNpmDependencies)(projectGraph, projectName);
+        : (0, find_all_npm_dependencies_1.findAllNpmDependencies)(projectGraph, projectName, { excludeImplicit });
     let npmDevdeps = all
         ? Object.keys(workspacePackageJson.devDependencies || {})
         : [];

package/src/utils/find-all-npm-dependencies.d.ts

@@ -1,2 +1,6 @@
-import { ProjectGraph } from '@nx/devkit';
-export declare function findAllNpmDependencies(graph: ProjectGraph, projectName: string, list?: string[], seen?: Set<string>): string[];
+import { type ProjectGraph } from '@nx/devkit';
+type Options = {
+    excludeImplicit: boolean;
+};
+export declare function findAllNpmDependencies(graph: ProjectGraph, projectName: string, options?: Options, seen?: Set<string>): string[];
+export {};

package/src/utils/find-all-npm-dependencies.js

@@ -1,27 +1,42 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.findAllNpmDependencies = void 0;
-function findAllNpmDependencies(graph, projectName, list = [], seen = new Set()) {
-    // In case of bad circular dependencies
-    if (seen.has(projectName)) {
-        return list;
-    }
+// Don't want to include '@nx/react-native' and '@nx/expo' because React Native
+// autolink will warn that the package has no podspec file for iOS.
+const EXCLUDED_EXTERNAL_NODES = new Set([
+    'npm:@nx/react-native',
+    'npm:@nrwl/react-native',
+    'npm:@nx/expo',
+    'npm:@nrwl/expo',
+]);
+function findAllNpmDependencies(graph, projectName, options = { excludeImplicit: false }, seen = new Set()) {
+    // Guard Case: In case of bad circular dependencies
+    if (seen.has(projectName))
+        return [];
     seen.add(projectName);
-    const node = graph.externalNodes[projectName];
-    // Don't want to include '@nx/react-native' and '@nx/expo' because React Native
-    // autolink will warn that the package has no podspec file for iOS.
-    if (node) {
-        if (node.name !== `npm:@nx/react-native` &&
-            node.name !== `npm:@nrwl/react-native` &&
-            node.name !== `npm:@nx/expo` &&
-            node.name !== `npm:@nrwl/expo`) {
-            list.push(node.data.packageName);
-        }
-    }
-    else {
-        // it's workspace project, search for it's dependencies
-        graph.dependencies[projectName]?.forEach((dep) => findAllNpmDependencies(graph, dep.target, list, seen));
+    // Base/Termination Case: when it finds a valid package in externalNodes
+    const node = graph.externalNodes?.[projectName];
+    if (node && !EXCLUDED_EXTERNAL_NODES.has(node.name)) {
+        return [node.data.packageName];
     }
-    return list;
+    // Recursive Case: Digging into related projects' dependencies
+    return ((graph.dependencies[projectName] || [])
+        // Conditional filtering based on options
+        .filter(getFilterPredicate(options))
+        // this is where the recursion happens
+        .flatMap((dep) => findAllNpmDependencies(graph, dep.target, options, seen)));
 }
 exports.findAllNpmDependencies = findAllNpmDependencies;
+// This function is used to filter out dependencies based on the options
+// provided.
+function getFilterPredicate(options) {
+    return (dep) => [
+        // base predicate returns true so it filters out nothing
+        (_pDep) => true,
+        // conditionally filter implicit dependencies based on the option
+        ...(options?.excludeImplicit
+            ? [(pDep) => pDep.type !== 'implicit']
+            : []),
+        // Future conditions can be added here in a similar way
+    ].every((predicate) => predicate(dep));
+}