@nx/eslint 23.0.0-beta.17 → 23.0.0-beta.19

package/dist/src/migrations/update-20-2-0/update-typescript-eslint-v8-13-0.md

@@ -0,0 +1,33 @@
+#### Update TypeScript ESLint to v8.13.0
+
+Update TypeScript ESLint packages to v8.13.0 if they are already on v8
+
+#### Sample Code Changes
+
+This migration will update `typescript-eslint`, `@typescript-eslint/eslint-plugin`, `@typescript-eslint/parser` and `@typescript-eslint/utils` to `8.13.0` if they are between version `8.0.0` and `8.13.0`.
+
+##### Before
+
+```json title="package.json"
+{
+  "devDependencies": {
+    "typescript-eslint": "^8.0.0",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
+    "@typescript-eslint/utils": "^8.0.0"
+  }
+}
+```
+
+##### After
+
+```json title="package.json"
+{
+  "devDependencies": {
+    "typescript-eslint": "^8.13.0",
+    "@typescript-eslint/eslint-plugin": "^8.13.0",
+    "@typescript-eslint/parser": "^8.13.0",
+    "@typescript-eslint/utils": "^8.13.0"
+  }
+}
+```

package/dist/src/migrations/update-20-3-0/add-file-extensions-to-overrides.md

@@ -0,0 +1,83 @@
+#### Update ESLint Config File Extensions in Overrides
+
+Update ESLint flat config to include .cjs, .mjs, .cts, and .mts files in overrides (if needed)
+
+#### Sample Code Changes
+
+Add `.cjs`, `.mjs`, `.cts`, `.mts` file extensions to overrides converted using `convert-to-flat-config`
+
+##### Before
+
+```js title="eslint.config.js"
+const { FlatCompat } = require('@eslint/eslintrc');
+const js = require('@eslint/js');
+const nxEslintPlugin = require('@nx/eslint-plugin');
+
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+});
+
+module.exports = [
+  ...compat
+    .config({
+      extends: ['plugin:@nx/typescript'],
+    })
+    .map((config) => ({
+      ...config,
+      files: ['**/*.ts', '**/*.tsx'],
+      rules: {
+        ...config.rules,
+      },
+    })),
+  ...compat
+    .config({
+      extends: ['plugin:@nx/javascript'],
+    })
+    .map((config) => ({
+      ...config,
+      files: ['**/*.js', '**/*.jsx'],
+      rules: {
+        ...config.rules,
+      },
+    })),
+];
+```
+
+##### After
+
+```js title="eslint.config.js" {17,28}
+const { FlatCompat } = require('@eslint/eslintrc');
+const js = require('@eslint/js');
+const nxEslintPlugin = require('@nx/eslint-plugin');
+
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+});
+
+module.exports = [
+  ...compat
+    .config({
+      extends: ['plugin:@nx/typescript'],
+    })
+    .map((config) => ({
+      ...config,
+      files: ['**/*.ts', '**/*.tsx', '**/*.cts', '**/*.mts'],
+      rules: {
+        ...config.rules,
+      },
+    })),
+  ...compat
+    .config({
+      extends: ['plugin:@nx/javascript'],
+    })
+    .map((config) => ({
+      ...config,
+      files: ['**/*.js', '**/*.jsx', '**/*.cjs', '**/*.mjs'],
+      rules: {
+        ...config.rules,
+      },
+    })),
+];
+```

package/dist/src/migrations/update-23-0-0/rewrite-internal-subpath-imports.js

@@ -145,19 +145,34 @@ function collectCallExpressionRewrites(sourceFile, changes) {
             // internal entry.
             replaceSpecifier(sourceFile, node.arguments[0], TO_INTERNAL, changes);
         }
+        else if (ts.isImportTypeNode(node)) {
+            // `typeof import('...')` parses as an `ImportTypeNode`, not a
+            // CallExpression — its argument is `LiteralTypeNode<StringLiteral>`.
+            // The whole module is referenced, so it can't be symbol-split.
+            const literal = getImportTypeStringLiteral(node);
+            if (literal && literal.text.startsWith(FROM_PREFIX)) {
+                replaceSpecifier(sourceFile, literal, TO_INTERNAL, changes);
+            }
+        }
         ts.forEachChild(node, visit);
     };
     visit(sourceFile);
 }
+function getImportTypeStringLiteral(node) {
+    const arg = node.argument;
+    if (arg && ts.isLiteralTypeNode(arg) && ts.isStringLiteral(arg.literal)) {
+        return arg.literal;
+    }
+    return undefined;
+}
 function shouldRewriteCallExpression(call) {
     const callee = call.expression;
     // `require('...')`
     if (ts.isIdentifier(callee) && callee.text === 'require')
         return true;
     // dynamic `import('...')` (runtime form parses as a CallExpression whose
-    // callee is the `import` keyword). The type-position form
-    // (`typeof import('...')`) is an `ImportTypeNode`, not a CallExpression, so
-    // we don't touch it.
+    // callee is the `import` keyword). The `typeof import('...')` type-position
+    // form is an `ImportTypeNode` (handled in `collectCallExpressionRewrites`).
     if (callee.kind === ts.SyntaxKind.ImportKeyword)
         return true;
     // `jest.mock(...)` / `vi.mock(...)` and friends.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint",
-  "version": "23.0.0-beta.17",
+  "version": "23.0.0-beta.19",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -73,17 +73,17 @@
   "peerDependencies": {
     "@zkochan/js-yaml": "0.0.7",
     "eslint": "^8.0.0 || ^9.0.0 || ^10.0.0",
-    "@nx/jest": "23.0.0-beta.17"
+    "@nx/jest": "23.0.0-beta.19"
   },
   "dependencies": {
     "semver": "^7.6.3",
     "tslib": "^2.3.0",
     "typescript": "~5.9.2",
-    "@nx/devkit": "23.0.0-beta.17",
-    "@nx/js": "23.0.0-beta.17"
+    "@nx/js": "23.0.0-beta.19",
+    "@nx/devkit": "23.0.0-beta.19"
   },
   "devDependencies": {
-    "nx": "23.0.0-beta.17"
+    "nx": "23.0.0-beta.19"
   },
   "peerDependenciesMeta": {
     "@nx/jest": {