@nx/eslint 19.4.2 → 19.4.4

package/README.md

@@ -59,7 +59,7 @@ npx nx@latest init
 - [Nx.Dev: Documentation, Guides, Tutorials](https://nx.dev)
 - [Intro to Nx](https://nx.dev/getting-started/intro)
 - [Official Nx YouTube Channel](https://www.youtube.com/@NxDevtools)
-- [Blog Posts About Nx](https://blog.nrwl.io/nx/home)
+- [Blog Posts About Nx](https://nx.dev/blog)
 
 <p style="text-align: center;"><a href="https://nx.dev/#learning-materials" target="_blank" rel="noreferrer"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-courses-and-videos.svg" 
 width="100%" alt="Nx - Smart Monorepos · Fast CI"></a></p>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint",
-  "version": "19.4.2",
+  "version": "19.4.4",
   "private": false,
   "description": "The ESLint plugin for Nx contains executors, generators and utilities used for linting JavaScript/TypeScript projects within an Nx workspace.",
   "repository": {
@@ -35,12 +35,12 @@
     "eslint": "^8.0.0 || ^9.0.0"
   },
   "dependencies": {
-    "@nx/devkit": "19.4.2",
-    "@nx/js": "19.4.2",
+    "@nx/devkit": "19.4.4",
+    "@nx/js": "19.4.4",
     "semver": "^7.5.3",
     "tslib": "^2.3.0",
     "typescript": "~5.4.2",
-    "@nx/linter": "19.4.2"
+    "@nx/linter": "19.4.4"
   },
   "peerDependenciesMeta": {
     "@zkochan/js-yaml": {

package/src/plugins/plugin.js

@@ -4,7 +4,7 @@ exports.createNodes = exports.createNodesV2 = void 0;
 const devkit_1 = require("@nx/devkit");
 const calculate_hash_for_create_nodes_1 = require("@nx/devkit/src/utils/calculate-hash-for-create-nodes");
 const node_fs_1 = require("node:fs");
-const node_path_1 = require("node:path");
+const posix_1 = require("node:path/posix");
 const file_hasher_1 = require("nx/src/hasher/file-hasher");
 const cache_directory_1 = require("nx/src/utils/cache-directory");
 const globs_1 = require("nx/src/utils/globs");
@@ -30,7 +30,7 @@ function writeTargetsToCache(cachePath, results) {
 }
 const internalCreateNodes = async (configFilePath, options, context, projectsCache) => {
     options = normalizeOptions(options);
-    const configDir = (0, node_path_1.dirname)(configFilePath);
+    const configDir = (0, posix_1.dirname)(configFilePath);
     // Ensure that configFiles are set, e2e-run fails due to them being undefined in CI (does not occur locally)
     // TODO(JamesHenry): Further troubleshoot this in CI
     context.configFiles = context.configFiles ?? [];
@@ -38,14 +38,14 @@ const internalCreateNodes = async (configFilePath, options, context, projectsCac
     // list of globs to exclude from child projects
     const nestedEslintRootPatterns = [];
     for (const configFile of context.configFiles) {
-        const eslintRootDir = (0, node_path_1.dirname)(configFile);
+        const eslintRootDir = (0, posix_1.dirname)(configFile);
         if (eslintRootDir !== configDir && isSubDir(configDir, eslintRootDir)) {
             nestedEslintRootPatterns.push(`${eslintRootDir}/**/*`);
         }
     }
-    const projectFiles = await (0, workspace_context_1.globWithWorkspaceContext)(context.workspaceRoot, ['project.json', 'package.json', '**/project.json', '**/package.json'].map((f) => (0, node_path_1.join)(configDir, f)), nestedEslintRootPatterns.length ? nestedEslintRootPatterns : undefined);
+    const projectFiles = await (0, workspace_context_1.globWithWorkspaceContext)(context.workspaceRoot, ['project.json', 'package.json', '**/project.json', '**/package.json'].map((f) => (0, posix_1.join)(configDir, f)), nestedEslintRootPatterns.length ? nestedEslintRootPatterns : undefined);
     // dedupe and sort project roots by depth for more efficient traversal
-    const dedupedProjectRoots = Array.from(new Set(projectFiles.map((f) => (0, node_path_1.dirname)(f)))).sort((a, b) => (a !== b && isSubDir(a, b) ? -1 : 1));
+    const dedupedProjectRoots = Array.from(new Set(projectFiles.map((f) => (0, posix_1.dirname)(f)))).sort((a, b) => (a !== b && isSubDir(a, b) ? -1 : 1));
     const excludePatterns = dedupedProjectRoots.map((root) => `${root}/**/*`);
     const ESLint = await (0, resolve_eslint_class_1.resolveESLintClass)((0, config_file_1.isFlatConfig)(configFilePath));
     const eslintVersion = ESLint.version;
@@ -54,22 +54,22 @@ const internalCreateNodes = async (configFilePath, options, context, projectsCac
         // anything after is either a nested project or a sibling project, can be excluded
         const nestedProjectRootPatterns = excludePatterns.slice(index + 1);
         // Ignore project roots where the project does not contain any lintable files
-        const lintableFiles = await (0, workspace_context_1.globWithWorkspaceContext)(context.workspaceRoot, [(0, node_path_1.join)(childProjectRoot, `**/*.{${options.extensions.join(',')}}`)], 
+        const lintableFiles = await (0, workspace_context_1.globWithWorkspaceContext)(context.workspaceRoot, [(0, posix_1.join)(childProjectRoot, `**/*.{${options.extensions.join(',')}}`)], 
         // exclude nested eslint roots and nested project roots
         [...nestedEslintRootPatterns, ...nestedProjectRootPatterns]);
-        const parentConfigs = context.configFiles.filter((eslintConfig) => isSubDir(childProjectRoot, (0, node_path_1.dirname)(eslintConfig)));
-        const hash = await (0, calculate_hash_for_create_nodes_1.calculateHashForCreateNodes)(childProjectRoot, options, context, [...parentConfigs, (0, node_path_1.join)(childProjectRoot, '.eslintignore')]);
+        const parentConfigs = context.configFiles.filter((eslintConfig) => isSubDir(childProjectRoot, (0, posix_1.dirname)(eslintConfig)));
+        const hash = await (0, calculate_hash_for_create_nodes_1.calculateHashForCreateNodes)(childProjectRoot, options, context, [...parentConfigs, (0, posix_1.join)(childProjectRoot, '.eslintignore')]);
         if (projectsCache[hash]) {
             // We can reuse the projects in the cache.
             Object.assign(projects, projectsCache[hash]);
             return;
         }
         const eslint = new ESLint({
-            cwd: (0, node_path_1.join)(context.workspaceRoot, childProjectRoot),
+            cwd: (0, posix_1.join)(context.workspaceRoot, childProjectRoot),
         });
         let hasNonIgnoredLintableFiles = false;
         for (const file of lintableFiles) {
-            if (!(await eslint.isPathIgnored((0, node_path_1.join)(context.workspaceRoot, file)))) {
+            if (!(await eslint.isPathIgnored((0, posix_1.join)(context.workspaceRoot, file)))) {
                 hasNonIgnoredLintableFiles = true;
                 break;
             }
@@ -96,17 +96,17 @@ const internalCreateNodes = async (configFilePath, options, context, projectsCac
 };
 let collectingLintableFilesPromise;
 const internalCreateNodesV2 = async (configFilePath, options, context, eslintConfigFiles, allProjectRoots, projectRootsByEslintRoots, lintableFilesPerProjectRoot, projectsCache) => {
-    const configDir = (0, node_path_1.dirname)(configFilePath);
+    const configDir = (0, posix_1.dirname)(configFilePath);
     const ESLint = await (0, resolve_eslint_class_1.resolveESLintClass)((0, config_file_1.isFlatConfig)(configFilePath));
     const eslintVersion = ESLint.version;
     const projects = {};
     await Promise.all(projectRootsByEslintRoots.get(configDir).map(async (projectRoot) => {
-        const parentConfigs = eslintConfigFiles.filter((eslintConfig) => isSubDir(projectRoot, (0, node_path_1.dirname)(eslintConfig)));
+        const parentConfigs = eslintConfigFiles.filter((eslintConfig) => isSubDir(projectRoot, (0, posix_1.dirname)(eslintConfig)));
         const hash = await (0, calculate_hash_for_create_nodes_1.calculateHashForCreateNodes)(projectRoot, options, {
             configFiles: eslintConfigFiles,
             nxJsonConfiguration: context.nxJsonConfiguration,
             workspaceRoot: context.workspaceRoot,
-        }, [...parentConfigs, (0, node_path_1.join)(projectRoot, '.eslintignore')]);
+        }, [...parentConfigs, (0, posix_1.join)(projectRoot, '.eslintignore')]);
         if (projectsCache[hash]) {
             // We can reuse the projects in the cache.
             Object.assign(projects, projectsCache[hash]);
@@ -118,11 +118,11 @@ const internalCreateNodesV2 = async (configFilePath, options, context, eslintCon
             collectingLintableFilesPromise = null;
         }
         const eslint = new ESLint({
-            cwd: (0, node_path_1.join)(context.workspaceRoot, projectRoot),
+            cwd: (0, posix_1.join)(context.workspaceRoot, projectRoot),
         });
         let hasNonIgnoredLintableFiles = false;
         for (const file of lintableFilesPerProjectRoot.get(projectRoot) ?? []) {
-            if (!(await eslint.isPathIgnored((0, node_path_1.join)(context.workspaceRoot, file)))) {
+            if (!(await eslint.isPathIgnored((0, posix_1.join)(context.workspaceRoot, file)))) {
                 hasNonIgnoredLintableFiles = true;
                 break;
             }
@@ -152,7 +152,7 @@ exports.createNodesV2 = [
     async (configFiles, options, context) => {
         options = normalizeOptions(options);
         const optionsHash = (0, file_hasher_1.hashObject)(options);
-        const cachePath = (0, node_path_1.join)(cache_directory_1.workspaceDataDirectory, `eslint-${optionsHash}.hash`);
+        const cachePath = (0, posix_1.join)(cache_directory_1.workspaceDataDirectory, `eslint-${optionsHash}.hash`);
         const targetsCache = readTargetsCache(cachePath);
         const { eslintConfigFiles, projectRoots, projectRootsByEslintRoots } = splitConfigFiles(configFiles);
         const lintableFilesPerProjectRoot = new Map();
@@ -175,8 +175,8 @@ function splitConfigFiles(configFiles) {
     const eslintConfigFiles = [];
     const projectRoots = new Set();
     for (const configFile of configFiles) {
-        if (PROJECT_CONFIG_FILENAMES.includes((0, node_path_1.basename)(configFile))) {
-            projectRoots.add((0, node_path_1.dirname)(configFile));
+        if (PROJECT_CONFIG_FILENAMES.includes((0, posix_1.basename)(configFile))) {
+            projectRoots.add((0, posix_1.dirname)(configFile));
         }
         else {
             eslintConfigFiles.push(configFile);
@@ -193,7 +193,7 @@ function splitConfigFiles(configFiles) {
 function groupProjectRootsByEslintRoots(eslintConfigFiles, projectRoots) {
     const projectRootsByEslintRoots = new Map();
     for (const eslintConfig of eslintConfigFiles) {
-        projectRootsByEslintRoots.set((0, node_path_1.dirname)(eslintConfig), []);
+        projectRootsByEslintRoots.set((0, posix_1.dirname)(eslintConfig), []);
     }
     for (const projectRoot of projectRoots) {
         const eslintRoot = getRootForDirectory(projectRoot, projectRootsByEslintRoots);
@@ -211,19 +211,19 @@ async function collectLintableFilesByProjectRoot(lintableFilesPerProjectRoot, pr
         lintableFilesPerProjectRoot.set(projectRoot, []);
     }
     for (const file of lintableFiles) {
-        const projectRoot = getRootForDirectory((0, node_path_1.dirname)(file), lintableFilesPerProjectRoot);
+        const projectRoot = getRootForDirectory((0, posix_1.dirname)(file), lintableFilesPerProjectRoot);
         if (projectRoot) {
             lintableFilesPerProjectRoot.get(projectRoot).push(file);
         }
     }
 }
 function getRootForDirectory(directory, roots) {
-    let currentPath = (0, node_path_1.normalize)(directory);
-    while (currentPath !== (0, node_path_1.dirname)(currentPath)) {
+    let currentPath = (0, posix_1.normalize)(directory);
+    while (currentPath !== (0, posix_1.dirname)(currentPath)) {
         if (roots.has(currentPath)) {
             return currentPath;
         }
-        currentPath = (0, node_path_1.dirname)(currentPath);
+        currentPath = (0, posix_1.dirname)(currentPath);
     }
     return roots.has(currentPath) ? currentPath : null;
 }
@@ -232,15 +232,15 @@ function getProjectUsingESLintConfig(configFilePath, projectRoot, eslintVersion,
         config_file_1.baseEsLintConfigFile,
         config_file_1.baseEsLintFlatConfigFile,
         ...config_file_1.ESLINT_CONFIG_FILENAMES,
-    ].find((f) => (0, node_fs_1.existsSync)((0, node_path_1.join)(context.workspaceRoot, f)));
+    ].find((f) => (0, node_fs_1.existsSync)((0, posix_1.join)(context.workspaceRoot, f)));
     // Add a lint target for each child project without an eslint config, with the root level config as an input
     let standaloneSrcPath;
     if (projectRoot === '.' &&
-        (0, node_fs_1.existsSync)((0, node_path_1.join)(context.workspaceRoot, projectRoot, 'package.json'))) {
-        if ((0, node_fs_1.existsSync)((0, node_path_1.join)(context.workspaceRoot, projectRoot, 'src'))) {
+        (0, node_fs_1.existsSync)((0, posix_1.join)(context.workspaceRoot, projectRoot, 'package.json'))) {
+        if ((0, node_fs_1.existsSync)((0, posix_1.join)(context.workspaceRoot, projectRoot, 'src'))) {
             standaloneSrcPath = 'src';
         }
-        else if ((0, node_fs_1.existsSync)((0, node_path_1.join)(context.workspaceRoot, projectRoot, 'lib'))) {
+        else if ((0, node_fs_1.existsSync)((0, posix_1.join)(context.workspaceRoot, projectRoot, 'lib'))) {
             standaloneSrcPath = 'lib';
         }
     }
@@ -269,7 +269,7 @@ function buildEslintTargets(eslintConfigs, eslintVersion, projectRoot, workspace
             // Certain lint rules can be impacted by changes to dependencies
             '^default',
             ...eslintConfigs.map((config) => `{workspaceRoot}/${config}`.replace(`{workspaceRoot}/${projectRoot}`, isRootProject ? '{projectRoot}/' : '{projectRoot}')),
-            ...((0, node_fs_1.existsSync)((0, node_path_1.join)(workspaceRoot, projectRoot, '.eslintignore'))
+            ...((0, node_fs_1.existsSync)((0, posix_1.join)(workspaceRoot, projectRoot, '.eslintignore'))
                 ? ['{projectRoot}/.eslintignore']
                 : []),
             '{workspaceRoot}/tools/eslint-rules/**/*',
@@ -323,10 +323,10 @@ function isSubDir(parent, child) {
     if (parent === '.') {
         return true;
     }
-    parent = (0, node_path_1.normalize)(parent);
-    child = (0, node_path_1.normalize)(child);
-    if (!parent.endsWith(node_path_1.sep)) {
-        parent += node_path_1.sep;
+    parent = (0, posix_1.normalize)(parent);
+    child = (0, posix_1.normalize)(child);
+    if (!parent.endsWith(posix_1.sep)) {
+        parent += posix_1.sep;
     }
     return child.startsWith(parent);
 }