@nx/eslint 17.0.2 → 17.0.4

package/LICENSE

@@ -1,6 +1,6 @@
 (The MIT License)
 
-Copyright (c) 2017-2023 Narwhal Technologies Inc.
+Copyright (c) 2017-2024 Narwhal Technologies Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

package/README.md

@@ -1,4 +1,9 @@
-<p style="text-align: center;"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx.png" width="600" alt="Nx - Smart, Fast and Extensible Build System"></p>
+<p style="text-align: center;">
+  <picture>
+    <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-dark.svg">
+    <img alt="Nx - Smart Monorepos · Fast CI" src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-light.svg" width="100%">
+  </picture>
+</p>
 
 <div style="text-align: center;">
 
@@ -15,9 +20,9 @@
 
 <hr>
 
-# Nx: Smart, Fast and Extensible Build System
+# Nx: Smart Monorepos · Fast CI
 
-Nx is a next generation build system with first class monorepo support and powerful integrations.
+Nx is a build system with built-in tooling and advanced CI capabilities. It helps you maintain and scale monorepos, both locally and on CI.
 
 ## Getting Started
 
@@ -57,5 +62,5 @@ npx nx@latest init
 - [Blog Posts About Nx](https://blog.nrwl.io/nx/home)
 
 <p style="text-align: center;"><a href="https://nx.dev/#learning-materials" target="_blank" rel="noreferrer"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-courses-and-videos.svg" 
-width="100%" alt="Nx - Smart, Fast and Extensible Build System"></a></p>
+width="100%" alt="Nx - Smart Monorepos · Fast CI"></a></p>
 

package/generators.json

@@ -2,6 +2,12 @@
   "name": "nx/eslint",
   "version": "0.1",
   "generators": {
+    "init": {
+      "factory": "./src/generators/init/init#initEsLint",
+      "schema": "./src/generators/init/schema.json",
+      "description": "Set up the ESLint plugin.",
+      "hidden": true
+    },
     "workspace-rules-project": {
       "factory": "./src/generators/workspace-rules-project/workspace-rules-project#lintWorkspaceRulesProjectGenerator",
       "schema": "./src/generators/workspace-rules-project/schema.json",

package/migrations.json

@@ -27,6 +27,21 @@
       "version": "17.0.0-beta.7",
       "description": "update-17-0-0-rename-to-eslint",
       "implementation": "./src/migrations/update-17-0-0-rename-to-eslint/update-17-0-0-rename-to-eslint"
+    },
+    "update-typescript-eslint": {
+      "version": "17.1.0-beta.1",
+      "description": "Updates for @typescript-utils/utils v6.9.1+",
+      "implementation": "./src/migrations/update-17-1-0/update-typescript-eslint"
+    },
+    "simplify-eslint-patterns": {
+      "version": "17.2.0-beta.0",
+      "description": "Simplify eslintFilePatterns",
+      "implementation": "./src/migrations/update-17-2-0/simplify-eslint-patterns"
+    },
+    "move-options-to-target-defaults": {
+      "version": "17.2.9",
+      "description": "Move executor options to target defaults",
+      "implementation": "./src/migrations/update-17-2-9/move-options-to-target-defaults"
     }
   },
   "packageJsonUpdates": {
@@ -82,6 +97,59 @@
           "version": "^9.0.0"
         }
       }
+    },
+    "17.1.0": {
+      "version": "17.1.0-beta.1",
+      "packages": {
+        "@typescript-eslint/parser": {
+          "version": "^6.9.1"
+        },
+        "@typescript-eslint/eslint-plugin": {
+          "version": "^6.9.1"
+        },
+        "@typescript-eslint/utils": {
+          "version": "^6.9.1"
+        }
+      }
+    },
+    "17.2.0": {
+      "version": "17.2.0-beta.2",
+      "packages": {
+        "eslint": {
+          "version": "~8.48.0"
+        }
+      }
+    },
+    "17.3.0": {
+      "version": "17.3.0-beta.0",
+      "packages": {
+        "@typescript-eslint/parser": {
+          "version": "^6.13.2"
+        },
+        "@typescript-eslint/eslint-plugin": {
+          "version": "^6.13.2"
+        },
+        "@typescript-eslint/utils": {
+          "version": "^6.13.2"
+        }
+      }
+    },
+    "18.2.0": {
+      "version": "18.2.0-beta.0",
+      "packages": {
+        "@typescript-eslint/parser": {
+          "version": "^7.3.0"
+        },
+        "@typescript-eslint/eslint-plugin": {
+          "version": "^7.3.0"
+        },
+        "@typescript-eslint/utils": {
+          "version": "^7.3.0"
+        },
+        "eslint": {
+          "version": "~8.57.0"
+        }
+      }
     }
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint",
-  "version": "17.0.2",
+  "version": "17.0.4",
   "private": false,
   "description": "The ESLint plugin for Nx contains executors, generators and utilities used for linting JavaScript/TypeScript projects within an Nx workspace.",
   "repository": {
@@ -27,20 +27,21 @@
     "requirements": {},
     "migrations": "./migrations.json"
   },
-  "executors": "./executors.json",
   "generators": "./generators.json",
+  "executors": "./executors.json",
   "peerDependencies": {
-    "eslint": "^8.0.0"
+    "js-yaml": "4.1.0"
   },
   "dependencies": {
+    "@nx/devkit": "17.0.4",
+    "@nx/js": "17.0.4",
+    "eslint": "^8.0.0",
     "tslib": "^2.3.0",
-    "@nx/devkit": "17.0.2",
-    "@nx/js": "17.0.2",
-    "typescript": "~5.1.3",
-    "@nx/linter": "17.0.2"
+    "typescript": "~5.4.2",
+    "@nx/linter": "17.0.4"
   },
   "peerDependenciesMeta": {
-    "eslint": {
+    "js-yaml": {
       "optional": true
     }
   },

package/plugin.d.ts

@@ -0,0 +1 @@
+export { createNodes, EslintPluginOptions } from './src/plugins/plugin';

package/plugin.js

@@ -0,0 +1,5 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.createNodes = void 0;
+var plugin_1 = require("./src/plugins/plugin");
+Object.defineProperty(exports, "createNodes", { enumerable: true, get: function () { return plugin_1.createNodes; } });

package/src/executors/lint/hasher.js

@@ -17,7 +17,7 @@ async function run(task, context) {
     }
     const nodes = {};
     const hashes = [];
-    for (const d of Object.keys(res.details.nodes)) {
+    for (const d of Object.keys(res.details.nodes).sort()) {
         if (d.indexOf('$fileset') === -1) {
             nodes[d] = res.details.nodes[d];
             hashes.push(res.details.nodes[d]);

package/src/executors/lint/lint.impl.js

@@ -4,6 +4,7 @@ const devkit_1 = require("@nx/devkit");
 const fs_1 = require("fs");
 const path_1 = require("path");
 const eslint_utils_1 = require("./utility/eslint-utils");
+const utils_1 = require("nx/src/tasks-runner/utils");
 async function run(options, context) {
     // this is only used for the hasher
     delete options.hasTypeAwareRules;
@@ -13,31 +14,36 @@ async function run(options, context) {
     // root to be able to run the lint executor from any subfolder.
     process.chdir(systemRoot);
     const projectName = context.projectName || '<???>';
+    const projectRoot = context.projectsConfigurations.projects[context.projectName].root;
     const printInfo = options.format && !options.silent;
     if (printInfo) {
         console.info(`\nLinting ${JSON.stringify(projectName)}...`);
     }
-    /**
-     * We want users to have the option of not specifying the config path, and let
-     * eslint automatically resolve the `.eslintrc.json` files in each folder.
-     */
-    let eslintConfigPath = options.eslintConfig
-        ? (0, path_1.resolve)(systemRoot, options.eslintConfig)
-        : undefined;
     options.cacheLocation = options.cacheLocation
         ? (0, devkit_1.joinPathFragments)(options.cacheLocation, projectName)
         : undefined;
-    const { printConfig, ...normalizedOptions } = options;
+    const { printConfig, errorOnUnmatchedPattern, ...normalizedOptions } = options;
     /**
      * Until ESLint v9 is released and the new so called flat config is the default
      * we only want to support it if the user has explicitly opted into it by converting
      * their root ESLint config to use eslint.config.js
      */
     const hasFlatConfig = (0, fs_1.existsSync)((0, devkit_1.joinPathFragments)(devkit_1.workspaceRoot, 'eslint.config.js'));
-    if (!eslintConfigPath && hasFlatConfig) {
-        const projectRoot = context.projectsConfigurations.projects[context.projectName].root;
-        eslintConfigPath = (0, devkit_1.joinPathFragments)(projectRoot, 'eslint.config.js');
+    // while standard eslint uses by default closest config to the file, if otherwise not specified,
+    // the flat config would always use the root config, so we need to explicitly set it to the local one
+    if (hasFlatConfig && !normalizedOptions.eslintConfig) {
+        const eslintConfigPath = (0, devkit_1.joinPathFragments)(projectRoot, 'eslint.config.js');
+        if ((0, fs_1.existsSync)(eslintConfigPath)) {
+            normalizedOptions.eslintConfig = eslintConfigPath;
+        }
     }
+    /**
+     * We want users to have the option of not specifying the config path, and let
+     * eslint automatically resolve the `.eslintrc.json` files in each folder.
+     */
+    let eslintConfigPath = normalizedOptions.eslintConfig
+        ? (0, path_1.resolve)(systemRoot, normalizedOptions.eslintConfig)
+        : undefined;
     const { eslint, ESLint } = await (0, eslint_utils_1.resolveAndInstantiateESLint)(eslintConfigPath, normalizedOptions, hasFlatConfig);
     const version = ESLint.version?.split('.');
     if (!version ||
@@ -62,18 +68,26 @@ async function run(options, context) {
         }
     }
     let lintResults = [];
+    const normalizedLintFilePatterns = normalizedOptions.lintFilePatterns.map((pattern) => {
+        return (0, utils_1.interpolate)(pattern, {
+            workspaceRoot: '',
+            projectRoot,
+            projectName: context.projectName,
+        });
+    });
     try {
-        lintResults = await eslint.lintFiles(normalizedOptions.lintFilePatterns);
+        lintResults = await eslint.lintFiles(normalizedLintFilePatterns);
     }
     catch (err) {
         if (err.message.includes('You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser')) {
+            const ruleName = err.message.match(/rule '([^']+)':/)?.[1];
             let eslintConfigPathForError = `for ${projectName}`;
             if (context.projectsConfigurations?.projects?.[projectName]?.root) {
                 const { root } = context.projectsConfigurations.projects[projectName];
                 eslintConfigPathForError = `\`${root}/.eslintrc.json\``;
             }
             console.error(`
-Error: You have attempted to use a lint rule which requires the full TypeScript type-checker to be available, but you do not have \`parserOptions.project\` configured to point at your project tsconfig.json files in the relevant TypeScript file "overrides" block of your project ESLint config ${eslintConfigPath || eslintConfigPathForError}
+Error: You have attempted to use ${ruleName ? `the lint rule ${ruleName}` : 'a lint rule'} which requires the full TypeScript type-checker to be available, but you do not have \`parserOptions.project\` configured to point at your project tsconfig.json files in the relevant TypeScript file "overrides" block of your project ESLint config ${eslintConfigPath || eslintConfigPathForError}
 
 Please see https://nx.dev/guides/eslint for full guidance on how to resolve this issue.
 `);
@@ -84,8 +98,8 @@ Please see https://nx.dev/guides/eslint for full guidance on how to resolve this
         // If some unexpected error, rethrow
         throw err;
     }
-    if (lintResults.length === 0) {
-        const ignoredPatterns = (await Promise.all(normalizedOptions.lintFilePatterns.map(async (pattern) => (await eslint.isPathIgnored(pattern)) ? pattern : null)))
+    if (lintResults.length === 0 && errorOnUnmatchedPattern) {
+        const ignoredPatterns = (await Promise.all(normalizedLintFilePatterns.map(async (pattern) => (await eslint.isPathIgnored(pattern)) ? pattern : null)))
             .filter((pattern) => !!pattern)
             .map((pattern) => `- '${pattern}'`);
         if (ignoredPatterns.length) {
@@ -104,14 +118,6 @@ Please see https://nx.dev/guides/eslint for full guidance on how to resolve this
         lintResults = ESLint.getErrorResults(lintResults);
     }
     const formatter = await eslint.loadFormatter(normalizedOptions.format);
-    let totalErrors = 0;
-    let totalWarnings = 0;
-    for (const result of lintResults) {
-        if (result.errorCount || result.warningCount) {
-            totalErrors += result.errorCount;
-            totalWarnings += result.warningCount;
-        }
-    }
     const formattedResults = await formatter.format(lintResults);
     if (normalizedOptions.outputFile) {
         const pathToOutputFile = (0, devkit_1.joinPathFragments)(context.root, normalizedOptions.outputFile);
@@ -121,20 +127,48 @@ Please see https://nx.dev/guides/eslint for full guidance on how to resolve this
     else {
         console.info(formattedResults);
     }
-    if (totalWarnings > 0 && printInfo) {
-        console.warn('Lint warnings found in the listed files.\n');
-    }
-    if (totalErrors > 0 && printInfo) {
-        console.error('Lint errors found in the listed files.\n');
-    }
-    if (totalWarnings === 0 && totalErrors === 0 && printInfo) {
-        console.info('All files pass linting.\n');
+    const totals = getTotals(lintResults);
+    if (printInfo) {
+        outputPrintInfo(totals);
     }
     return {
         success: normalizedOptions.force ||
-            (totalErrors === 0 &&
+            (totals.errors === 0 &&
                 (normalizedOptions.maxWarnings === -1 ||
-                    totalWarnings <= normalizedOptions.maxWarnings)),
+                    totals.warnings <= normalizedOptions.maxWarnings)),
     };
 }
 exports.default = run;
+function getTotals(lintResults) {
+    let errors = 0;
+    let warnings = 0;
+    let fixableErrors = 0;
+    let fixableWarnings = 0;
+    for (const result of lintResults) {
+        errors += result.errorCount || 0;
+        warnings += result.warningCount || 0;
+        fixableErrors += result.fixableErrorCount || 0;
+        fixableWarnings += result.fixableWarningCount || 0;
+    }
+    return {
+        errors,
+        warnings,
+        fixableErrors,
+        fixableWarnings,
+    };
+}
+function pluralizedOutput(word, count) {
+    return `${count} ${word}${count === 1 ? '' : 's'}`;
+}
+function outputPrintInfo({ errors, warnings, fixableErrors, fixableWarnings, }) {
+    const total = warnings + errors;
+    const totalFixable = fixableErrors + fixableWarnings;
+    if (total <= 0) {
+        console.info('\u2714 All files pass linting\n');
+        return;
+    }
+    console.info(`\u2716 ${pluralizedOutput('problem', total)} (${pluralizedOutput('error', errors)}, ${pluralizedOutput('warning', warnings)})\n`);
+    if (totalFixable <= 0)
+        return;
+    console.info(`  ${pluralizedOutput('error', fixableErrors)} and ${pluralizedOutput('warning', fixableWarnings)} are potentially fixable with the \`--fix\` option.\n`);
+}

package/src/executors/lint/schema.d.ts

@@ -21,6 +21,7 @@ export interface Schema extends JsonObject {
   resolvePluginsRelativeTo: string | null;
   reportUnusedDisableDirectives: Linter.StringSeverity | null;
   printConfig?: string | null;
+  errorOnUnmatchedPattern?: boolean;
 }
 
 type Formatter =

package/src/executors/lint/schema.json

@@ -1,7 +1,7 @@
 {
   "version": 2,
   "outputCapture": "direct-nodejs",
-  "$schema": "http://json-schema.org/schema",
+  "$schema": "https://json-schema.org/schema",
   "title": "ESLint Lint Target",
   "description": "ESLint Lint Target.",
   "cli": "nx",
@@ -17,7 +17,7 @@
     "lintFilePatterns": {
       "type": "array",
       "description": "One or more files/dirs/globs to pass directly to ESLint's `lintFiles()` method.",
-      "default": [],
+      "default": ["{projectRoot}"],
       "items": {
         "type": "string"
       }
@@ -137,8 +137,12 @@
       "type": "string",
       "description": "The equivalent of the `--print-config` flag on the ESLint CLI.",
       "x-completion-type": "file"
+    },
+    "errorOnUnmatchedPattern": {
+      "type": "boolean",
+      "description": "When set to false, equivalent of the `--no-error-on-unmatched-pattern` flag on the ESLint CLI.",
+      "default": true
     }
   },
-  "required": ["lintFilePatterns"],
   "examplesFile": "../../../docs/eslint-examples.md"
 }

package/src/executors/lint/utility/eslint-utils.js

@@ -38,7 +38,6 @@ async function resolveAndInstantiateESLint(eslintConfigPath, options, useFlatCon
          * not be any html files in the project, so keeping it true would break linting every time
          */
         errorOnUnmatchedPattern: false,
-        reportUnusedDisableDirectives: options.reportUnusedDisableDirectives || undefined,
     };
     if (useFlatConfig) {
         if (typeof options.useEslintrc !== 'undefined') {
@@ -50,6 +49,9 @@ async function resolveAndInstantiateESLint(eslintConfigPath, options, useFlatCon
         if (options.ignorePath !== undefined) {
             throw new Error('For Flat Config, ESLint removed `ignorePath` and so it is not supported as an option. See https://eslint.org/docs/latest/use/configure/configuration-files-new');
         }
+        if (options.reportUnusedDisableDirectives) {
+            throw new Error('For Flat Config, ESLint removed `reportedUnusedDisableDirectives` and so it is not supported as an option. See https://eslint.org/docs/latest/use/configure/configuration-files-new');
+        }
     }
     else {
         eslintOptions.rulePaths = options.rulesdir || [];
@@ -61,6 +63,8 @@ async function resolveAndInstantiateESLint(eslintConfigPath, options, useFlatCon
          * merge the provided config with others it finds automatically.
          */
         eslintOptions.useEslintrc = !options.noEslintrc;
+        eslintOptions.reportUnusedDisableDirectives =
+            options.reportUnusedDisableDirectives || undefined;
     }
     const eslint = new ESLint(eslintOptions);
     return {

package/src/generators/convert-to-flat-config/converters/json-converter.d.ts

@@ -1,6 +1,11 @@
 import { Tree } from '@nx/devkit';
+import { ESLint } from 'eslint';
 /**
  * Converts an ESLint JSON config to a flat config.
  * Deletes the original file along with .eslintignore if it exists.
  */
-export declare function convertEslintJsonToFlatConfig(tree: Tree, root: string, sourceFile: string, destinationFile: string): void;
+export declare function convertEslintJsonToFlatConfig(tree: Tree, root: string, config: ESLint.ConfigData, ignorePaths: string[]): {
+    content: string;
+    addESLintRC: boolean;
+    addESLintJS: boolean;
+};

package/src/generators/convert-to-flat-config/converters/json-converter.js

@@ -2,25 +2,25 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.convertEslintJsonToFlatConfig = void 0;
 const devkit_1 = require("@nx/devkit");
-const path_1 = require("path");
 const ts = require("typescript");
-const versions_1 = require("../../../utils/versions");
 const ast_utils_1 = require("../../utils/flat-config/ast-utils");
 const eslint_file_1 = require("../../utils/eslint-file");
+const path_utils_1 = require("../../utils/flat-config/path-utils");
 /**
  * Converts an ESLint JSON config to a flat config.
  * Deletes the original file along with .eslintignore if it exists.
  */
-function convertEslintJsonToFlatConfig(tree, root, sourceFile, destinationFile) {
+function convertEslintJsonToFlatConfig(tree, root, config, ignorePaths) {
     const importsMap = new Map();
     const exportElements = [];
     let isFlatCompatNeeded = false;
+    let isESLintJSNeeded = false;
     let combinedConfig = [];
     let languageOptions = [];
-    // read original config
-    const config = (0, devkit_1.readJson)(tree, `${root}/${sourceFile}`);
     if (config.extends) {
-        isFlatCompatNeeded = addExtends(importsMap, exportElements, config, tree);
+        const extendsResult = addExtends(importsMap, exportElements, config);
+        isFlatCompatNeeded = extendsResult.isFlatCompatNeeded;
+        isESLintJSNeeded = extendsResult.isESLintJSNeeded;
     }
     if (config.plugins) {
         addPlugins(importsMap, exportElements, config);
@@ -70,7 +70,7 @@ function convertEslintJsonToFlatConfig(tree, root, sourceFile, destinationFile)
                 override.parser) {
                 isFlatCompatNeeded = true;
             }
-            exportElements.push((0, ast_utils_1.generateFlatOverride)(override, root));
+            exportElements.push((0, ast_utils_1.generateFlatOverride)(override));
         });
     }
     if (config.ignorePatterns) {
@@ -79,36 +79,35 @@ function convertEslintJsonToFlatConfig(tree, root, sourceFile, destinationFile)
             : [config.ignorePatterns]).filter((pattern) => !['**/*', '!**/*', 'node_modules'].includes(pattern)); // these are useless in a flat config
         if (patterns.length > 0) {
             exportElements.push((0, ast_utils_1.generateAst)({
-                ignores: patterns.map((path) => (0, ast_utils_1.mapFilePath)(path, root)),
+                ignores: patterns.map((path) => (0, path_utils_1.mapFilePath)(path)),
             }));
         }
     }
-    if (tree.exists(`${root}/.eslintignore`)) {
-        const patterns = tree
-            .read(`${root}/.eslintignore`, 'utf-8')
-            .split('\n')
-            .filter((line) => line.length > 0 && line !== 'node_modules')
-            .map((path) => (0, ast_utils_1.mapFilePath)(path, root));
-        if (patterns.length > 0) {
-            exportElements.push((0, ast_utils_1.generateAst)({ ignores: patterns }));
+    for (const ignorePath of ignorePaths) {
+        if (tree.exists(ignorePath)) {
+            const patterns = tree
+                .read(ignorePath, 'utf-8')
+                .split('\n')
+                .filter((line) => line.length > 0 && line !== 'node_modules')
+                .map((path) => (0, path_utils_1.mapFilePath)(path));
+            if (patterns.length > 0) {
+                exportElements.push((0, ast_utils_1.generateAst)({ ignores: patterns }));
+            }
         }
     }
-    tree.delete((0, path_1.join)(root, sourceFile));
-    tree.delete((0, path_1.join)(root, '.eslintignore'));
     // create the node list and print it to new file
     const nodeList = (0, ast_utils_1.createNodeList)(importsMap, exportElements, isFlatCompatNeeded);
-    const content = (0, ast_utils_1.stringifyNodeList)(nodeList, root, destinationFile);
-    tree.write((0, path_1.join)(root, destinationFile), content);
-    if (isFlatCompatNeeded) {
-        (0, devkit_1.addDependenciesToPackageJson)(tree, {}, {
-            '@eslint/eslintrc': versions_1.eslintrcVersion,
-        });
-    }
+    return {
+        content: (0, ast_utils_1.stringifyNodeList)(nodeList),
+        addESLintRC: isFlatCompatNeeded,
+        addESLintJS: isESLintJSNeeded,
+    };
 }
 exports.convertEslintJsonToFlatConfig = convertEslintJsonToFlatConfig;
 // add parsed extends to export blocks and add import statements
-function addExtends(importsMap, configBlocks, config, tree) {
+function addExtends(importsMap, configBlocks, config) {
     let isFlatCompatNeeded = false;
+    let isESLintJSNeeded = false;
     const extendsConfig = Array.isArray(config.extends)
         ? config.extends
         : [config.extends];
@@ -137,9 +136,7 @@ function addExtends(importsMap, configBlocks, config, tree) {
             }
         });
         if (eslintPluginExtends.length) {
-            (0, devkit_1.addDependenciesToPackageJson)(tree, {}, {
-                '@eslint/js': versions_1.eslintVersion,
-            });
+            isESLintJSNeeded = true;
             importsMap.set('@eslint/js', 'js');
             eslintPluginExtends.forEach((plugin) => {
                 configBlocks.push(ts.factory.createPropertyAccessExpression(ts.factory.createPropertyAccessExpression(ts.factory.createIdentifier('js'), ts.factory.createIdentifier('configs')), ts.factory.createIdentifier(plugin.slice(7)) // strip 'eslint:' prefix
@@ -149,12 +146,10 @@ function addExtends(importsMap, configBlocks, config, tree) {
     }
     if (eslintrcConfigs.length) {
         isFlatCompatNeeded = true;
-        (0, devkit_1.addDependenciesToPackageJson)(tree, {}, {
-            '@eslint/js': versions_1.eslintVersion,
-        });
+        isESLintJSNeeded = true;
         configBlocks.push((0, ast_utils_1.generatePluginExtendsElement)(eslintrcConfigs));
     }
-    return isFlatCompatNeeded;
+    return { isFlatCompatNeeded, isESLintJSNeeded };
 }
 function addPlugins(importsMap, configBlocks, config) {
     const mappedPlugins = [];