@nx/eslint 0.0.0-pr-22179-271588f → 0.0.0-pr-26482-ebe2dba

package/LICENSE

@@ -1,6 +1,6 @@
 (The MIT License)
 
-Copyright (c) 2017-2023 Narwhal Technologies Inc.
+Copyright (c) 2017-2024 Narwhal Technologies Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

package/generators.json

@@ -23,6 +23,11 @@
       "factory": "./src/generators/convert-to-flat-config/generator",
       "schema": "./src/generators/convert-to-flat-config/schema.json",
       "description": "Convert an Nx workspace's ESLint configs to use Flat Config."
+    },
+    "convert-to-inferred": {
+      "factory": "./src/generators/convert-to-inferred/convert-to-inferred",
+      "schema": "./src/generators/convert-to-inferred/schema.json",
+      "description": "Convert existing ESLint project(s) using `@nx/eslint:lint` executor to use `@nx/eslint/plugin`."
     }
   }
 }

package/migrations.json

@@ -1,17 +1,5 @@
 {
   "generators": {
-    "add-eslint-inputs": {
-      "cli": "nx",
-      "version": "15.0.0-beta.0",
-      "description": "Stop hashing eslint config files for build targets and dependent tasks",
-      "factory": "./src/migrations/update-15-0-0/add-eslint-inputs"
-    },
-    "add-eslint-ignore": {
-      "cli": "nx",
-      "version": "15.7.1-beta.0",
-      "description": "Add node_modules to root eslint ignore",
-      "factory": "./src/migrations/update-15-7-1/add-eslint-ignore"
-    },
     "update-16-0-0-add-nx-packages": {
       "cli": "nx",
       "version": "16.0.0-beta.1",
@@ -133,6 +121,23 @@
           "version": "^6.13.2"
         }
       }
+    },
+    "18.2.0": {
+      "version": "18.2.0-beta.0",
+      "packages": {
+        "@typescript-eslint/parser": {
+          "version": "^7.3.0"
+        },
+        "@typescript-eslint/eslint-plugin": {
+          "version": "^7.3.0"
+        },
+        "@typescript-eslint/utils": {
+          "version": "^7.3.0"
+        },
+        "eslint": {
+          "version": "~8.57.0"
+        }
+      }
     }
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint",
-  "version": "0.0.0-pr-22179-271588f",
+  "version": "0.0.0-pr-26482-ebe2dba",
   "private": false,
   "description": "The ESLint plugin for Nx contains executors, generators and utilities used for linting JavaScript/TypeScript projects within an Nx workspace.",
   "repository": {
@@ -13,9 +13,10 @@
     "Web",
     "Lint",
     "ESLint",
-    "CLI"
+    "CLI",
+    "Testing"
   ],
-  "main": "./index.js",
+  "main": "./index",
   "typings": "./index.d.ts",
   "author": "Victor Savkin",
   "license": "MIT",
@@ -30,18 +31,19 @@
   "generators": "./generators.json",
   "executors": "./executors.json",
   "peerDependencies": {
-    "js-yaml": "4.1.0"
+    "@zkochan/js-yaml": "0.0.7",
+    "eslint": "^8.0.0 || ^9.0.0"
   },
   "dependencies": {
-    "@nx/devkit": "0.0.0-pr-22179-271588f",
-    "@nx/js": "0.0.0-pr-22179-271588f",
-    "eslint": "^8.0.0",
+    "@nx/devkit": "0.0.0-pr-26482-ebe2dba",
+    "@nx/js": "0.0.0-pr-26482-ebe2dba",
+    "semver": "^7.5.3",
     "tslib": "^2.3.0",
-    "typescript": "~5.3.2",
-    "@nx/linter": "0.0.0-pr-22179-271588f"
+    "typescript": "~5.4.2",
+    "@nx/linter": "0.0.0-pr-26482-ebe2dba"
   },
   "peerDependenciesMeta": {
-    "js-yaml": {
+    "@zkochan/js-yaml": {
       "optional": true
     }
   },

package/plugin.d.ts

@@ -1 +1 @@
-export { createNodes, EslintPluginOptions } from './src/plugins/plugin';
+export { createNodes, createNodesV2, EslintPluginOptions, } from './src/plugins/plugin';

package/plugin.js

@@ -1,5 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.createNodes = void 0;
+exports.createNodesV2 = exports.createNodes = void 0;
 var plugin_1 = require("./src/plugins/plugin");
 Object.defineProperty(exports, "createNodes", { enumerable: true, get: function () { return plugin_1.createNodes; } });
+Object.defineProperty(exports, "createNodesV2", { enumerable: true, get: function () { return plugin_1.createNodesV2; } });

package/src/executors/lint/lint.impl.d.ts

@@ -1,4 +1,4 @@
-import { ExecutorContext } from '@nx/devkit';
+import { type ExecutorContext } from '@nx/devkit';
 import type { Schema } from './schema';
 export default function run(options: Schema, context: ExecutorContext): Promise<{
     success: boolean;

package/src/executors/lint/lint.impl.js

@@ -2,9 +2,10 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const devkit_1 = require("@nx/devkit");
 const fs_1 = require("fs");
+const utils_1 = require("nx/src/tasks-runner/utils");
 const path_1 = require("path");
+const config_file_1 = require("../../utils/config-file");
 const eslint_utils_1 = require("./utility/eslint-utils");
-const utils_1 = require("nx/src/tasks-runner/utils");
 async function run(options, context) {
     // this is only used for the hasher
     delete options.hasTypeAwareRules;
@@ -23,19 +24,14 @@ async function run(options, context) {
         ? (0, devkit_1.joinPathFragments)(options.cacheLocation, projectName)
         : undefined;
     const { printConfig, errorOnUnmatchedPattern, ...normalizedOptions } = options;
-    /**
-     * Until ESLint v9 is released and the new so called flat config is the default
-     * we only want to support it if the user has explicitly opted into it by converting
-     * their root ESLint config to use eslint.config.js
-     */
-    const hasFlatConfig = (0, fs_1.existsSync)((0, devkit_1.joinPathFragments)(devkit_1.workspaceRoot, 'eslint.config.js'));
+    // locate the flat config file if it exists starting from the project root
+    const flatConfigFilePath = (0, config_file_1.findFlatConfigFile)(projectRoot, context.root);
+    const hasFlatConfig = flatConfigFilePath !== null;
     // while standard eslint uses by default closest config to the file, if otherwise not specified,
-    // the flat config would always use the root config, so we need to explicitly set it to the local one
+    // the flat config would be resolved starting from the cwd, which we changed to the workspace root
+    // so we explicitly set the config path to the flat config file path we previously found
     if (hasFlatConfig && !normalizedOptions.eslintConfig) {
-        const eslintConfigPath = (0, devkit_1.joinPathFragments)(projectRoot, 'eslint.config.js');
-        if ((0, fs_1.existsSync)(eslintConfigPath)) {
-            normalizedOptions.eslintConfig = eslintConfigPath;
-        }
+        normalizedOptions.eslintConfig = path_1.posix.relative(systemRoot, flatConfigFilePath);
     }
     /**
      * We want users to have the option of not specifying the config path, and let
@@ -81,15 +77,24 @@ async function run(options, context) {
     catch (err) {
         if (err.message.includes('You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser')) {
             const ruleName = err.message.match(/rule '([^']+)':/)?.[1];
-            let eslintConfigPathForError = `for ${projectName}`;
-            if (context.projectsConfigurations?.projects?.[projectName]?.root) {
-                const { root } = context.projectsConfigurations.projects[projectName];
-                eslintConfigPathForError = `\`${root}/.eslintrc.json\``;
+            const reportedFile = err.message.match(/Occurred while linting (.+)$/)?.[1];
+            let eslintConfigPathForError = `for the project "${projectName}"`;
+            if (eslintConfigPath) {
+                eslintConfigPathForError = `"${path_1.posix.relative(context.root, eslintConfigPath)}"`;
+            }
+            else {
+                const configPathForfile = hasFlatConfig
+                    ? (0, config_file_1.findFlatConfigFile)(projectRoot, context.root)
+                    : (0, config_file_1.findOldConfigFile)(reportedFile ?? projectRoot, context.root);
+                if (configPathForfile) {
+                    eslintConfigPathForError = `"${path_1.posix.relative(context.root, configPathForfile)}"`;
+                }
             }
             console.error(`
-Error: You have attempted to use ${ruleName ? `the lint rule ${ruleName}` : 'a lint rule'} which requires the full TypeScript type-checker to be available, but you do not have \`parserOptions.project\` configured to point at your project tsconfig.json files in the relevant TypeScript file "overrides" block of your project ESLint config ${eslintConfigPath || eslintConfigPathForError}
+Error: You have attempted to use ${ruleName ? `the lint rule "${ruleName}"` : 'a lint rule'} which requires the full TypeScript type-checker to be available, but you do not have "parserOptions.project" configured to point at your project tsconfig.json files in the relevant TypeScript file "overrides" block of your ESLint config ${eslintConfigPathForError}
+${reportedFile ? `Occurred while linting ${reportedFile}` : ''}
 
-Please see https://nx.dev/guides/eslint for full guidance on how to resolve this issue.
+Please see https://nx.dev/recipes/tips-n-tricks/eslint for full guidance on how to resolve this issue.
 `);
             return {
                 success: false,

package/src/executors/lint/utility/eslint-utils.js

@@ -1,26 +1,13 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.resolveAndInstantiateESLint = void 0;
-async function resolveESLintClass(useFlatConfig = false) {
-    try {
-        if (!useFlatConfig) {
-            return (await Promise.resolve().then(() => require('eslint'))).ESLint;
-        }
-        // eslint-disable-next-line @typescript-eslint/no-var-requires
-        const { FlatESLint } = require('eslint/use-at-your-own-risk');
-        return FlatESLint;
-    }
-    catch {
-        throw new Error('Unable to find ESLint. Ensure ESLint is installed.');
-    }
-}
+const config_file_1 = require("../../../utils/config-file");
+const resolve_eslint_class_1 = require("../../../utils/resolve-eslint-class");
 async function resolveAndInstantiateESLint(eslintConfigPath, options, useFlatConfig = false) {
-    if (useFlatConfig &&
-        eslintConfigPath &&
-        !eslintConfigPath?.endsWith('eslint.config.js')) {
+    if (useFlatConfig && eslintConfigPath && !(0, config_file_1.isFlatConfig)(eslintConfigPath)) {
         throw new Error('When using the new Flat Config with ESLint, all configs must be named eslint.config.js and .eslintrc files may not be used. See https://eslint.org/docs/latest/use/configure/configuration-files-new');
     }
-    const ESLint = await resolveESLintClass(useFlatConfig);
+    const ESLint = await (0, resolve_eslint_class_1.resolveESLintClass)(useFlatConfig);
     const eslintOptions = {
         overrideConfigFile: eslintConfigPath,
         fix: !!options.fix,

package/src/generators/convert-to-flat-config/generator.d.ts

@@ -1,4 +1,4 @@
-import { Tree } from '@nx/devkit';
+import { GeneratorCallback, Tree } from '@nx/devkit';
 import { ConvertToFlatConfigGeneratorSchema } from './schema';
-export declare function convertToFlatConfigGenerator(tree: Tree, options: ConvertToFlatConfigGeneratorSchema): Promise<void>;
+export declare function convertToFlatConfigGenerator(tree: Tree, options: ConvertToFlatConfigGeneratorSchema): Promise<void | GeneratorCallback>;
 export default convertToFlatConfigGenerator;

package/src/generators/convert-to-flat-config/generator.js

@@ -6,7 +6,7 @@ const eslint_file_1 = require("../utils/eslint-file");
 const path_1 = require("path");
 const versions_1 = require("../../utils/versions");
 const json_converter_1 = require("./converters/json-converter");
-const js_yaml_1 = require("js-yaml");
+let shouldInstallDeps = false;
 async function convertToFlatConfigGenerator(tree, options) {
     const eslintFile = (0, eslint_file_1.findEslintFile)(tree);
     if (!eslintFile) {
@@ -33,6 +33,9 @@ async function convertToFlatConfigGenerator(tree, options) {
     if (!options.skipFormat) {
         await (0, devkit_1.formatFiles)(tree);
     }
+    if (shouldInstallDeps) {
+        return () => (0, devkit_1.installPackagesTask)(tree);
+    }
 }
 exports.convertToFlatConfigGenerator = convertToFlatConfigGenerator;
 exports.default = convertToFlatConfigGenerator;
@@ -112,7 +115,8 @@ function convertConfigToFlatConfig(tree, root, source, target, ignorePath) {
     }
     if (source.endsWith('.yaml') || source.endsWith('.yml')) {
         const originalContent = tree.read(`${root}/${source}`, 'utf-8');
-        const config = (0, js_yaml_1.load)(originalContent, {
+        const { load } = require('@zkochan/js-yaml');
+        const config = load(originalContent, {
             json: true,
             filename: source,
         });
@@ -127,11 +131,13 @@ function processConvertedConfig(tree, root, source, target, { content, addESLint
     tree.write((0, path_1.join)(root, target), content);
     // add missing packages
     if (addESLintRC) {
+        shouldInstallDeps = true;
         (0, devkit_1.addDependenciesToPackageJson)(tree, {}, {
             '@eslint/eslintrc': versions_1.eslintrcVersion,
         });
     }
     if (addESLintJS) {
+        shouldInstallDeps = true;
         (0, devkit_1.addDependenciesToPackageJson)(tree, {}, {
             '@eslint/js': versions_1.eslintVersion,
         });

package/src/generators/convert-to-inferred/convert-to-inferred.d.ts

@@ -0,0 +1,7 @@
+import { type Tree } from '@nx/devkit';
+interface Schema {
+    project?: string;
+    skipFormat?: boolean;
+}
+export declare function convertToInferred(tree: Tree, options: Schema): Promise<void>;
+export default convertToInferred;

package/src/generators/convert-to-inferred/convert-to-inferred.js

@@ -0,0 +1,80 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.convertToInferred = void 0;
+const devkit_1 = require("@nx/devkit");
+const plugin_1 = require("../../plugins/plugin");
+const executor_to_plugin_migrator_1 = require("@nx/devkit/src/generators/plugin-migrations/executor-to-plugin-migrator");
+const target_options_map_1 = require("./lib/target-options-map");
+const utils_1 = require("nx/src/tasks-runner/utils");
+async function convertToInferred(tree, options) {
+    const projectGraph = await (0, devkit_1.createProjectGraphAsync)();
+    const migratedProjectsModern = await (0, executor_to_plugin_migrator_1.migrateExecutorToPlugin)(tree, projectGraph, '@nx/eslint:lint', '@nx/eslint/plugin', (targetName) => ({ targetName }), postTargetTransformer, plugin_1.createNodesV2, options.project);
+    const migratedProjectsLegacy = await (0, executor_to_plugin_migrator_1.migrateExecutorToPlugin)(tree, projectGraph, '@nrwl/linter:eslint', '@nx/eslint/plugin', (targetName) => ({ targetName }), postTargetTransformer, plugin_1.createNodesV2, options.project);
+    const migratedProjects = migratedProjectsModern.size + migratedProjectsLegacy.size;
+    if (migratedProjects === 0) {
+        throw new Error('Could not find any targets to migrate.');
+    }
+    if (!options.skipFormat) {
+        await (0, devkit_1.formatFiles)(tree);
+    }
+}
+exports.convertToInferred = convertToInferred;
+function postTargetTransformer(target, tree, projectDetails) {
+    if (target.inputs) {
+        const inputs = target.inputs.filter((input) => typeof input === 'string' &&
+            ![
+                'default',
+                '{workspaceRoot}/.eslintrc.json',
+                '{workspaceRoot}/.eslintignore',
+                '{workspaceRoot}/eslint.config.js',
+            ].includes(input));
+        if (inputs.length === 0) {
+            delete target.inputs;
+        }
+    }
+    if (target.options) {
+        if ('eslintConfig' in target.options) {
+            delete target.options.eslintConfig;
+        }
+        if ('force' in target.options) {
+            delete target.options.force;
+        }
+        if ('silent' in target.options) {
+            delete target.options.silent;
+        }
+        if ('hasTypeAwareRules' in target.options) {
+            delete target.options.hasTypeAwareRules;
+        }
+        if ('errorOnUnmatchedPattern' in target.options) {
+            if (!target.options.errorOnUnmatchedPattern) {
+                target.options['no-error-on-unmatched-pattern'] = true;
+            }
+            delete target.options.errorOnUnmatchedPattern;
+        }
+        if ('outputFile' in target.options) {
+            target.outputs ??= [];
+            target.outputs.push(target.options.outputFile);
+        }
+        for (const key in target_options_map_1.targetOptionsToCliMap) {
+            if (target.options[key]) {
+                target.options[target_options_map_1.targetOptionsToCliMap[key]] = target.options[key];
+                delete target.options[key];
+            }
+        }
+        if ('lintFilePatterns' in target.options) {
+            const normalizedLintFilePatterns = target.options.lintFilePatterns.map((pattern) => {
+                return (0, utils_1.interpolate)(pattern, {
+                    workspaceRoot: '',
+                    projectRoot: projectDetails.root,
+                    projectName: projectDetails.projectName,
+                });
+            });
+            target.options.args = normalizedLintFilePatterns.map((pattern) => pattern.startsWith(projectDetails.root)
+                ? pattern.replace(new RegExp(`^${projectDetails.root}/`), './')
+                : pattern);
+            delete target.options.lintFilePatterns;
+        }
+    }
+    return target;
+}
+exports.default = convertToInferred;

package/src/generators/convert-to-inferred/lib/target-options-map.d.ts

@@ -0,0 +1,16 @@
+export declare const targetOptionsToCliMap: {
+    fix: string;
+    format: string;
+    cache: string;
+    cacheLocation: string;
+    cacheStrategy: string;
+    noEslintrc: string;
+    outputFile: string;
+    maxWarnings: string;
+    quiet: string;
+    ignorePath: string;
+    rulesdir: string;
+    resolvePluginsRelativeTo: string;
+    reportUnusedDisableDirectives: string;
+    printConfig: string;
+};

package/src/generators/convert-to-inferred/lib/target-options-map.js

@@ -0,0 +1,19 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.targetOptionsToCliMap = void 0;
+exports.targetOptionsToCliMap = {
+    fix: 'fix',
+    format: 'format',
+    cache: 'cache',
+    cacheLocation: 'cache-location',
+    cacheStrategy: 'cache-strategy',
+    noEslintrc: 'no-eslintrc',
+    outputFile: 'output-file',
+    maxWarnings: 'max-warnings',
+    quiet: 'quiet',
+    ignorePath: 'ignore-path',
+    rulesdir: 'rulesdir',
+    resolvePluginsRelativeTo: 'resolve-plugins-relative-to',
+    reportUnusedDisableDirectives: 'report-unused-disable-directives',
+    printConfig: 'print-config',
+};

package/src/generators/convert-to-inferred/schema.json

@@ -0,0 +1,19 @@
+{
+  "$schema": "https://json-schema.org/schema",
+  "$id": "NxEslintConvertToInferred",
+  "description": "Convert existing Eslint project(s) using `@nx/eslint:lint` executor to use `@nx/eslint/plugin`. Defaults to migrating all projects. Pass '--project' to migrate only one target.",
+  "title": "Convert Eslint project from executor to plugin",
+  "type": "object",
+  "properties": {
+    "project": {
+      "type": "string",
+      "description": "The project to convert from using the `@nx/eslint:lint` executor to use `@nx/eslint/plugin`.",
+      "x-priority": "important"
+    },
+    "skipFormat": {
+      "type": "boolean",
+      "description": "Whether to format files at the end of the migration.",
+      "default": false
+    }
+  }
+}

package/src/generators/init/init-migration.js

@@ -104,6 +104,10 @@ function migrateEslintFile(projectEslintPath, tree) {
                 }
                 // add extends
                 json.extends = json.extends || [];
+                // ensure extends is an array
+                if (typeof json.extends === 'string') {
+                    json.extends = [json.extends];
+                }
                 const pathToRootConfig = `${(0, devkit_1.offsetFromRoot)((0, path_1.dirname)(projectEslintPath))}${baseFile}`;
                 if (json.extends.indexOf(pathToRootConfig) === -1) {
                     json.extends.push(pathToRootConfig);

package/src/generators/init/init.d.ts

@@ -1,4 +1,4 @@
-import type { GeneratorCallback, Tree } from '@nx/devkit';
+import { GeneratorCallback, Tree } from '@nx/devkit';
 export interface LinterInitOptions {
     skipPackageJson?: boolean;
     keepExistingVersions?: boolean;

package/src/generators/init/init.js

@@ -2,7 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.lintInitGenerator = exports.initEsLint = void 0;
 const devkit_1 = require("@nx/devkit");
-const update_package_scripts_1 = require("@nx/devkit/src/utils/update-package-scripts");
+const add_plugin_1 = require("@nx/devkit/src/utils/add-plugin");
 const versions_1 = require("../../utils/versions");
 const eslint_file_1 = require("../utils/eslint-file");
 const plugin_1 = require("../../plugins/plugin");
@@ -31,24 +31,6 @@ function addTargetDefaults(tree) {
     ];
     (0, devkit_1.updateNxJson)(tree, nxJson);
 }
-function addPlugin(tree) {
-    const nxJson = (0, devkit_1.readNxJson)(tree);
-    nxJson.plugins ??= [];
-    for (const plugin of nxJson.plugins) {
-        if (typeof plugin === 'string'
-            ? plugin === '@nx/eslint/plugin'
-            : plugin.plugin === '@nx/eslint/plugin') {
-            return;
-        }
-    }
-    nxJson.plugins.push({
-        plugin: '@nx/eslint/plugin',
-        options: {
-            targetName: 'lint',
-        },
-    });
-    (0, devkit_1.updateNxJson)(tree, nxJson);
-}
 async function initEsLint(tree, options) {
     const nxJson = (0, devkit_1.readNxJson)(tree);
     const addPluginDefault = process.env.NX_ADD_PLUGINS !== 'false' &&
@@ -56,11 +38,19 @@ async function initEsLint(tree, options) {
     options.addPlugin ??= addPluginDefault;
     const hasPlugin = (0, plugin_2.hasEslintPlugin)(tree);
     const rootEslintFile = (0, eslint_file_1.findEslintFile)(tree);
+    const graph = await (0, devkit_1.createProjectGraphAsync)();
+    const lintTargetNames = [
+        'lint',
+        'eslint:lint',
+        'eslint-lint',
+        '_lint',
+        '_eslint:lint',
+        '_eslint-lint',
+    ];
     if (rootEslintFile && options.addPlugin && !hasPlugin) {
-        addPlugin(tree);
-        if (options.updatePackageScripts) {
-            await (0, update_package_scripts_1.updatePackageScripts)(tree, plugin_1.createNodes);
-        }
+        await (0, add_plugin_1.addPlugin)(tree, graph, '@nx/eslint/plugin', plugin_1.createNodesV2, {
+            targetName: lintTargetNames,
+        }, options.updatePackageScripts);
         return () => { };
     }
     if (rootEslintFile) {
@@ -68,7 +58,9 @@ async function initEsLint(tree, options) {
     }
     updateProductionFileset(tree);
     if (options.addPlugin) {
-        addPlugin(tree);
+        await (0, add_plugin_1.addPlugin)(tree, graph, '@nx/eslint/plugin', plugin_1.createNodesV2, {
+            targetName: lintTargetNames,
+        }, options.updatePackageScripts);
     }
     else {
         addTargetDefaults(tree);
@@ -81,9 +73,6 @@ async function initEsLint(tree, options) {
             eslint: versions_1.eslintVersion,
         }, undefined, options.keepExistingVersions));
     }
-    if (options.updatePackageScripts) {
-        await (0, update_package_scripts_1.updatePackageScripts)(tree, plugin_1.createNodes);
-    }
     return (0, devkit_1.runTasksInSerial)(...tasks);
 }
 exports.initEsLint = initEsLint;

package/src/generators/lint-project/lint-project.d.ts

@@ -1,4 +1,4 @@
-import type { GeneratorCallback, Tree } from '@nx/devkit';
+import { GeneratorCallback, Tree } from '@nx/devkit';
 import { Linter as LinterEnum } from '../utils/linter';
 interface LintProjectOptions {
     project: string;
@@ -16,6 +16,7 @@ interface LintProjectOptions {
      * @internal
      */
     addExplicitTargets?: boolean;
+    addPackageJsonDependencyChecks?: boolean;
 }
 export declare function lintProjectGenerator(tree: Tree, options: LintProjectOptions): Promise<GeneratorCallback>;
 export declare function lintProjectGeneratorInternal(tree: Tree, options: LintProjectOptions): Promise<GeneratorCallback>;

package/src/generators/lint-project/lint-project.js

@@ -73,7 +73,8 @@ async function lintProjectGeneratorInternal(tree, options) {
     if (!options.rootProject) {
         const projects = {};
         (0, project_configuration_1.getProjects)(tree).forEach((v, k) => (projects[k] = v));
-        if (isMigrationToMonorepoNeeded(projects, tree)) {
+        const graph = await (0, devkit_1.createProjectGraphAsync)();
+        if (isMigrationToMonorepoNeeded(tree, graph)) {
             // we only migrate project configurations that have been created
             const filteredProjects = [];
             Object.entries(projects).forEach(([name, project]) => {
@@ -88,7 +89,7 @@ async function lintProjectGeneratorInternal(tree, options) {
     // additionally, the companion e2e app would have `rootProject: true`
     // so we need to check for the root path as well
     if (!options.rootProject || projectConfig.root !== '.') {
-        createEsLintConfiguration(tree, projectConfig, options.setParserOptionsProject, options.rootProject);
+        createEsLintConfiguration(tree, options, projectConfig, options.setParserOptionsProject, options.rootProject);
     }
     // Buildable libs need source analysis enabled for linting `package.json`.
     if (isBuildableLibraryProject(projectConfig) &&
@@ -107,7 +108,7 @@ async function lintProjectGeneratorInternal(tree, options) {
     return (0, devkit_1.runTasksInSerial)(...tasks);
 }
 exports.lintProjectGeneratorInternal = lintProjectGeneratorInternal;
-function createEsLintConfiguration(tree, projectConfig, setParserOptionsProject, rootProject) {
+function createEsLintConfiguration(tree, options, projectConfig, setParserOptionsProject, rootProject) {
     // we are only extending root for non-standalone projects or their complementary e2e apps
     const extendedRootConfig = rootProject ? undefined : (0, eslint_file_1.findEslintFile)(tree);
     const pathToRootConfig = extendedRootConfig
@@ -150,7 +151,8 @@ function createEsLintConfiguration(tree, projectConfig, setParserOptionsProject,
             rules: {},
         },
     ];
-    if (isBuildableLibraryProject(projectConfig)) {
+    if (options.addPackageJsonDependencyChecks ||
+        isBuildableLibraryProject(projectConfig)) {
         overrides.push({
             files: ['*.json'],
             parser: 'jsonc-eslint-parser',
@@ -198,30 +200,24 @@ function isBuildableLibraryProject(projectConfig) {
  * Detect based on the state of lint target configuration of the root project
  * if we should migrate eslint configs to monorepo style
  */
-function isMigrationToMonorepoNeeded(projects, tree) {
+function isMigrationToMonorepoNeeded(tree, graph) {
     // the base config is already created, migration has been done
     if (tree.exists(config_file_1.baseEsLintConfigFile) ||
         tree.exists(config_file_1.baseEsLintFlatConfigFile)) {
         return false;
     }
-    const configs = Object.values(projects);
-    if (configs.length === 1) {
-        return false;
-    }
+    const nodes = Object.values(graph.nodes);
     // get root project
-    const rootProject = configs.find((p) => p.root === '.');
-    if (!rootProject || !rootProject.targets) {
+    const rootProject = nodes.find((p) => p.data.root === '.');
+    if (!rootProject || !rootProject.data.targets) {
         return false;
     }
-    // check if we're inferring lint target from `@nx/eslint/plugin`
-    if ((0, plugin_1.hasEslintPlugin)(tree)) {
-        for (const f of config_file_1.ESLINT_CONFIG_FILENAMES) {
-            if (tree.exists(f)) {
-                return true;
-            }
+    for (const targetConfig of Object.values(rootProject.data.targets ?? {})) {
+        if (['@nx/eslint:lint', '@nrwl/linter:eslint', '@nx/linter:eslint'].includes(targetConfig.executor) ||
+            (targetConfig.executor === 'nx:run-commands' &&
+                targetConfig.options?.command.startsWith('eslint '))) {
+            return true;
         }
     }
-    // find if root project has lint target
-    const lintTarget = (0, init_migration_1.findLintTarget)(rootProject);
-    return !!lintTarget;
+    return false;
 }

package/src/generators/utils/eslint-file.js

@@ -189,7 +189,7 @@ function replaceOverridesInLintConfig(tree, root, overrides) {
         content = (0, ast_utils_1.removeOverridesFromLintConfig)(content);
         overrides.forEach((override) => {
             const flatOverride = (0, ast_utils_1.generateFlatOverride)(override);
-            (0, ast_utils_1.addBlockToFlatConfigExport)(content, flatOverride);
+            content = (0, ast_utils_1.addBlockToFlatConfigExport)(content, flatOverride);
         });
         tree.write(fileName, content);
     }
@@ -209,7 +209,9 @@ function addExtendsToLintConfig(tree, root, plugin) {
         const pluginExtends = (0, ast_utils_1.generatePluginExtendsElement)(plugins);
         let content = tree.read(fileName, 'utf8');
         content = (0, ast_utils_1.addCompatToFlatConfig)(content);
-        tree.write(fileName, (0, ast_utils_1.addBlockToFlatConfigExport)(content, pluginExtends));
+        tree.write(fileName, (0, ast_utils_1.addBlockToFlatConfigExport)(content, pluginExtends, {
+            insertAtTheEnd: false,
+        }));
     }
     else {
         const fileName = (0, devkit_1.joinPathFragments)(root, '.eslintrc.json');