@nx/eslint-plugin 23.2.0-beta.2 → 23.2.0-beta.3

package/dist/src/rules/dependency-checks.js

@@ -112,7 +112,6 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
         const projPackageJsonDeps = (0, package_json_utils_1.getProductionDependencies)(packageJson);
         const rootPackageJsonDeps = (0, package_json_utils_1.getAllDependencies)(rootPackageJson);
         const catalogManager = (0, internal_1.getCatalogManager)(devkit_1.workspaceRoot);
-        const catalogDefs = catalogManager?.getCatalogDefinitions(devkit_1.workspaceRoot);
         function catalogEntryMatchesInstalled(catalogVersionSpec, installedVersion) {
             if (installedVersion === '*') {
                 return true;
@@ -126,29 +125,7 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
             });
         }
         function getCatalogVersionForPackage(packageName) {
-            if (!catalogDefs) {
-                return null;
-            }
-            const matches = [];
-            // Check default catalog — `catalog` takes precedence over `catalogs.default`.
-            // Both existing simultaneously is a pnpm error caught by validateCatalogReference.
-            const defaultEntry = catalogDefs.catalog?.[packageName] ??
-                catalogDefs.catalogs?.default?.[packageName];
-            if (defaultEntry) {
-                matches.push({ catalogRef: 'catalog:', versionSpec: defaultEntry });
-            }
-            // Check named catalogs (skip "default" — handled above)
-            if (catalogDefs.catalogs) {
-                for (const [name, entries] of Object.entries(catalogDefs.catalogs)) {
-                    if (name === 'default' || !entries?.[packageName]) {
-                        continue;
-                    }
-                    matches.push({
-                        catalogRef: `catalog:${name}`,
-                        versionSpec: entries[packageName],
-                    });
-                }
-            }
+            const matches = catalogManager?.getCatalogReferencesForPackage(devkit_1.workspaceRoot, packageName) ?? [];
             if (!matches.length) {
                 return null;
             }

package/dist/src/rules/nx-plugin-checks.d.ts

@@ -11,7 +11,7 @@ export type Options = [
         tsConfig?: string;
     }
 ];
-export type MessageIds = 'missingRequiredSchema' | 'invalidSchemaPath' | 'missingImplementation' | 'invalidImplementationPath' | 'invalidImplementationModule' | 'unableToReadImplementationExports' | 'invalidPromptPath' | 'invalidVersion' | 'missingVersion' | 'noGeneratorsOrSchematicsFound' | 'noExecutorsOrBuildersFound' | 'valueShouldBeObject';
+export type MessageIds = 'missingRequiredSchema' | 'invalidSchemaPath' | 'missingImplementation' | 'invalidImplementationPath' | 'invalidImplementationModule' | 'unableToReadImplementationExports' | 'invalidPromptPath' | 'invalidVersion' | 'missingVersion' | 'noGeneratorsOrSchematicsFound' | 'noExecutorsOrBuildersFound' | 'valueShouldBeObject' | 'duplicateKey';
 export declare const RULE_NAME = "nx-plugin-checks";
 declare const _default: TSESLint.RuleModule<MessageIds, Options, unknown, TSESLint.RuleListener> & {
     name: string;
@@ -23,5 +23,12 @@ export declare function validateEntry(baseNode: AST.JSONObjectExpression, key: s
 export declare function validateImplementationNode(implementationNode: AST.JSONProperty, key: string, context: TSESLint.RuleContext<MessageIds, Options>, projects: Record<string, ProjectConfiguration>): void;
 export declare function validatePromptNode(promptNode: AST.JSONProperty, key: string, context: TSESLint.RuleContext<MessageIds, Options>): void;
 export declare function validatePackageGroup(baseNode: AST.JSONObjectExpression, context: TSESLint.RuleContext<MessageIds, Options>): void;
+/**
+ * A duplicate key anywhere in these manifests silently drops data:
+ * JSON parsers keep only the last occurrence, so a duplicated generator,
+ * executor, or migration entry key discards the earlier definition with no
+ * error at runtime.
+ */
+export declare function validateNoDuplicateKeys(node: AST.JSONObjectExpression | AST.JSONArrayExpression, context: TSESLint.RuleContext<MessageIds, Options>): void;
 export declare function validateVersionJsonExpression(node: AST.JSONExpression, context: TSESLint.RuleContext<MessageIds, Options>): string | boolean;
 export declare function checkIfIdentifierIsFunction(filePath: string, identifier: string): boolean;

package/dist/src/rules/nx-plugin-checks.js

@@ -7,6 +7,7 @@ exports.validateEntry = validateEntry;
 exports.validateImplementationNode = validateImplementationNode;
 exports.validatePromptNode = validatePromptNode;
 exports.validatePackageGroup = validatePackageGroup;
+exports.validateNoDuplicateKeys = validateNoDuplicateKeys;
 exports.validateVersionJsonExpression = validateVersionJsonExpression;
 exports.checkIfIdentifierIsFunction = checkIfIdentifierIsFunction;
 const tslib_1 = require("tslib");
@@ -82,6 +83,7 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => ``)({
             missingImplementation: '{{ key }}: Missing required property - `implementation`',
             invalidPromptPath: '{{ key }}: Prompt path should point to a valid file',
             missingVersion: '{{ key }}: Missing required property - `version`',
+            duplicateKey: '{{ key }}: Duplicate key. JSON parsers keep only the last occurrence, silently dropping the earlier one',
         },
     },
     defaultOptions: [DEFAULT_OPTIONS],
@@ -109,6 +111,7 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => ``)({
         }
         return {
             ['JSONExpressionStatement > JSONObjectExpression'](node) {
+                validateNoDuplicateKeys(node, context);
                 if (sourceFilePath === generatorsJson) {
                     checkCollectionFileNode(node, 'generator', context, projects);
                 }
@@ -425,6 +428,43 @@ function validatePackageGroup(baseNode, context) {
         }
     }
 }
+/**
+ * A duplicate key anywhere in these manifests silently drops data:
+ * JSON parsers keep only the last occurrence, so a duplicated generator,
+ * executor, or migration entry key discards the earlier definition with no
+ * error at runtime.
+ */
+function validateNoDuplicateKeys(node, context) {
+    if (node.type === 'JSONObjectExpression') {
+        const seen = new Set();
+        for (const property of node.properties) {
+            const key = property.key.type === 'JSONLiteral'
+                ? String(property.key.value)
+                : property.key.name;
+            if (seen.has(key)) {
+                context.report({
+                    messageId: 'duplicateKey',
+                    data: { key },
+                    node: property.key,
+                });
+            }
+            seen.add(key);
+            if (property.value.type === 'JSONObjectExpression' ||
+                property.value.type === 'JSONArrayExpression') {
+                validateNoDuplicateKeys(property.value, context);
+            }
+        }
+    }
+    else {
+        for (const element of node.elements) {
+            if (element &&
+                (element.type === 'JSONObjectExpression' ||
+                    element.type === 'JSONArrayExpression')) {
+                validateNoDuplicateKeys(element, context);
+            }
+        }
+    }
+}
 function validateVersionJsonExpression(node, context) {
     return (node &&
         node.type === 'JSONLiteral' &&

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "23.2.0-beta.2",
+  "version": "23.2.0-beta.3",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -101,11 +101,11 @@
     "picocolors": "^1.1.0",
     "semver": "^7.6.3",
     "tslib": "^2.3.0",
-    "@nx/js": "23.2.0-beta.2",
-    "@nx/devkit": "23.2.0-beta.2"
+    "@nx/devkit": "23.2.0-beta.3",
+    "@nx/js": "23.2.0-beta.3"
   },
   "devDependencies": {
-    "nx": "23.2.0-beta.2"
+    "nx": "23.2.0-beta.3"
   },
   "publishConfig": {
     "access": "public"